[GitHub] dpogue commented on issue #863: Minimum Xcode version in cordova-docs & cordova-ios not consistent

dpogue commented on issue #863: Minimum Xcode version in cordova-docs & cordova-ios not consistent URL: https://github.com/apache/cordova-docs/issues/863#issuecomment-409452758 Worth noting that regardless of what we say our minimum Xcode version is, Apple enforces a minimum version for

[GitHub] brodybits opened a new pull request #864: GH-863 update minimum Xcode version to 8 for iOS

brodybits opened a new pull request #864: GH-863 update minimum Xcode version to 8 for iOS URL: https://github.com/apache/cordova-docs/pull/864 ### Platforms affected iOS ### What does this PR do? GH-863 update minimum Xcode version to 8 for iOS TODO:

[GitHub] brodybits commented on issue #863: Minimum Xcode version in cordova-docs & cordova-ios not consistent

brodybits commented on issue #863: Minimum Xcode version in cordova-docs & cordova-ios not consistent URL: https://github.com/apache/cordova-docs/issues/863#issuecomment-409451889 A strange thing is that in Traavis CI cordova-ios@4.5.x is tested on Xcode 8 while plugins seem to be tested

[GitHub] erisu commented on a change in pull request #377: Increase Code Coverage & use nyc

erisu commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206744539 ## File path: tests/spec/unit/versions.spec.js ## @@ -0,0 +1,91 @@ +/** + Licensed to the Apache Software

[GitHub] brodybits opened a new issue #863: Minimum Xcode version in cordova-docs & cordova-ios not consistent

brodybits opened a new issue #863: Minimum Xcode version in cordova-docs & cordova-ios not consistent URL: https://github.com/apache/cordova-docs/issues/863 **Issue Type** [x] Bug [ ] Feature Request **Priority** [ ] Minor [x] Major [ ] Critical [ ]

[GitHub] codecov-io commented on issue #386: WIP: README.md drop support for Xcode pre-9.0 - WIP FOR DISCUSSION

codecov-io commented on issue #386: WIP: README.md drop support for Xcode pre-9.0 - WIP FOR DISCUSSION URL: https://github.com/apache/cordova-ios/pull/386#issuecomment-409448634 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/386?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #386: WIP: README.md drop support for Xcode pre-9.0 - WIP FOR DISCUSSION

codecov-io edited a comment on issue #386: WIP: README.md drop support for Xcode pre-9.0 - WIP FOR DISCUSSION URL: https://github.com/apache/cordova-ios/pull/386#issuecomment-409448634 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/386?src=pr=h1) Report > Merging

[GitHub] aszmyd commented on issue #99: CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar

aszmyd commented on issue #99: CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409447930 I do not know why travis build failed for safari browser.

[GitHub] brodybits opened a new pull request #386: WIP: README.md drop support for Xcode pre-9.0 - WIP FOR DISCUSSION

brodybits opened a new pull request #386: WIP: README.md drop support for Xcode pre-9.0 - WIP FOR DISCUSSION URL: https://github.com/apache/cordova-ios/pull/386 ### Platforms affected iOS ### What does this PR do? - Drop support for Xcode pre-9.0 in README.md - add

[GitHub] brodybits commented on issue #99: CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar

brodybits commented on issue #99: CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409443946 A couple minor points FYI: - First line should generally be within 50

[GitHub] aszmyd commented on issue #99: CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar

aszmyd commented on issue #99: CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409442707 @brodybits thanks. I've pushed clean one commit with name changed.

[GitHub] brodybits commented on issue #99: CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar

brodybits commented on issue #99: CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409441677 @aszmyd it should be fine to update by force push (we do this kind of thing all

[GitHub] aszmyd commented on issue #99: CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar

aszmyd commented on issue #99: CB-14238: Make transparency of statusbar persistent when hiding and showing statusbar URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409440198 @janpio I've created JIRA issue: https://issues.apache.org/jira/browse/CB-14238 and

[GitHub] brodybits closed pull request #284: CB-14224 Default.rd.xml header fixes

brodybits closed pull request #284: CB-14224 Default.rd.xml header fixes URL: https://github.com/apache/cordova-windows/pull/284 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[cordova-windows] branch master updated: CB-14224 Default.rd.xml header fixes (#284)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-windows.git The following commit(s) were added to refs/heads/master by this push: new 6572801 CB-14224 Default.rd.xml

[GitHub] brodybits commented on issue #284: CB-14224 Default.rd.xml header fixes

brodybits commented on issue #284: CB-14224 Default.rd.xml header fixes URL: https://github.com/apache/cordova-windows/pull/284#issuecomment-409439861 As this change is already part of 6.0.x (GH-285) it should now be in master. Title and description have been updated.

[GitHub] dpogue commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s…

dpogue commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s… URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-409438779 @shazron @sebastiangrail Do we have any idea what would be involved in making it compatible with the new build

[GitHub] erisu edited a comment on issue #377: Increase Code Coverage & use nyc

erisu edited a comment on issue #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#issuecomment-409431284 @brodybits With the recent mailing list discussion, to mark the next major Cordova dev release (cordova-ios@5.0.0-dev), does it mean

[GitHub] erisu edited a comment on issue #377: Increase Code Coverage & use nyc

erisu edited a comment on issue #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#issuecomment-409431284 @brodybits With the recent mailing list discussion, to mark the next major Cordova dev release (cordova-ios@5.0.0-dev), does it mean

[GitHub] brodybits opened a new pull request #862: [CB-14192] Xcode 10 issue notice

brodybits opened a new pull request #862: [CB-14192] Xcode 10 issue notice URL: https://github.com/apache/cordova-docs/pull/862 ### Platforms affected iOS ### What does this PR do? Add notice about problem with Xcode 10 ref: - apache/cordova-ios#378 -

[GitHub] erisu commented on a change in pull request #377: Increase Code Coverage & use nyc

erisu commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206744539 ## File path: tests/spec/unit/versions.spec.js ## @@ -0,0 +1,91 @@ +/** + Licensed to the Apache Software

[GitHub] erisu commented on a change in pull request #377: Increase Code Coverage & use nyc

erisu commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206744539 ## File path: tests/spec/unit/versions.spec.js ## @@ -0,0 +1,91 @@ +/** + Licensed to the Apache Software

[GitHub] erisu commented on a change in pull request #377: Increase Code Coverage & use nyc

erisu commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206743811 ## File path: tests/spec/unit/versions.spec.js ## @@ -0,0 +1,91 @@ +/** + Licensed to the Apache Software

[GitHub] erisu commented on issue #377: Increase Code Coverage & use nyc

erisu commented on issue #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#issuecomment-409431284 @brodybits With the recent mailing list discussion, to mark the next major Cordova dev release (cordova-ios@5.0.0-dev), does it mean we can

[GitHub] brodybits opened a new pull request #186: Add tools dependency graph by @raphinesse

brodybits opened a new pull request #186: Add tools dependency graph by @raphinesse URL: https://github.com/apache/cordova-coho/pull/186 ### Platforms affected All ### What does this PR do? Add tools dependency graph from

[GitHub] brodybits closed pull request #185: Quick notes for tools release planning

brodybits closed pull request #185: Quick notes for tools release planning URL: https://github.com/apache/cordova-coho/pull/185 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[cordova-coho] branch master updated: Quick tools release planning notes (#185)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-coho.git The following commit(s) were added to refs/heads/master by this push: new b502887 Quick tools release planning

[GitHub] brodybits opened a new pull request #185: Quick notes for tools release planning

brodybits opened a new pull request #185: Quick notes for tools release planning URL: https://github.com/apache/cordova-coho/pull/185 ### Platforms affected All ### What does this PR do? Add quick tools release planning notes to `docs/tools-release-process.md`

[GitHub] brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409405089 I pulled the changes from

[cordova-plugin-inappbrowser] 01/01: Merge pull request #277 from brodybits/quick-ci-fixes

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git commit de86501026cbef4dfba5f962d32f893bbb8a4729 Merge: 9cc7f69 07d9a99 Author: Chris Brody

[GitHub] brodybits closed pull request #277: Quick CI fixes

brodybits closed pull request #277: Quick CI fixes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/277 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[cordova-plugin-inappbrowser] branch master updated (9cc7f69 -> de86501)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git. from 9cc7f69 Merge pull request #272 from jcesarmobile/CB-12922 add eb245ec .travis.yml

[GitHub] brodybits opened a new pull request #277: Quick Ci fixes

brodybits opened a new pull request #277: Quick Ci fixes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/277 ### Platforms affected Browser, Android, iOS ### What does this PR do? - `.travis.yml` skip android-7.0 for now to workaround Travis CI

[GitHub] brodybits commented on a change in pull request #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes

brodybits commented on a change in pull request #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#discussion_r206679000 ## File path: tests/tests.js ## @@ -693,4 +698,29 @@

[GitHub] brodybits commented on issue #377: Increase Code Coverage & use nyc

brodybits commented on issue #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#issuecomment-409336903 @erisu I took the liberty to include a small part of this PR in GH-384 (#384) that I just merged in order to add coverage for the changes merged

[GitHub] codecov-io edited a comment on issue #385: WIP: nyc with increased coverage on 4.5.x (for testing & discussion)

codecov-io edited a comment on issue #385: WIP: nyc with increased coverage on 4.5.x (for testing & discussion) URL: https://github.com/apache/cordova-ios/pull/385#issuecomment-409334116 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/385?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #385: WIP: nyc with increased coverage on 4.5.x (for testing & discussion)

codecov-io commented on issue #385: WIP: nyc with increased coverage on 4.5.x (for testing & discussion) URL: https://github.com/apache/cordova-ios/pull/385#issuecomment-409334116 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/385?src=pr=h1) Report > Merging

[GitHub] brodybits opened a new pull request #385: WIP: nyc with increased coverage on 4.5.x (for testing & discussion)

brodybits opened a new pull request #385: WIP: nyc with increased coverage on 4.5.x (for testing & discussion) URL: https://github.com/apache/cordova-ios/pull/385 ### Platforms affected iOS ### What does this PR do? WIP for testing & discussion: ported GH-377

[cordova-ios] branch master updated: spec cover apple version functions (#384)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git The following commit(s) were added to refs/heads/master by this push: new b3f4bbb spec cover apple version

[GitHub] brodybits closed pull request #384: spec cover apple version functions (covers GH-376 update)

brodybits closed pull request #384: spec cover apple version functions (covers GH-376 update) URL: https://github.com/apache/cordova-ios/pull/384 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] codecov-io edited a comment on issue #384: spec cover apple version functions (covers GH-376 update)

codecov-io edited a comment on issue #384: spec cover apple version functions (covers GH-376 update) URL: https://github.com/apache/cordova-ios/pull/384#issuecomment-409314652 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/384?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #384: spec cover apple version functions (covers GH-376 update)

codecov-io commented on issue #384: spec cover apple version functions (covers GH-376 update) URL: https://github.com/apache/cordova-ios/pull/384#issuecomment-409314652 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/384?src=pr=h1) Report > Merging

[GitHub] brodybits commented on issue #375: CB-14074 ios: Remove Node 4 from CI

brodybits commented on issue #375: CB-14074 ios: Remove Node 4 from CI URL: https://github.com/apache/cordova-ios/pull/375#issuecomment-409314306 I like this in general. As I said elsewhere () I would favor dropping

[cordova-ios] branch master updated: appveyor.yml simplify install (#383)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git The following commit(s) were added to refs/heads/master by this push: new ff65098 appveyor.yml simplify install

[GitHub] brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc

brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206621691 ## File path: tests/spec/unit/versions.spec.js ## @@ -0,0 +1,91 @@ +/** + Licensed to the Apache Software

[GitHub] brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc

brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206614597 ## File path: tests/spec/unit/versions.spec.js ## @@ -0,0 +1,91 @@ +/** + Licensed to the Apache Software

[GitHub] brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc

brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206605952 ## File path: tests/spec/unit/versions.spec.js ## @@ -0,0 +1,91 @@ +/** + Licensed to the Apache Software

[GitHub] erisu commented on a change in pull request #377: Increase Code Coverage & use nyc

erisu commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206605068 ## File path: tests/spec/unit/versions.spec.js ## @@ -0,0 +1,91 @@ +/** + Licensed to the Apache Software

[GitHub] brodybits opened a new pull request #384: spec cover apple version functions (covers GH-376 update)

brodybits opened a new pull request #384: spec cover apple version functions (covers GH-376 update) URL: https://github.com/apache/cordova-ios/pull/384 ### Platforms affected iOS ### What does this PR do? - cover apple version functions in spec, as needed to

[GitHub] erisu commented on a change in pull request #377: Increase Code Coverage & use nyc

erisu commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206603722 ## File path: tests/spec/unit/versions.spec.js ## @@ -0,0 +1,91 @@ +/** + Licensed to the Apache Software

[GitHub] brodybits commented on issue #377: Increase Code Coverage & use nyc

brodybits commented on issue #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#issuecomment-409288973 Really nice in general. My major comment is that I am personally not ready to break deprecated Node.js 4 compatibility for a couple reasons: -

[GitHub] brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc

brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206592169 ## File path: package.json ## @@ -67,5 +67,9 @@ "shelljs", "xcode", "xml-escape" - ] + ], +

[GitHub] erisu commented on a change in pull request #377: Increase Code Coverage & use nyc

erisu commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206586953 ## File path: package.json ## @@ -67,5 +67,9 @@ "shelljs", "xcode", "xml-escape" - ] + ], +

svn commit: r1837161 - in /cordova/site/public: docs/en/5.4.0/guide/platforms/win8/packaging.html docs/en/dev/reference/cordova-plugin-splashscreen/index.html docs/en/dev/reference/cordova-plugin-whit

Author: steven Date: Tue Jul 31 15:47:35 2018 New Revision: 1837161 URL: http://svn.apache.org/viewvc?rev=1837161=rev Log: Updated docs Modified: cordova/site/public/docs/en/5.4.0/guide/platforms/win8/packaging.html

[GitHub] brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc

brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206567921 ## File path: package.json ## @@ -67,5 +67,9 @@ "shelljs", "xcode", "xml-escape" - ] + ], +

[GitHub] brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc

brodybits commented on a change in pull request #377: Increase Code Coverage & use nyc URL: https://github.com/apache/cordova-ios/pull/377#discussion_r206567709 ## File path: tests/spec/unit/versions.spec.js ## @@ -0,0 +1,91 @@ +/** + Licensed to the Apache Software

[GitHub] brodybits edited a comment on issue #860: Security Page

brodybits edited a comment on issue #860: Security Page URL: https://github.com/apache/cordova-docs/issues/860#issuecomment-409244606 ~~I would mark this one as a blocker.~~ _(accepting the response below)_ This is an

[GitHub] janpio commented on issue #860: Security Page

janpio commented on issue #860: Security Page URL: https://github.com/apache/cordova-docs/issues/860#issuecomment-409249226 > I would mark this one as a blocker. I don't agree. There is a link to http://www.apache.org/security/ in the footer, see the updated description. The page

[GitHub] brodybits commented on issue #860: Security Page

brodybits commented on issue #860: Security Page URL: https://github.com/apache/cordova-docs/issues/860#issuecomment-409246928 - a classic! This is an automated message from the Apache Git

[GitHub] janpio opened a new issue #861: Update Contributor guidelines for GitHub Issues activation

janpio opened a new issue #861: Update Contributor guidelines for GitHub Issues activation URL: https://github.com/apache/cordova-docs/issues/861 * https://cordova.apache.org/contribute/ Change "View All Issues" and replace Issue Search *

[GitHub] brodybits commented on issue #860: Security Page

brodybits commented on issue #860: Security Page URL: https://github.com/apache/cordova-docs/issues/860#issuecomment-409244606 I would mark this one as a blocker. This is an automated message from the Apache Git Service. To

[GitHub] janpio opened a new issue #860: Security Page

janpio opened a new issue #860: Security Page URL: https://github.com/apache/cordova-docs/issues/860 Cordova is currently missing a Security page at https://cordova.apache.org/security/ or similar where the process of reporting security bugs is documented. From what I understood,

[cordova-plugin-whitelist] branch master updated: Clarify unconfigured Intent Whitelist behaviour (#26)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-whitelist.git The following commit(s) were added to refs/heads/master by this push: new 8d3f86b Clarify unconfigured

[GitHub] janpio closed pull request #26: Incorrect default value listing for Intents

janpio closed pull request #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] rossdonald97 commented on issue #26: Incorrect default value listing for Intents

rossdonald97 commented on issue #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26#issuecomment-409234300 Perfect, the inconsistent structure was annoying me too, so glad you had a quick fix of that too.

[GitHub] brodybits commented on issue #382: WIP - update dev deps WIP

brodybits commented on issue #382: WIP - update dev deps WIP URL: https://github.com/apache/cordova-ios/pull/382#issuecomment-409233343 Thanks @erisu. I did already reference #375 as GH-375, did not realize that #377 already included nyc. I think you can see that I already reviewed

[GitHub] janpio commented on issue #26: Incorrect default value listing for Intents

janpio commented on issue #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26#issuecomment-409232763 I had a go as well, I saw below it was structured a bit better and adapted that to the documentation above. Agree?

[GitHub] rossdonald97 commented on issue #26: Incorrect default value listing for Intents

rossdonald97 commented on issue #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26#issuecomment-409229778 Hope that commit there fits better. I did feel to keep the last part about changing it to suit needs since many of the

[GitHub] janpio commented on issue #26: Incorrect default value listing for Intents

janpio commented on issue #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26#issuecomment-409228808 Awesome. Feel free to update your PR, then we can merge pretty quickly I think.

[GitHub] brodybits edited a comment on issue #376: Fixed Get Apple OSX Version method

brodybits edited a comment on issue #376: Fixed Get Apple OSX Version method URL: https://github.com/apache/cordova-ios/pull/376#issuecomment-409226737 I discovered a few TODO items after merging: - should have added test coverage first, as you already proposed in ~~GH-376 (#376)~~

[GitHub] rossdonald97 commented on issue #26: Incorrect default value listing for Intents

rossdonald97 commented on issue #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26#issuecomment-409227444 Agreed on just removing the term default from the listing. I think it is partially inferred due to the plugin being a

[GitHub] brodybits edited a comment on issue #376: Fixed Get Apple OSX Version method

brodybits edited a comment on issue #376: Fixed Get Apple OSX Version method URL: https://github.com/apache/cordova-ios/pull/376#issuecomment-409226737 I discovered a few TODO items after merging: - should have added test coverage first, as you already proposed in ~~GH-376 (#376)~~

[GitHub] brodybits commented on issue #376: Fixed Get Apple OSX Version method

brodybits commented on issue #376: Fixed Get Apple OSX Version method URL: https://github.com/apache/cordova-ios/pull/376#issuecomment-409226737 I discovered a few TODO items after merging: - should have added test coverage first, as you already proposed in GH-376 (#376) - minor:

[GitHub] janpio edited a comment on issue #26: Incorrect default value listing for Intents

janpio edited a comment on issue #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26#issuecomment-409224016 Exactly, that's what I meant with my last sentence. Maybe we should try to get rid of the word "default" and maybe even

[GitHub] janpio commented on issue #26: Incorrect default value listing for Intents

janpio commented on issue #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26#issuecomment-409224016 Exactly, that's what I meant with my last sentence. Maybe we should try to get rid of the word "default" and maybe even use

[GitHub] wvengen edited a comment on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes

wvengen edited a comment on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409220992 It took me some experimentation to find the cause, but the page you load in the whitelist

[GitHub] brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409222786 Thanks @wvengen I will take another look today.

[GitHub] rossdonald97 commented on issue #26: Incorrect default value listing for Intents

rossdonald97 commented on issue #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26#issuecomment-409221301 Ahh I guess I understand what you mean. It depends what you mean by default? I'd say creating a blank brand new project

[GitHub] wvengen edited a comment on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes

wvengen edited a comment on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409220992 It took me some experimentation to find the cause, but since the page you load in the

[GitHub] wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409220992 It took me some experimentation to find the cause, but since the page you load is local, it is

[GitHub] janpio edited a comment on issue #26: Incorrect default value listing for Intents

janpio edited a comment on issue #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26#issuecomment-409216056 > Note: Could not find an applicable area in JIRA to post this since it's a documentation fix. All non plugin

[GitHub] janpio commented on issue #26: Incorrect default value listing for Intents

janpio commented on issue #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26#issuecomment-409216056 > Note: Could not find an applicable area in JIRA to post this since it's a documentation fix. All non plugin documentation

[cordova-ios] branch master updated: Fixed Get Apple OSX Version method

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git The following commit(s) were added to refs/heads/master by this push: new f967fc4 Fixed Get Apple OSX Version

[GitHub] brodybits closed pull request #376: Fixed Get Apple OSX Version method

brodybits closed pull request #376: Fixed Get Apple OSX Version method URL: https://github.com/apache/cordova-ios/pull/376 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] rossdonald97 opened a new pull request #26: Incorrect default value listing for Intents

rossdonald97 opened a new pull request #26: Incorrect default value listing for Intents URL: https://github.com/apache/cordova-plugin-whitelist/pull/26 Within the "Intent Whitelist" subheading the statement saying that the default blocks all external URLs is incorrect. Currently a newly

[cordova-docs] branch master updated: Fix typo in old win8 docs (#859)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new b05e288 Fix typo in old win8 docs (#859)

[GitHub] janpio closed pull request #859: Fix typo

janpio closed pull request #859: Fix typo URL: https://github.com/apache/cordova-docs/pull/859 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the

[GitHub] janpio edited a comment on issue #99: Make transparency of statusbar persistent when hiding and showing sta…

janpio edited a comment on issue #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409206936 @aszmyd Some feedback from other commiters I got when asking for a review of this: >

[GitHub] janpio edited a comment on issue #99: Make transparency of statusbar persistent when hiding and showing sta…

janpio edited a comment on issue #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409206936 @aszmyd Some feedback from other commiters I got when asking for a review of this: >

[GitHub] janpio commented on issue #99: Make transparency of statusbar persistent when hiding and showing sta…

janpio commented on issue #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409206936 Some feedback from other commiters I got when asking for a review of this: > doesn't have

[GitHub] AragurDEV opened a new pull request #859: Fix typo

AragurDEV opened a new pull request #859: Fix typo URL: https://github.com/apache/cordova-docs/pull/859 This fixes a typo in the win8 packaging.md (thmis -> this) This is an automated message from the Apache Git Service. To

[GitHub] 349989153 commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors)

349989153 commented on issue #417: CB-13580: (android) fix build for multiple apks (different product flavors) URL: https://github.com/apache/cordova-android/pull/417#issuecomment-409200904 @Ankoul Maybe you wanna try this:

[GitHub] janpio closed pull request #56: TypeScript Definition Created

janpio closed pull request #56: TypeScript Definition Created URL: https://github.com/apache/cordova-plugin-statusbar/pull/56 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] jcesarmobile commented on issue #56: TypeScript Definition Created

jcesarmobile commented on issue #56: TypeScript Definition Created URL: https://github.com/apache/cordova-plugin-statusbar/pull/56#issuecomment-409183312 The plugin has now types, so I think this can be closed

[GitHub] emanuelecesari opened a new pull request #858: Incorrect default value in config.xml

emanuelecesari opened a new pull request #858: Incorrect default value in config.xml URL: https://github.com/apache/cordova-docs/pull/858 the default loglevel value is DEBUG not ERROR ### Platforms affected ### What does this PR do? ### What testing has

[GitHub] janpio commented on issue #99: Make transparency of statusbar persistent when hiding and showing sta…

janpio commented on issue #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409156240 Unfortunately not. You could try emailing the Dev mailing list, see

[cordova-lib] branch janpio-patch-1 deleted (was b05b5ec)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-patch-1 in repository https://gitbox.apache.org/repos/asf/cordova-lib.git. was b05b5ec Adapt plugman_uninstall.spec.js to new error messages The revisions that were on this branch

[cordova-lib] branch master updated: Improve plugman/uninstall.js messages (#630)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-lib.git The following commit(s) were added to refs/heads/master by this push: new 6019d92 Improve plugman/uninstall.js

[GitHub] aszmyd commented on issue #99: Make transparency of statusbar persistent when hiding and showing sta…

aszmyd commented on issue #99: Make transparency of statusbar persistent when hiding and showing sta… URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409150616 @janpio do you have anyone specific in mind? Maybe @infil00p can jump in here? I see he merged

[GitHub] erisu edited a comment on issue #382: WIP - update dev deps WIP

erisu edited a comment on issue #382: WIP - update dev deps WIP URL: https://github.com/apache/cordova-ios/pull/382#issuecomment-409126625 @brodybits I just noticed that this PR and some of the PRs I submitted over a month ago are somewhat inline. I am not sure if you had taken a look at

  1   2   >