[GitHub] GVB1 commented on issue #17: Grey Screen while opening the app

2018-09-18 Thread GitBox
GVB1 commented on issue #17: Grey Screen while opening the app URL: https://github.com/apache/cordova/issues/17#issuecomment-422679600 > Do you have the same problem with a new app created with `cordova create`? > > If not, http://forum.ionicframework.com/ is probably the more appropr

[GitHub] DRneilC commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-09-18 Thread GitBox
DRneilC commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-422655238 @dpogue Thanks! The answer solved my problem. This is an automated message

[GitHub] erisu commented on a change in pull request #8: Janpio reproduction grammar

2018-09-18 Thread GitBox
erisu commented on a change in pull request #8: Janpio reproduction grammar URL: https://github.com/apache/cordova-contribute/pull/8#discussion_r218650160 ## File path: create-reproduction.md ## @@ -1,29 +1,71 @@ -# Create a minimal reproduction repository or sample +# Crea

[GitHub] raphinesse commented on issue #171: Migrate from jasmine-node to Jasmine 3

2018-09-18 Thread GitBox
raphinesse commented on issue #171: Migrate from jasmine-node to Jasmine 3 URL: https://github.com/apache/cordova-js/issues/171#issuecomment-422623199 I have a local branch with tests driven by Karma on Headless Chrome using Jasmine 3. Needs a bit of work still, but I will open a PR as soon

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422570066 I'm completely confused as well, so I'll retract and wait for others more qualified than me to report, so as not to confuse you. In t

[GitHub] svanzoest commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS

2018-09-18 Thread GitBox
svanzoest commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-422590225 We have been testing this PR and it is working for us, but we did have to deal with local storage migration. -

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422570066 I'm completely confused as well, so I'll retract and wait for others more qualified than me to report, so as not to confuse you. In t

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] neofuture commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
neofuture commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422574136 "is there a problem wherein Cordova CLI is making builds with missing embedded mobileprovision files" I can't confirm as the version numb

[GitHub] neofuture commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
neofuture commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422573711 I use Cordova to create the project, but then I roll over to Xcode to increase versions, and upload to App Store via the organiser, I can build

[GitHub] pliablepixels commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422570066 I'm completely confused as well, so I'll retract and wait for others more qualified than me to report, so as not to confuse you. In the morn

[GitHub] fernandoocf removed a comment on issue #114: Not working on Android devices

2018-09-18 Thread GitBox
fernandoocf removed a comment on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-422562826 You are right @battika . Code updated! I can't understand why It won't works on your Xiaomi, because LocationAccura

[GitHub] fernandoocf commented on issue #114: Not working on Android devices

2018-09-18 Thread GitBox
fernandoocf commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-422569444 Code updated! I can't understand why It won't works on your Xiaomi, because LocationAccuracy plugin use a native call from

[GitHub] fernandoocf edited a comment on issue #114: Not working on Android devices

2018-09-18 Thread GitBox
fernandoocf edited a comment on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-422562826 You are right @battika . Code updated! I can't understand why It won't works on your Xiaomi, because LocationAccurac

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] dpogue commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
dpogue commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422568198 @pliablepixels I assume that `ad-hoc` or `app-store` (or even `enterprise`) would be fine... It has to sign the build in all cases. Maybe I'

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 @dpogue - I'm new to the cordova command line "build for release" process so I'm not sure I'm doing what you need. It looks like I ca

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 Tests with adhoc profile | | Export withAutomatic Signing | Export withManual Signing | |---

[GitHub] fernandoocf edited a comment on issue #114: Not working on Android devices

2018-09-18 Thread GitBox
fernandoocf edited a comment on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-422136951 Here is my solution: You will need use: Platform: https://ionicframework.com/docs/api/platform/Platform/ Diagno

[GitHub] fernandoocf commented on issue #114: Not working on Android devices

2018-09-18 Thread GitBox
fernandoocf commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-422562826 You are right @battika . Code updated! This is an automated messa

[GitHub] fernandoocf edited a comment on issue #114: Not working on Android devices

2018-09-18 Thread GitBox
fernandoocf edited a comment on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-422136951 Here is my solution: You will need use: Platform: https://ionicframework.com/docs/api/platform/Platform/ Diagno

[GitHub] pliablepixels commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422560235 | | Export withAutomatic Signing | Export withManual Signing | |---|--

[GitHub] pliablepixels removed a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels removed a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422500780 @rossholdway for the Xcode IDE row when you say "validation will succeed" what exactly are you doing? I tried exporting both automa

[GitHub] brodybits commented on issue #162: [CB-14156] Remove browserify

2018-09-18 Thread GitBox
brodybits commented on issue #162: [CB-14156] Remove browserify URL: https://github.com/apache/cordova-js/pull/162#issuecomment-422547916 I tested that if I would do `coho copy-js` to include the recent changes in master branch of each platform I am able to run the cordova-sqlite-storage te

svn commit: r1841256 - in /cordova/site/public: docs/en/dev/config_ref/index.html docs/en/dev/plugin_ref/spec.html docs/en/dev/reference/cordova-plugin-file/index.html feed.xml

2018-09-18 Thread steven
Author: steven Date: Tue Sep 18 20:43:29 2018 New Revision: 1841256 URL: http://svn.apache.org/viewvc?rev=1841256&view=rev Log: Updated docs Modified: cordova/site/public/docs/en/dev/config_ref/index.html cordova/site/public/docs/en/dev/plugin_ref/spec.html cordova/site/public/docs/en

[GitHub] battika commented on issue #114: Not working on Android devices

2018-09-18 Thread GitBox
battika commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-422543621 > if (locationMode.HIGH_ACCURACY) Are you sure this line is doing what it is supposed to be doing? [According to the documenta

[GitHub] brodybits commented on issue #413: remove node_modules from repository

2018-09-18 Thread GitBox
brodybits commented on issue #413: remove node_modules from repository URL: https://github.com/apache/cordova-ios/pull/413#issuecomment-422536125 My bad, apologies! This is an automated message from the Apache Git Service. To

[cordova-ios] branch brodybits-remove-node_modules deleted (was 87ee041)

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-remove-node_modules in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. was 87ee041 completely remove node_modules from repository The revisions that were on th

[GitHub] brodybits closed pull request #413: remove node_modules from repository

2018-09-18 Thread GitBox
brodybits closed pull request #413: remove node_modules from repository URL: https://github.com/apache/cordova-ios/pull/413 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] brodybits opened a new pull request #413: remove node_modules from repository

2018-09-18 Thread GitBox
brodybits opened a new pull request #413: remove node_modules from repository URL: https://github.com/apache/cordova-ios/pull/413 - ignore all node_modules - completely remove node_modules from repository This is an automat

[cordova-ios] branch brodybits-remove-node_modules created (now 87ee041)

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-remove-node_modules in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. at 87ee041 completely remove node_modules from repository This branch includes the foll

[cordova-ios] 01/02: ignore all node_modules

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch brodybits-remove-node_modules in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit eee9382d539bdec0276150e5cf8231c321a96698 Author: Christopher J. Brody AuthorDate: Tue Sep

[cordova-docs] branch master updated: Add missing cordova-browser engine (#888)

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new 0ed1be8 Add missing cordova-browser en

[GitHub] brodybits closed pull request #888: Add missing cordova-browser engine

2018-09-18 Thread GitBox
brodybits closed pull request #888: Add missing cordova-browser engine URL: https://github.com/apache/cordova-docs/pull/888 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] oliversalzburg opened a new pull request #888: Add missing cordova-browser engine

2018-09-18 Thread GitBox
oliversalzburg opened a new pull request #888: Add missing cordova-browser engine URL: https://github.com/apache/cordova-docs/pull/888 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist -

[GitHub] raphinesse commented on issue #173: additional btest cleanup

2018-09-18 Thread GitBox
raphinesse commented on issue #173: additional btest cleanup URL: https://github.com/apache/cordova-js/pull/173#issuecomment-422525595 I just noticed it. So that task did depend on `browserify`. :thinking: This is an

[GitHub] brodybits commented on issue #173: additional btest cleanup

2018-09-18 Thread GitBox
brodybits commented on issue #173: additional btest cleanup URL: https://github.com/apache/cordova-js/pull/173#issuecomment-422524759 I think the "Run tests in the browser" task is no longer possible now that `tasks/lib/test-browser.js` is gone.

[GitHub] raphinesse commented on issue #173: additional btest cleanup

2018-09-18 Thread GitBox
raphinesse commented on issue #173: additional btest cleanup URL: https://github.com/apache/cordova-js/pull/173#issuecomment-422522175 The description of the test says: "Runs tests in the browser". Sounds like something we want to keep. Do you have any more insight to share? ---

[GitHub] raphinesse commented on issue #17: Grey Screen while opening the app

2018-09-18 Thread GitBox
raphinesse commented on issue #17: Grey Screen while opening the app URL: https://github.com/apache/cordova/issues/17#issuecomment-422515042 While I have no experience with that myself, I remember having read about a similar issue in our slack. There it was suggested that it had to do with

[GitHub] janpio commented on issue #17: Grey Screen while opening the app

2018-09-18 Thread GitBox
janpio commented on issue #17: Grey Screen while opening the app URL: https://github.com/apache/cordova/issues/17#issuecomment-422513241 Do you have the same problem with a new app created with `cordova create`? If not, http://forum.ionicframework.com/ is probably the more appropriate

[GitHub] janpio edited a comment on issue #17: Grey Screen while opening the app

2018-09-18 Thread GitBox
janpio edited a comment on issue #17: Grey Screen while opening the app URL: https://github.com/apache/cordova/issues/17#issuecomment-422513241 Do you have the same problem with a new app created with `cordova create`? If not, http://forum.ionicframework.com/ is probably the more appr

[GitHub] GVB1 opened a new issue #17: Grey Screen while opening the app

2018-09-18 Thread GitBox
GVB1 opened a new issue #17: Grey Screen while opening the app URL: https://github.com/apache/cordova/issues/17 HI Team I have created an app using Ionic3 and cordova. I see 2-3 seconds of Grey screen even before my splash screen. Need assistance in this regards on how to solve this

[GitHub] brodybits opened a new pull request #173: additional btest cleanup

2018-09-18 Thread GitBox
brodybits opened a new pull request #173: additional btest cleanup URL: https://github.com/apache/cordova-js/pull/173 related to removed browserify functionality This is an automated message from the Apache Git Service. To res

[GitHub] pliablepixels commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422500780 @rossholdway for the Xcode IDE row when you say "validation will succeed" what exactly are you doing? I tried exporting both automatic and m

[GitHub] brodybits commented on issue #171: Migrate from jasmine-node to Jasmine 3

2018-09-18 Thread GitBox
brodybits commented on issue #171: Migrate from jasmine-node to Jasmine 3 URL: https://github.com/apache/cordova-js/issues/171#issuecomment-422494613 PR #140 looks like an attempt to migrate to Jasmine (2) almost 2 years ago, does not seem to be working. I am thinking it may be easie

[GitHub] dpogue commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
dpogue commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422488295 hmm, that confuses me a bit because everyone seems to be saying that Cordova with automatic signing is resulting in the error about missing embedd

[GitHub] brodybits closed pull request #172: add test labels (GH-140)

2018-09-18 Thread GitBox
brodybits closed pull request #172: add test labels (GH-140) URL: https://github.com/apache/cordova-js/pull/172 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fr

[cordova-js] branch master updated: add test labels (GH-140) (#172)

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-js.git The following commit(s) were added to refs/heads/master by this push: new 0f60f1a add test labels (GH-140) (#172)

[GitHub] rossholdway edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
rossholdway edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422480801 @dpogue From my testing... others should probably confirm :) | | Export withAutomatic Signing | Exp

[GitHub] rossholdway commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
rossholdway commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422480801 From my testing... others should probably confirm :) | | Export withAutomatic Signing | Export withManual

[GitHub] brodybits opened a new pull request #172: add test labels (GH-140)

2018-09-18 Thread GitBox
brodybits opened a new pull request #172: add test labels (GH-140) URL: https://github.com/apache/cordova-js/pull/172 from #140 (with some modifications) This is an automated message from the Apache Git Service. To respond to

[GitHub] sgoldberg-sfdc commented on issue #409: Another possible Xcode 10 fix

2018-09-18 Thread GitBox
sgoldberg-sfdc commented on issue #409: Another possible Xcode 10 fix URL: https://github.com/apache/cordova-ios/pull/409#issuecomment-422469592 We consume the framework as we use Carthage for dependency management. I don't think I would force it on developers, but an option to the CLI migh

[GitHub] HarelM opened a new issue #346: saveToPhotoAlbum doesn't save image

2018-09-18 Thread GitBox
HarelM opened a new issue #346: saveToPhotoAlbum doesn't save image URL: https://github.com/apache/cordova-plugin-camera/issues/346 Image is not stored to my DCIM folder on my device nor it shows in my gallery app even though `saveToPhotoAlbum` is set to `true`. Android, xiomi redmi 4.

[GitHub] dpogue commented on issue #409: Another possible Xcode 10 fix

2018-09-18 Thread GitBox
dpogue commented on issue #409: Another possible Xcode 10 fix URL: https://github.com/apache/cordova-ios/pull/409#issuecomment-422466382 > I believe when you generate a project using Cordova it uses the static library, so the framework issues will not appear in the typical workflow.

[GitHub] hamzatrq opened a new issue #345: Camera plugin crashes app on some android phones when an image is taken

2018-09-18 Thread GitBox
hamzatrq opened a new issue #345: Camera plugin crashes app on some android phones when an image is taken URL: https://github.com/apache/cordova-plugin-camera/issues/345 So the plugin works on most of the devices, it works on IOS perfectly. But on android it works on some devices and on so

[GitHub] dpogue commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
dpogue commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422461902 @pliablepixels @mlegenhausen Thanks for providing more information to help us understand what's going on! I might be missing something, but it seem

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422451078 @sufian4199 - I can confirm your solution works. To summarize the hacks so far: 1. While building, we need to do (if using ion

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422451078 @sufian4199 - I can confirm your solution works. To summarize the hacks so far: 1. While building, we need to do (if using ion

[GitHub] sufian4199 commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
sufian4199 commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422453359 @pliablepixels thank you for summarising it in the best possible way 👍 This i

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422451078 @sufian4199 - I can confirm your solution works. To summarize the hacks so far: 1. While building, we need to do (if using ion

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422451078 @sufian4199 - I can confirm your solution works. To summarize the hacks so far: 1. While building, we need to do (if using ion

[GitHub] kitolog edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
kitolog edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422450735 I got the same issue using Xcode 10 I cannot also distribute the latest build via Fabric or run ios app using cli Xcode 10 iOS 12

[GitHub] pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422451078 @sufian4199 - I can confirm your solution works. To summarize the hacks so far: 1. While building, we need to do (if using ion

[GitHub] pliablepixels commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422451078 @sufian4199 - I can confirm your solution works. To summarize the hacks so far: 1. While building, we need to do (if using ionic) `io

[GitHub] kitolog commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
kitolog commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422450735 I got the same issue using Xcode 10 I cannot also distribute the latest build via Fabric or run ios app using cli Xcode 10 iOS 12 macOS

[GitHub] kohlia commented on issue #339: Localizing hardcoded messages

2018-09-18 Thread GitBox
kohlia commented on issue #339: Localizing hardcoded messages URL: https://github.com/apache/cordova-plugin-camera/pull/339#issuecomment-422448861 Its up to the maintainers now. This is an automated message from the Apache G

[GitHub] sufian4199 edited a comment on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
sufian4199 edited a comment on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422447550 @pliablepixels yes i am submitting via xcode 10. I did the following things 1) Created provisioning profile in my developer accoun

[GitHub] sufian4199 commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
sufian4199 commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422447550 Yes i am submitting via xcode 10. I did the following things 1) Created provisioning profile in my developer account for that app id.

[GitHub] brodybits opened a new issue #171: Migrate from jasmine-node to Jasmine 3

2018-09-18 Thread GitBox
brodybits opened a new issue #171: Migrate from jasmine-node to Jasmine 3 URL: https://github.com/apache/cordova-js/issues/171 I picked up maintainer responsibility of jasmine-node as a temporary workaround to resolve npm audit issues before the next major release. Now that we are targetin

[GitHub] pliablepixels commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
pliablepixels commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422444912 @sufian4199 how did you submit app? Are you still using Xcode 10? I am able to build with `ionic cordova build ios -- --buildFlag="-UseMode

[GitHub] brodybits commented on issue #162: [CB-14156] Remove browserify

2018-09-18 Thread GitBox
brodybits commented on issue #162: [CB-14156] Remove browserify URL: https://github.com/apache/cordova-js/pull/162#issuecomment-422444508 I will go ahead with a quick test then, thanks. This is an automated message from the Ap

[GitHub] raphinesse edited a comment on issue #162: [CB-14156] Remove browserify

2018-09-18 Thread GitBox
raphinesse edited a comment on issue #162: [CB-14156] Remove browserify URL: https://github.com/apache/cordova-js/pull/162#issuecomment-422444144 @brodybits I approved the changes since I thoroughly reviewed them and since they passed the automated tests. I did not know whether you wanted t

[GitHub] raphinesse commented on issue #162: [CB-14156] Remove browserify

2018-09-18 Thread GitBox
raphinesse commented on issue #162: [CB-14156] Remove browserify URL: https://github.com/apache/cordova-js/pull/162#issuecomment-422444144 @brodybits I approved the changes since I reviewed and since they passed the automated tests. I did not know whether you wanted to do some manual tests

[cordova-js] 01/01: Merge pull request #162 from brodybits/cb-remove-browserify

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-js.git commit 0b56cbc27bf580a63d11a6d8ed9c6fdb205dd829 Merge: ab1b04b cfbe4e4 Author: Chris Brody AuthorDate: Tue Sep 18 11:37:

[cordova-js] branch master updated (ab1b04b -> 0b56cbc)

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-js.git. from ab1b04b Mark 5.0.0-dev (#170) add 1779cb1 Remove browserify tasks from Gruntfile & scripts add 981

[GitHub] brodybits closed pull request #162: [CB-14156] Remove browserify

2018-09-18 Thread GitBox
brodybits closed pull request #162: [CB-14156] Remove browserify URL: https://github.com/apache/cordova-js/pull/162 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] janpio commented on issue #339: Localizing hardcoded messages

2018-09-18 Thread GitBox
janpio commented on issue #339: Localizing hardcoded messages URL: https://github.com/apache/cordova-plugin-camera/pull/339#issuecomment-422442657 Nobody told you to include the other plugin, @oliversalzburg just mentioned it so we all can consider if these changes might make this plugin

[GitHub] sufian4199 commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
sufian4199 commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422441936 @neofuture i was able to submit app via xcode but now instead of wildcard i had to create an individual provisioning profile for each app. Howe

[GitHub] kohlia commented on issue #339: Localizing hardcoded messages

2018-09-18 Thread GitBox
kohlia commented on issue #339: Localizing hardcoded messages URL: https://github.com/apache/cordova-plugin-camera/pull/339#issuecomment-422440183 > Now you can decide if this has any impact on your PR and change something or not. > And then some maintainer will maybe review your PR and

[GitHub] ryakoviv commented on issue #103: overlaysWebView change the overlay not only status bar but the keyboard also

2018-09-18 Thread GitBox
ryakoviv commented on issue #103: overlaysWebView change the overlay not only status bar but the keyboard also URL: https://github.com/apache/cordova-plugin-statusbar/issues/103#issuecomment-422439239 platform Android Checked on Android 5.0, Android 6.0, Android 7.1 Cordova 8.0 (the

[GitHub] brodybits commented on issue #162: [CB-14156] Remove browserify

2018-09-18 Thread GitBox
brodybits commented on issue #162: [CB-14156] Remove browserify URL: https://github.com/apache/cordova-js/pull/162#issuecomment-422439253 > @brodybits Could you explain what you mean by "known to fail `npm test`"? The CI tests all passed. I think (recall) that when I raised this PR i

[GitHub] janpio commented on issue #339: Localizing hardcoded messages

2018-09-18 Thread GitBox
janpio commented on issue #339: Localizing hardcoded messages URL: https://github.com/apache/cordova-plugin-camera/pull/339#issuecomment-422438471 Now you can decide if this has any impact on your PR and change something or not. And then some maintainer will maybe review your PR and dec

[cordova-js] branch brodybits-mark-5.0.0-dev deleted (was 0daa2a5)

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-mark-5.0.0-dev in repository https://gitbox.apache.org/repos/asf/cordova-js.git. was 0daa2a5 Mark 5.0.0-dev The revisions that were on this branch are still contained in other

[cordova-js] branch master updated (284c1b1 -> ab1b04b)

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-js.git. from 284c1b1 Merge pull request #168 from erisu/CB-14071 add ab1b04b Mark 5.0.0-dev (#170) No new revisions

[GitHub] brodybits opened a new pull request #170: Mark 5.0.0-dev

2018-09-18 Thread GitBox
brodybits opened a new pull request #170: Mark 5.0.0-dev URL: https://github.com/apache/cordova-js/pull/170 Needed since we did already drop Node.js 4 support and are planning to remove browserify This is an automated message

[cordova-js] 01/01: Mark 5.0.0-dev

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch brodybits-mark-5.0.0-dev in repository https://gitbox.apache.org/repos/asf/cordova-js.git commit 0daa2a51211acfbaabf90153d60c59bc511aba9b Author: Chris Brody AuthorDate: Tue Sep 18 11:22:13 20

[GitHub] brodybits closed pull request #170: Mark 5.0.0-dev

2018-09-18 Thread GitBox
brodybits closed pull request #170: Mark 5.0.0-dev URL: https://github.com/apache/cordova-js/pull/170 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL a

[cordova-js] branch brodybits-mark-5.0.0-dev created (now 0daa2a5)

2018-09-18 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-mark-5.0.0-dev in repository https://gitbox.apache.org/repos/asf/cordova-js.git. at 0daa2a5 Mark 5.0.0-dev This branch includes the following new commits: new 0daa2a5

[GitHub] kohlia commented on issue #339: Localizing hardcoded messages

2018-09-18 Thread GitBox
kohlia commented on issue #339: Localizing hardcoded messages URL: https://github.com/apache/cordova-plugin-camera/pull/339#issuecomment-422434744 So what now? This is an automated message from the Apache Git Service. To resp

[GitHub] mlegenhausen commented on issue #412: Unable to distribute with Xcode 10

2018-09-18 Thread GitBox
mlegenhausen commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-422430937 I used `fastlane deliver` today for uploading two apps build with Xcode 10 without problems. The only thing that needed to be changed so the

[GitHub] sgoldberg-sfdc commented on issue #409: Another possible Xcode 10 fix

2018-09-18 Thread GitBox
sgoldberg-sfdc commented on issue #409: Another possible Xcode 10 fix URL: https://github.com/apache/cordova-ios/pull/409#issuecomment-422430828 I believe when you generate a project using Cordova it uses the static library, so the framework issues will not appear in the typical workflow.

  1   2   >