[GitHub] codecov-io commented on issue #461: fix issue #458

2018-11-12 Thread GitBox
codecov-io commented on issue #461: fix issue #458 URL: https://github.com/apache/cordova-ios/pull/461#issuecomment-438165224 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/461?src=pr&el=h1) Report > Merging [#461](https://codecov.io/gh/apache/cordova-ios/pull/461?src=pr&el=d

[GitHub] regiMario commented on issue #461: fix issue #458

2018-11-12 Thread GitBox
regiMario commented on issue #461: fix issue #458 URL: https://github.com/apache/cordova-ios/pull/461#issuecomment-438160911 I tried running the tests before i uploaded and got this far. `[mario@mac13dev ~/github/cordova-ios]$ npm test > cordova-ios@5.0.0-dev test /Users/mario/gith

[GitHub] adilthree commented on issue #511: java.lang.RuntimeException: Unable to get provider com.google.android.gms.ads.MobileAdsInitProvider

2018-11-12 Thread GitBox
adilthree commented on issue #511: java.lang.RuntimeException: Unable to get provider com.google.android.gms.ads.MobileAdsInitProvider URL: https://github.com/apache/cordova-android/issues/511#issuecomment-438153984 compile 'com.google.android.gms:play-services-ads:12.0.0' add this depen

[GitHub] pengzhiqiang110 opened a new issue #65: 想问下这个插件怎么使用,

2018-11-12 Thread GitBox
pengzhiqiang110 opened a new issue #65: 想问下这个插件怎么使用, URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/65 这个插件怎么用啊 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] Narasimhulumadhana opened a new issue #114: upload media file in ionic data[0].fullPath not reading in readasDataUrl

2018-11-12 Thread GitBox
Narasimhulumadhana opened a new issue #114: upload media file in ionic data[0].fullPath not reading in readasDataUrl URL: https://github.com/apache/cordova-plugin-media-capture/issues/114 This is an automated message from th

[GitHub] brodybits edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-12 Thread GitBox
brodybits edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438018889 Reproduction steps in : * `cordova plugin add co

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-12 Thread GitBox
brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438018889 Reproduction steps in : * `cordova plugin add cordova-s

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-12 Thread GitBox
brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-437989889 P.S. This *may* affect : Document how to use Android NDK lib

[GitHub] jcesarmobile edited a comment on issue #34: lock on iOS does not work right after device ready event

2018-11-12 Thread GitBox
jcesarmobile edited a comment on issue #34: lock on iOS does not work right after device ready event URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-437976690 I don't know how to do Apache Cordova plugin releases, sorry, it's not as simple as publi

[GitHub] mpotter-modus commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape Orientation turn up-sidedown

2018-11-12 Thread GitBox
mpotter-modus commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape Orientation turn up-sidedown URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/25#issuecomment-437987205 @maverickmishra do you have any insight into whether a 3.0.2 release of this plugin i

[GitHub] brodybits commented on issue #542: Resolve GH-539 & GH-540 on master

2018-11-12 Thread GitBox
brodybits commented on issue #542: Resolve GH-539 & GH-540 on master URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437982480 I just remembered a TODO item is that the pluginHandler tests need to be renumbered, leaving this for the next PR. ---

[cordova-android] branch master updated (e31596f -> 576ad18)

2018-11-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from e31596f Remove obsolete check for JellyBean (GH-534) (#544) add 898a6a8 Add a unit test to test so

[GitHub] brodybits closed pull request #542: Resolve GH-539 & GH-540 on master

2018-11-12 Thread GitBox
brodybits closed pull request #542: Resolve GH-539 & GH-540 on master URL: https://github.com/apache/cordova-android/pull/542 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] dpogue commented on issue #32: Link `node_modules` during platform creation if it exists

2018-11-12 Thread GitBox
dpogue commented on issue #32: Link `node_modules` during platform creation if it exists URL: https://github.com/apache/cordova/issues/32#issuecomment-437981352 There are a bunch of similar-sounding problems here, and I think you've identified one and @erisu handled one, but they're not qu

[cordova-android] 01/01: Merge pull request #542 from brodybits/gh-540-hotfix

2018-11-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 576ad183e72376b8f525552d081a154f0e924eed Merge: e31596f ef493b4 Author: Chris Brody AuthorDate: Mon Nov 12 1

[GitHub] brodybits commented on issue #542: Resolve GH-539 & GH-540 on master

2018-11-12 Thread GitBox
brodybits commented on issue #542: Resolve GH-539 & GH-540 on master URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437980723 > I think we should fix .jar and .aar for now in a separate PR and investigate the .so I just raised #547 for that. Merging now.

[GitHub] brodybits opened a new issue #547: Compatibility of old plugins with non-Java source-file entries

2018-11-12 Thread GitBox
brodybits opened a new issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547 From &

[GitHub] jcesarmobile commented on issue #542: [WIP] Resolve GH-539 & GH-540 on master

2018-11-12 Thread GitBox
jcesarmobile commented on issue #542: [WIP] Resolve GH-539 & GH-540 on master URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437976956 All the plugin examples linked by @dpogue have .jar source-files except for the last one. They also happen to have .so files, n

[GitHub] jcesarmobile commented on issue #34: lock on iOS does not work right after device ready event

2018-11-12 Thread GitBox
jcesarmobile commented on issue #34: lock on iOS does not work right after device ready event URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-437976690 I don't know how to do Apache plugin releases, sorry, it's not as simple as publishing it in npm

[GitHub] mpotter-modus commented on issue #34: lock on iOS does not work right after device ready event

2018-11-12 Thread GitBox
mpotter-modus commented on issue #34: lock on iOS does not work right after device ready event URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-437974228 @jcesarmobile could we get a new release please so the changes can be pulled from the NPM repo?

[GitHub] brodybits commented on issue #507: Gradle updates

2018-11-12 Thread GitBox
brodybits commented on issue #507: Gradle updates URL: https://github.com/apache/cordova-android/pull/507#issuecomment-437968642 Or should some of the suggestions be considered in yet another PR? This is an automated message f

[GitHub] dpogue commented on issue #441: CB-14089: (android) Add Kotlin support

2018-11-12 Thread GitBox
dpogue commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-437968135 The status is that we're trying to find an option that doesn't unconditionally pull kotlin support libraries into all Cordova projects, alth

[GitHub] brodybits commented on issue #507: Gradle updates

2018-11-12 Thread GitBox
brodybits commented on issue #507: Gradle updates URL: https://github.com/apache/cordova-android/pull/507#issuecomment-437968251 I understand that Kotlin is out of scope. But I think some suggestions in #441 should be considered since they seem to be outside the scope of adding Kotlin. --

[GitHub] brodybits commented on a change in pull request #507: Gradle updates

2018-11-12 Thread GitBox
brodybits commented on a change in pull request #507: Gradle updates URL: https://github.com/apache/cordova-android/pull/507#discussion_r232750991 ## File path: bin/templates/project/app/build.gradle ## @@ -22,33 +22,32 @@ apply plugin: 'com.android.application' buildscrip

[GitHub] dpogue commented on issue #507: Gradle updates

2018-11-12 Thread GitBox
dpogue commented on issue #507: Gradle updates URL: https://github.com/apache/cordova-android/pull/507#issuecomment-437967593 I believe this is ready to be merged, but I'm not sure what you think it has to do with #441, which is proposing the addition of an entirely different feature.

[GitHub] brodybits commented on issue #441: CB-14089: (android) Add Kotlin support

2018-11-12 Thread GitBox
brodybits commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-437967179 What is the status of this proposal? If we merge PR #507 (Gradle updates) I think this one should be rebased. -

[GitHub] janpio commented on a change in pull request #507: Gradle updates

2018-11-12 Thread GitBox
janpio commented on a change in pull request #507: Gradle updates URL: https://github.com/apache/cordova-android/pull/507#discussion_r232750039 ## File path: bin/templates/project/app/build.gradle ## @@ -22,33 +22,32 @@ apply plugin: 'com.android.application' buildscript {

[GitHub] brodybits commented on issue #507: Gradle updates

2018-11-12 Thread GitBox
brodybits commented on issue #507: Gradle updates URL: https://github.com/apache/cordova-android/pull/507#issuecomment-437966890 I raised a few comments based on PR #441. Should we address these? Is this ready to be merged?

[GitHub] janpio commented on a change in pull request #507: Gradle updates

2018-11-12 Thread GitBox
janpio commented on a change in pull request #507: Gradle updates URL: https://github.com/apache/cordova-android/pull/507#discussion_r232749688 ## File path: bin/templates/project/app/build.gradle ## @@ -22,33 +22,32 @@ apply plugin: 'com.android.application' buildscript {

[GitHub] brodybits commented on a change in pull request #507: Gradle updates

2018-11-12 Thread GitBox
brodybits commented on a change in pull request #507: Gradle updates URL: https://github.com/apache/cordova-android/pull/507#discussion_r232749469 ## File path: bin/templates/project/app/build.gradle ## @@ -22,33 +22,32 @@ apply plugin: 'com.android.application' buildscrip

[GitHub] brodybits commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-11-12 Thread GitBox
brodybits commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r232747948 ## File path: bin/templates/project/app/build.gradle ## @@ -30,13 +34,16 @@ buildscript { depen

[GitHub] brodybits commented on a change in pull request #507: Gradle updates

2018-11-12 Thread GitBox
brodybits commented on a change in pull request #507: Gradle updates URL: https://github.com/apache/cordova-android/pull/507#discussion_r232748408 ## File path: bin/templates/project/app/build.gradle ## @@ -22,33 +22,32 @@ apply plugin: 'com.android.application' buildscrip

[GitHub] brodybits commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-11-12 Thread GitBox
brodybits commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r232747948 ## File path: bin/templates/project/app/build.gradle ## @@ -30,13 +34,16 @@ buildscript { depen

[GitHub] brodybits closed pull request #539: Fix dest overwrite

2018-11-12 Thread GitBox
brodybits closed pull request #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fro

[GitHub] brodybits commented on issue #539: Fix dest overwrite

2018-11-12 Thread GitBox
brodybits commented on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437962285 Closing now in favor of PR #542. I just put this change back onto the 7.1.x branch (including the original commits by @kkirby). I am closing this becau

[GitHub] brodybits closed pull request #535: Fix user agent match issue android pie

2018-11-12 Thread GitBox
brodybits closed pull request #535: Fix user agent match issue android pie URL: https://github.com/apache/cordova-android/pull/535 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[cordova-android] branch master updated: Remove obsolete check for JellyBean (GH-534) (#544)

2018-11-12 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git The following commit(s) were added to refs/heads/master by this push: new e31596f Remove obsolete check for J

[GitHub] brodybits closed issue #534: User agent check in Cordova.js raises exception in Android 9

2018-11-12 Thread GitBox
brodybits closed issue #534: User agent check in Cordova.js raises exception in Android 9 URL: https://github.com/apache/cordova-android/issues/534 This is an automated message from the Apache Git Service. To respond to the

[GitHub] brodybits closed pull request #544: Remove obsolete check for JellyBean (GH-534)

2018-11-12 Thread GitBox
brodybits closed pull request #544: Remove obsolete check for JellyBean (GH-534) URL: https://github.com/apache/cordova-android/pull/544 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-12 Thread GitBox
brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437956630 @j3k0 I just raised #546 for tracking of the issues with cordova-plugin-purchase.

[GitHub] brodybits opened a new issue #546: cordova-plugin-purchase plugin issues

2018-11-12 Thread GitBox
brodybits opened a new issue #546: cordova-plugin-purchase plugin issues URL: https://github.com/apache/cordova-android/issues/546 - installation was broken by 7.1.2 release (,

[GitHub] j3k0 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-12 Thread GitBox
j3k0 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437950138 > I wish you had reported it to us I didn't as I as thought I was doing something wrong and ended up finding work

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-12 Thread GitBox
brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437946441 > Yes, we had to put an [ugly hack](https://github.com/j3k0/cordova-plugin-purchase/blob/master/scripts/androidBefo

[GitHub] j3k0 edited a comment on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-12 Thread GitBox
j3k0 edited a comment on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437942669 > I think we will need another unit test to check installation of `.aidl` for cordova-plugin-purchase. Yes

[GitHub] dpogue commented on issue #461: fix issue #458

2018-11-12 Thread GitBox
dpogue commented on issue #461: fix issue #458 URL: https://github.com/apache/cordova-ios/pull/461#issuecomment-437942804 Just a note that the test failures are coming from [these tests](https://github.com/apache/cordova-ios/blob/master/tests/spec/unit/lib/list-devices.spec.js#L31-L33) tha

[GitHub] j3k0 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-12 Thread GitBox
j3k0 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437942669 > I think we will need another unit test to check installation of `.aidl` for cordova-plugin-purchase. Yes, we ha

[GitHub] brodybits commented on issue #542: [WIP] Resolve GH-539 & GH-540 on master

2018-11-12 Thread GitBox
brodybits commented on issue #542: [WIP] Resolve GH-539 & GH-540 on master URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437942538 Thanks @dpogue. The plugins you listed seem to use `.so` files, for which I recall that the installation location is not the same between

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-12 Thread GitBox
brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437941193 Thanks guys. We will test installation with both plugins before releasing the next patch. I think we will need anot

[GitHub] brodybits commented on issue #454: Use NSOperationQueue (GH-452)

2018-11-12 Thread GitBox
brodybits commented on issue #454: Use NSOperationQueue (GH-452) URL: https://github.com/apache/cordova-ios/pull/454#issuecomment-437935236 P.S. If we merge this one I would like to see a similar change on cordova-osx (macOS), just raised f

[GitHub] brodybits commented on issue #454: Use NSOperationQueue (GH-452)

2018-11-12 Thread GitBox
brodybits commented on issue #454: Use NSOperationQueue (GH-452) URL: https://github.com/apache/cordova-ios/pull/454#issuecomment-437934794 I just updated the title to quickly reflect the actual proposed change. I would favor this change in general for the next major release, would like to

[GitHub] regiMario commented on issue #458: cordova run --list --device fails for Virtualhere devices

2018-11-12 Thread GitBox
regiMario commented on issue #458: cordova run --list --device fails for Virtualhere devices URL: https://github.com/apache/cordova-ios/issues/458#issuecomment-437934005 Had to read up on that first. Done as good as i could for the first time. ---

[GitHub] brodybits opened a new issue #70: Use NSOperationQueue to resolve possible concurrency issue on macOS

2018-11-12 Thread GitBox
brodybits opened a new issue #70: Use NSOperationQueue to resolve possible concurrency issue on macOS URL: https://github.com/apache/cordova-osx/issues/70 Similar to issue discussed for iOS in apache/cordova-ios#452, with PR proposed in for iOS in apache/cordova-ios#454 --

[GitHub] regiMario opened a new pull request #461: fix issue #458

2018-11-12 Thread GitBox
regiMario opened a new pull request #461: fix issue #458 URL: https://github.com/apache/cordova-ios/pull/461 ### Platforms affected iOS ### What does this PR do? I'm using Virtualhere (https://www.virtualhere.com/home) for developing remotely. While Safari and Xcode

[GitHub] brodybits commented on issue #452: [Discussion]Why not use nsoperation queue instead of dispatch queue in CDVCommandDelegateImpl.m?

2018-11-12 Thread GitBox
brodybits commented on issue #452: [Discussion]Why not use nsoperation queue instead of dispatch queue in CDVCommandDelegateImpl.m? URL: https://github.com/apache/cordova-ios/issues/452#issuecomment-437926769 It would be great if someone could post a plugin that demonstrates this issue.

[GitHub] dpogue commented on issue #543: Cordova Platform add Android command failure

2018-11-12 Thread GitBox
dpogue commented on issue #543: Cordova Platform add Android command failure URL: https://github.com/apache/cordova-android/issues/543#issuecomment-437924312 This sounds like an npm issue rather than specifically a Cordova issue. It's normal to have the `node_modules/.staging` folder during

[GitHub] dpogue closed issue #543: Cordova Platform add Android command failure

2018-11-12 Thread GitBox
dpogue closed issue #543: Cordova Platform add Android command failure URL: https://github.com/apache/cordova-android/issues/543 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] jcesarmobile closed issue #34: lock on iOS does not work right after device ready event

2018-11-12 Thread GitBox
jcesarmobile closed issue #34: lock on iOS does not work right after device ready event URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/34 This is an automated message from the Apache Git Service. To

[GitHub] jcesarmobile commented on issue #34: lock on iOS does not work right after device ready event

2018-11-12 Thread GitBox
jcesarmobile commented on issue #34: lock on iOS does not work right after device ready event URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-437916380 Closing as it's fixed in that commit ---

[GitHub] mpotter-modus commented on issue #34: lock on iOS does not work right after device ready event

2018-11-12 Thread GitBox
mpotter-modus commented on issue #34: lock on iOS does not work right after device ready event URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-437914978 Confirmed - we're having the same issue. Looks like this was fixed in a89e94c Any plans t

[GitHub] AutoAlert opened a new issue #373: Cannot take pictures on Android 8

2018-11-12 Thread GitBox
AutoAlert opened a new issue #373: Cannot take pictures on Android 8 URL: https://github.com/apache/cordova-plugin-camera/issues/373 If I try and take a photo on a device using Android 8 with targetSDK 26, i get an error > file:///data/user/0/{mypackage}/cache/Capture.jpg exposed be

[GitHub] mahnuh opened a new issue #372: Cropping image from camera not working on iOS

2018-11-12 Thread GitBox
mahnuh opened a new issue #372: Cropping image from camera not working on iOS URL: https://github.com/apache/cordova-plugin-camera/issues/372 When taking a picture with the camera I'm not able to crop the image. As you can see in the following video the image always bounces back, even avert

[GitHub] oliversalzburg commented on issue #452: [Discussion]Why not use nsoperation queue instead of dispatch queue in CDVCommandDelegateImpl.m?

2018-11-12 Thread GitBox
oliversalzburg commented on issue #452: [Discussion]Why not use nsoperation queue instead of dispatch queue in CDVCommandDelegateImpl.m? URL: https://github.com/apache/cordova-ios/issues/452#issuecomment-437832852 It sounds reasonable and the change seems minor, but I know too little of th

[GitHub] saikiran1264 opened a new issue #545: cordova platform add android command is not working in windows 10

2018-11-12 Thread GitBox
saikiran1264 opened a new issue #545: cordova platform add android command is not working in windows 10 URL: https://github.com/apache/cordova-android/issues/545 Hi, I have followed exactly the belows steps in my windows 10 npm install -g cordova cd my_project cordova platfo

[GitHub] afdev82 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-12 Thread GitBox
afdev82 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437791781 > @afdev82 it would really help us if you can name the specific plugin that triggers this issue. > > We will n