[GitHub] dpogue commented on issue #559: Ignore version file in eslint to resolve build error

dpogue commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438935516 > I may be wrong here. Not sure if I would favor an extra eslint comment though. Build of `master` branch is green again,

[GitHub] ECNU3D commented on issue #454: Use NSOperationQueue (GH-452)

ECNU3D commented on issue #454: Use NSOperationQueue (GH-452) URL: https://github.com/apache/cordova-ios/pull/454#issuecomment-438925110 @brodybits thanks, I will try to follow that document and post some plugin to demonstrate the issue.

[GitHub] artuska edited a comment on issue #260: File becomes [object Object] in FormData

artuska edited a comment on issue #260: File becomes [object Object] in FormData URL: https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438918491 About the Blob. There are a lot of weird stuff here about the Blob in Cordova. I used some custom file chooser (do

[GitHub] artuska commented on issue #260: File becomes [object Object] in FormData

artuska commented on issue #260: File becomes [object Object] in FormData URL: https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438918491 About the Blob. There are a lot of weird stuff here about the Blob in Cordova. I used some custom file chooser (do not

[GitHub] blukis opened a new issue #560: Content-security-policy bug

blukis opened a new issue #560: Content-security-policy bug URL: https://github.com/apache/cordova-android/issues/560 I believe I found an issue with content-security-policy in cordova environment... I have an app that includes this page in an iframe:

[GitHub] brodybits commented on issue #555: 7.1.3 patch updates

brodybits commented on issue #555: 7.1.3 patch updates URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438911311 I just finished testing the patch updates with some plugins listed in the OP description, quick review would be appreciated.

[GitHub] artuska commented on issue #260: File becomes [object Object] in FormData

artuska commented on issue #260: File becomes [object Object] in FormData URL: https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438907238 @Polypants in my case the reason why some Androids cannot select files from the file system and returns `null` is

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438905081 Payments plugin is not supported here. For payments problem please raise a new issue on the payments plugin

[GitHub] nagthgr8 commented on issue #547: Compatibility of old plugins with non-Java source-file entries

nagthgr8 commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438900353 Guys, can anyone help me understand why does build succeed on such breaking changes, the runtime failures are

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

brodybits commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-43302 > That would involve updating the cordova-coho tool. I may be wrong here. Not sure if I would favor an extra eslint

[GitHub] brodybits closed pull request #559: Ignore version file in eslint to resolve build error

brodybits closed pull request #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[cordova-android] branch master updated: eslint ignore version file (#559)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git The following commit(s) were added to refs/heads/master by this push: new f1396c7 eslint ignore version file

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

brodybits commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438883292 Build is green, merging now This is an automated message

[GitHub] dpolivy commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

dpolivy commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438873097 I'm seeing a potentially similar issue with `UIWebView` on iOS 12: if you are scrolled to the bottom of the page

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

brodybits commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438869673 Passes on Travis CI now, will watch for the result on AppVeyor. Hope we can get this finished soon.

[GitHub] brodybits commented on issue #559: Ignore version file in eslint to resolve build error

brodybits commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438866450 > There might be an eslint ignore comment we can wrap around the version line to suppress the error? That would

[GitHub] dpogue commented on issue #559: Ignore version file in eslint to resolve build error

dpogue commented on issue #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559#issuecomment-438866164 There might be an eslint ignore comment we can wrap around the version line to suppress the error?

[GitHub] brodybits opened a new pull request #559: Ignore version file in eslint to resolve build error

brodybits opened a new pull request #559: Ignore version file in eslint to resolve build error URL: https://github.com/apache/cordova-android/pull/559 This change should to give us a green build again. Rationale is that the eslint update introduced in

[GitHub] brodybits closed pull request #199: [WIP] Add previous patch dependency note

brodybits closed pull request #199: [WIP] Add previous patch dependency note URL: https://github.com/apache/cordova-coho/pull/199 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] brodybits commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP

brodybits commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438857403 > I don't see #551 fix in the resulting changes Just added it, thanks for catching it! FYI This PR is still marked as WIP

[GitHub] jcesarmobile commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP

jcesarmobile commented on issue #555: [WIP] 7.1.3 patch updates - proposed WIP URL: https://github.com/apache/cordova-android/pull/555#issuecomment-438854815 I don't see https://github.com/apache/cordova-android/pull/551 fix in the resulting changes

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438847411 Thanks @jcesarmobile for the detailed review! This is an

[cordova-android] 01/01: Merge pull request #550 from brodybits/gh-547-bugfix

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 21ae48eada2f1aebe970857c5d54eadcc91fd16d Merge: 53e1c1b a67bc75 Author: Chris Brody AuthorDate: Wed Nov 14

[GitHub] brodybits closed pull request #550: Fix for old plugins with non-Java sources (GH-547)

brodybits closed pull request #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[cordova-android] branch master updated (53e1c1b -> 21ae48e)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 53e1c1b Set version & VERSION to 8.0.0-dev (coho) add 9d03e4e Fix tests of plugin files with new

[GitHub] brodybits commented on issue #558: Mark 8.0.0-dev & update cordova.js

brodybits commented on issue #558: Mark 8.0.0-dev & update cordova.js URL: https://github.com/apache/cordova-android/pull/558#issuecomment-438845851 > Why is a PR with failing tests being merged? It is a build error, no actually failing tests. I deleted my branch right after

[GitHub] janpio commented on issue #194: onDestroy and dealloc ambiguity

janpio commented on issue #194: onDestroy and dealloc ambiguity URL: https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438839380 Yes, that sounds very reasonable. Maybe an additional [`MediaError`](https://github.com/apache/cordova-plugin-media#mediaerror)? Is

[GitHub] janpio commented on issue #558: Mark 8.0.0-dev

janpio commented on issue #558: Mark 8.0.0-dev URL: https://github.com/apache/cordova-android/pull/558#issuecomment-438837496 Why is a PR with failing tests being merged? Why does this PR contain a lot more than it says in the PR title? Why does this PR refer to a WIP and unmerged

[GitHub] brodybits closed pull request #558: Mark 8.0.0-dev

brodybits closed pull request #558: Mark 8.0.0-dev URL: https://github.com/apache/cordova-android/pull/558 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[cordova-android] branch master updated (7eed65e -> 53e1c1b)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 7eed65e GH-552 (android) check for build-extras.gradle in the app-parent directory (#553) add

[GitHub] brodybits opened a new pull request #558: Mark 8.0.0-dev

brodybits opened a new pull request #558: Mark 8.0.0-dev URL: https://github.com/apache/cordova-android/pull/558 According to the following steps taken, using local checkout of cordova-coho with `improve-patch-and-dev-version-support` branch as proposed in

[GitHub] Polypants commented on issue #260: File becomes [object Object] in FormData

Polypants commented on issue #260: File becomes [object Object] in FormData URL: https://github.com/apache/cordova-plugin-file/issues/260#issuecomment-438802756 @artuska how exactly did you do that? I'm dealing with the same issue

[GitHub] wspresto commented on issue #194: onDestroy and dealloc ambiguity

wspresto commented on issue #194: onDestroy and dealloc ambiguity URL: https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438801783 Correct. That is what was happening in my situation which was causing a bug in my use case. I personally do not believe the plugin

[GitHub] shokry055 commented on issue #120: When getting location does'nt return anything or return empty error with a timeout (Android Oreo)

shokry055 commented on issue #120: When getting location does'nt return anything or return empty error with a timeout (Android Oreo) URL: https://github.com/apache/cordova-plugin-geolocation/issues/120#issuecomment-438794450 +1

[GitHub] shokry055 commented on issue #119: Getting location with high accuracy taking time more than 4 mins

shokry055 commented on issue #119: Getting location with high accuracy taking time more than 4 mins URL: https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-438794348 same here i takes more than 3 minutes or return code 3 TO

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438788760 @janpio I was thinking to do a merge commit to keep the cleanup changes separate from the behavior change. I think it makes

[GitHub] datamystic closed issue #187: Dies under iPhone XHR

datamystic closed issue #187: Dies under iPhone XHR URL: https://github.com/apache/cordova-plugin-media/issues/187 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[cordova-lib] branch azure-pipelines updated (4fa827a -> 6dc2051)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch azure-pipelines in repository https://gitbox.apache.org/repos/asf/cordova-lib.git. discard 4fa827a add job on macOS discard 20f2fec extract steps to own file discard 9c98b80 add another

[GitHub] janpio commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

janpio commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438779027 How can you add a non-merged PR to a new PR? Did you just cherry pick the individual commits? If so, I would advise

[GitHub] janpio commented on issue #194: onDestroy and dealloc ambiguity

janpio commented on issue #194: onDestroy and dealloc ambiguity URL: https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438778052 Ok, now I think I understand - the plugin could report "playback successfully finished" to the web app even though the OS pulled the rug

[GitHub] wspresto commented on issue #194: onDestroy and dealloc ambiguity

wspresto commented on issue #194: onDestroy and dealloc ambiguity URL: https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438776438 Sure. For Android specifically, When the success callback is triggered, there is client JavaScript code that is executed on the

[cordova-lib] branch azure-pipelines updated (501c9ab -> 4fa827a)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch azure-pipelines in repository https://gitbox.apache.org/repos/asf/cordova-lib.git. omit 501c9ab add job on macOS add 4fa827a add job on macOS This update added new revisions after

[cordova-lib] branch azure-pipelines updated (f0a73ad -> 501c9ab)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch azure-pipelines in repository https://gitbox.apache.org/repos/asf/cordova-lib.git. discard f0a73ad add job on macOS add 501c9ab add job on macOS This update added new revisions after

[cordova-lib] branch azure-pipelines updated (9c98b80 -> f0a73ad)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch azure-pipelines in repository https://gitbox.apache.org/repos/asf/cordova-lib.git. from 9c98b80 add another newline at the end to trigger another CI run add 20f2fec extract steps to

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438768035 I just added these changes to PR #555 on 7.x for a patch release, hope we can make it soon!

[GitHub] janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438766049 Best minimize the HTML as well so it is really just the needed elements then please.

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438766049 Best minimize the HTML as well so it is really just the needed elements then please.-

[GitHub] janpio edited a comment on issue #194: onDestroy and dealloc ambiguity

janpio edited a comment on issue #194: onDestroy and dealloc ambiguity URL: https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438765687 We are always open for Pull Requests improving the plugin. That being said, I don't really understand what currently doesn't

[GitHub] janpio commented on issue #194: onDestroy and dealloc ambiguity

janpio commented on issue #194: onDestroy and dealloc ambiguity URL: https://github.com/apache/cordova-plugin-media/issues/194#issuecomment-438765687 We are always open for Pull Requests improving the plugin. That being said, I don't really understand what currently doesn't work as

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438765761 Just removed the comment, my bad. This is an automated

[GitHub] jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438762849 I still see the thanks comment, can you remove it? This

[GitHub] Kasun002 opened a new issue #121: Askin permission when need

Kasun002 opened a new issue #121: Askin permission when need URL: https://github.com/apache/cordova-plugin-geolocation/issues/121 Iam using this plugin with this permission how to ask permission when we need only. In my situation it ask location when

[GitHub] wspresto opened a new issue #194: onDestroy and dealloc ambiguity

wspresto opened a new issue #194: onDestroy and dealloc ambiguity URL: https://github.com/apache/cordova-plugin-media/issues/194 Currently, it is impossible for client code to interpret the state or event in which the underlying native Media object has been destroyed when the OS is

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438732150 > `app/src/main` is used multiple times, might be worth to put it in a variable Done. CanI get a final approval to

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438724335 Yeah without the status bar plugin, I get the same result as the browser :) Actually I

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438714101 I think the primary rule should be to place files based on target-dir prefix, i.e. `app` vs `src` vs `lib`, and extensions

[GitHub] brodybits opened a new issue #557: Inconsistent installation of NDK .so files

brodybits opened a new issue #557: Inconsistent installation of NDK .so files URL: https://github.com/apache/cordova-android/issues/557 For JAR files I can think of the following options: * `source-file` element with `libs` or `app/libs` target dir * `lib-file` element AFAIK

[GitHub] janpio commented on issue #907: browser platform is missing from sections

janpio commented on issue #907: browser platform is missing from sections URL: https://github.com/apache/cordova-docs/issues/907#issuecomment-438692446 Is `browser` really a fully supported platform? Is plugin support good enough?

[GitHub] brodybits opened a new issue #908: Platform Centered Workflow missing for macOS ("osx")

brodybits opened a new issue #908: Platform Centered Workflow missing for macOS ("osx") URL: https://github.com/apache/cordova-docs/issues/908 **Issue Type** [x] Bug [ ] Feature Request **Priority** [x] Minor [ ] Major [ ] Critical [ ] Blocker

[GitHub] brodybits opened a new issue #907: browser platform is missing from sections

brodybits opened a new issue #907: browser platform is missing from sections URL: https://github.com/apache/cordova-docs/issues/907 **Issue Type** [x] Bug [ ] Feature Request **Priority** [ ] Minor [x] Major [ ] Critical [ ] Blocker

[cordova-docs] branch brodybits-ios-create-docfix created (now e9017e7)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-ios-create-docfix in repository https://gitbox.apache.org/repos/asf/cordova-docs.git. at e9017e7 Remove incorrect info for cordova-ios-bin/create This branch includes the

[GitHub] brodybits opened a new pull request #906: Remove incorrect info for cordova-ios-bin/create

brodybits opened a new pull request #906: Remove incorrect info for cordova-ios-bin/create URL: https://github.com/apache/cordova-docs/pull/906 This is an automated message from the Apache Git Service. To respond to the

[cordova-docs] 01/01: Remove incorrect info for cordova-ios-bin/create

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch brodybits-ios-create-docfix in repository https://gitbox.apache.org/repos/asf/cordova-docs.git commit e9017e75c80a9749f26ce1b93166f5a36879703a Author: Chris Brody AuthorDate: Wed Nov 14

[GitHub] thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438682821 My solution was use a plugin or any thing to detect the event on keyboard native hide, and on this

[GitHub] uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438684410 Awesome. Thank you very much, will keep an eye on 7.1.3 official release and update plugin and docs accordingly. Cheers! 

[GitHub] brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438684105 > Is there a way to declare paths in `plugin.xml` in a way that it supports both, `cordova-android@6` and

[GitHub] thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

thepianist2 edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438682821 My solution was use a plugin or any thing to detect the event on keyboard native hide, and on this

[GitHub] thepianist2 commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

thepianist2 commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-438682821 My solution was use a plugin or any thing to detect the event on keyboard native hide, and on this moment

[GitHub] uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

uerceg commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438680723 Awesome guys, thanks for super quick reply. I tried @brodybits's flow with nightly build and it works like a charm. Nice.

[GitHub] brodybits opened a new issue #556: app/build.gradle vs legacy/build.gradle?

brodybits opened a new issue #556: app/build.gradle vs legacy/build.gradle? URL: https://github.com/apache/cordova-android/issues/556 Can someone explain the relationship between `bin/templates/project/app/build.gradle` and `bin/templates/project/legacy/build.gradle`? Do they work

[GitHub] brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438679242 Closing since PR #553 was merged. This should be fixed in upcoming 7.1.3 release.

[GitHub] brodybits closed issue #552: Cordova project ignores build-extras after toolchain upgrade

brodybits closed issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552 This is an automated message from the Apache Git Service. To respond to the

[GitHub] janpio commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

janpio commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438679126 (FYI: Can also reproduce @brodybits' temp fix via using nightly [we seem to have replied at the same time])

[GitHub] brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438678457 P.S. Once PR #550 is merged and released you should not need the cordova-8 changes in

[GitHub] janpio commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

janpio commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438678478 (FYI: Can reproduce on Windows with same Cordova CLI version)

[GitHub] brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

brodybits commented on issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554#issuecomment-438677676 Already solved in `master`, tested as follows: * `cordova platform add cordova-android@nightly` * `cordova plugin

[GitHub] brodybits closed issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

brodybits closed issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12

janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438675407 What version of `cordova-ios` are you using? The best way for us to reporoduce and later debug this issue

[GitHub] jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438669256 It knows nothing about any file extension at all, this PR is the one placing files based on the extension

[GitHub] Nazirovich commented on issue #345: In App Browser - doesn't load webpage in iOS 12

Nazirovich commented on issue #345: In App Browser - doesn't load webpage in iOS 12 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438667199 > You are posting this in the Cordova plugin repository, not Ionic. Any specific reason why you are using the

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438665079 > [...] it also has `.h` and `.c` files that are treated as `.java` files. > They were `src/c/common/mylib/parts` and he

[GitHub] janpio edited a comment on issue #345: In App Browser - doesn't load webpage in iOS 12

janpio edited a comment on issue #345: In App Browser - doesn't load webpage in iOS 12 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438664689 You are posting this in the Cordova plugin repository, not Ionic. Any specific reason why you are using the

[GitHub] janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12

janpio commented on issue #345: In App Browser - doesn't load webpage in iOS 12 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/345#issuecomment-438664689 You are posting this in the Cordova plugin repository, not Ionic. Any specific reason why you are using the Ionic

[GitHub] Nazirovich opened a new issue #345: In App Browser - doesn't load webpage in iOS 12

Nazirovich opened a new issue #345: In App Browser - doesn't load webpage in iOS 12 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/345 **Ionic version:** [ ] 1.x [ ] 2.x [X] 3.x **I'm submitting a ...** (check one with "x") [x ] bug report

[GitHub] duncan-c edited a comment on issue #173: App crashes on ANDROID 8 version

duncan-c edited a comment on issue #173: App crashes on ANDROID 8 version URL: https://github.com/apache/cordova-plugin-contacts/issues/173#issuecomment-434470449 Have done now: https://github.com/apache/cordova-plugin-contacts/pull/180 I wasn't sure if I should as the plugin is marked

[GitHub] janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438662302 And without the statusbar plugin, you get the same result as in the browser? I think

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438662302 And without the statusbar plugin, you get the same result as in the browser? I think it

[GitHub] OmarHassan25 commented on issue #173: App crashes on ANDROID 8 version

OmarHassan25 commented on issue #173: App crashes on ANDROID 8 version URL: https://github.com/apache/cordova-plugin-contacts/issues/173#issuecomment-438661600 @duncan-c updated ContactManager.java solves the problem This

[GitHub] brodybits commented on issue #468: Update CordovaResourceApi.java

brodybits commented on issue #468: Update CordovaResourceApi.java URL: https://github.com/apache/cordova-android/pull/468#issuecomment-438659079 Can we move some of this functionality into a plugin? This is an automated

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438654508 *cordova This is an

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears URL: https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-438654430 sure!

[cordova-android] branch master updated: GH-552 (android) check for build-extras.gradle in the app-parent directory (#553)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git The following commit(s) were added to refs/heads/master by this push: new 7eed65e GH-552 (android) check for

[GitHub] brodybits closed pull request #553: #552: (android) check for build-extras.gradle in the app-parent directory

brodybits closed pull request #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] janpio commented on issue #94: check for required permission before video capture

janpio commented on issue #94: check for required permission before video capture URL: https://github.com/apache/cordova-plugin-media-capture/pull/94#issuecomment-438652925 This PR here seems to have quite some more code and differentiates between different permissions being required.

[GitHub] brodybits opened a new pull request #555: [WIP] 7.1.3 patch updates - proposed

brodybits opened a new pull request #555: [WIP] 7.1.3 patch updates - proposed URL: https://github.com/apache/cordova-android/pull/555 * Remove obsolete check for JellyBean to work properly on Android Pie (GH-534) * GH-539 fix destination path fallback * GH-540 fix for source-file

[GitHub] uerceg opened a new issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update

uerceg opened a new issue #554: ERR_INVALID_ARG_TYPE after android@7.1.2 update URL: https://github.com/apache/cordova-android/issues/554 Hey guys. We have our plugin built for Cordova and the version on Github `master` branch is compatible with pre `android@7.0.0` platform version.

[GitHub] brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438645251 Thanks @DavidWiesner, would like to get review from one more member before merging. If someone

[GitHub] ffMathy edited a comment on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices

ffMathy edited a comment on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices URL: https://github.com/apache/cordova-plugin-media-capture/pull/100#issuecomment-438601158 Do you have a list of committers somewhere that would elligible for that

[GitHub] ffMathy commented on issue #94: check for required permission before video capture

ffMathy commented on issue #94: check for required permission before video capture URL: https://github.com/apache/cordova-plugin-media-capture/pull/94#issuecomment-438643472 #95? This is an automated message from the

[GitHub] brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade

brodybits commented on issue #552: Cordova project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552#issuecomment-438643092 From the history it looks like the work was done in PR #389. It seems like they did try to preserve

  1   2   >