[GitHub] [cordova-android] erisu commented on issue #438: Add support for EnableGoogleServicesPlugin

2020-01-15 Thread GitBox
erisu commented on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-574946339 @chemerisuk I do not have an issue ticket on the `phonegap-plugin-push` issues I mentioned. But I pushed a PR that briefly explains some c

[GitHub] [cordova-android] erisu commented on issue #438: Add support for EnableGoogleServicesPlugin

2020-01-14 Thread GitBox
erisu commented on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-574463652 @chemerisuk I went ahead and created a second PR to be able to quickly fix the merge conflicts as well as apply the additional change requ

[GitHub] [cordova-android] erisu commented on issue #438: Add support for EnableGoogleServicesPlugin

2020-01-13 Thread GitBox
erisu commented on issue #438: Add support for EnableGoogleServicesPlugin URL: https://github.com/apache/cordova-android/pull/438#issuecomment-573939558 @chemerisuk I would like to try and get this PR updated and merged before the upcoming major release. If possible, could you rebase