[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-11-28 Thread GitBox
infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-347703326 1. The package.json's version is meaningless since this is a PR and not released code. It should read 6.5.0-dev

[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-30 Thread GitBox
infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-340582879 @macdonst Read @stevegill's note about changing package.json when testing locally. If you don't do this, you will

[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-19 Thread GitBox
infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-338001365 Bad news: There's issues with the installation of the File Plugin, and cordova clean doesn't work properly, so

[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-18 Thread GitBox
infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-337675034 @stevengill Doesn't npm linking cordova-common do the same thing?

[GitHub] infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit

2017-10-03 Thread git
infil00p commented on issue #389: CB-11244: Studio Project Compatibility: Now with merge commit URL: https://github.com/apache/cordova-android/pull/389#issuecomment-333994635 @dpogue @filmaj This should be ready to review once the cordova-common code change is added.