[GitHub] knight9999 commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command.

2019-01-10 Thread GitBox
knight commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command. URL: https://github.com/apache/cordova-ios/pull/487#issuecomment-453329118 @shazron Thanks you for the great work https://github.com/apache/cordova-ios/pull/494 . This resol

[GitHub] knight9999 commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command.

2019-01-09 Thread GitBox
knight commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command. URL: https://github.com/apache/cordova-ios/pull/487#issuecomment-452946636 The patch in https://github.com/ios-control/ios-deploy/issues/364#issuecomment-452627292 may be the

[GitHub] knight9999 commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command.

2019-01-09 Thread GitBox
knight commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command. URL: https://github.com/apache/cordova-ios/pull/487#issuecomment-452944002 @dpogue Thanks for the comment. > I am still having trouble with Xcode 10 not making valid builds,

[GitHub] knight9999 commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command.

2019-01-09 Thread GitBox
knight commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command. URL: https://github.com/apache/cordova-ios/pull/487#issuecomment-452940989 @shazron Thanks for the comment. You means `cordova run` or `cordova build`? I removed all the c

[GitHub] knight9999 commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command.

2019-01-06 Thread GitBox
knight commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command. URL: https://github.com/apache/cordova-ios/pull/487#issuecomment-451828557 @brodybits I have already updated my PR and now my PR passes all CI Checks. Would you please re-rev

[GitHub] knight9999 commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command.

2018-12-24 Thread GitBox
knight commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command. URL: https://github.com/apache/cordova-ios/pull/487#issuecomment-449789777 Thanks for the valuable comment @brodybits . I have updated my PR as you mentioned. -