[GitHub] shazron commented on issue #442: Fix Java tests and cleanup CI

2018-06-13 Thread GitBox
shazron commented on issue #442: Fix Java tests and cleanup CI URL: https://github.com/apache/cordova-android/pull/442#issuecomment-396838105 I don't think Joe can chime in, he can't devote time to this at this juncture -- we'll just have to pull this in since its a blocker for other PRs,

[GitHub] shazron commented on issue #49: Package update WIP FOR DISCUSSION

2018-06-13 Thread GitBox
shazron commented on issue #49: Package update WIP FOR DISCUSSION URL: https://github.com/apache/cordova-osx/pull/49#issuecomment-396830850 Sounds good to me -- don't forget the major version update This is an automated

[GitHub] brodybits commented on issue #49: Package update WIP FOR DISCUSSION

2018-06-13 Thread GitBox
brodybits commented on issue #49: Package update WIP FOR DISCUSSION URL: https://github.com/apache/cordova-osx/pull/49#issuecomment-396832624 Good point @Shazron! This is an automated message from the Apache Git Service.

[GitHub] rdksgit commented on issue #115: Support for passing request headers for android

2018-06-13 Thread GitBox
rdksgit commented on issue #115: Support for passing request headers for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/115#issuecomment-396895675 Does this work with ios This is an automated message

[GitHub] raphinesse commented on issue #442: Fix Java tests and cleanup CI

2018-06-13 Thread GitBox
raphinesse commented on issue #442: Fix Java tests and cleanup CI URL: https://github.com/apache/cordova-android/pull/442#issuecomment-396892727 Thanks for the info @shazron. I will go ahead, give this a last polish and merge then. I am quite confident that these changes are OK.

[cordova-android] branch master updated (bf29fe0 -> 2106e2e)

2018-06-13 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from bf29fe0 CB-14101 Fix Java version check for Java >= 9 (#446) add 0d4b9f4 Fix output and exit

[cordova-android] 01/01: Merge pull request #442 from raphinesse/fix-tests

2018-06-13 Thread raphinesse
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 2106e2e081b08f86f0da57d795b2f441566f297f Merge: bf29fe0 d3c80ea Author: Raphael von der GrĂ¼n AuthorDate:

[GitHub] brodybits commented on issue #451: Minor release items: cordova-common 2.2.3 update with node 4 enabled again

2018-06-13 Thread GitBox
brodybits commented on issue #451: Minor release items: cordova-common 2.2.3 update with node 4 enabled again URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397035995 Now tested as follows: - passes `npm test` on Travis CI - Using `cordova platform add

[GitHub] brodybits commented on issue #369: Cleanup WIP FOR DISCUSSION

2018-06-13 Thread GitBox
brodybits commented on issue #369: Cleanup WIP FOR DISCUSSION URL: https://github.com/apache/cordova-ios/pull/369#issuecomment-397017011 Closing for now This is an automated message from the Apache Git Service. To respond to

[GitHub] codecov-io commented on issue #451: Minor release items: cordova-common 2.2.3 update with node 4 enabled again

2018-06-13 Thread GitBox
codecov-io commented on issue #451: Minor release items: cordova-common 2.2.3 update with node 4 enabled again URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=h1) Report > Merging

[GitHub] brodybits opened a new pull request #370: Package updates for minor release - PENDING WIP

2018-06-13 Thread GitBox
brodybits opened a new pull request #370: Package updates for minor release - PENDING WIP URL: https://github.com/apache/cordova-ios/pull/370 ### Platforms affected iOS ### What does this PR do? - Update to plist@3 (#367) - Cleanup devDependencies: remove

[GitHub] codecov-io commented on issue #451: Enable node 4 (again) & cordova-common 2.2.3 update for minor release [WIP]

2018-06-13 Thread GitBox
codecov-io commented on issue #451: Enable node 4 (again) & cordova-common 2.2.3 update for minor release [WIP] URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=h1) Report > Merging

[GitHub] brodybits opened a new pull request #451: Enable node 4 (again) & cordova-common 2.2.3 update

2018-06-13 Thread GitBox
brodybits opened a new pull request #451: Enable node 4 (again) & cordova-common 2.2.3 update URL: https://github.com/apache/cordova-android/pull/451 ### Platforms affected Android ### What does this PR do? Items wanted for minor release: -

[GitHub] codecov-io commented on issue #368: package.json cleanup devDependencies

2018-06-13 Thread GitBox
codecov-io commented on issue #368: package.json cleanup devDependencies URL: https://github.com/apache/cordova-ios/pull/368#issuecomment-396781013 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/368?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #368: package.json cleanup devDependencies

2018-06-13 Thread GitBox
codecov-io commented on issue #368: package.json cleanup devDependencies URL: https://github.com/apache/cordova-ios/pull/368#issuecomment-396781013 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/368?src=pr=h1) Report > Merging

[GitHub] raphinesse commented on issue #451: Enable node 4 (again) & cordova-common 2.2.3 update for minor release [WIP]

2018-06-13 Thread GitBox
raphinesse commented on issue #451: Enable node 4 (again) & cordova-common 2.2.3 update for minor release [WIP] URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397030928 Why do we need the dependency update before unbundling the dependencies (and thus the next major

[GitHub] codecov-io commented on issue #371: CI testing on Node.js versions 8 & 10

2018-06-13 Thread GitBox
codecov-io commented on issue #371: CI testing on Node.js versions 8 & 10 URL: https://github.com/apache/cordova-ios/pull/371#issuecomment-397159825 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/371?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #367: Update to plist@3 WIP

2018-06-13 Thread GitBox
codecov-io commented on issue #367: Update to plist@3 WIP URL: https://github.com/apache/cordova-ios/pull/367#issuecomment-396776897 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/367?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #368: package.json cleanup devDependencies

2018-06-13 Thread GitBox
codecov-io commented on issue #368: package.json cleanup devDependencies URL: https://github.com/apache/cordova-ios/pull/368#issuecomment-396781013 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/368?src=pr=h1) Report > Merging

[cordova-android] 01/01: Merge pull request #449 from jcesarmobile/CB-14125

2018-06-13 Thread jcesarmobile
This is an automated email from the ASF dual-hosted git repository. jcesarmobile pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 472ab626d654842484b7eb5c377df16c42bdd2af Merge: 2106e2e 83e9aef Author: jcesarmobile AuthorDate: Wed Jun

[cordova-android] branch master updated (2106e2e -> 472ab62)

2018-06-13 Thread jcesarmobile
This is an automated email from the ASF dual-hosted git repository. jcesarmobile pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 2106e2e Merge pull request #442 from raphinesse/fix-tests add 83e9aef CB-14125:(android)

[GitHub] jcesarmobile commented on issue #449: CB-14125:(android) Increase old plugin compatibility

2018-06-13 Thread GitBox
jcesarmobile commented on issue #449: CB-14125:(android) Increase old plugin compatibility URL: https://github.com/apache/cordova-android/pull/449#issuecomment-397085517 Agree, but we should start by updating core plugins and docs

[GitHub] codecov-io commented on issue #368: package.json cleanup devDependencies

2018-06-13 Thread GitBox
codecov-io commented on issue #368: package.json cleanup devDependencies URL: https://github.com/apache/cordova-ios/pull/368#issuecomment-396781013 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/368?src=pr=h1) Report > Merging

[GitHub] jcesarmobile closed pull request #449: CB-14125:(android) Increase old plugin compatibility

2018-06-13 Thread GitBox
jcesarmobile closed pull request #449: CB-14125:(android) Increase old plugin compatibility URL: https://github.com/apache/cordova-android/pull/449 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[cordova-windows] 01/05: remove most existing devdeps for now

2018-06-13 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch cb-update-wip1 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit ceaca3a668e8bfddcd6f89472fac28cbb28cace5 Author: Christopher J. Brody AuthorDate: Wed Jun 13

[cordova-windows] 03/05: [squash] add node_modules/fs.realpath

2018-06-13 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch cb-update-wip1 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit 53ca1a31dc618e33d9618c7dc2718298f63d9ac6 Author: Christopher J. Brody AuthorDate: Wed Jun 13

[GitHub] codecov-io commented on issue #368: package.json cleanup devDependencies

2018-06-13 Thread GitBox
codecov-io commented on issue #368: package.json cleanup devDependencies URL: https://github.com/apache/cordova-ios/pull/368#issuecomment-396781013 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/368?src=pr=h1) Report > Merging

[cordova-windows] branch cb-update-wip1 updated (8cc627b -> 6b8e7e3)

2018-06-13 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch cb-update-wip1 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git. from 8cc627b Update requirements, issues and Platform Guide link new ceaca3a remove most

[cordova-windows] 04/05: [squash] add node_modules/strip-bom

2018-06-13 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch cb-update-wip1 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit af71d788c50adb52ecba6eabd75c08cc11457b8e Author: Christopher J. Brody AuthorDate: Wed Jun 13

[cordova-windows] 05/05: Revert "remove most existing devdeps for now"

2018-06-13 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch cb-update-wip1 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit 6b8e7e319c640645d07c3e8591396cc957b2b835 Author: Christopher J. Brody AuthorDate: Wed Jun 13

[GitHub] brodybits opened a new pull request #371: CI testing on Node.js versions 8 & 10

2018-06-13 Thread GitBox
brodybits opened a new pull request #371: CI testing on Node.js versions 8 & 10 URL: https://github.com/apache/cordova-ios/pull/371 ### Platforms affected iOS ### What does this PR do? Enable AppVeyor CI & Travis CI testing on Node.js versions 8 & 10. ###

[GitHub] brodybits commented on issue #368: package.json cleanup devDependencies

2018-06-13 Thread GitBox
brodybits commented on issue #368: package.json cleanup devDependencies URL: https://github.com/apache/cordova-ios/pull/368#issuecomment-396787973 ## Updated description Description is updated as follows: ### What does this PR do? Removes devDependencies no longer

[GitHub] brodybits opened a new pull request #370: Package updates for minor release - PENDING WIP

2018-06-13 Thread GitBox
brodybits opened a new pull request #370: Package updates for minor release - PENDING WIP URL: https://github.com/apache/cordova-ios/pull/370 ### Platforms affected iOS ### What does this PR do? - Update to plist@3 (#367) - Cleanup devDependencies: remove

[GitHub] brodybits commented on issue #370: Package updates for minor release - PENDING WIP

2018-06-13 Thread GitBox
brodybits commented on issue #370: Package updates for minor release - PENDING WIP URL: https://github.com/apache/cordova-ios/pull/370#issuecomment-397154595 Reopening for WIP CI testing, apologies to watchers for the bother

[GitHub] brodybits closed pull request #368: package.json cleanup devDependencies

2018-06-13 Thread GitBox
brodybits closed pull request #368: package.json cleanup devDependencies URL: https://github.com/apache/cordova-ios/pull/368 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[cordova-ios] branch master updated: package.json cleanup devDependencies

2018-06-13 Thread brodybits
This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git The following commit(s) were added to refs/heads/master by this push: new fdd12a1 package.json cleanup

[GitHub] brodybits commented on issue #368: package.json cleanup devDependencies

2018-06-13 Thread GitBox
brodybits commented on issue #368: package.json cleanup devDependencies URL: https://github.com/apache/cordova-ios/pull/368#issuecomment-397157178 Squashed, rebased without plist@3 update (#367), and merged in fdd12a1a3bb66a779113c2e7c094ab1fabbd3475