[GitHub] erisu commented on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu commented on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165160 ## Review **Target:** cordova-common **Status:** Complete

[GitHub] erisu commented on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu commented on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165500 ## Review **Target:** cordova-lib **Status:** Complete https://github.com/apache/cordova-lib/commit/61395d2946a743a0a5ad5bf273a57701af15a145

[GitHub] erisu commented on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu commented on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420169168 ## cordova-js Review **Status:** Not Started - [ ] package.json - [ ] Travis CI - [ ] AppVeyor

[GitHub] erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165160 ## cordova-common Review **Status:** Complete https://github.com/apache/cordova-common/commit/d473b190960ae3401ede0993994220c89d262bc0 -

[GitHub] lukeinage commented on issue #53: iPhone X initial height issue

2018-09-11 Thread GitBox
lukeinage commented on issue #53: iPhone X initial height issue URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/53#issuecomment-420192535 @janpio Yes, that's in inappbrowser wkwebview now  This is an

[GitHub] erisu commented on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu commented on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420166188 ## Review **Target:** cordova-cli **Status:** Complete https://github.com/apache/cordova-cli/commit/f567c26f2eed45af2d5aa5ef3d825f18297d4cd6

[GitHub] erisu opened a new issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu opened a new issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5 ## Goal - Drop Node 4 Support - Add Node 10 Support # Task List - [x] cordova-common - [x] cordova-lib - [x] cordova-fetch - [x] cordova-create -

[GitHub] erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165996 ## cordova-create Review **Status:** Complete https://github.com/apache/cordova-create/commit/7e40c4558ad8ff018a6f8c272a2cbd5e7715691b -

[GitHub] erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420166188 ## cordova-cli Review **Status:** Complete https://github.com/apache/cordova-cli/commit/f567c26f2eed45af2d5aa5ef3d825f18297d4cd6 - [x]

[GitHub] erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420167746 ## cordova-serve Review **Status:** Not started - [ ] package.json - [ ] AppVeyor - [ ] Travis CI

[GitHub] erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165160 ## cordova-common Review **Status:** Complete https://github.com/apache/cordova-common/commit/d473b190960ae3401ede0993994220c89d262bc0 -

[GitHub] erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420166188 ## cordova-cli Review **Status:** Complete https://github.com/apache/cordova-cli/commit/f567c26f2eed45af2d5aa5ef3d825f18297d4cd6 - [x]

[GitHub] erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165737 ## cordova-fetch Review **Status:** Complete https://github.com/apache/cordova-fetch/commit/b0040a463b0f3f22fe03f17f79686d2b820b7e37 -

[GitHub] erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165996 ## cordova-create Review **Status:** Complete https://github.com/apache/cordova-create/commit/7e40c4558ad8ff018a6f8c272a2cbd5e7715691b

[GitHub] erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165500 ## cordova-lib Review **Status:** Complete https://github.com/apache/cordova-lib/commit/61395d2946a743a0a5ad5bf273a57701af15a145 - [x]

[GitHub] erisu opened a new pull request #168: CB-14071: Drop Node 4 Support

2018-09-11 Thread GitBox
erisu opened a new pull request #168: CB-14071: Drop Node 4 Support URL: https://github.com/apache/cordova-js/pull/168 ### Platforms affected none ### What does this PR do? - Drop Node 4 Support ### What testing has been done on this change? - `npm test` -

[GitHub] alan-grixti commented on issue #272: CB-12922 (ios): fix In-app browser does not cede control

2018-09-11 Thread GitBox
alan-grixti commented on issue #272: CB-12922 (ios): fix In-app browser does not cede control URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/272#issuecomment-420199685 Hi, I've integrated your fixes into my local version of the plugin however I am not managing to get it

[GitHub] erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165160 ## cordova-common Review **Status:** Complete https://github.com/apache/cordova-common/commit/d473b190960ae3401ede0993994220c89d262bc0 -

[GitHub] erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420168699 ## cordova-plugman Review **Status:** Completed

[GitHub] raphinesse opened a new issue #7: Drop dependency on Q, use native promises

2018-09-11 Thread GitBox
raphinesse opened a new issue #7: Drop dependency on Q, use native promises URL: https://github.com/apache/cordova/issues/7 We have to do this top down in our dependency graph. That way, we always can release each package without risking to break any of its consumers that rely on Q

[GitHub] erisu commented on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu commented on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165737 ## Review **Target:** cordova-fetch **Status:** Complete

[GitHub] erisu commented on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu commented on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420168699 ## cordova-plugman Review **Status:** Completed

[GitHub] erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420169168 ## cordova-js Review **Status:** Not Started - [ ] package.json - [ ] Travis CI - [ ] AppVeyor

[GitHub] erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165160 ## cordova-common Review **Status:** Complete https://github.com/apache/cordova-common/commit/d473b190960ae3401ede0993994220c89d262bc0 -

[GitHub] erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu removed a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420167746 ## cordova-serve Review **Status:** Not started - [ ] package.json - [ ] AppVeyor - [ ] Travis CI

[GitHub] raphinesse opened a new issue #6: Remove committed `node_modules` from platforms

2018-09-11 Thread GitBox
raphinesse opened a new issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6 We don't need them anymore since CLI installs all dependencies properly now. Not having to bundle dependencies vastly simplifies adding a new dependency if you

[GitHub] erisu commented on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu commented on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165996 ## Review **Target:** cordova-create **Status:** Complete

[GitHub] erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165160 ## cordova-common Review **Status:** Complete https://github.com/apache/cordova-common/commit/d473b190960ae3401ede0993994220c89d262bc0 -

[GitHub] erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165737 ## cordova-fetch Review **Status:** Complete https://github.com/apache/cordova-fetch/commit/b0040a463b0f3f22fe03f17f79686d2b820b7e37 -

[GitHub] erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu edited a comment on issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5#issuecomment-420165500 ## cordova-lib Review **Status:** Complete https://github.com/apache/cordova-lib/commit/61395d2946a743a0a5ad5bf273a57701af15a145 - [x]

[GitHub] erisu opened a new pull request #58: CB-14073 browser: Drop Node 4, Added Node 10

2018-09-11 Thread GitBox
erisu opened a new pull request #58: CB-14073 browser: Drop Node 4, Added Node 10 URL: https://github.com/apache/cordova-browser/pull/58 ### Platforms affected browser ### What does this PR do? - Drop Node 4 Support - Added Node 10 Support ### What testing has been

[GitHub] erisu opened a new pull request #53: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
erisu opened a new pull request #53: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova-osx/pull/53 ### Platforms affected osx ### What does this PR do? - Drop Node 4 Support - Add Node 10 Support ### What testing has been done on this change?

[GitHub] janpio commented on issue #6: Remove committed `node_modules` from platforms

2018-09-11 Thread GitBox
janpio commented on issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6#issuecomment-420203485 (Added "Cordova coho Release Process documentation" as task) This is an

[GitHub] raphinesse opened a new issue #9: Purge remnants of `fetch` option support

2018-09-11 Thread GitBox
raphinesse opened a new issue #9: Purge remnants of `fetch` option support URL: https://github.com/apache/cordova/issues/9 ## Tasks - [x] cordova-lib (https://github.com/apache/cordova-lib/pull/617, https://github.com/apache/cordova-lib/pull/624) - [ ] cordova-cli - [ ]

[GitHub] janpio commented on a change in pull request #197: Remove test instructions for browserify

2018-09-11 Thread GitBox
janpio commented on a change in pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197#discussion_r216647461 ## File path: docs/tools-release-process.md ## @@ -225,10 +225,6 @@ Ensure that mobilespec creates okay

[GitHub] raphinesse commented on a change in pull request #197: Remove test instructions for browserify

2018-09-11 Thread GitBox
raphinesse commented on a change in pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197#discussion_r216656219 ## File path: docs/tools-release-process.md ## @@ -225,10 +225,6 @@ Ensure that mobilespec creates

[GitHub] alan-grixti opened a new issue #296: App freezing after opening the InAppBrowser on specific URLs

2018-09-11 Thread GitBox
alan-grixti opened a new issue #296: App freezing after opening the InAppBrowser on specific URLs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296 I would like to bring to attention an issue (I believe it's a bug, could be wrong) which I've come across. I believe it

[GitHub] janpio commented on a change in pull request #197: Remove test instructions for browserify

2018-09-11 Thread GitBox
janpio commented on a change in pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197#discussion_r216655795 ## File path: docs/tools-release-process.md ## @@ -225,10 +225,6 @@ Ensure that mobilespec creates okay

[GitHub] raphinesse opened a new issue #8: Remove `browserify` support

2018-09-11 Thread GitBox
raphinesse opened a new issue #8: Remove `browserify` support URL: https://github.com/apache/cordova/issues/8 ## Tasks - [ ] [cordova-cli](https://github.com/apache/cordova-cli/pull/321) - [x] [cordova-lib](https://github.com/apache/cordova-lib/pull/682) - [ ] cordova-js - [ ]

[GitHub] raphinesse opened a new pull request #197: Remove test instructions for browserify

2018-09-11 Thread GitBox
raphinesse opened a new pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197 Part of https://github.com/apache/cordova/issues/8 This is an automated message from the

[GitHub] joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-09-11 Thread GitBox
joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r216674955 ## File path: bin/templates/project/Activity.kt ## @@ -0,0 +1,38 @@ +/* Review comment: This

[GitHub] joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-09-11 Thread GitBox
joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r216674985 ## File path: bin/templates/project/app/build.gradle ## @@ -30,13 +32,14 @@ buildscript {

[GitHub] raphinesse commented on a change in pull request #197: Remove test instructions for browserify

2018-09-11 Thread GitBox
raphinesse commented on a change in pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197#discussion_r216648078 ## File path: docs/tools-release-process.md ## @@ -225,10 +225,6 @@ Ensure that mobilespec creates

[cordova-browser] branch master updated (ffdc001 -> f23c998)

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-browser.git. from ffdc001 CB-14073 browser: Drop Node 4, Added Node 10 add 41176ad Remove bundledDependencies key from

[cordova-browser] 01/01: Merge pull request #59 from raphinesse/remove-bundled-dependencies

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-browser.git commit f23c998241314144b9a0c670094c59ead68e1aef Merge: ffdc001 4e8f62a Author: Darryl Pogue AuthorDate: Tue Sep 11

[GitHub] dpogue closed pull request #198: Remove instructions on how to bundle dependencies

2018-09-11 Thread GitBox
dpogue closed pull request #198: Remove instructions on how to bundle dependencies URL: https://github.com/apache/cordova-coho/pull/198 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] erisu opened a new pull request #55: Upgrade cordova common

2018-09-11 Thread GitBox
erisu opened a new pull request #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55 ### Platforms affected osx ### What does this PR do? - Bumps cordova-common to ^2.2.5 ### What testing has been done on this change? - `npm test`

[GitHub] erisu commented on issue #56: Test framework consistency

2018-09-11 Thread GitBox
erisu commented on issue #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56#issuecomment-420512037 Commits cherry-picked from @brodybits' PR #49 This is an automated message from the Apache Git

[GitHub] erisu commented on issue #57: package.json use xcode@1 (1.x.x)

2018-09-11 Thread GitBox
erisu commented on issue #57: package.json use xcode@1 (1.x.x) URL: https://github.com/apache/cordova-osx/pull/57#issuecomment-420512061 Commits cherry-picked from @brodybits' PR #49 This is an automated message from the

[GitHub] erisu commented on issue #55: Upgrade cordova common

2018-09-11 Thread GitBox
erisu commented on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420512002 Commits cherry-picked from @brodybits' PR #49 This is an automated message from the Apache Git

[GitHub] knight9999 commented on issue #880: About SwiftSupport

2018-09-11 Thread GitBox
knight commented on issue #880: About SwiftSupport URL: https://github.com/apache/cordova-docs/pull/880#issuecomment-420487453 @janpio Thanks for the advice. I have updated my PR to use ` ==iOS==` This is an automated

[GitHub] ArGaspar commented on issue #114: Not working on Android devices

2018-09-11 Thread GitBox
ArGaspar commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-420459771 Is this plugin getting updated for android 8.0 or do we have to move on?

[cordova-docs] branch master updated: CB-13685 android: Added adaptive icon docs (#830)

2018-09-11 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new d52d998 CB-13685 android: Added adaptive

[GitHub] erisu closed pull request #830: CB-13685 android: Added adaptive icon docs

2018-09-11 Thread GitBox
erisu closed pull request #830: CB-13685 android: Added adaptive icon docs URL: https://github.com/apache/cordova-docs/pull/830 This is an automated message from the Apache Git Service. To respond to the message, please log

[cordova-coho] 01/01: Merge pull request #198 from apache/remove-bundled-dependencies

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-coho.git commit 318cd51ebba1d733d8002be6141915b279965339 Merge: 2eff92c f4ecced Author: Darryl Pogue AuthorDate: Tue Sep 11

[cordova-coho] branch remove-bundled-dependencies deleted (was f4ecced)

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch remove-bundled-dependencies in repository https://gitbox.apache.org/repos/asf/cordova-coho.git. was f4ecced Remove instructions on how to bundle dependencies The revisions that were on

[cordova-coho] branch master updated (2eff92c -> 318cd51)

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-coho.git. from 2eff92c Merge pull request #197 from raphinesse/browserify-nomore add f4ecced Remove instructions on

[GitHub] dpogue commented on issue #198: Remove instructions on how to bundle dependencies

2018-09-11 Thread GitBox
dpogue commented on issue #198: Remove instructions on how to bundle dependencies URL: https://github.com/apache/cordova-coho/pull/198#issuecomment-420441260 I have no idea what the tests are doing (why are they running 4 times?), but your change isn't testable code anyways, so let's

[GitHub] erisu opened a new pull request #56: Test framework consistency

2018-09-11 Thread GitBox
erisu opened a new pull request #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56 ### Platforms affected osx ### What does this PR do? Makes the testing framework consistent the testing framework used in our other platform and tooling repos.

[GitHub] erisu opened a new pull request #57: package.json use xcode@1 (1.x.x)

2018-09-11 Thread GitBox
erisu opened a new pull request #57: package.json use xcode@1 (1.x.x) URL: https://github.com/apache/cordova-osx/pull/57 ### Platforms affected osx ### What does this PR do? - bumps xcode dependency to `^1.0.0` ### What testing has been done on this change? - `npm

[GitHub] sandeep2244 opened a new issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working

2018-09-11 Thread GitBox
sandeep2244 opened a new issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working URL: https://github.com/apache/cordova-android/issues/494 I stuck in my old version Android App based on Codova I updated My Android App to latest version

[GitHub] davidgovea commented on issue #114: Not working on Android devices

2018-09-11 Thread GitBox
davidgovea commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-420480600 Working fine for me on 8.0, and 8.1 devices. However, I am experiencing intermittent timeout issues on **some** devices

svn commit: r1840621 - in /cordova/site/public: docs/en/dev/config_ref/images.html docs/en/dev/reference/cordova-cli/index.html docs/en/dev/reference/cordova-plugin-statusbar/index.html feed.xml

2018-09-11 Thread steven
Author: steven Date: Wed Sep 12 02:14:25 2018 New Revision: 1840621 URL: http://svn.apache.org/viewvc?rev=1840621=rev Log: Updated docs Modified: cordova/site/public/docs/en/dev/config_ref/images.html cordova/site/public/docs/en/dev/reference/cordova-cli/index.html

[GitHub] PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs

2018-09-11 Thread GitBox
PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420285229 Hello, it seems like we're experiencing the same issue. We experience it after

[cordova-osx] branch master updated: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-osx.git The following commit(s) were added to refs/heads/master by this push: new ffcf496 Add Node 10 & Drop Node 4 Support

[GitHub] alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs

2018-09-11 Thread GitBox
alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420295354 At first I was using a fork of this which I created myself for development purposes,

[GitHub] erisu commented on issue #6: Remove committed `node_modules` from platforms

2018-09-11 Thread GitBox
erisu commented on issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6#issuecomment-420295286 It seems https://github.com/apache/cordova-osx/pull/49, covers removing the node_modules and many other smaller tasks. Could the node_module

[GitHub] PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs

2018-09-11 Thread GitBox
PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420296914 In my app I have next line [tmpWindow setWindowLevel:baseWindowLevel+1]; from

[GitHub] alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs

2018-09-11 Thread GitBox
alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-42021 So basically if I revert commit `dc5329d`, the mentioned issue would be fixed?

[cordova-serve] branch master updated: CB-14069: Drop Node 4, Add Node 10 Support

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-serve.git The following commit(s) were added to refs/heads/master by this push: new 9708785 CB-14069: Drop Node 4, Add Node

[GitHub] codecov-io edited a comment on issue #441: CB-14089: (android) Add Kotlin support

2018-09-11 Thread GitBox
codecov-io edited a comment on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-420286698 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #441: CB-14089: (android) Add Kotlin support

2018-09-11 Thread GitBox
codecov-io edited a comment on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-420286698 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #441: CB-14089: (android) Add Kotlin support

2018-09-11 Thread GitBox
codecov-io commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-420286698 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=h1) Report > Merging

[GitHub] erisu commented on issue #6: Remove committed `node_modules` from platforms

2018-09-11 Thread GitBox
erisu commented on issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6#issuecomment-420291667 For https://github.com/apache/cordova-ios/pull/388, conflicts needs to be resolved and should be OK for merging since I last reviewed it. Would

[GitHub] PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs

2018-09-11 Thread GitBox
PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420315544 I think you should try it. But you have to be sure the line is out of the xcode

[GitHub] bb128b edited a comment on issue #70: How to detect latency or ping or can I detect connection if the device network is slow or fast?

2018-09-11 Thread GitBox
bb128b edited a comment on issue #70: How to detect latency or ping or can I detect connection if the device network is slow or fast? URL: https://github.com/apache/cordova-plugin-network-information/issues/70#issuecomment-420283187 The way I achieved this in our project (we are using

[GitHub] bb128b commented on issue #70: How to detect latency or ping or can I detect connection if the device network is slow or fast?

2018-09-11 Thread GitBox
bb128b commented on issue #70: How to detect latency or ping or can I detect connection if the device network is slow or fast? URL: https://github.com/apache/cordova-plugin-network-information/issues/70#issuecomment-420283187 The way I achieved this in our project (we are using Ionic 3.x

[GitHub] erisu edited a comment on issue #6: Remove committed `node_modules` from platforms

2018-09-11 Thread GitBox
erisu edited a comment on issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6#issuecomment-420295286 It seems https://github.com/apache/cordova-osx/pull/49, covers removing the node_modules and many other smaller tasks. - Could

[GitHub] erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-09-11 Thread GitBox
erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r216679161 ## File path: bin/templates/project/app/build.gradle ## @@ -30,13 +32,14 @@ buildscript {

[cordova-js] 01/01: Merge pull request #168 from erisu/CB-14071

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-js.git commit 284c1b1a710682ece82784a6f99725ebdd2acf4c Merge: 9e8e1b7 d046b85 Author: Darryl Pogue AuthorDate: Tue Sep 11

[GitHub] dpogue closed pull request #168: CB-14071: Drop Node 4 Support

2018-09-11 Thread GitBox
dpogue closed pull request #168: CB-14071: Drop Node 4 Support URL: https://github.com/apache/cordova-js/pull/168 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[cordova-js] branch master updated (9e8e1b7 -> 284c1b1)

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-js.git. from 9e8e1b7 readme fixes (#166) add d046b85 CB-14071: Drop Node 4 Support new 284c1b1 Merge pull

[GitHub] dpogue closed issue #5: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
dpogue closed issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs

2018-09-11 Thread GitBox
PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420293651 I am currently using a fork of the plugin, so it is possibly related to a development

[GitHub] raphinesse commented on issue #7: Drop dependency on Q, use native promises

2018-09-11 Thread GitBox
raphinesse commented on issue #7: Drop dependency on Q, use native promises URL: https://github.com/apache/cordova/issues/7#issuecomment-420308949 I've added a full dependency graph to make it easier to determine the correct order of doing this.

[GitHub] dpogue closed pull request #58: CB-14073 browser: Drop Node 4, Added Node 10

2018-09-11 Thread GitBox
dpogue closed pull request #58: CB-14073 browser: Drop Node 4, Added Node 10 URL: https://github.com/apache/cordova-browser/pull/58 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[cordova-browser] branch master updated: CB-14073 browser: Drop Node 4, Added Node 10

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-browser.git The following commit(s) were added to refs/heads/master by this push: new ffdc001 CB-14073 browser: Drop Node

[GitHub] dpogue closed pull request #53: Add Node 10 & Drop Node 4 Support

2018-09-11 Thread GitBox
dpogue closed pull request #53: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova-osx/pull/53 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] erisu commented on issue #391: CocoaPods Improvement

2018-09-11 Thread GitBox
erisu commented on issue #391: CocoaPods Improvement URL: https://github.com/apache/cordova-ios/issues/391#issuecomment-420521439 ### Pull Requests - https://github.com/apache/cordova-common/pull/48 - https://github.com/apache/cordova-ios/pull/405

[GitHub] knight9999 opened a new pull request #405: Cocoapods support improvement, using podspec tag in plugin.xml

2018-09-11 Thread GitBox
knight opened a new pull request #405: Cocoapods support improvement, using podspec tag in plugin.xml URL: https://github.com/apache/cordova-ios/pull/405 ### Platforms affected ios ### What does this PR do? - Cocoapods Support Improvement - Support Custom

[cordova-plugman] branch master updated (944e8e6 -> 292f7ff)

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugman.git. from 944e8e6 CB-14164 Use native Promises instead of Q (#94) add 14a8bb9 Remove browserify option

[cordova-cli] branch master updated: GH-320 Remove support for browserify

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-cli.git The following commit(s) were added to refs/heads/master by this push: new 7fc2707 GH-320 Remove support for

[cordova-plugman] 01/01: Merge pull request #95 from raphinesse/browserify-nomore

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugman.git commit 292f7ff904567dd78dd7f4dfdab0cab69c01cb0d Merge: 944e8e6 14a8bb9 Author: Darryl Pogue AuthorDate: Tue Sep 11

[GitHub] dpogue closed pull request #197: Remove test instructions for browserify

2018-09-11 Thread GitBox
dpogue closed pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[cordova-coho] 01/01: Merge pull request #197 from raphinesse/browserify-nomore

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-coho.git commit 2eff92cae0315b8dfcc14f7aab51377e19fd1e97 Merge: 2ae50f2 3ca7b93 Author: Darryl Pogue AuthorDate: Tue Sep 11

[cordova-coho] branch master updated (2ae50f2 -> 2eff92c)

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-coho.git. from 2ae50f2 GH-195: Ensure synchronous operation add 3ca7b93 Remove test instructions for browserify

[cordova-common] branch master updated: CB-14108: fix incorrect count in config_munge in ios.json and android.json

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-common.git The following commit(s) were added to refs/heads/master by this push: new ce3801a CB-14108: fix incorrect count

[cordova-common] branch master updated: CB-13496: Fix greedy regex in plist-helpers

2018-09-11 Thread dpogue
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-common.git The following commit(s) were added to refs/heads/master by this push: new 9c6cda3 CB-13496: Fix greedy regex in

[GitHub] joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

2018-09-11 Thread GitBox
joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r216728546 ## File path: bin/templates/project/app/build.gradle ## @@ -30,13 +32,14 @@ buildscript {

[GitHub] tmk1991 opened a new issue #340: FILE URI Not showing in tag - Android

2018-09-11 Thread GitBox
tmk1991 opened a new issue #340: FILE URI Not showing in tag - Android URL: https://github.com/apache/cordova-plugin-camera/issues/340 When selecting an image from the users library, the file URI returns `/storage/emulated/0/Pictures/IMG_20180911_114705.jpg` When taking a picture

  1   2   >