[GitHub] sgruhier commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-10-01 Thread GitBox
sgruhier commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-425926385 thanks I did it, I can run a build in xcode but I'm curious how I can use command line like others with --buildFlag :)

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425929064 Similar situation in the Appium Server log as before in the normal Appium log: First 281 lines are identical, then

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425932393 (Maybe the test is actually already run - and Appium is trying to take care of other stuff) In the successful

[GitHub] janpio commented on issue #320: Get applicationId from package name

2018-10-01 Thread GitBox
janpio commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425932701 Yes, Travis now happy  This is an automated message from the Apache

[GitHub] janpio commented on issue #136: Add dots spinner loader for android

2018-10-01 Thread GitBox
janpio commented on issue #136: Add dots spinner loader for android URL: https://github.com/apache/cordova-plugin-splashscreen/pull/136#issuecomment-425934760 `rebase` is git command that takes your changes from your branch, which was created in the past and with an old state of code, and

[GitHub] janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for iOS

2018-10-01 Thread GitBox
janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425896071 The test failure was caused by a timeout - the test seemed to need a tiny bit more than the 5 minutes that were

[cordova-plugin-inappbrowser] branch janpio-remove_data_from_readme_table created (now 4dadf6e)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-remove_data_from_readme_table in repository https://gitbox.apache.org/repos/asf/cordova-plugin-inappbrowser.git. at 4dadf6e remove unwanted information in README table This

[GitHub] ansarikhurshid786 commented on issue #114: Canot open PDF file with inappbrowser ionic

2018-10-01 Thread GitBox
ansarikhurshid786 commented on issue #114: Canot open PDF file with inappbrowser ionic URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/114#issuecomment-425908219 I am also facing same issue in android only and it is working fine in ios. how to resolve in android

[GitHub] janpio commented on issue #114: Canot open PDF file with inappbrowser ionic

2018-10-01 Thread GitBox
janpio commented on issue #114: Canot open PDF file with inappbrowser ionic URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/114#issuecomment-425909813 Step 1: Open an issue instead of commenting on a closed PR. Thank you.

[GitHub] janpio commented on issue #137: CB-13460: Apply Android style to the splash screen

2018-10-01 Thread GitBox
janpio commented on issue #137: CB-13460: Apply Android style to the splash screen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/137#issuecomment-425911395 Hey, I just fixed the problem that caused Android tests to fail. Rebasing on master should get rid of those and

[GitHub] ansarikhurshid786 opened a new issue #309: pdf is not opening in android inappbrower using ionic 3.

2018-10-01 Thread GitBox
ansarikhurshid786 opened a new issue #309: pdf is not opening in android inappbrower using ionic 3. URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/309 I am using ionic 3 plugin to view pdf inappbrowser. It is working fine in ios but not working in android. I am

[GitHub] dominikse commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-10-01 Thread GitBox
dominikse commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-425911427 > when I run `ng run app:ionic-cordova-build --platform=ios --buildFlag="-UseModernBuildSystem=0"` I have > > ``` > Unknown

[GitHub] luisfernando-rf commented on issue #115: Frequency/Interval feature for `watchPosition`

2018-10-01 Thread GitBox
luisfernando-rf commented on issue #115: Frequency/Interval feature for `watchPosition` URL: https://github.com/apache/cordova-plugin-geolocation/issues/115#issuecomment-425911443 This is an automated message from

[GitHub] janpio commented on issue #273: CB-NOBUG: (iOS) improvement for UI debugging/visualization

2018-10-01 Thread GitBox
janpio commented on issue #273: CB-NOBUG: (iOS) improvement for UI debugging/visualization URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/273#issuecomment-425912933 I did @justf4st - you are of course right. I just fixed the problem that caused Android tests to

[GitHub] janpio commented on issue #276: CB-14188: add beforeload event, catching navigation before it happens

2018-10-01 Thread GitBox
janpio commented on issue #276: CB-14188: add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-425913068 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase

[GitHub] janpio commented on issue #275: CB-14190: (windows) Fix bug where double clicking `` exits app

2018-10-01 Thread GitBox
janpio commented on issue #275: CB-14190: (windows) Fix bug where double clicking `` exits app URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/275#issuecomment-425913000 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR

[cordova-plugin-dialogs] branch remove-docs-translations deleted (was dad8fd5)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch remove-docs-translations in repository https://gitbox.apache.org/repos/asf/cordova-plugin-dialogs.git. was dad8fd5 remove docs translations The revisions that were on this branch are

[cordova-status] branch janpio-update deleted (was 58478df)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-update in repository https://gitbox.apache.org/repos/asf/cordova-status.git. was 58478df remove "Organization / Apache" The revisions that were on this branch are still contained

[GitHub] janpio commented on issue #320: Get applicationId from package name

2018-10-01 Thread GitBox
janpio commented on issue #320: Get applicationId from package name URL: https://github.com/apache/cordova-plugin-camera/pull/320#issuecomment-425919871 Yep, merge commit looks clean: https://github.com/apache/cordova-plugin-camera/pull/320/commits/d1516bd0966608736e62423f18bc1619b02e2cea

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425923522 Last 2 entries from "Appium Logs": ``` ... { "screenshot": null, "between_commands":

[GitHub] janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio edited a comment on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425923522 Last 2 entries from ["Appium

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425924693 Turn out the successful test run in `cordova-plugin-geolocation` has the same line with `alow` in it in line 146 the

[GitHub] airstep commented on issue #136: Add dots spinner loader for android

2018-10-01 Thread GitBox
airstep commented on issue #136: Add dots spinner loader for android URL: https://github.com/apache/cordova-plugin-splashscreen/pull/136#issuecomment-425930572 What you mean about rebase? How to do it? This is an automated

[GitHub] CesarBalzer commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-10-01 Thread GitBox
CesarBalzer commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-425935703 Changing the configuration in xcode to legacy did not work, setting the flag cordova build ios --buildFlag = '- UseModernBuildSystem =

[GitHub] janpio commented on issue #265: CB-14024 Take into account statusbar height when toolbar is enabled

2018-10-01 Thread GitBox
janpio commented on issue #265: CB-14024 Take into account statusbar height when toolbar is enabled URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-425913163 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase

[GitHub] janpio commented on issue #88: CB-12479: Add loading spinner for android

2018-10-01 Thread GitBox
janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425913364 Awesome. Unfortunately I have some more "work" for you: I just fixed the problem that caused Android tests to fail in

[cordova-plugin-geolocation] branch remove-docs-translation deleted (was 6a10456)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch remove-docs-translation in repository https://gitbox.apache.org/repos/asf/cordova-plugin-geolocation.git. was 6a10456 remove outdated doccs translations The revisions that were on this

[GitHub] janpio closed pull request #117: Remove outdated doccs translations

2018-10-01 Thread GitBox
janpio closed pull request #117: Remove outdated doccs translations URL: https://github.com/apache/cordova-plugin-geolocation/pull/117 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425921890 Compare the failing test here, to a similarly configured one from another plugin: failing here:

[GitHub] janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing

2018-10-01 Thread GitBox
janpio commented on issue #307: [Tests/CI/Travis] android-7.0 tests are failing URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/307#issuecomment-425930838 ### Preliminary result This code here hangs:

[GitHub] DavidBriglio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t…

2018-10-01 Thread GitBox
DavidBriglio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t… URL: https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-426020724 @janpio Tests are now passing!

[GitHub] anupamgovind1981 opened a new issue #422: App crashes on iOS 12.0

2018-10-01 Thread GitBox
anupamgovind1981 opened a new issue #422: App crashes on iOS 12.0 URL: https://github.com/apache/cordova-ios/issues/422 Description: App start crashes on iPad after upgrade to iOS 12.0. [ERROR] An error occurred while running subprocess cordova. Steps to Reproduce:

[cordova-plugin-file] branch master updated: CB-13850: Fix spelling in typed-file: property name filesystem (wrong… (#229)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file.git The following commit(s) were added to refs/heads/master by this push: new 4642fde CB-13850: Fix spelling in

[GitHub] janpio closed pull request #229: CB-13850: Fix spelling in typed-file: property name filesystem (wrong…

2018-10-01 Thread GitBox
janpio closed pull request #229: CB-13850: Fix spelling in typed-file: property name filesystem (wrong… URL: https://github.com/apache/cordova-plugin-file/pull/229 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[cordova-plugin-file] branch master updated: CB-13960: fix FileWriter.write argument type definition for typescript (#231)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file.git The following commit(s) were added to refs/heads/master by this push: new 5353b84 CB-13960: fix

[GitHub] janpio closed pull request #231: CB-13960: fix FileWriter.write argument type definition for typescript

2018-10-01 Thread GitBox
janpio closed pull request #231: CB-13960: fix FileWriter.write argument type definition for typescript URL: https://github.com/apache/cordova-plugin-file/pull/231 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] janpio commented on issue #233: bug: filesystemName is undefined

2018-10-01 Thread GitBox
janpio commented on issue #233: bug: filesystemName is undefined URL: https://github.com/apache/cordova-plugin-file/pull/233#issuecomment-426052331 Oh what platform does this problem occur? Can you post the error message you are getting? What is the code needed to reproduce this?

[GitHub] janpio commented on issue #198: Updated README for Android file uploads.

2018-10-01 Thread GitBox
janpio commented on issue #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198#issuecomment-426054895 Can you provide some context? Is this true for all upload or just for some configuration? What happens if one doesn't set

[cordova-plugin-file-transfer] branch master updated (b7de6f9 -> 2e4539d)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file-transfer.git. from b7de6f9 CB-13826 Incremented plugin version. add 2e4539d also accept android sdk terms

[cordova-plugin-file-transfer] branch master updated (2e4539d -> 6c99dfa)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file-transfer.git. from 2e4539d also accept android sdk terms for android-27 add 6c99dfa [windows] Fix js

[GitHub] janpio closed pull request #199: Fix js error "The parameter is incorrect"

2018-10-01 Thread GitBox
janpio closed pull request #199: Fix js error "The parameter is incorrect" URL: https://github.com/apache/cordova-plugin-file-transfer/pull/199 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] janpio commented on issue #159: CB-13690 : (browser) Add src change to method to Media object

2018-10-01 Thread GitBox
janpio commented on issue #159: CB-13690 : (browser) Add src change to method to Media object URL: https://github.com/apache/cordova-plugin-media/pull/159#issuecomment-426056733 Tests are now passing. This is an automated

[GitHub] janpio commented on issue #197: CB-12551: (android) Patch Security Provider to support TLS 1.2

2018-10-01 Thread GitBox
janpio commented on issue #197: CB-12551: (android) Patch Security Provider to support TLS 1.2 URL: https://github.com/apache/cordova-plugin-file-transfer/pull/197#issuecomment-426063702 I just submitted a fix to master, if you rebase on that your tests might pass (or at least fail

[GitHub] janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t…

2018-10-01 Thread GitBox
janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t… URL: https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-426024101 Jippieh! I removed some unwanted changes to README that somehow made their way into this via

[GitHub] PieterVanPoyer edited a comment on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6

2018-10-01 Thread GitBox
PieterVanPoyer edited a comment on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6 URL: https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426035590 I triggered a new build. (I did

[cordova-paramedic] branch master updated (5bed039 -> c78d74a)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git. from 5bed039 decrease to 9 min to work around 10min command limit on travis:

[cordova-paramedic] branch janpio-add_plugin_package.json deleted (was 2b24b0a)

2018-10-01 Thread janpio
This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-add_plugin_package.json in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git. was 2b24b0a most rudimentary package.json for plugins and plugin tests possible

[GitHub] PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6

2018-10-01 Thread GitBox
PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6 URL: https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426029809 @janpio Hey janpio, the travis-ci build

[GitHub] PieterVanPoyer removed a comment on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6

2018-10-01 Thread GitBox
PieterVanPoyer removed a comment on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6 URL: https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426029809 @janpio Hey janpio, the travis-ci

[GitHub] PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6

2018-10-01 Thread GitBox
PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug [cordova-plugin-network-information] connection info is not reliable on Android 6 URL: https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426035590 I triggered a new build. (I did change some

[GitHub] shamilovtim commented on issue #198: Updated README for Android file uploads.

2018-10-01 Thread GitBox
shamilovtim commented on issue #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198#issuecomment-426068611 @janpio Thanks for your answer. I was trying to send a simple .jpg avatar from an Android application to our Flask REST

[GitHub] shamilovtim edited a comment on issue #198: Updated README for Android file uploads.

2018-10-01 Thread GitBox
shamilovtim edited a comment on issue #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198#issuecomment-426068611 @janpio Thanks for your answer. I was trying to send a simple .jpg avatar from an Android application to our

[GitHub] shamilovtim closed pull request #198: Updated README for Android file uploads.

2018-10-01 Thread GitBox
shamilovtim closed pull request #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] shamilovtim commented on issue #198: Updated README for Android file uploads.

2018-10-01 Thread GitBox
shamilovtim commented on issue #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198#issuecomment-426070505 Further research leads me to believe that this is an issue with Flask rather than Android. Closing

[GitHub] janpio commented on issue #198: Updated README for Android file uploads.

2018-10-01 Thread GitBox
janpio commented on issue #198: Updated README for Android file uploads. URL: https://github.com/apache/cordova-plugin-file-transfer/pull/198#issuecomment-426071073 Thanks for following up, was suspecting something like this.

<    1   2