winnerliu commented on issue #529:
org.apache.cordova.engine.SystemWebView.mContext leak !
URL: https://github.com/apache/cordova-android/issues/529#issuecomment-437656885
@janpio
This is an automated message from the
winnerliu commented on issue #529:
org.apache.cordova.engine.SystemWebView.mContext leak !
URL: https://github.com/apache/cordova-android/issues/529#issuecomment-437656775
[use leakcanary found](https://i.imgur.com/6gBzMoT.png)
brodybits commented on issue #518: Native crash abort on android 8.1
URL: https://github.com/apache/cordova-android/issues/518#issuecomment-437685443
I gotta say this looks like an issue on the Android platform and not on
Cordova. I wouldn't mind a workaround solution, though.
brodybits commented on issue #529:
org.apache.cordova.engine.SystemWebView.mContext leak !
URL: https://github.com/apache/cordova-android/issues/529#issuecomment-437686184
Reopening for now. @winnerliu a better explanation to walk us through the
issue would be really appreciated since not
winnerliu opened a new issue #529:
org.apache.cordova.engine.SystemWebView.mContext leak !
URL: https://github.com/apache/cordova-android/issues/529
SystemWebView memory leak
This is an automated message from the Apache Git
janpio commented on issue #64: Layout abnormal under iPhone X+
URL:
https://github.com/apache/cordova-plugin-wkwebview-engine/issues/64#issuecomment-437689326
Can you provide a screenshot what is happening exactly?
What versions of everything are you using?
janpio commented on issue #193: setRate not working
URL:
https://github.com/apache/cordova-plugin-media/issues/193#issuecomment-437689397
`setRate` is only supported on iOS, as documented:
https://github.com/apache/cordova-plugin-media#supported-platforms-7
janpio closed issue #193: setRate not working
URL: https://github.com/apache/cordova-plugin-media/issues/193
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
brodybits commented on issue #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437719905
@jcesarmobile I was hoping to close in on an approved solution for this one
and #540, sorry I did not really understand you before. I would slightly favor
sdgpalm2 commented on issue #164: Not working for iPhone XR and XS max
URL:
https://github.com/apache/cordova-plugin-splashscreen/issues/164#issuecomment-437742723
See early issue #158, the code for this #159 has been submitted and which is
in the Ready for Review state.
FlySnowIII commented on issue #459: Beta versions of cocoapods cause adding of
pod-dependent plugins to fail
URL: https://github.com/apache/cordova-ios/issues/459#issuecomment-437760066
I'm waiting for this Bug fixes.
During this time, My way is:
1. uninstall cocoapods use brew
brodybits commented on issue #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437713435
P.S. If someone else does a squash merge, please keep the "Co-authored-by"
comments to give due credit to both @kkirby and myself.
jcesarmobile commented on issue #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437717111
The “other” was #542, but as you keep changing both I don’t know anymore
This is an
kkjhamb01 opened a new issue #460: Issue in Cordova iOS 4.5.5 for xcode 10.0
URL: https://github.com/apache/cordova-ios/issues/460
@dpogue I build successfully app in IOS12 / Xcode20 but I am facing many
design related issues like header disappear after moving to a screen and click
not
brodybits edited a comment on issue #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437713435
P.S. If someone else does a squash merge, please keep the "Co-authored-by"
comments from the commits to give due credit to both @kkirby and myself.
brodybits commented on issue #542: [WIP] Resolve GH-539 & GH-540 on master
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437713593
> But it can be done in a separate PR
I would favor that.
I am now waiting for final approval to merge #539 before merging
brodybits edited a comment on issue #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437712752
I just rebased on master (actually pushed the first 3 changes from PR #542
to resolve the original issue on master). Fix should be straightforward to
brodybits commented on issue #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437712752
I just rebased on master (actually pushed the first 3 changes from PR #542
to resolve the original issue on master). Fix should be straightforward to
FlySnowIII edited a comment on issue #459: Beta versions of cocoapods cause
adding of pod-dependent plugins to fail
URL: https://github.com/apache/cordova-ios/issues/459#issuecomment-437760066
I'm waiting for this Bug fixes.
During this time, My way is:
1. uninstall cocoapods use
j3k0 commented on issue #540: Issue to copy library from plugin after updating
to v7.1.2
URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437769075
Hi @brodybits
The `cc.fovea.cordova.purchase` plugin has the same error (fails on 7.1.2,
succeeds on 7.1.1). Cf
brodybits opened a new pull request #544: Remove obsolete check for JellyBean
(GH-534)
URL: https://github.com/apache/cordova-android/pull/544
to work properly on Android Pie
was introduced in dc0bfeb0c (CB-11828)
Not needed since Android JellyBean (4.0-4.3) is no longer
codecov-io commented on issue #544: Remove obsolete check for JellyBean (GH-534)
URL: https://github.com/apache/cordova-android/pull/544#issuecomment-437706958
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/544?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #544: Remove obsolete check for JellyBean
(GH-534)
URL: https://github.com/apache/cordova-android/pull/544#issuecomment-437706958
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/544?src=pr=h1)
Report
> Merging
benmcmaster opened a new issue #371: Crashing in iOS 12 with
PictureSourceType.CAMERA
URL: https://github.com/apache/cordova-plugin-camera/issues/371
`getPicture` is crashing in iOS 12 with:
```
photoObj =
quality: 40
allowEdit: false
destinationType:
brodybits commented on issue #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437709899
What do you mean by "the other one"?
This is an automated message from the Apache Git
brodybits commented on issue #542: Resolve GH-539 & GH-540 on master
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437710409
> we still need to handle it ends in .jar or .aar to remap to app/target-dir
instead of app/src/main/target-dir
Can you think of any
brodybits commented on issue #542: Resolve GH-539 & GH-540 on master
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437702681
Updated as follows:
- rebased on master
- added uninstall tests
- Solution for GH-539 needed rewrite to work on master branch
-
brodybits commented on a change in pull request #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#discussion_r232503550
##
File path: bin/templates/cordova/lib/pluginHandlers.js
##
@@ -34,7 +34,7 @@ var handlers = {
// a later
codecov-io commented on issue #542: Resolve GH-539 & GH-540 on master
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437703013
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/542?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #542: Resolve GH-539 & GH-540 on master
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437703013
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/542?src=pr=h1)
Report
> Merging
brodybits commented on issue #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437704214
I just pushed an update that would be much easier to cherry-pick between
7.1.x and master. Note that this update basically clobbers the change proposed
by
brodybits commented on issue #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437698190
I just pushed changes to add unit test and fix the issue in case of
uninstall.
Unfortunately I am not able to rebase this fix onto master since the
32 matches
Mail list logo
