[GitHub] pengzhiqiang110 opened a new issue #65: 想问下这个插件怎么使用,

[GitBox]

pengzhiqiang110 opened a new issue #65: 想问下这个插件怎么使用,
URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/65
 
 
   这个插件怎么用啊


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] Narasimhulumadhana opened a new issue #114: upload media file in ionic data[0].fullPath not reading in readasDataUrl

[GitBox]

Narasimhulumadhana opened a new issue #114: upload media file in ionic 
data[0].fullPath not reading in readasDataUrl
URL: https://github.com/apache/cordova-plugin-media-capture/issues/114
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] saikiran1264 opened a new issue #545: cordova platform add android command is not working in windows 10

[GitBox]

saikiran1264 opened a new issue #545: cordova platform add android command is 
not working in windows 10
URL: https://github.com/apache/cordova-android/issues/545
 
 
   Hi,
   I have followed exactly the belows steps in my windows 10
   
   npm install -g cordova
   cd my_project
   cordova platform remove android
   cordova platform add android@7.1.2
   
   but after providing "cordova platform add android@7.1.2" command , it is not 
showing any error or any platform addition.
output : cordova platform add android@7.1.2
   Using cordova-fetch for cordova-android@7.1.2
   After this, screen(command prompts) hangs there without showing any progress
   
   whereas in MAC O.S its working fine with above steps. Could you please check 
and resolve
   
   >cordova --version
   8.1.2 (cordova-lib@8.1.1)
   >node --version
   v10.13.0
   >npm --version
   6.4.1
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] afdev82 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

[GitBox]

afdev82 commented on issue #540: Issue to copy library from plugin after 
updating to v7.1.2
URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437791781
 
 
   > @afdev82 it would really help us if you can name the specific plugin that 
triggers this issue.
   > 
   > We will need to make a specific exception to solve this issue without 
breaking old plugin compatibility.
   
   Hi, the plugin is this: https://github.com/adnotam/cordova-plugin-deezer


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] oliversalzburg commented on issue #452: [Discussion]Why not use nsoperation queue instead of dispatch queue in CDVCommandDelegateImpl.m?

[GitBox]

oliversalzburg commented on issue #452: [Discussion]Why not use nsoperation 
queue instead of dispatch queue in CDVCommandDelegateImpl.m?
URL: https://github.com/apache/cordova-ios/issues/452#issuecomment-437832852
 
 
   It sounds reasonable and the change seems minor, but I know too little of 
the subject to properly assess the change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] adilthree commented on issue #511: java.lang.RuntimeException: Unable to get provider com.google.android.gms.ads.MobileAdsInitProvider

[GitBox]

adilthree commented on issue #511: java.lang.RuntimeException: Unable to get 
provider com.google.android.gms.ads.MobileAdsInitProvider
URL: https://github.com/apache/cordova-android/issues/511#issuecomment-438153984
 
 
   compile 'com.google.android.gms:play-services-ads:12.0.0'
   add this dependency your sdk is low for your dependency. 
   I faced this problem now i add this my problem solved 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] regiMario commented on issue #461: fix issue #458

[GitBox]

regiMario commented on issue #461: fix issue #458
URL: https://github.com/apache/cordova-ios/pull/461#issuecomment-438160911
 
 
   I tried running the tests before i uploaded and got this far.
   `[mario@mac13dev ~/github/cordova-ios]$ npm test
   
   > cordova-ios@5.0.0-dev test /Users/mario/github/cordova-ios
   > npm run unit-tests && npm run test:component && npm run objc-tests && npm 
run e2e-tests
   
   
   > cordova-ios@5.0.0-dev unit-tests /Users/mario/github/cordova-ios
   > jasmine --config=tests/spec/unit.json
   
   DEPRECATION: Setting throwOnExpectationFailure directly on Env is 
deprecated, please use the oneFailurePerSpec option in `configure`
   DEPRECATION: Setting randomizeTests directly is deprecated, please use the 
random option in `configure`
   internal/modules/cjs/loader.js:582
   throw err;
   ^
   
   Error: Cannot find module 'cordova-common'
   at Function.Module._resolveFilename 
(internal/modules/cjs/loader.js:580:15)
   at Function.Module._load (internal/modules/cjs/loader.js:506:25)
   at Module.require (internal/modules/cjs/loader.js:636:17)
   at require (internal/modules/cjs/helpers.js:20:18)
   at Object. 
(/Users/mario/github/cordova-ios/tests/spec/unit/Api.spec.js:22:21)
   at Module._compile (internal/modules/cjs/loader.js:688:30)
   at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
   at Module.load (internal/modules/cjs/loader.js:598:32)
   at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
   at Function.Module._load (internal/modules/cjs/loader.js:529:3)
   npm ERR! code ELIFECYCLE
   npm ERR! errno 4
   npm ERR! cordova-ios@5.0.0-dev unit-tests: `jasmine 
--config=tests/spec/unit.json`
   npm ERR! Exit status 4
   npm ERR! 
   npm ERR! Failed at the cordova-ios@5.0.0-dev unit-tests script.
   npm ERR! This is probably not a problem with npm. There is likely additional 
logging output above.
   npm WARN Local package.json exists, but node_modules missing, did you mean 
to install?
   npm ERR! Test failed.  See above for more details.
   [mario@mac13dev ~/github/cordova-ios]$ npm -g list --depth=0
   /usr/local/lib
   ├── cordova@8.1.2
   ├── cordova-common@3.0.0
   ├── ios-deploy@1.9.4
   ├── jasmine@3.3.0
   └── npm@6.4.1`
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] AutoAlert opened a new issue #373: Cannot take pictures on Android 8

[GitBox]

AutoAlert opened a new issue #373: Cannot take pictures on Android 8
URL: https://github.com/apache/cordova-plugin-camera/issues/373
 
 
   If I try and take a photo on a device using Android 8 with targetSDK 26, i 
get an error 
   
   > file:///data/user/0/{mypackage}/cache/Capture.jpg exposed beyond app 
through ClipData.Item.getUri()
   
   Which I believe is due to changes in how apps can access the file system 
from Android Nougat.  See [
   
https://stackoverflow.com/questions/38200282/android-os-fileuriexposedexception-file-storage-emulated-0-test-txt-exposed](url)
   
   I am using:
   
   - 8.1.2  (cordova-lib@8.1.1)
   - android 7.1.2
   - cordova-plugin-camera 4.0.3
   - cordova-plugin-console 1.0.3
   - cordova-plugin-file 6.0.1
   
   I have tried adding the following to my AndroidManifest.xml
   
   `
   
   `
   
   And the following to camera_provider_paths.xml
   
   `http://schemas.android.com/apk/res/android;>
   `
   
   But I get the same error unless I change the targetSDK to a lower value.  Is 
this something simple i'm missing or is it a bug in the plugin?
   
   Thanks
   Richard


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] mahnuh opened a new issue #372: Cropping image from camera not working on iOS

[GitBox]

mahnuh opened a new issue #372: Cropping image from camera not working on iOS
URL: https://github.com/apache/cordova-plugin-camera/issues/372
 
 
   When taking a picture with the camera I'm not able to crop the image. As you 
can see in the following video the image always bounces back, even avert 
zooming in:
   http://sharedby.manuel-heidrich.com/UkrCU8/nRSiht3HXY
   
   When selecting an image from the camera roll everything works fine. I'm 
using v4.0.3 of the plugin.
   
   Is this a bug or am I missing something?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] codecov-io commented on issue #461: fix issue #458

[GitBox]

codecov-io commented on issue #461: fix issue #458
URL: https://github.com/apache/cordova-ios/pull/461#issuecomment-438165224
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/461?src=pr=h1) 
Report
   > Merging 
[#461](https://codecov.io/gh/apache/cordova-ios/pull/461?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/62ebfbd74aff11b9fa0ca26685ee0578ecd9150f?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/461/graphs/tree.svg?width=650=WomDD5jInz=150=pr)](https://codecov.io/gh/apache/cordova-ios/pull/461?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #461   +/-   ##
   ===
 Coverage   74.29%   74.29%   
   ===
 Files  12   12   
 Lines1564 1564   
   ===
 Hits 1162 1162   
 Misses402  402
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/461?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/461?src=pr=footer). 
Last update 
[62ebfbd...8ad9dc5](https://codecov.io/gh/apache/cordova-ios/pull/461?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile closed issue #34: lock on iOS does not work right after device ready event

[GitBox]

jcesarmobile closed issue #34: lock on iOS does not work right after device 
ready event 
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/34
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] regiMario commented on issue #458: cordova run --list --device fails for Virtualhere devices

[GitBox]

regiMario commented on issue #458: cordova run --list --device fails for 
Virtualhere devices
URL: https://github.com/apache/cordova-ios/issues/458#issuecomment-437934005
 
 
   Had to read up on that first.
   Done as good as i could for the first time.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #454: Use NSOperationQueue (GH-452)

[GitBox]

brodybits commented on issue #454: Use NSOperationQueue (GH-452)
URL: https://github.com/apache/cordova-ios/pull/454#issuecomment-437935236
 
 
   P.S. If we merge this one I would like to see a similar change on 
cordova-osx (macOS), just raised 
 for tracking.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

[GitBox]

brodybits commented on issue #540: Issue to copy library from plugin after 
updating to v7.1.2
URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437941193
 
 
   Thanks guys. We will test installation with both plugins before releasing 
the next patch. I think we will need another unit test to check installation of 
`.aidl` for cordova-plugin-purchase.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #70: Use NSOperationQueue to resolve possible concurrency issue on macOS

[GitBox]

brodybits opened a new issue #70: Use NSOperationQueue to resolve possible 
concurrency issue on macOS
URL: https://github.com/apache/cordova-osx/issues/70
 
 
   Similar to issue discussed for iOS in apache/cordova-ios#452, with PR 
proposed in for iOS in apache/cordova-ios#454


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #454: Use NSOperationQueue (GH-452)

[GitBox]

brodybits commented on issue #454: Use NSOperationQueue (GH-452)
URL: https://github.com/apache/cordova-ios/pull/454#issuecomment-437934794
 
 
   I just updated the title to quickly reflect the actual proposed change. I 
would favor this change in general for the next major release, would like to 
see some testing according to 

 and quick performance testing.
   
   I cannot promise when any of us will have a chance to test and merge, 
suggest you continue to ask on d...@cordova.apache.org.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue commented on issue #543: Cordova Platform add Android command failure

[GitBox]

dpogue commented on issue #543: Cordova Platform add Android command failure
URL: https://github.com/apache/cordova-android/issues/543#issuecomment-437924312
 
 
   This sounds like an npm issue rather than specifically a Cordova issue. It's 
normal to have the `node_modules/.staging` folder during an npm install, but it 
should be removed automatically when the install finishes.
   
   Other people facing this issue suggested checking that you have enough 
available disk space and memory.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue closed issue #543: Cordova Platform add Android command failure

[GitBox]

dpogue closed issue #543: Cordova Platform add Android command failure
URL: https://github.com/apache/cordova-android/issues/543
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #452: [Discussion]Why not use nsoperation queue instead of dispatch queue in CDVCommandDelegateImpl.m?

[GitBox]

brodybits commented on issue #452: [Discussion]Why not use nsoperation queue 
instead of dispatch queue in CDVCommandDelegateImpl.m?
URL: https://github.com/apache/cordova-ios/issues/452#issuecomment-437926769
 
 
   It would be great if someone could post a plugin that demonstrates this 
issue.
   
   From some quick research I think this would be a nice enhancement for a 
major release, someday in the future. It should be pretty straightforward: 

   
   I found another really nice resource at: 

   
   A pull request would definitely be welcome.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] mpotter-modus commented on issue #34: lock on iOS does not work right after device ready event

[GitBox]

mpotter-modus commented on issue #34: lock on iOS does not work right after 
device ready event 
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-437914978
 
 
   Confirmed - we're having the same issue. Looks like this was fixed in a89e94c
   
   Any plans to publish an update to the NPM repo @jcesarmobile / @macdonst ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] regiMario opened a new pull request #461: fix issue #458

[GitBox]

regiMario opened a new pull request #461: fix issue #458
URL: https://github.com/apache/cordova-ios/pull/461
 
 
   
   
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   I'm using Virtualhere (https://www.virtualhere.com/home) for developing 
remotely.
   While Safari and Xcode do see the device after connecting via Virtualhere, 
cordova does not.
   The attached patch remedies the issue in cordova-ios@4.5.5
   
   ### What testing has been done on this change?
   Manual testing with virtualhere devices as well as regular USB devices
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #542: Resolve GH-539 & GH-540 on master

[GitBox]

brodybits closed pull request #542: Resolve GH-539 & GH-540 on master
URL: https://github.com/apache/cordova-android/pull/542
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/cordova/lib/pluginHandlers.js 
b/bin/templates/cordova/lib/pluginHandlers.js
index bee2841f9..f1b0dba02 100644
--- a/bin/templates/cordova/lib/pluginHandlers.js
+++ b/bin/templates/cordova/lib/pluginHandlers.js
@@ -26,7 +26,7 @@ var handlers = {
 if (!obj.src) throw new CordovaError(generateAttributeError('src', 
'source-file', plugin.id));
 if (!obj.targetDir) throw new 
CordovaError(generateAttributeError('target-dir', 'source-file', plugin.id));
 
-var dest = studioPathRemap(obj);
+var dest = getInstallDestination(obj);
 
 if (options && options.force) {
 copyFile(plugin.dir, obj.src, project.projectDir, dest, 
!!(options && options.link));
@@ -35,7 +35,7 @@ var handlers = {
 }
 },
 uninstall: function (obj, plugin, project, options) {
-var dest = studioPathRemap(obj);
+var dest = getInstallDestination(obj);
 
 // TODO: Add Koltin extension to uninstall, since they are handled 
like Java files
 if (obj.src.endsWith('java')) {
@@ -292,9 +292,15 @@ function generateAttributeError (attribute, element, id) {
 return 'Required attribute "' + attribute + '" not specified in <' + 
element + '> element from plugin: ' + id;
 }
 
+function getInstallDestination (obj) {
+return studioPathRemap(obj) ||
+path.join(obj.targetDir, path.basename(obj.src));
+}
+
 function studioPathRemap (obj) {
-// If a Java file is using the new directory structure, don't penalize it
-if (!obj.targetDir.includes('app/src/main')) {
+// If any source file is using the app new directory structure,
+// don't penalize it
+if (!obj.targetDir.includes('app')) {
 if (obj.src.endsWith('.java')) {
 return path.join('app/src/main/java', obj.targetDir.substring(4), 
path.basename(obj.src));
 } else {
diff --git a/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml 
b/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml
index a40df2b28..b299b645a 100644
--- a/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml
+++ b/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml
@@ -70,6 +70,12 @@
 
 
+
+
+
 
 
 
diff --git 
a/spec/fixtures/org.test.plugins.dummyplugin/src/android/DummyPlugin2.java 
b/spec/fixtures/org.test.plugins.dummyplugin/src/android/DummyPlugin2.java
new file mode 100644
index 0..c2dd0f731
--- /dev/null
+++ b/spec/fixtures/org.test.plugins.dummyplugin/src/android/DummyPlugin2.java
@@ -0,0 +1 @@
+./org.test.plugins.dummyplugin/src/android/DummyPlugin2.java
diff --git a/spec/fixtures/org.test.plugins.dummyplugin/src/android/TestAar.aar 
b/spec/fixtures/org.test.plugins.dummyplugin/src/android/TestAar.aar
new file mode 100644
index 0..ce4015431
--- /dev/null
+++ b/spec/fixtures/org.test.plugins.dummyplugin/src/android/TestAar.aar
@@ -0,0 +1 @@
+./org.test.plugins.dummyplugin/src/android/TestAar.aar
diff --git a/spec/unit/pluginHandlers/handlers.spec.js 
b/spec/unit/pluginHandlers/handlers.spec.js
index cc6a39dde..4c398eabb 100644
--- a/spec/unit/pluginHandlers/handlers.spec.js
+++ b/spec/unit/pluginHandlers/handlers.spec.js
@@ -102,6 +102,25 @@ describe('android project handler', function () {
 android['source-file'].install(valid_source[0], 
dummyPluginInfo, dummyProject);
 }).toThrow(new Error('"' + target + '" already exists!'));
 });
+
+it('Test#007 : should allow installing sources using proper path', 
function () {
+android['source-file'].install(valid_source[1], 
dummyPluginInfo, dummyProject, {android_studio: true});
+expect(copyFileSpy)
+.toHaveBeenCalledWith(dummyplugin, 
'src/android/DummyPlugin2.java', temp, 
path.join('app/src/main/src/com/phonegap/plugins/dummyplugin/DummyPlugin2.java'),
 false);
+});
+
+// TODO: renumber these tests and other tests below
+it('Test#007a : should allow installing lib file from sources 
using proper path', function () {
+android['source-file'].install(valid_source[2], 
dummyPluginInfo, dummyProject, {android_studio: true});
+expect(copyFileSpy)
+.toHaveBeenCalledWith(dummyplugin, 
'src/android/TestLib.jar', temp, path.join('app/libs/TestLib.jar'), false);
+});
+
+it('Test#007b : should allow installing aar file from sources 
using proper path', function () {
+

[cordova-android] branch master updated (e31596f -> 576ad18)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git.


from e31596f  Remove obsolete check for JellyBean (GH-534) (#544)
 add 898a6a8  Add a unit test to test source-file target-dir /app/src/main/…
 add fb1dfb2  unit test uninstall of  with app dest
 add c2f6631  GH-539 fix destination path fallback
 add 3caefca  unit test source-file with custom lib target-dir
 add c15312e  unit test uninstall of  with app dest
 add ef493b4  GH-540 fix for source-file with app target-dir
 new 576ad18  Merge pull request #542 from brodybits/gh-540-hotfix

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 bin/templates/cordova/lib/pluginHandlers.js| 14 +--
 .../org.test.plugins.dummyplugin/plugin.xml|  6 +++
 .../src/android/DummyPlugin2.java  |  1 +
 .../src/android/TestAar.aar|  1 +
 spec/unit/pluginHandlers/handlers.spec.js  | 47 ++
 5 files changed, 65 insertions(+), 4 deletions(-)
 create mode 100644 
spec/fixtures/org.test.plugins.dummyplugin/src/android/DummyPlugin2.java
 create mode 100644 
spec/fixtures/org.test.plugins.dummyplugin/src/android/TestAar.aar


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-android] 01/01: Merge pull request #542 from brodybits/gh-540-hotfix

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git

commit 576ad183e72376b8f525552d081a154f0e924eed
Merge: e31596f ef493b4
Author: Chris Brody 
AuthorDate: Mon Nov 12 13:23:23 2018 -0500

Merge pull request #542 from brodybits/gh-540-hotfix

Resolve GH-539 & GH-540 on master

 bin/templates/cordova/lib/pluginHandlers.js| 14 +--
 .../org.test.plugins.dummyplugin/plugin.xml|  6 +++
 .../src/android/DummyPlugin2.java  |  1 +
 .../src/android/TestAar.aar|  1 +
 spec/unit/pluginHandlers/handlers.spec.js  | 47 ++
 5 files changed, 65 insertions(+), 4 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue commented on issue #32: Link `node_modules` during platform creation if it exists

[GitBox]

dpogue commented on issue #32: Link `node_modules` during platform creation if 
it exists
URL: https://github.com/apache/cordova/issues/32#issuecomment-437981352
 
 
   There are a bunch of similar-sounding problems here, and I think you've 
identified one and @erisu handled one, but they're not quite the same problem 
and it probably makes sense to try to identify all the problems:
   
   1. **Existing released platforms need their node_modules copied when 
installing with the CLI**
 This *should* already happen, because the copy command is unconditionally 
in their project create scripts.
   
   2. **Existing released platforms need their node_modules copied when 
installing using `bin/create` from a tarball**
 This is currently broken because the tarballs don't include node_modules, 
but I think it's out of our current scope to try to fix this for existing 
releases.
   
   3. **Current platforms do not need their node_modules copied because they 
should match the CLI**
 But it's not safe to rely on this, which is what I believe @raphinesse is 
pointing out. See case 5 below.
   
   4. **Current platforms need their node_modules copied when installing using 
`bin/create` from a tarball**
 @erisu fixed part of this by ensuring that the bin/create scripts will 
include the command to copy node_modules. One problem that still exists is that 
the tarball releases on dist don't actually include node_modules, but that's 
probably also out of scope for this particular discussion (it should, however, 
get raised for discussion in terms of our release process).
   
   5. **Current platforms with a future CLI (or vice versa) need their 
node_modules copied when installing with the CLI**
 This is @raphinesse's point, that is the complication in case 3. If we 
install an older platform, its dependencies might not match the versions used 
by the CLI, so we would need to copy the nested node_modules folder to ensure 
we don't break module resolution.
   
   The PRs from @erisu solve part of case 4, but we probably need to always 
copy node_modules if they exist to handle case 5.
   
   Are there any additional edge cases that I've missed?
   
   ---
   
   Doing this "the right way", and running the platform API scripts from the 
node_modules folder itself is definitely something we should eventually try to 
move towards, but we would still need to account for case 4 that requires 
copying everything.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #542: Resolve GH-539 & GH-540 on master

[GitBox]

brodybits commented on issue #542: Resolve GH-539 & GH-540 on master
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437982480
 
 
   I just remembered a TODO item is that the pluginHandler tests need to be 
renumbered, leaving this for the next PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] mpotter-modus commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape Orientation turn up-sidedown

[GitBox]

mpotter-modus commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape 
Orientation turn up-sidedown
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/25#issuecomment-437987205
 
 
   @maverickmishra do you have any insight into whether a 3.0.2 release of this 
plugin is planned? If not, do you know who would? Thank you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #542: Resolve GH-539 & GH-540 on master

[GitBox]

brodybits commented on issue #542: Resolve GH-539 & GH-540 on master
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437980723
 
 
   > I think we should fix .jar and .aar for now in a separate PR and 
investigate the .so
   
   I just raised #547 for that.
   
   Merging now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile edited a comment on issue #34: lock on iOS does not work right after device ready event

[GitBox]

jcesarmobile edited a comment on issue #34: lock on iOS does not work right 
after device ready event 
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-437976690
 
 
   I don't know how to do Apache Cordova plugin releases, sorry, it's not as 
simple as publishing it in npm


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

brodybits commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-437989889
 
 
   P.S. This *may* affect : 
Document how to use Android NDK libraries in plugins


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

[GitBox]

brodybits commented on issue #540: Issue to copy library from plugin after 
updating to v7.1.2
URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437946441
 
 
   > Yes, we had to put an [ugly 
hack](https://github.com/j3k0/cordova-plugin-purchase/blob/master/scripts/androidBeforeInstall.js#L21-L25)
 in place to have installation/uninstallation work in all cases.
   
   Starting with 

   
   Which seems to deal with the changed `res` location. I wish you had reported 
it to us. We did make some efforts to support plugins using the old project 
structure in the recent patch release, think it would be ideal if we could do 
this as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

[GitBox]

brodybits commented on issue #540: Issue to copy library from plugin after 
updating to v7.1.2
URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437956630
 
 
   @j3k0 I just raised #546 for tracking of the issues with 
cordova-plugin-purchase.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #546: cordova-plugin-purchase plugin issues

[GitBox]

brodybits opened a new issue #546: cordova-plugin-purchase plugin issues
URL: https://github.com/apache/cordova-android/issues/546
 
 
   - installation was broken by 7.1.2 release 
(, 
)
   - before-plugin-install hook script was needed to support both 
cordova-android@6 and cordova-android@7 
(,
 , 
, 
, 
)
   
   Issue with 7.1.2 release *seems* like it should be solved by PR #539 but I 
would have to test to be 100% sure.
   
   The before-plugin-install hook seems to be needed to deal with `.aidl`, 
changed `res` location, and maybe changed `config-file` handling. Using hook 
scripts is an ugly solution that we would like to avoid, especially considering 
that they are not supported by PhoneGap Build.
   
   This issue *may* turn out to be a duplicate, raising it before we lose track.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #539: Fix dest overwrite

[GitBox]

brodybits commented on issue #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437962285
 
 
   Closing now in favor of PR #542. I just put this change back onto the 7.1.x 
branch (including the original commits by @kkirby).
   
   I am closing this because the proposed change is only a partial solution for 
the issues we need to fix in #542, to resolve #540 and maybe some other issues 
with plugins using the old project structure.
   
   @kkirby will absolutely get co-author credit for the added test and solution 
for the case when `studioPathRemap` returns null.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #539: Fix dest overwrite

[GitBox]

brodybits closed pull request #539: Fix dest overwrite
URL: https://github.com/apache/cordova-android/pull/539
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/cordova/lib/pluginHandlers.js 
b/bin/templates/cordova/lib/pluginHandlers.js
index a3ebed0eb..e78e3ee4e 100644
--- a/bin/templates/cordova/lib/pluginHandlers.js
+++ b/bin/templates/cordova/lib/pluginHandlers.js
@@ -34,7 +34,7 @@ var handlers = {
 // a later plugins release.  This is for legacy plugins to work 
with Cordova.
 
 if (options && options.android_studio === true) {
-dest = studioPathRemap(obj);
+dest = getInstallDestination(obj);
 }
 
 if (options && options.force) {
@@ -47,7 +47,7 @@ var handlers = {
 var dest = path.join(obj.targetDir, path.basename(obj.src));
 
 if (options && options.android_studio === true) {
-dest = studioPathRemap(obj);
+dest = getInstallDestination(obj);
 }
 
 // TODO: Add Koltin extension to uninstall, since they are handled 
like Java files
@@ -317,6 +317,11 @@ function generateAttributeError (attribute, element, id) {
 return 'Required attribute "' + attribute + '" not specified in <' + 
element + '> element from plugin: ' + id;
 }
 
+function getInstallDestination (obj) {
+return studioPathRemap(obj) ||
+path.join(obj.targetDir, path.basename(obj.src));
+}
+
 function studioPathRemap (obj) {
 // If a Java file is using the new directory structure, don't penalize it
 if (!obj.targetDir.includes('app/src/main')) {
diff --git a/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml 
b/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml
index a40df2b28..5451ef8da 100644
--- a/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml
+++ b/spec/fixtures/org.test.plugins.dummyplugin/plugin.xml
@@ -70,6 +70,8 @@
 
 
+
 
 
 
diff --git 
a/spec/fixtures/org.test.plugins.dummyplugin/src/android/DummyPlugin2.java 
b/spec/fixtures/org.test.plugins.dummyplugin/src/android/DummyPlugin2.java
new file mode 100644
index 0..c2dd0f731
--- /dev/null
+++ b/spec/fixtures/org.test.plugins.dummyplugin/src/android/DummyPlugin2.java
@@ -0,0 +1 @@
+./org.test.plugins.dummyplugin/src/android/DummyPlugin2.java
diff --git a/spec/unit/pluginHandlers/handlers.spec.js 
b/spec/unit/pluginHandlers/handlers.spec.js
index edc8f43bc..206de56e2 100644
--- a/spec/unit/pluginHandlers/handlers.spec.js
+++ b/spec/unit/pluginHandlers/handlers.spec.js
@@ -108,6 +108,12 @@ describe('android project handler', function () {
 android['source-file'].install(valid_source[0], 
dummyPluginInfo, dummyProject);
 }).toThrow(new Error('"' + target + '" already exists!'));
 });
+
+it('Test#007 : should allow installing sources using proper path', 
function () {
+android['source-file'].install(valid_source[1], 
dummyPluginInfo, dummyProject, {android_studio: true});
+expect(copyFileSpy)
+.toHaveBeenCalledWith(dummyplugin, 
'src/android/DummyPlugin2.java', temp, 
path.join('app/src/main/src/com/phonegap/plugins/dummyplugin/DummyPlugin2.java'),
 false);
+});
 });
 
 describe('of  elements', function () {
@@ -257,6 +263,10 @@ describe('android project handler', function () {
 });
 });
 
+// TODO:
+// - merge tests of  elements into single describe block
+//   (with proper beforeEach/afterEach)
+// - renumber the tests after Test#019
 describe('of  elements', function () {
 it('Test#019 : should remove stuff by calling common.deleteJava 
for Android Studio projects', function () {
 android['source-file'].install(valid_source[0], 
dummyPluginInfo, dummyProject, {android_studio: true});
@@ -265,6 +275,14 @@ describe('android project handler', function () {
 });
 });
 
+describe('of  element, with specific app target-dir', 
function () {
+it('Test#019a : should remove stuff by calling common.deleteJava 
for Android Studio projects, with specific app target-dir', function () {
+android['source-file'].install(valid_source[1], 
dummyPluginInfo, dummyProject, {android_studio: true});
+android['source-file'].uninstall(valid_source[1], 
dummyPluginInfo, dummyProject, {android_studio: true});
+expect(deleteJavaSpy).toHaveBeenCalledWith(temp, 
path.join('app/src/main/src/com/phonegap/plugins/dummyplugin/DummyPlugin2.java'));
+});
+});
+
 describe('of  elements', function () {
 

[GitHub] brodybits commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

[GitBox]

brodybits commented on a change in pull request #441: CB-14089: (android) Add 
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r232747948
 
 

 ##
 File path: bin/templates/project/app/build.gradle
 ##
 @@ -30,13 +34,16 @@ buildscript {
 
 dependencies {
 classpath 'com.android.tools.build:gradle:3.1.0'
+if (cdvHelpers.getConfigPreference('EnableKotlin', 
'false').toBoolean()) {
+classpath 
"org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+}
 }
 }
 
 // Allow plugins to declare Maven dependencies via build-extras.gradle.
 allprojects {
 repositories {
-mavenCentral();
+mavenCentral()
 
 Review comment:
   I think this should be proposed in a separate PR (this may be done in PR 
#507).
   
   Also I think removing semicolons should be proposed in a separate PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #507: Gradle updates

[GitBox]

brodybits commented on a change in pull request #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#discussion_r232749469
 
 

 ##
 File path: bin/templates/project/app/build.gradle
 ##
 @@ -22,33 +22,32 @@ apply plugin: 'com.android.application'
 buildscript {
 repositories {
 mavenCentral()
-maven {
-url "https://maven.google.com;
-}
+google()
 jcenter()
 }
 
 dependencies {
-classpath 'com.android.tools.build:gradle:3.1.0'
+classpath 'com.android.tools.build:gradle:3.2.0'
 }
 }
 
 // Allow plugins to declare Maven dependencies via build-extras.gradle.
 allprojects {
 repositories {
-mavenCentral();
+mavenCentral()
 
 Review comment:
   Add google() or replace mavenCentral() with google() here, as suggested in 
?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #507: Gradle updates

[GitBox]

janpio commented on a change in pull request #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#discussion_r232749688
 
 

 ##
 File path: bin/templates/project/app/build.gradle
 ##
 @@ -22,33 +22,32 @@ apply plugin: 'com.android.application'
 buildscript {
 repositories {
 mavenCentral()
-maven {
-url "https://maven.google.com;
-}
+google()
 jcenter()
 }
 
 dependencies {
-classpath 'com.android.tools.build:gradle:3.1.0'
+classpath 'com.android.tools.build:gradle:3.2.0'
 }
 }
 
 // Allow plugins to declare Maven dependencies via build-extras.gradle.
 allprojects {
 repositories {
-mavenCentral();
+mavenCentral()
 jcenter()
 }
 }
 
 task wrapper(type: Wrapper) {
-gradleVersion = '4.4.0'
+gradleVersion = '4.6.0'
 }
 
 // Configuration properties. Set these via environment variables, 
build-extras.gradle, or gradle.properties.
 // Refer to: 
http://www.gradle.org/docs/current/userguide/tutorial_this_and_that.html
 ext {
 apply from: '../CordovaLib/cordova.gradle'
+
 // The value for android.compileSdkVersion.
 if (!project.hasProperty('cdvCompileSdkVersion')) {
 cdvCompileSdkVersion = null;
 
 Review comment:
   What does this have to do with this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue commented on issue #507: Gradle updates

[GitBox]

dpogue commented on issue #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#issuecomment-437967593
 
 
   I believe this is ready to be merged, but I'm not sure what you think it has 
to do with #441, which is proposing the addition of an entirely different 
feature.
   
   **This** PR is updating gradle versions for compatibility with the latest 
Android SDK.  
   Kotlin support is out of scope here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #507: Gradle updates

[GitBox]

brodybits commented on a change in pull request #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#discussion_r232750991
 
 

 ##
 File path: bin/templates/project/app/build.gradle
 ##
 @@ -22,33 +22,32 @@ apply plugin: 'com.android.application'
 buildscript {
 repositories {
 mavenCentral()
-maven {
-url "https://maven.google.com;
-}
+google()
 jcenter()
 }
 
 dependencies {
-classpath 'com.android.tools.build:gradle:3.1.0'
+classpath 'com.android.tools.build:gradle:3.2.0'
 }
 }
 
 // Allow plugins to declare Maven dependencies via build-extras.gradle.
 allprojects {
 repositories {
-mavenCentral();
+mavenCentral()
 
 Review comment:
   Updates and suggestions in #441 may be relevant here. This PR is to update 
Gradle in general. #441 was raised to introduce Kotlin support but it did 
include some general updates that I think we should consider outside of adding 
the Kotlin support.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #34: lock on iOS does not work right after device ready event

[GitBox]

jcesarmobile commented on issue #34: lock on iOS does not work right after 
device ready event 
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-437976690
 
 
   I don't know how to do Apache plugin releases, sorry, it's not as simple as 
publishing it in npm


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #535: Fix user agent match issue android pie

[GitBox]

brodybits closed pull request #535: Fix user agent match issue android pie
URL: https://github.com/apache/cordova-android/pull/535
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/project/assets/www/cordova.js 
b/bin/templates/project/assets/www/cordova.js
index 3ae354cd8..aa5c6f8f8 100644
--- a/bin/templates/project/assets/www/cordova.js
+++ b/bin/templates/project/assets/www/cordova.js
@@ -977,7 +977,7 @@ androidExec.init = function() {
 //using the Online Event bridge for communicating from Native to JS
 //
 //It's ugly, but it's necessary.
-var check = 
navigator.userAgent.toLowerCase().match(/android\s[0-9].[0-9]/);
+var check = 
navigator.userAgent.toLowerCase().match(/android\s[0-9]+(\.[0-9]?)?/);
 var version_code = check && check[0].match(/4.[0-3].*/);
 if (version_code != null && nativeToJsBridgeMode == 
nativeToJsModes.EVAL_BRIDGE) {
   nativeToJsBridgeMode = nativeToJsModes.ONLINE_EVENT;
@@ -2183,4 +2183,4 @@ window.cordova = require('cordova');
 
 require('cordova/init');
 
-})();
\ No newline at end of file
+})();
diff --git a/cordova-js-src/exec.js b/cordova-js-src/exec.js
index f73d87a12..639144530 100644
--- a/cordova-js-src/exec.js
+++ b/cordova-js-src/exec.js
@@ -114,7 +114,7 @@ androidExec.init = function() {
 //using the Online Event bridge for communicating from Native to JS
 //
 //It's ugly, but it's necessary.
-var check = 
navigator.userAgent.toLowerCase().match(/android\s[0-9].[0-9]/);
+var check = 
navigator.userAgent.toLowerCase().match(/android\s[0-9]+(\.[0-9]?)?/);
 var version_code = check && check[0].match(/4.[0-3].*/);
 if (version_code != null && nativeToJsBridgeMode == 
nativeToJsModes.EVAL_BRIDGE) {
   nativeToJsBridgeMode = nativeToJsModes.ONLINE_EVENT;
diff --git a/test/app/src/main/assets/www/cordova.js 
b/test/app/src/main/assets/www/cordova.js
index 11da9eb0e..75781fd8a 100644
--- a/test/app/src/main/assets/www/cordova.js
+++ b/test/app/src/main/assets/www/cordova.js
@@ -982,7 +982,7 @@ androidExec.init = function() {
 //using the Online Event bridge for communicating from Native to JS
 //
 //It's ugly, but it's necessary.
-var check = 
navigator.userAgent.toLowerCase().match(/android\s[0-9].[0-9]/);
+var check = 
navigator.userAgent.toLowerCase().match(/android\s[0-9]+(\.[0-9]?)?/);
 var version_code = check && check[0].match(/4.[0-3].*/);
 if (version_code != null && nativeToJsBridgeMode == 
nativeToJsModes.EVAL_BRIDGE) {
   nativeToJsBridgeMode = nativeToJsModes.ONLINE_EVENT;
@@ -2203,4 +2203,4 @@ window.cordova = require('cordova');
 
 require('cordova/init');
 
-})();
\ No newline at end of file
+})();


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-android] branch master updated: Remove obsolete check for JellyBean (GH-534) (#544)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git


The following commit(s) were added to refs/heads/master by this push:
 new e31596f  Remove obsolete check for JellyBean (GH-534) (#544)
e31596f is described below

commit e31596f60eeb3d9a7d47844b3e0e45304530d30f
Author: Chris Brody 
AuthorDate: Mon Nov 12 12:06:45 2018 -0500

Remove obsolete check for JellyBean (GH-534) (#544)

to work properly on Android Pie

was introduced in dc0bfeb0c (CB-11828)

Resolves #534

Co-authored-by: 
Co-authored-by: Christopher J. Brody 
---
 cordova-js-src/exec.js | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/cordova-js-src/exec.js b/cordova-js-src/exec.js
index f73d87a..39e8c97 100644
--- a/cordova-js-src/exec.js
+++ b/cordova-js-src/exec.js
@@ -109,17 +109,6 @@ function androidExec(success, fail, service, action, args) 
{
 }
 
 androidExec.init = function() {
-//CB-11828
-//This failsafe checks the version of Android and if it's Jellybean, it 
switches it to
-//using the Online Event bridge for communicating from Native to JS
-//
-//It's ugly, but it's necessary.
-var check = 
navigator.userAgent.toLowerCase().match(/android\s[0-9].[0-9]/);
-var version_code = check && check[0].match(/4.[0-3].*/);
-if (version_code != null && nativeToJsBridgeMode == 
nativeToJsModes.EVAL_BRIDGE) {
-  nativeToJsBridgeMode = nativeToJsModes.ONLINE_EVENT;
-}
-
 bridgeSecret = +prompt('', 'gap_init:' + nativeToJsBridgeMode);
 channel.onNativeReady.fire();
 };


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed issue #534: User agent check in Cordova.js raises exception in Android 9

[GitBox]

brodybits closed issue #534: User agent check in Cordova.js raises exception in 
Android 9
URL: https://github.com/apache/cordova-android/issues/534
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #544: Remove obsolete check for JellyBean (GH-534)

[GitBox]

brodybits closed pull request #544: Remove obsolete check for JellyBean (GH-534)
URL: https://github.com/apache/cordova-android/pull/544
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/cordova-js-src/exec.js b/cordova-js-src/exec.js
index f73d87a12..39e8c97ee 100644
--- a/cordova-js-src/exec.js
+++ b/cordova-js-src/exec.js
@@ -109,17 +109,6 @@ function androidExec(success, fail, service, action, args) 
{
 }
 
 androidExec.init = function() {
-//CB-11828
-//This failsafe checks the version of Android and if it's Jellybean, it 
switches it to
-//using the Online Event bridge for communicating from Native to JS
-//
-//It's ugly, but it's necessary.
-var check = 
navigator.userAgent.toLowerCase().match(/android\s[0-9].[0-9]/);
-var version_code = check && check[0].match(/4.[0-3].*/);
-if (version_code != null && nativeToJsBridgeMode == 
nativeToJsModes.EVAL_BRIDGE) {
-  nativeToJsBridgeMode = nativeToJsModes.ONLINE_EVENT;
-}
-
 bridgeSecret = +prompt('', 'gap_init:' + nativeToJsBridgeMode);
 channel.onNativeReady.fire();
 };


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #441: CB-14089: (android) Add Kotlin support

[GitBox]

brodybits commented on issue #441: CB-14089: (android) Add Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#issuecomment-437967179
 
 
   What is the status of this proposal?
   
   If we merge PR #507 (Gradle updates) I think this one should be rebased.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue commented on issue #441: CB-14089: (android) Add Kotlin support

[GitBox]

dpogue commented on issue #441: CB-14089: (android) Add Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#issuecomment-437968135
 
 
   The status is that we're trying to find an option that doesn't 
unconditionally pull kotlin support libraries into all Cordova projects, 
although it's worth more investigation there to see whether that actually 
impacts the resulting APK filesize.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #507: Gradle updates

[GitBox]

brodybits commented on issue #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#issuecomment-437968251
 
 
   I understand that Kotlin is out of scope. But I think some suggestions in 
#441 should be considered since they seem to be outside the scope of adding 
Kotlin.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] j3k0 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

[GitBox]

j3k0 commented on issue #540: Issue to copy library from plugin after updating 
to v7.1.2
URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437942669
 
 
   > I think we will need another unit test to check installation of `.aidl` 
for cordova-plugin-purchase.
   
   Yes, we had to put an [ugly 
hack](https://github.com/j3k0/cordova-plugin-purchase/blob/master/scripts/androidBeforeInstall.js)
 in place to have installation/uninstallation work in all cases.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #542: [WIP] Resolve GH-539 & GH-540 on master

[GitBox]

brodybits commented on issue #542: [WIP] Resolve GH-539 & GH-540 on master
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437942538
 
 
   Thanks @dpogue. The plugins you listed seem to use `.so` files, for which I 
recall that the installation location is not the same between cordova-android@6 
and cordova-android@7.
   
   I think that any plugins that did work on 7.1.1 but not 7.1.2 should be 
added to #540, along with reproduction steps. I think any plugins that have 
never worked on cordova-android@7 (and not fixed by 7.1.2 update) should be 
listed in a new issue, along with reproduction steps.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #507: Gradle updates

[GitBox]

brodybits commented on a change in pull request #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#discussion_r232748408
 
 

 ##
 File path: bin/templates/project/app/build.gradle
 ##
 @@ -22,33 +22,32 @@ apply plugin: 'com.android.application'
 buildscript {
 repositories {
 mavenCentral()
-maven {
-url "https://maven.google.com;
-}
+google()
 jcenter()
 }
 
 dependencies {
-classpath 'com.android.tools.build:gradle:3.1.0'
+classpath 'com.android.tools.build:gradle:3.2.0'
 }
 }
 
 // Allow plugins to declare Maven dependencies via build-extras.gradle.
 allprojects {
 repositories {
-mavenCentral();
+mavenCentral()
 jcenter()
 }
 }
 
 task wrapper(type: Wrapper) {
-gradleVersion = '4.4.0'
+gradleVersion = '4.6.0'
 }
 
 // Configuration properties. Set these via environment variables, 
build-extras.gradle, or gradle.properties.
 // Refer to: 
http://www.gradle.org/docs/current/userguide/tutorial_this_and_that.html
 ext {
 apply from: '../CordovaLib/cordova.gradle'
+
 // The value for android.compileSdkVersion.
 if (!project.hasProperty('cdvCompileSdkVersion')) {
 cdvCompileSdkVersion = null;
 
 Review comment:
   Remove semicolon here (as proposed in PR #441)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #507: Gradle updates

[GitBox]

janpio commented on a change in pull request #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#discussion_r232750039
 
 

 ##
 File path: bin/templates/project/app/build.gradle
 ##
 @@ -22,33 +22,32 @@ apply plugin: 'com.android.application'
 buildscript {
 repositories {
 mavenCentral()
-maven {
-url "https://maven.google.com;
-}
+google()
 jcenter()
 }
 
 dependencies {
-classpath 'com.android.tools.build:gradle:3.1.0'
+classpath 'com.android.tools.build:gradle:3.2.0'
 }
 }
 
 // Allow plugins to declare Maven dependencies via build-extras.gradle.
 allprojects {
 repositories {
-mavenCentral();
+mavenCentral()
 
 Review comment:
   What has #441 to do with this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #507: Gradle updates

[GitBox]

brodybits commented on issue #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#issuecomment-437966890
 
 
   I raised a few comments based on PR #441. Should we address these?
   
   Is this ready to be merged?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #542: [WIP] Resolve GH-539 & GH-540 on master

[GitBox]

jcesarmobile commented on issue #542: [WIP] Resolve GH-539 & GH-540 on master
URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437976956
 
 
   All the plugin examples linked by @dpogue have .jar source-files except for 
the last one.
   
   They also happen to have .so files, not sure how we should handle them, I 
think proper folder is `app/src/main/jniLibs`, but most of those plugins were 
just putting it in libs folder, so should be `app/libs`.
   
   I think we should fix .jar and .aar for now in a separate PR and investigate 
the .so


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

brodybits opened a new issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547
 
 
   From 
 & 
:
   
   Some old plugins with non-Java source-file entries still do not seem to work 
since version 7.0.0. Some examples from 
:
   * https://github.com/dylearning/cordova-plugin-hikvisionVedio
   * https://github.com/wyne1986/cordova-plugin-sip-fjh
   * https://github.com/mul1sh/corewise-plugin-fingerprintauth
   * https://github.com/ispikit/ispikit-cordova
   * cordova-sqlite-storage@2.1.5 (not an issue with newer versions of 
cordova-sqlite-storage)
   
   Example file types to deal with here:
   * `.jar` - generally has target-dir="lib" in old plugins
   * `.aar` - also generally has target-dir="lib" in old plugins
   * `.so` - generally has a "lib" subdirectory in old plugins
   
   Purpose is that a massive number of plugins should be able to just work on 
both old and new Android project structure.
   
   Possibly related: issues with `cordova-plugin-purchase` (#546).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

brodybits commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438018889
 
 
   Reproduction steps in :
   * `cordova plugin add cordova-sqlite-storage@2.1.5`
   * `cordova platform add android@7.1.2`
   * `cordova build android`
   
   Then I get errors such as:
   - 
`/Users/brodybits/Documents/cordova/cordova-sqlite-test-app/platforms/android/app/src/main/java/io/sqlc/SQLiteConnectorDatabase.java:29:
 error: package io.liteglue does not exist`
   - 
`/Users/brodybits/Documents/cordova/cordova-sqlite-test-app/platforms/android/app/src/main/java/io/sqlc/SQLiteConnectorDatabase.java:41:
 error: cannot find symbol`
   
   It worked when I did `cordova plugin add cordova-sqlite-storage@2.1.5` and 
`cordova platform add android@6`.
   
   Note that newer versions of cordova-sqlite-storage do not show this issue. 
My solution was to use `lib-file` with JARs. But countless other plugins are 
likely affected by this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

brodybits edited a comment on issue #547: Compatibility of old plugins with 
non-Java source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438018889
 
 
   Reproduction steps in :
   * `cordova plugin add cordova-sqlite-storage@2.1.5`
   * `cordova platform add android@7.1.2`
   * `cordova build android`
   
   Then I get errors such as:
   - 
`/Users/brodybits/Documents/cordova/cordova-sqlite-test-app/platforms/android/app/src/main/java/io/sqlc/SQLiteConnectorDatabase.java:29:
 error: package io.liteglue does not exist`
   - 
`/Users/brodybits/Documents/cordova/cordova-sqlite-test-app/platforms/android/app/src/main/java/io/sqlc/SQLiteConnectorDatabase.java:41:
 error: cannot find symbol`
   
   It worked when I did `cordova plugin add cordova-sqlite-storage@2.1.5` and 
`cordova platform add android@6`.
   
   Note that newer versions of cordova-sqlite-storage do not show this issue. 
My solution was to use `lib-file` with JARs. But countless other plugins are 
likely affected by this issue.
   
   P.S. The following reproduction steps lead to the same result on the master 
branch of cordova-android (this project):
   * `cordova plugin add cordova-sqlite-storage@2.1.5`
   * `cordova platform add https://github.com/apache/cordova-android`
   * `cordova build android`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue commented on issue #461: fix issue #458

[GitBox]

dpogue commented on issue #461: fix issue #458
URL: https://github.com/apache/cordova-ios/pull/461#issuecomment-437942804
 
 
   Just a note that the test failures are coming from [these 
tests](https://github.com/apache/cordova-ios/blob/master/tests/spec/unit/lib/list-devices.spec.js#L31-L33)
 that are checking to see if a command matching `/system_profiler/` was 
invoked. You can update those to check for `/ioreg/` and they should pass.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] j3k0 edited a comment on issue #540: Issue to copy library from plugin after updating to v7.1.2

[GitBox]

j3k0 edited a comment on issue #540: Issue to copy library from plugin after 
updating to v7.1.2
URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437942669
 
 
   > I think we will need another unit test to check installation of `.aidl` 
for cordova-plugin-purchase.
   
   Yes, we had to put an [ugly 
hack](https://github.com/j3k0/cordova-plugin-purchase/blob/master/scripts/androidBeforeInstall.js#L21-L25)
 in place to have installation/uninstallation work in all cases.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] j3k0 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

[GitBox]

j3k0 commented on issue #540: Issue to copy library from plugin after updating 
to v7.1.2
URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437950138
 
 
   > I wish you had reported it to us
   
   I didn't as I as thought I was doing something wrong and ended up finding 
workarounds.
   
   I have no problems reporting all sorts of installation issues we encounter 
if it's helpful to you... and if it's ok when I end up being the one that 
screwed up.
   
   Looking forward for the fix!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

[GitBox]

brodybits commented on a change in pull request #441: CB-14089: (android) Add 
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r232747948
 
 

 ##
 File path: bin/templates/project/app/build.gradle
 ##
 @@ -30,13 +34,16 @@ buildscript {
 
 dependencies {
 classpath 'com.android.tools.build:gradle:3.1.0'
+if (cdvHelpers.getConfigPreference('EnableKotlin', 
'false').toBoolean()) {
+classpath 
"org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+}
 }
 }
 
 // Allow plugins to declare Maven dependencies via build-extras.gradle.
 allprojects {
 repositories {
-mavenCentral();
+mavenCentral()
 
 Review comment:
   I think this should be proposed in a separate PR (this may be done in PR 
#507).
   
   Also I think removing semicolons should be proposed in a separate PR. (EDIT: 
already proposed in PR #507)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #507: Gradle updates

[GitBox]

brodybits commented on issue #507: Gradle updates
URL: https://github.com/apache/cordova-android/pull/507#issuecomment-437968642
 
 
   Or should some of the suggestions be considered in yet another PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] mpotter-modus commented on issue #34: lock on iOS does not work right after device ready event

[GitBox]

mpotter-modus commented on issue #34: lock on iOS does not work right after 
device ready event 
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/issues/34#issuecomment-437974228
 
 
   @jcesarmobile could we get a new release please so the changes can be pulled 
from the NPM repo?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org