[GitHub] janpio commented on issue #356: documenting the custom schemes handling

janpio commented on issue #356: documenting the custom schemes handling URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/356#issuecomment-442093692 Thanks @boynet, seems like a reasonable thing to do. Where would you put those in the README/documentation? Feel free to

[GitHub] brodybits opened a new pull request #72: npm test fixes

brodybits opened a new pull request #72: npm test fixes URL: https://github.com/apache/cordova-osx/pull/72 * add test:objc to npm test script * test:coverage separated from npm test script to npm cover script * separate npm run cover step in .travis.yml (more consistent with

[GitHub] gandhirajan commented on issue #159: mobile-spec project creation fails with error "Cannot find module 'cordova-common'"

gandhirajan commented on issue #159: mobile-spec project creation fails with error "Cannot find module 'cordova-common'" URL: https://github.com/apache/cordova-mobile-spec/issues/159#issuecomment-442135183 @janpio I just checked out all the repos to a root folder using coho repo update.

[GitHub] brodybits opened a new pull request #74: Fix Travis CI on 4.0.x branch

brodybits opened a new pull request #74: Fix Travis CI on 4.0.x branch URL: https://github.com/apache/cordova-osx/pull/74 Combination of changes needed for Travis CI to pass on 4.0.x branch needed before we enable Travis CI (#71)

[cordova-osx] branch master updated: npm test fixes (#72)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-osx.git The following commit(s) were added to refs/heads/master by this push: new 5a5887f npm test fixes (#72) 5a5887f

[GitHub] janpio opened a new pull request #69: remove outdated translations of README

janpio opened a new pull request #69: remove outdated translations of README URL: https://github.com/apache/cordova-plugin-vibration/pull/69 remove 4 year old outdated translations This is an automated message from the Apache

[GitHub] boynet opened a new issue #356: documenting the custom schemes handling

boynet opened a new issue #356: documenting the custom schemes handling URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/356 I am not native english so I cant create a pr for this, but we need to documente the lastest changes in custom schemes handling

[GitHub] alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442102839 Thanks a lot @janpio . Yes sure, with great pleasure. Will let you guys know whatever

[cordova-plugin-vibration] branch janpio-remove_translations created (now eb7cc63)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-remove_translations in repository https://gitbox.apache.org/repos/asf/cordova-plugin-vibration.git. at eb7cc63 remove outdated translations of README This branch includes the

[cordova-plugin-vibration] 01/01: remove outdated translations of README

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-remove_translations in repository https://gitbox.apache.org/repos/asf/cordova-plugin-vibration.git commit eb7cc6357880a7c0162660a319d4ba0780138f72 Author: Jan Piotrowski AuthorDate: Tue

[cordova-plugin-vibration] branch janpio-remove_translations updated (eb7cc63 -> c97e0f6)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-remove_translations in repository https://gitbox.apache.org/repos/asf/cordova-plugin-vibration.git. discard eb7cc63 remove outdated translations of README add 46d7db8

[GitHub] alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442089059 Technically it could be it I presume. However that is something completely related to

[GitHub] brodybits closed pull request #72: npm test fixes

brodybits closed pull request #72: npm test fixes URL: https://github.com/apache/cordova-osx/pull/72 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] dpogue commented on issue #588: 7.1.4 defaults to android-27

dpogue commented on issue #588: 7.1.4 defaults to android-27 URL: https://github.com/apache/cordova-android/issues/588#issuecomment-442117295 I'll just note here that Cordova-Android 7.x is not compatible with the Android API 28 build tools, so you might run into issues trying to target

[GitHub] brodybits opened a new pull request #73: More verbose test reporter

brodybits opened a new pull request #73: More verbose test reporter URL: https://github.com/apache/cordova-osx/pull/73 thanks to @raphinesse () Travis CI passes for these changes in my own fork

[GitHub] janpio commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

janpio commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442093094 Yep, that's where I am out: I never understood that gradle dependency version stuff, sorry.

[GitHub] janpio opened a new issue #70: No automated tests

janpio opened a new issue #70: No automated tests URL: https://github.com/apache/cordova-plugin-vibration/issues/70 The tests in `tests/tests.js` are all manual tests, on CI _nothing_ is executed as a result. This is an

[GitHub] brodybits opened a new issue #211: Remove deprecated repos from repo-update

brodybits opened a new issue #211: Remove deprecated repos from repo-update URL: https://github.com/apache/cordova-coho/issues/211 For example: remove references to `amazon-fireos`, `bada`, `blackberry`, `ubuntu`, `firefoxos`, `qt`, `tizen`, `webos`, `wp8` platforms from sources such as:

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236807686 ## File path: createmobilespec/createmobilespec.js ## @@ -71,7 +71,12 @@ function

[GitHub] brodybits commented on issue #172: mac osx platform cleanup

brodybits commented on issue #172: mac osx platform cleanup URL: https://github.com/apache/cordova-mobile-spec/pull/172#issuecomment-442190060 from review of PR #153 This is an automated message from the Apache Git Service.

[GitHub] brodybits opened a new pull request #172: mac osx platform cleanup

brodybits opened a new pull request #172: mac osx platform cleanup URL: https://github.com/apache/cordova-mobile-spec/pull/172 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] boynet commented on issue #263: CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth

boynet commented on issue #263: CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/263#issuecomment-442143355 I started testing it and I ran into bug, the event only working on the first time so a

[GitHub] janpio commented on issue #263: CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth

janpio commented on issue #263: CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/263#issuecomment-442148534 Can you please create a new issue @boynet? This will be forgotten here, just link to

[cordova-paramedic] 03/04: more steps of what it does

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-readme in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git commit 2c951dfc2587f2e1015e96328576a2fb465f1093 Author: Jan Piotrowski AuthorDate: Tue Nov 27 19:01:42 2018

[cordova-paramedic] 01/04: Improve readme (WIP)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-readme in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git commit 0be186698ec34fe4054d908f7f0b6bfc56498e01 Author: Jan Piotrowski AuthorDate: Sat Nov 24 18:37:22 2018

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236811746 ## File path: createmobilespec/createmobilespec.js ## @@ -153,11 +158,11 @@ var top_dir =

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236812441 ## File path: createmobilespec/createmobilespec.js ## @@ -227,6 +232,7 @@ var

[GitHub] brodybits commented on issue #73: [WIP] More verbose test reporter

brodybits commented on issue #73: [WIP] More verbose test reporter URL: https://github.com/apache/cordova-osx/pull/73#issuecomment-442141609 Marked [WIP] pending rebase on master, with Travis CI enabled (#71). I would like to wait until Travis CI is enabled before rebasing to get a

[GitHub] janpio closed pull request #148: remove deprecated platforms

janpio closed pull request #148: remove deprecated platforms URL: https://github.com/apache/cordova-mobile-spec/pull/148 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236806921 ## File path: createmobilespec/createmobilespec.js ## @@ -489,31 +495,32 @@ if

[GitHub] brodybits commented on issue #171: Cleanup third-party plugins

brodybits commented on issue #171: Cleanup third-party plugins URL: https://github.com/apache/cordova-mobile-spec/issues/171#issuecomment-442190171 from review of #153 This is an automated message from the Apache Git

[cordova-mobile-spec] branch janpio-remove_deprecated deleted (was 4b32bc0)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-remove_deprecated in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git. was 4b32bc0 remove deprecated platforms The revisions that were on this branch are

[cordova-mobile-spec] branch master updated (e4b0a23 -> 8f8304f)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git. from e4b0a23 known quirks in createmobilespec/README.md (#147) add 8f8304f remove deprecated

[GitHub] brodybits closed pull request #74: Fix Travis CI on 4.0.x branch

brodybits closed pull request #74: Fix Travis CI on 4.0.x branch URL: https://github.com/apache/cordova-osx/pull/74 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[cordova-osx] branch 4.0.x updated: .travis.yml fixes for 4.0.x branch (#74)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch 4.0.x in repository https://gitbox.apache.org/repos/asf/cordova-osx.git The following commit(s) were added to refs/heads/4.0.x by this push: new b967c2a .travis.yml fixes for 4.0.x

[cordova-paramedic] 04/04: better docs for externalServerUrl

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-readme in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git commit 5e2d055c6fef39fc788d0fd43c3d5c255d88a271 Author: Jan Piotrowski AuthorDate: Tue Nov 27 19:01:54 2018

[cordova-paramedic] branch janpio-readme created (now 5e2d055)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-readme in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git. at 5e2d055 better docs for externalServerUrl This branch includes the following new commits:

[cordova-paramedic] 02/04: better intro

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-readme in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git commit 51cef2babf327b6f7d06dda29892186e46d274ee Author: Jan Piotrowski AuthorDate: Tue Nov 27 19:01:31 2018

[GitHub] brodybits commented on issue #71: Set up CI

brodybits commented on issue #71: Set up CI URL: https://github.com/apache/cordova-osx/issues/71#issuecomment-442144059 Once #74 is reviewed and merged this should become an INFRA request. This is an automated message from

[GitHub] janpio commented on issue #159: mobile-spec project creation fails with error "Cannot find module 'cordova-common'"

janpio commented on issue #159: mobile-spec project creation fails with error "Cannot find module 'cordova-common'" URL: https://github.com/apache/cordova-mobile-spec/issues/159#issuecomment-442147152 Please install a new node version (to make sure there are not more global tools

[cordova-paramedic] 05/05: gitignore package-lock.json

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-misc in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git commit 9a617d6add19ecaf5d2bebedfe5295323c1e7ffb Author: Jan Piotrowski AuthorDate: Tue Nov 27 19:08:28 2018

[cordova-paramedic] 01/05: 0.6.0-dev

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-misc in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git commit 1e699a4a2cfc44c844be13cd68febd7681831a06 Author: Jan Piotrowski AuthorDate: Tue Nov 27 19:07:29 2018

[cordova-paramedic] 04/05: output where logfiles are written to

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-misc in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git commit aea5e1ef53f851106f8194669ecd36d7bef92b0d Author: Jan Piotrowski AuthorDate: Tue Nov 27 19:07:58 2018

[cordova-paramedic] 02/05: fix license

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-misc in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git commit 0baf75db31adb8639540a14f9576807f095b8be7 Author: Jan Piotrowski AuthorDate: Tue Nov 27 19:07:38 2018

[cordova-paramedic] 03/05: replace author

This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-misc in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git commit 3819786acbc8b63a02dd1811f31073dbad814ddc Author: Jan Piotrowski AuthorDate: Tue Nov 27 19:07:45 2018

[cordova-paramedic] branch janpio-misc updated (8efb65d -> 9a617d6)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-misc in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git. from 8efb65d some comments what the script is doing new 1e699a4 0.6.0-dev new 0baf75d fix

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236810474 ## File path: createmobilespec/createmobilespec.js ## @@ -130,7 +135,7 @@ var top_dir =

[GitHub] brodybits opened a new issue #171: Cleanup third-party plugins

brodybits opened a new issue #171: Cleanup third-party plugins URL: https://github.com/apache/cordova-mobile-spec/issues/171 in Some things I

[GitHub] michaelpeterlee removed a comment on issue #275: iOS > Remove > Code 5

michaelpeterlee removed a comment on issue #275: iOS > Remove > Code 5 URL: https://github.com/apache/cordova-plugin-file/issues/275#issuecomment-441875853 Code review likely mutations in this Cordova project and not a fault with cordova-plugin-file. Will confirm tomorrow. :)

[cordova-mobile-spec] branch janpio-improve_script updated (34b84ed -> 6ae7706)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-improve_script in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git. from 34b84ed Update createmobilespec/createmobilespec.js add 6ae7706 Update

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236820695 ## File path: createmobilespec/createmobilespec.js ## @@ -303,7 +309,7 @@ var cli =

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236824165 ## File path: createmobilespec/createmobilespec.js ## @@ -489,31 +495,32 @@ if

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236824165 ## File path: createmobilespec/createmobilespec.js ## @@ -489,31 +495,32 @@ if

[GitHub] brodybits commented on issue #152: fix location of key and build-extra.gradle for cordova-anroid 7.x

brodybits commented on issue #152: fix location of key and build-extra.gradle for cordova-anroid 7.x URL: https://github.com/apache/cordova-mobile-spec/pull/152#issuecomment-442195948 Looks good, I would like to test it.

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236825443 ## File path: createmobilespec/createmobilespec.js ## @@ -404,7 +410,7 @@ function

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236829175 ## File path: createmobilespec/createmobilespec.js ## @@ -153,11 +158,11 @@ var top_dir =

[GitHub] nprail commented on issue #448: CB-13685 android: Adaptive Icon Support

nprail commented on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-442208713 Has this been released yet? If not, when will it be? This is an automated

[GitHub] dpogue commented on issue #448: CB-13685 android: Adaptive Icon Support

dpogue commented on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-442213195 It is not released yet, it will be included in the next major version. We can't/won't commit to any particular timeline for that next

[cordova-mobile-spec] branch janpio-improve_script updated (3e30f76 -> 34597ab)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-improve_script in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git. from 3e30f76 better console.log add 34597ab Update

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236858889 ## File path: createmobilespec/createmobilespec.js ## @@ -130,7 +135,7 @@ var top_dir =

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236860505 ## File path: createmobilespec/createmobilespec.js ## @@ -130,7 +135,7 @@ var top_dir =

[cordova-mobile-spec] branch janpio-improve_script updated (62ac397 -> 34b84ed)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-improve_script in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git. from 62ac397 Update createmobilespec/createmobilespec.js add 34b84ed Update

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236828277 ## File path: createmobilespec/createmobilespec.js ## @@ -424,7 +430,7 @@ if

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236827965 ## File path: createmobilespec/createmobilespec.js ## @@ -413,7 +419,7 @@ function

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236861655 ## File path: createmobilespec/createmobilespec.js ## @@ -303,7 +309,7 @@ var cli =

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236861860 ## File path: createmobilespec/createmobilespec.js ## @@ -404,7 +410,7 @@ function

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236862725 ## File path: createmobilespec/createmobilespec.js ## @@ -130,7 +135,7 @@ var top_dir =

[GitHub] brodybits opened a new pull request #173: [WIP] Remove browserify flag support - NOT TESTED

brodybits opened a new pull request #173: [WIP] Remove browserify flag support - NOT TESTED URL: https://github.com/apache/cordova-mobile-spec/pull/173 Chore to resolve a TODO in PR #153. - [ ] Will be tested when I test some other proposed changes /cc @janpio

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236857654 ## File path: createmobilespec/createmobilespec.js ## @@ -489,31 +495,32 @@ if (argv.plugman)

[cordova-mobile-spec] branch janpio-improve_script updated (34597ab -> 62ac397)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-improve_script in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git. from 34597ab Update createmobilespec/createmobilespec.js add 62ac397 Update

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236860234 ## File path: createmobilespec/createmobilespec.js ## @@ -71,7 +71,12 @@ function

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236862465 ## File path: createmobilespec/createmobilespec.js ## @@ -424,7 +430,7 @@ if (!argv.skiplink)

[cordova-mobile-spec] branch janpio-improve_script updated (6ae7706 -> 80775ea)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch janpio-improve_script in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git. from 6ae7706 Update createmobilespec/createmobilespec.js add 80775ea Update

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236862725 ## File path: createmobilespec/createmobilespec.js ## @@ -130,7 +135,7 @@ var top_dir =

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236861171 ## File path: createmobilespec/createmobilespec.js ## @@ -153,11 +158,11 @@ var top_dir =

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236861324 ## File path: createmobilespec/createmobilespec.js ## @@ -227,6 +232,7 @@ var DEFAULT_PLUGINS

[GitHub] janpio commented on issue #172: mac osx platform cleanup

janpio commented on issue #172: mac osx platform cleanup URL: https://github.com/apache/cordova-mobile-spec/pull/172#issuecomment-442235269 The platform is called [`osx`](https://github.com/apache/cordova-osx), to which most of the messages refer, so this should probably be the "main"

[GitHub] brodybits closed pull request #177: .gitignore add .*.swp

brodybits closed pull request #177: .gitignore add .*.swp URL: https://github.com/apache/cordova-mobile-spec/pull/177 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] brodybits commented on issue #177: .gitignore add .*.swp

brodybits commented on issue #177: .gitignore add .*.swp URL: https://github.com/apache/cordova-mobile-spec/pull/177#issuecomment-442254027 > Can't you disable theses swap files on your system or add the to your local, global .gitignore? Sure:

[GitHub] michaelpeterlee commented on issue #275: iOS > Remove > Code 5

michaelpeterlee commented on issue #275: iOS > Remove > Code 5 URL: https://github.com/apache/cordova-plugin-file/issues/275#issuecomment-442240011 Problem also affects Android, so likely our implementation at this stage. Will update status in a few days when we resume this project.

[GitHub] brodybits opened a new pull request #178: Tip to delete existing mobilespec if it exists

brodybits opened a new pull request #178: Tip to delete existing mobilespec if it exists URL: https://github.com/apache/cordova-mobile-spec/pull/178 before running `createmobilespec.js` (this seems to help me avoid the quirks I documented before) Note that this proposal is

[cordova-mobile-spec] branch brodybits-delete-existing-mobilespec-tip updated (c6a3a5c -> 982665c)

This is an automated email from the ASF dual-hosted git repository. janpio pushed a change to branch brodybits-delete-existing-mobilespec-tip in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git. from c6a3a5c Tip to delete existing mobilespec if it exists add

[GitHub] brodybits commented on issue #172: [WIP] mac osx platform cleanup

brodybits commented on issue #172: [WIP] mac osx platform cleanup URL: https://github.com/apache/cordova-mobile-spec/pull/172#issuecomment-442237241 > The platform is called [`osx`](https://github.com/apache/cordova-osx), to which most of the messages refer, so this should probably be the

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js URL: https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236871437 ## File path: createmobilespec/createmobilespec.js ## @@ -71,7 +71,12 @@ function

[GitHub] janpio commented on issue #171: Cleanup or remove testing with third-party plugins

janpio commented on issue #171: Cleanup or remove testing with third-party plugins URL: https://github.com/apache/cordova-mobile-spec/issues/171#issuecomment-442245335 Seems I did the research in parallel - replied with what I found on the thread ;)

[GitHub] brodybits opened a new pull request #177: .gitignore add .*.swp

brodybits opened a new pull request #177: .gitignore add .*.swp URL: https://github.com/apache/cordova-mobile-spec/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on

[cordova-mobile-spec] 01/01: Tip to delete existing mobilespec if it exists

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch brodybits-delete-existing-mobilespec-tip in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git commit c6a3a5c7c9d58b5a94558ab0b2300f401a91c1dc Author: Chris Brody

[cordova-mobile-spec] branch brodybits-delete-existing-mobilespec-tip created (now c6a3a5c)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-delete-existing-mobilespec-tip in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git. at c6a3a5c Tip to delete existing mobilespec if it exists This

[GitHub] erisu commented on a change in pull request #72: npm test fixes

erisu commented on a change in pull request #72: npm test fixes URL: https://github.com/apache/cordova-osx/pull/72#discussion_r236897148 ## File path: .travis.yml ## @@ -19,3 +19,4 @@ script: - node --version - npm --version - npm test Review comment: It

[GitHub] erisu commented on a change in pull request #72: npm test fixes

erisu commented on a change in pull request #72: npm test fixes URL: https://github.com/apache/cordova-osx/pull/72#discussion_r236896369 ## File path: package.json ## @@ -15,7 +15,8 @@ "cordova:platform" ], "scripts": { -"test": "npm run eslint && npm run

[GitHub] brodybits commented on a change in pull request #72: npm test fixes

brodybits commented on a change in pull request #72: npm test fixes URL: https://github.com/apache/cordova-osx/pull/72#discussion_r236900752 ## File path: .travis.yml ## @@ -19,3 +19,4 @@ script: - node --version - npm --version - npm test Review comment:

[GitHub] janpio commented on issue #171: Cleanup third-party plugins

janpio commented on issue #171: Cleanup third-party plugins URL: https://github.com/apache/cordova-mobile-spec/issues/171#issuecomment-442233543 Afaik the Telerik Plugin registry also is no more. What is/was plugreg? The general concept of being able to test 3rd party plugins is

[GitHub] brodybits commented on issue #171: Cleanup or remove testing with third-party plugins

brodybits commented on issue #171: Cleanup or remove testing with third-party plugins URL: https://github.com/apache/cordova-mobile-spec/issues/171#issuecomment-442240275 > What is/was plugreg? I think plugreg was a registry made 5-7 years ago, before PhoneGap Build was available

[GitHub] brodybits opened a new issue #176: Check that all Cordova-maintained plugins are in DEFAULT_PLUGINS list

brodybits opened a new issue #176: Check that all Cordova-maintained plugins are in DEFAULT_PLUGINS list URL: https://github.com/apache/cordova-mobile-spec/issues/176 in

[GitHub] brodybits commented on issue #171: Cleanup or remove testing with third-party plugins

brodybits commented on issue #171: Cleanup or remove testing with third-party plugins URL: https://github.com/apache/cordova-mobile-spec/issues/171#issuecomment-442248640 > > What is/was plugreg? > > I think plugreg was a registry made 5-7 years ago, before PhoneGap Build was

[GitHub] janpio commented on issue #177: .gitignore add .*.swp

janpio commented on issue #177: .gitignore add .*.swp URL: https://github.com/apache/cordova-mobile-spec/pull/177#issuecomment-442252583 Can't you disable theses swap files on your system or add the to your local, global .gitignore? Those are not really that common so all devs need this,

[GitHub] janpio commented on issue #178: Tip to delete existing mobilespec if it exists

janpio commented on issue #178: Tip to delete existing mobilespec if it exists URL: https://github.com/apache/cordova-mobile-spec/pull/178#issuecomment-442267901 Hm, I changed the merge target to my PR branch so this is less complicated - but seems it added another commit here, thanks

[GitHub] janpio commented on a change in pull request #178: Tip to delete existing mobilespec if it exists

janpio commented on a change in pull request #178: Tip to delete existing mobilespec if it exists URL: https://github.com/apache/cordova-mobile-spec/pull/178#discussion_r236901856 ## File path: createmobilespec/README.md ## @@ -78,6 +78,9 @@ If anything is going wrong

[cordova-mobile-spec] branch brodybits-delete-existing-mobilespec-tip updated (982665c -> 455dada)

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a change to branch brodybits-delete-existing-mobilespec-tip in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git. omit 982665c Merge branch 'janpio-cleanup_readmes' into

[GitHub] brodybits commented on a change in pull request #178: Tip to delete existing mobilespec if it exists

brodybits commented on a change in pull request #178: Tip to delete existing mobilespec if it exists URL: https://github.com/apache/cordova-mobile-spec/pull/178#discussion_r236903925 ## File path: createmobilespec/README.md ## @@ -78,6 +78,9 @@ If anything is going wrong

  1   2   >