[GitHub] janpio closed pull request #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

janpio closed pull request #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-CB-13834 updated: VSINSTALLDIR as proper env var

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-CB-13834
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to refs/heads/janpio-CB-13834 by this push:
 new 0a0cfe2  VSINSTALLDIR as proper env var
0a0cfe2 is described below

commit 0a0cfe23945ac1809c56b218c919ba66b492d226
Author: Jan Piotrowski 
AuthorDate: Wed Feb 14 01:01:42 2018 +0100

VSINSTALLDIR as proper env var
---
 appveyor.yml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/appveyor.yml b/appveyor.yml
index c3b44f9..6a58ab2 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -23,11 +23,10 @@ image:
 - Visual Studio 2015
 - Visual Studio 2017
 environment:
+  VSINSTALLDIR: "C:\\Program Files (x86)\\Microsoft Visual 
Studio\\2017\\Community"
   matrix:
 - nodejs_version: "4"
 - nodejs_version: "6"
-- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
-  VSINSTALLDIR: "C:\\Program Files (x86)\\Microsoft Visual 
Studio\\2017\\Community"
 
 install:
   - ps: Install-Product node $env:nodejs_version

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365446627
 
 
   #254 is now in a state to be tested and reviewed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

[GitBox]

janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be 
called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#issuecomment-365446432
 
 
   Fixed by making sure the `index.html` is present (by copying from a folder 
where it exists).
   
   This is now as good as `master` but works with any Windows 10 SDK installed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: add legacy

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-more_env_info_on_appveyor
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to 
refs/heads/janpio-more_env_info_on_appveyor by this push:
 new 871f52b  add legacy
871f52b is described below

commit 871f52b438424975002246cfb7493eef44c328ff
Author: Jan Piotrowski 
AuthorDate: Wed Feb 14 00:33:36 2018 +0100

add legacy
---
 appveyor.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/appveyor.yml b/appveyor.yml
index 5eff4f9..b073562 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -40,4 +40,5 @@ test_script:
   - where msbuild
   - "\"%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere\" 
-property installationPath -products * -all"
   - "\"%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere\" 
-property installationPath -all"
+  - "\"%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere\" 
-property installationPath -legacy"
   - npm test
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-prepare_script_in_e2e updated: fix www source folder

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-prepare_script_in_e2e
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to refs/heads/janpio-prepare_script_in_e2e 
by this push:
 new f3f5dad  fix www source folder
f3f5dad is described below

commit f3f5dadcb2356269becae3dfcbaa26f07cd0bfb1
Author: Jan Piotrowski 
AuthorDate: Wed Feb 14 00:03:13 2018 +0100

fix www source folder
---
 template/cordova/prepare | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/template/cordova/prepare b/template/cordova/prepare
index e18b975..e919b77 100644
--- a/template/cordova/prepare
+++ b/template/cordova/prepare
@@ -50,7 +50,7 @@ var project = {
 projectConfig: new ConfigParser(path.join(projectRoot, 'config.xml')),
 locations: {
 plugins: path.join(projectRoot, 'plugins'),
-www: path.join(projectRoot, 'platform_www')
+www: path.join(projectRoot, 'www')
 }
 };
 

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: add where

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-more_env_info_on_appveyor
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to 
refs/heads/janpio-more_env_info_on_appveyor by this push:
 new 815c381  add where
815c381 is described below

commit 815c3819ff5a2bab991c84af62845f34d6c9e57e
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 23:47:19 2018 +0100

add where
---
 appveyor.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/appveyor.yml b/appveyor.yml
index 290af11..5eff4f9 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -37,6 +37,7 @@ test_script:
   - node --version
   - npm --version
   - msbuild -version -nologo
+  - where msbuild
   - "\"%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere\" 
-property installationPath -products * -all"
   - "\"%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere\" 
-property installationPath -all"
   - npm test
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-prepare_script_in_e2e updated: less minimal

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-prepare_script_in_e2e
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to refs/heads/janpio-prepare_script_in_e2e 
by this push:
 new 4b53029  less minimal
4b53029 is described below

commit 4b53029acc8e84e37d7e6252af9bed2b646ca4a6
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 23:34:35 2018 +0100

less minimal
---
 template/config.xml | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/template/config.xml b/template/config.xml
index b496797..c8b4a2c 100644
--- a/template/config.xml
+++ b/template/config.xml
@@ -21,4 +21,10 @@
 -->
 http://www.w3.org/ns/widgets; 
xmlns:cdv="http://cordova.apache.org/ns/1.0;>
HelloCordova
+
+A sample Apache Cordova application that responds to the deviceready 
event.
+
+http://cordova.io;>
+Apache Cordova Team
+
 

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-CB-13834 updated: escape

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-CB-13834
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to refs/heads/janpio-CB-13834 by this push:
 new 2a47b6b  escape
2a47b6b is described below

commit 2a47b6b71e77874097511e585fcaa5effdd8c2a3
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 22:52:10 2018 +0100

escape
---
 appveyor.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/appveyor.yml b/appveyor.yml
index e3fd258..c3b44f9 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -27,7 +27,7 @@ environment:
 - nodejs_version: "4"
 - nodejs_version: "6"
 - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
-  VSINSTALLDIR: "C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community"
+  VSINSTALLDIR: "C:\\Program Files (x86)\\Microsoft Visual 
Studio\\2017\\Community"
 
 install:
   - ps: Install-Product node $env:nodejs_version

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-prepare_script_in_e2e updated: minimal config.xml

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-prepare_script_in_e2e
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to refs/heads/janpio-prepare_script_in_e2e 
by this push:
 new 102f637  minimal config.xml
102f637 is described below

commit 102f6376c4a2941dd2feb0fe4bfd4c558e0ed944
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 21:20:27 2018 +0100

minimal config.xml
---
 template/config.xml | 14 --
 1 file changed, 14 deletions(-)

diff --git a/template/config.xml b/template/config.xml
index 4292614..b496797 100644
--- a/template/config.xml
+++ b/template/config.xml
@@ -21,18 +21,4 @@
 -->
 http://www.w3.org/ns/widgets; 
xmlns:cdv="http://cordova.apache.org/ns/1.0;>
HelloCordova
-
-A sample Apache Cordova application that responds to the deviceready 
event.
-
-http://cordova.io;>
-Apache Cordova Team
-
-
-
-http://*/*; />
-https://*/*; />
-
-
-mailto:*; />
-
 

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

[GitBox]

janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be 
called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#issuecomment-365390984
 
 
   The missing `index.html` in the test project is causing issues now:
   
   ```
   EXEC : warning : Start page is missing on the disk. The build must go on but 
note that this will cause WACK failures. 
[C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
   MakeAppx : error : Manifest validation error: Line 26, Column 47, Reason: 
The file name "www\index.html" declared for element 
"m:Applications/m:Application" doesn't exist in the package. 
[C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
   MakeAppx : error : Package creation failed. 
[C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
   MakeAppx : error : 0x80080204 - The specified package format is not valid: 
The package manifest is not valid. 
   ```
   
   Locally I only get the first line, but on CI the MSBuildTools version seems 
to do some additional validation.
   
   Working on a fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

[GitBox]

janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` 
script that can be called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#discussion_r167985739
 
 

 ##
 File path: template/cordova/prepare
 ##
 @@ -0,0 +1,61 @@
+#!/usr/bin/env node
+
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+
+var Api = require('./Api');
+var nopt = require('nopt');
+var path = require('path');
+var ConfigParser = require('cordova-common').ConfigParser;
+
+// Support basic help commands
+if(['--help', '/?', '-h', 'help', '-help', '/help'].indexOf(process.argv[2]) 
>= 0) {
+console.log('Usage: \nprepare\n');
+process.exit(0);
+}
+
+// Do some basic argument parsing
+var opts = nopt({
+'verbose' : Boolean,
+'silent' : Boolean
+}, { 'd' : '--verbose' });
+
+// Make buildOptions compatible with PlatformApi clean method spec
+opts.argv = opts.argv.original;
+
+// Skip cleaning prepared files when not invoking via cordova CLI.
+opts.noPrepare = true;
+
+require('./lib/loggingHelper').adjustLoggerLevel(opts);
+
+var projectRoot = path.join(__dirname, '..');
+var project = {
 
 Review comment:
   this is pretty ugly here, but `prepare` is the only one of the "main" 
commands that takes a `project` as a param so I had to improvise. think the end 
result isn't that bad.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-CB-13817 updated: add missing space

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-CB-13817
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to refs/heads/janpio-CB-13817 by this push:
 new ea28080  add missing space
ea28080 is described below

commit ea28080d47cbf99faf26e12c6e80242a63dfdf4a
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 21:12:23 2018 +0100

add missing space
---
 spec/e2e/endtoend.spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/e2e/endtoend.spec.js b/spec/e2e/endtoend.spec.js
index c80b8ba..34b9a44 100644
--- a/spec/e2e/endtoend.spec.js
+++ b/spec/e2e/endtoend.spec.js
@@ -85,7 +85,7 @@ describe('Cordova create and build', function () {
 
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });
 
-it('spec.2cshould build uwp (win10) project', function () {
+it('spec.2c should build uwp (win10) project', function () {
 shell.exec(buildScriptPath + ' --appx=uwp', {silent: silent});
 
_expectSubdirAndFileExist('CordovaApp.Windows10_1.0.0.0_anycpu_debug_Test', 
'CordovaApp.Windows10_1.0.0.0_anycpu_debug.appx');
 });

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365388649
 
 
   See https://github.com/apache/cordova-windows/pull/254 as a replacement. 
Would be nice if you could check that out and run it locally to see if the 
tests succeed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

[GitBox]

janpio commented on a change in pull request #254: [WIP] CB-13875 add `prepare` 
script that can be called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#discussion_r167985739
 
 

 ##
 File path: template/cordova/prepare
 ##
 @@ -0,0 +1,61 @@
+#!/usr/bin/env node
+
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+
+var Api = require('./Api');
+var nopt = require('nopt');
+var path = require('path');
+var ConfigParser = require('cordova-common').ConfigParser;
+
+// Support basic help commands
+if(['--help', '/?', '-h', 'help', '-help', '/help'].indexOf(process.argv[2]) 
>= 0) {
+console.log('Usage: \nprepare\n');
+process.exit(0);
+}
+
+// Do some basic argument parsing
+var opts = nopt({
+'verbose' : Boolean,
+'silent' : Boolean
+}, { 'd' : '--verbose' });
+
+// Make buildOptions compatible with PlatformApi clean method spec
+opts.argv = opts.argv.original;
+
+// Skip cleaning prepared files when not invoking via cordova CLI.
+opts.noPrepare = true;
+
+require('./lib/loggingHelper').adjustLoggerLevel(opts);
+
+var projectRoot = path.join(__dirname, '..');
+var project = {
 
 Review comment:
   this is pretty ugly here, but `prepare` is the only one of the "main" 
commands that takes a `project` as a param so I had to improvise.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio opened a new pull request #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

[GitBox]

janpio opened a new pull request #254: [WIP] CB-13875 add `prepare` script that 
can be called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254
 
 
   ? to prepare project files
   
   (based on `clean` and some terrible code to build a `project` object)
   also adds default `config.xml` as in other projects
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-prepare_script_in_e2e updated (6dde4eb -> 9100723)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-prepare_script_in_e2e
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git.


 discard 6dde4eb  add `prepare` script that can be called in e2e tests to 
prepare project files (based on `clean` and some terrible code to build a 
`project` object) also adds default `config.xml`
 new 9100723  CB-13875 add `prepare` script that can be called in e2e tests 
to prepare project files (based on `clean` and some terrible code to build a 
`project` object) also adds default `config.xml`

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (6dde4eb)
\
 N -- N -- N   refs/heads/janpio-prepare_script_in_e2e (9100723)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] 01/01: CB-13875 add `prepare` script that can be called in e2e tests to prepare project files (based on `clean` and some terrible code to build a `project` object) also adds default

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-prepare_script_in_e2e
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit 910072309ff06266797f6ea9a4ee8e28feb9685c
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 21:00:31 2018 +0100

CB-13875 add `prepare` script that can be called in e2e tests to prepare 
project files
(based on `clean` and some terrible code to build a `project` object)
also adds default `config.xml`
---
 spec/e2e/endtoend.spec.js|  3 +++
 template/config.xml  | 18 +++--
 template/cordova/prepare | 61 
 template/cordova/prepare.bat | 25 ++
 4 files changed, 105 insertions(+), 2 deletions(-)

diff --git a/spec/e2e/endtoend.spec.js b/spec/e2e/endtoend.spec.js
index a06ebb9..632d7d5 100644
--- a/spec/e2e/endtoend.spec.js
+++ b/spec/e2e/endtoend.spec.js
@@ -34,6 +34,8 @@ describe('Cordova create and build', function () {
 var buildDirectory = path.join(__dirname, '../..');
 var appPackagesFolder = path.join(buildDirectory, projectFolder, 
'AppPackages');
 var buildScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'build') + '"';
+var prepareScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'prepare') + '"';
+
 var silent = false;
 
 function verifySubDirContainsFile (subDirName, fileName, count) {
@@ -60,6 +62,7 @@ describe('Cordova create and build', function () {
 
 beforeEach(function () {
 shell.exec(path.join('bin', 'create') + ' "' + projectFolder + '" 
com.test.app 応用', {silent: silent});
+shell.exec(prepareScriptPath + '', {silent: silent});
 });
 
 afterEach(function () {
diff --git a/template/config.xml b/template/config.xml
index 1850536..4292614 100644
--- a/template/config.xml
+++ b/template/config.xml
@@ -19,6 +19,20 @@
 # under the License.
 #
 -->
-http://www.w3.org/ns/widgets;>
-
+http://www.w3.org/ns/widgets; 
xmlns:cdv="http://cordova.apache.org/ns/1.0;>
+   HelloCordova
+
+A sample Apache Cordova application that responds to the deviceready 
event.
+
+http://cordova.io;>
+Apache Cordova Team
+
+
+
+http://*/*; />
+https://*/*; />
+
+
+mailto:*; />
+
 
diff --git a/template/cordova/prepare b/template/cordova/prepare
new file mode 100644
index 000..e18b975
--- /dev/null
+++ b/template/cordova/prepare
@@ -0,0 +1,61 @@
+#!/usr/bin/env node
+
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+
+var Api = require('./Api');
+var nopt = require('nopt');
+var path = require('path');
+var ConfigParser = require('cordova-common').ConfigParser;
+
+// Support basic help commands
+if(['--help', '/?', '-h', 'help', '-help', '/help'].indexOf(process.argv[2]) 
>= 0) {
+console.log('Usage: \nprepare\n');
+process.exit(0);
+}
+
+// Do some basic argument parsing
+var opts = nopt({
+'verbose' : Boolean,
+'silent' : Boolean
+}, { 'd' : '--verbose' });
+
+// Make buildOptions compatible with PlatformApi clean method spec
+opts.argv = opts.argv.original;
+
+// Skip cleaning prepared files when not invoking via cordova CLI.
+opts.noPrepare = true;
+
+require('./lib/loggingHelper').adjustLoggerLevel(opts);
+
+var projectRoot = path.join(__dirname, '..');
+var project = {
+root: projectRoot,
+projectConfig: new ConfigParser(path.join(projectRoot, 'config.xml')),
+locations: {
+plugins: path.join(projectRoot, 'plugins'),
+www: path.join(projectRoot, 'platform_www')
+}
+};
+
+new Api().prepare(project, opts)
+.catch(function(err) {
+console.error(err.stack);
+process.exit(2);
+});
diff --git a/template/cordova/prepare.bat b/template/cordova/prepare.bat
new file mode 100644
index 000..eb14e74
--- /dev/null
+++ b/template/cordova/prepare.bat
@@ -0,0 +1,25 @@
+:: Licensed to the Apache Software Foundation (ASF) under one
+:: or more contributor license agreements.  See the NOTICE file
+:: distributed with this work for additional information
+:: regarding 

[cordova-windows] 01/01: add `prepare` script that can be called in e2e tests to prepare project files (based on `clean` and some terrible code to build a `project` object) also adds default `config.x

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-prepare_script_in_e2e
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit 6dde4ebeb56d51f0d12fedc854baaed53505c4d5
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 21:00:31 2018 +0100

add `prepare` script that can be called in e2e tests to prepare project 
files
(based on `clean` and some terrible code to build a `project` object)
also adds default `config.xml`
---
 spec/e2e/endtoend.spec.js|  3 +++
 template/config.xml  | 18 +++--
 template/cordova/prepare | 61 
 template/cordova/prepare.bat | 25 ++
 4 files changed, 105 insertions(+), 2 deletions(-)

diff --git a/spec/e2e/endtoend.spec.js b/spec/e2e/endtoend.spec.js
index a06ebb9..632d7d5 100644
--- a/spec/e2e/endtoend.spec.js
+++ b/spec/e2e/endtoend.spec.js
@@ -34,6 +34,8 @@ describe('Cordova create and build', function () {
 var buildDirectory = path.join(__dirname, '../..');
 var appPackagesFolder = path.join(buildDirectory, projectFolder, 
'AppPackages');
 var buildScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'build') + '"';
+var prepareScriptPath = '"' + path.join(buildDirectory, projectFolder, 
'cordova', 'prepare') + '"';
+
 var silent = false;
 
 function verifySubDirContainsFile (subDirName, fileName, count) {
@@ -60,6 +62,7 @@ describe('Cordova create and build', function () {
 
 beforeEach(function () {
 shell.exec(path.join('bin', 'create') + ' "' + projectFolder + '" 
com.test.app 応用', {silent: silent});
+shell.exec(prepareScriptPath + '', {silent: silent});
 });
 
 afterEach(function () {
diff --git a/template/config.xml b/template/config.xml
index 1850536..4292614 100644
--- a/template/config.xml
+++ b/template/config.xml
@@ -19,6 +19,20 @@
 # under the License.
 #
 -->
-http://www.w3.org/ns/widgets;>
-
+http://www.w3.org/ns/widgets; 
xmlns:cdv="http://cordova.apache.org/ns/1.0;>
+   HelloCordova
+
+A sample Apache Cordova application that responds to the deviceready 
event.
+
+http://cordova.io;>
+Apache Cordova Team
+
+
+
+http://*/*; />
+https://*/*; />
+
+
+mailto:*; />
+
 
diff --git a/template/cordova/prepare b/template/cordova/prepare
new file mode 100644
index 000..e18b975
--- /dev/null
+++ b/template/cordova/prepare
@@ -0,0 +1,61 @@
+#!/usr/bin/env node
+
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+
+var Api = require('./Api');
+var nopt = require('nopt');
+var path = require('path');
+var ConfigParser = require('cordova-common').ConfigParser;
+
+// Support basic help commands
+if(['--help', '/?', '-h', 'help', '-help', '/help'].indexOf(process.argv[2]) 
>= 0) {
+console.log('Usage: \nprepare\n');
+process.exit(0);
+}
+
+// Do some basic argument parsing
+var opts = nopt({
+'verbose' : Boolean,
+'silent' : Boolean
+}, { 'd' : '--verbose' });
+
+// Make buildOptions compatible with PlatformApi clean method spec
+opts.argv = opts.argv.original;
+
+// Skip cleaning prepared files when not invoking via cordova CLI.
+opts.noPrepare = true;
+
+require('./lib/loggingHelper').adjustLoggerLevel(opts);
+
+var projectRoot = path.join(__dirname, '..');
+var project = {
+root: projectRoot,
+projectConfig: new ConfigParser(path.join(projectRoot, 'config.xml')),
+locations: {
+plugins: path.join(projectRoot, 'plugins'),
+www: path.join(projectRoot, 'platform_www')
+}
+};
+
+new Api().prepare(project, opts)
+.catch(function(err) {
+console.error(err.stack);
+process.exit(2);
+});
diff --git a/template/cordova/prepare.bat b/template/cordova/prepare.bat
new file mode 100644
index 000..eb14e74
--- /dev/null
+++ b/template/cordova/prepare.bat
@@ -0,0 +1,25 @@
+:: Licensed to the Apache Software Foundation (ASF) under one
+:: or more contributor license agreements.  See the NOTICE file
+:: distributed with this work for additional information
+:: regarding copyright 

[cordova-windows] branch janpio-prepare_script_in_e2e created (now 6dde4eb)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-prepare_script_in_e2e
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git.


  at 6dde4eb  add `prepare` script that can be called in e2e tests to 
prepare project files (based on `clean` and some terrible code to build a 
`project` object) also adds default `config.xml`

This branch includes the following new commits:

 new 6dde4eb  add `prepare` script that can be called in e2e tests to 
prepare project files (based on `clean` and some terrible code to build a 
`project` object) also adds default `config.xml`

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365383160
 
 
   Problem is that `prepare` is not available on the command line... so I had 
to implement that. 
   Will open an issue and PR later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #253: CB-13870 change default from UAP to 10.0

[GitBox]

janpio commented on issue #253: CB-13870 change default from UAP to 10.0 
URL: https://github.com/apache/cordova-windows/pull/253#issuecomment-365382904
 
 
   Yes, this is actually required for `cordova requirements` not to explode 
(which happened after the change to `UAP`).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] purplecabbage commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

purplecabbage commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365382091
 
 
   Yeah, I believe prepare is the right place for this to happen.
   Consider this pr dead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365357575
 
 
   So I installed my branch which is giving me errors on running the test. 
   
   On `cordova platform add ...` it creates a `CordovaApp.Windows10.jsproj` 
file with:
   ```
   
   UAP
   10.0.16299.0
   10.0.10240.0
   14.0
   100
   
   ```
   
   So it updates the `TargetPlatformVersion` to the current version somewhere.
   
   Yes, there is some code for that in `prepare.js` and this is actually 
executed during `cordova platform add ...`.
   
   Which means that the tests should probably/maybe do something similar 
instead of this PR here, right? This PR is only making it possible to run the 
tests with a very specific setup.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] codecov-io commented on issue #356: Fix prototype declaration warnings

[GitBox]

codecov-io commented on issue #356: Fix prototype declaration warnings
URL: https://github.com/apache/cordova-ios/pull/356#issuecomment-365354329
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=h1) 
Report
   > Merging 
[#356](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/2e51796fa6d4acf5fecd17fe08bdfb1224761b8f?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/356/graphs/tree.svg?width=650=150=pr=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #356   +/-   ##
   ===
 Coverage   63.45%   63.45%   
   ===
 Files  14   14   
 Lines1691 1691   
 Branches  284  284   
   ===
 Hits 1073 1073   
 Misses618  618
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=footer). 
Last update 
[2e51796...9f2c6ab](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] codecov-io commented on issue #356: Fix prototype declaration warnings

[GitBox]

codecov-io commented on issue #356: Fix prototype declaration warnings
URL: https://github.com/apache/cordova-ios/pull/356#issuecomment-365354329
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=h1) 
Report
   > Merging 
[#356](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-ios/commit/2e51796fa6d4acf5fecd17fe08bdfb1224761b8f?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-ios/pull/356/graphs/tree.svg?src=pr=650=WomDD5jInz=150)](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #356   +/-   ##
   ===
 Coverage   63.45%   63.45%   
   ===
 Files  14   14   
 Lines1691 1691   
 Branches  284  284   
   ===
 Hits 1073 1073   
 Misses618  618
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `? = absolute  (impact)`, `? = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=footer). 
Last update 
[2e51796...9f2c6ab](https://codecov.io/gh/apache/cordova-ios/pull/356?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] 03/03: output path to used MSBuildTools in during build

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-rework_MSBuildTools
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit 2014e205e28b7ea76766c5df54b5436b028bf53b
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 18:29:35 2018 +0100

output path to used MSBuildTools in during build
---
 template/cordova/lib/MSBuildTools.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/template/cordova/lib/MSBuildTools.js 
b/template/cordova/lib/MSBuildTools.js
index f974872..eb9d7f0 100644
--- a/template/cordova/lib/MSBuildTools.js
+++ b/template/cordova/lib/MSBuildTools.js
@@ -35,7 +35,7 @@ MSBuildTools.prototype.buildProject = function (projFile, 
buildType, buildarch,
 events.emit('log', '\tConfiguration : ' + buildType);
 events.emit('log', '\tPlatform  : ' + buildarch);
 events.emit('log', '\tBuildflags: ' + buildFlags);
-events.emit('log', '\tMSBuildTools  : ' + msbuild.path);
+events.emit('log', '\tMSBuildTools  : ' + this.path);
 
 var checkWinSDK = function (target_platform) {
 return require('./check_reqs').isWinSDKPresent(target_platform);

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-rework_MSBuildTools created (now 2014e20)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-rework_MSBuildTools
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git.


  at 2014e20  output path to used MSBuildTools in during build

This branch includes the following new commits:

 new 0ecda20  notes on method usage
 new 2bed154  move getLatestMSBuild over to MSBuildTools
 new 2014e20  output path to used MSBuildTools in during build

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] 02/03: move getLatestMSBuild over to MSBuildTools

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-rework_MSBuildTools
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit 2bed15493bd5458a850e6b8f0068e5d9f365f8f8
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 18:29:12 2018 +0100

move getLatestMSBuild over to MSBuildTools
---
 template/cordova/lib/MSBuildTools.js | 28 
 template/cordova/lib/build.js| 27 ++-
 2 files changed, 30 insertions(+), 25 deletions(-)

diff --git a/template/cordova/lib/MSBuildTools.js 
b/template/cordova/lib/MSBuildTools.js
index ada837a..f974872 100644
--- a/template/cordova/lib/MSBuildTools.js
+++ b/template/cordova/lib/MSBuildTools.js
@@ -35,6 +35,7 @@ MSBuildTools.prototype.buildProject = function (projFile, 
buildType, buildarch,
 events.emit('log', '\tConfiguration : ' + buildType);
 events.emit('log', '\tPlatform  : ' + buildarch);
 events.emit('log', '\tBuildflags: ' + buildFlags);
+events.emit('log', '\tMSBuildTools  : ' + msbuild.path);
 
 var checkWinSDK = function (target_platform) {
 return require('./check_reqs').isWinSDKPresent(target_platform);
@@ -233,3 +234,30 @@ module.exports.getWillowInstallations = function () {
 });
 return installations;
 };
+
+// gets the latest MSBuild version from a list of versions
+module.exports.getLatestMSBuild = function (allMsBuildVersions) {
+events.emit('verbose', 'getLatestMSBuild');
+
+var availableVersions = allMsBuildVersions
+.filter(function (buildTools) {
+// Sanitize input - filter out tools w/ invalid versions
+return Version.tryParse(buildTools.version);
+}).sort(function (a, b) {
+// Sort tools list - use parsed Version objects for that
+// to respect both major and minor versions segments
+var parsedA = Version.fromString(a.version);
+var parsedB = Version.fromString(b.version);
+
+if (parsedA.gt(parsedB)) return -1;
+if (parsedA.eq(parsedB)) return 0;
+return 1;
+});
+
+console.log('availableVersions', availableVersions);
+
+if (availableVersions.length > 0) {
+// After sorting the first item will be the highest version available
+return availableVersions[0];
+}
+};
diff --git a/template/cordova/lib/build.js b/template/cordova/lib/build.js
index eeaa7e3..9dbaeef 100644
--- a/template/cordova/lib/build.js
+++ b/template/cordova/lib/build.js
@@ -24,7 +24,6 @@ var shell = require('shelljs');
 var utils = require('./utils');
 var prepare = require('./prepare');
 var pckage = require('./package');
-var Version = require('./Version');
 var MSBuildTools = require('./MSBuildTools');
 var AppxManifest = require('./AppxManifest');
 var ConfigParser = require('./ConfigParser');
@@ -305,7 +304,7 @@ function updateManifestWithPublisher (allMsBuildVersions, 
config) {
 if (!config.publisherId) return;
 
 var selectedBuildTargets = getBuildTargets(config.win, config.phone, 
config.projVerOverride, config);
-var msbuild = getLatestMSBuild(allMsBuildVersions);
+var msbuild = MSBuildTools.getLatestMSBuild(allMsBuildVersions);
 var myBuildTargets = filterSupportedTargets(selectedBuildTargets, msbuild);
 var manifestFiles = myBuildTargets.map(function (proj) {
 return projFilesToManifests[proj];
@@ -320,7 +319,7 @@ function updateManifestWithPublisher (allMsBuildVersions, 
config) {
 function buildTargets (allMsBuildVersions, config) {
 // filter targets to make sure they are supported on this development 
machine
 var selectedBuildTargets = getBuildTargets(config.win, config.phone, 
config.projVerOverride, config);
-var msbuild = getLatestMSBuild(allMsBuildVersions);
+var msbuild = MSBuildTools.getLatestMSBuild(allMsBuildVersions);
 if (!msbuild) {
 return Q.reject(new CordovaError('No valid MSBuild was detected for 
the selected target.'));
 }
@@ -437,28 +436,6 @@ function clearIntermediatesAndGetPackage (bundleTerms, 
config, hasAnyCpu) {
 return pckage.getPackageFileInfo(finalFile);
 }
 
-function getLatestMSBuild (allMsBuildVersions) {
-var availableVersions = allMsBuildVersions
-.filter(function (buildTools) {
-// Sanitize input - filter out tools w/ invalid versions
-return Version.tryParse(buildTools.version);
-}).sort(function (a, b) {
-// Sort tools list - use parsed Version objects for that
-// to respect both major and minor versions segments
-var parsedA = Version.fromString(a.version);
-var parsedB = Version.fromString(b.version);
-
-if (parsedA.gt(parsedB)) return -1;
-if (parsedA.eq(parsedB)) return 0;
-return 1;
-});
-
-if (availableVersions.length > 0) {
-// After sorting the first 

[cordova-windows] 01/03: notes on method usage

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-rework_MSBuildTools
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit 0ecda20cd0716ed1e8e01c6fe5c55780d03d1b7a
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 17:23:52 2018 +0100

notes on method usage
---
 template/cordova/lib/MSBuildTools.js | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/template/cordova/lib/MSBuildTools.js 
b/template/cordova/lib/MSBuildTools.js
index 7710372..ada837a 100644
--- a/template/cordova/lib/MSBuildTools.js
+++ b/template/cordova/lib/MSBuildTools.js
@@ -70,6 +70,7 @@ MSBuildTools.prototype.buildProject = function (projFile, 
buildType, buildarch,
 };
 
 // returns full path to msbuild tools required to build the project and tools 
version
+// check_reqs.js -> run()
 module.exports.findAvailableVersion = function () {
 var versions = ['15.0', '14.0', '12.0', '4.0'];
 
@@ -92,6 +93,8 @@ function findAllAvailableVersionsFallBack () {
 });
 }
 
+// build.js -> run()
+// check_reqs.js -> checkMSBuild()
 module.exports.findAllAvailableVersions = function () {
 // CB-11548 use VSINSTALLDIR environment if defined to find MSBuild. If 
VSINSTALLDIR
 // is not specified or doesn't contain the MSBuild path we are looking for 
- fall back
@@ -155,7 +158,8 @@ function checkMSBuildVersion (version) {
 });
 }
 
-/// returns an array of available UAP Versions
+// returns an array of available UAP Versions
+// prepare.js
 module.exports.getAvailableUAPVersions = function () {
 var programFilesFolder = process.env['ProgramFiles(x86)'] || 
process.env['ProgramFiles'];
 // No Program Files folder found, so we won't be able to find UAP SDK

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] nrbrook opened a new pull request #356: Fix prototype declaration warnings

[GitBox]

nrbrook opened a new pull request #356: Fix prototype declaration warnings
URL: https://github.com/apache/cordova-ios/pull/356
 
 
   
   
   ### Platforms affected
   
   
   ### What does this PR do?
   
   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365348748
 
 
   Can confirm, I currently only have `10.0.16299.0` (newest) installed. These 
tests only succeed if I change it to that version.
   
   Let me confirm that I can actually build an app without updating this value 
when I install the branch I am currently working on.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

brodybits commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345897
 
 
   > Is this maybe related to the actually installed local versions of Windows 
SDK?
   
   I would think so
   
   > Could you both please check which ones you have installed?
   
   I will check sometime later


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345308
 
 
   Unfortunately I can not confirm that changing the value to `...10586...` 
fixes the issue:
   
   ```
   C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\MSBuild\Microsoft\VisualStudio\v15.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(84,3):
 error : "10.0.10586.0" is not a supported value for TargetPlatformVersion. 
Please change it on the Project Property page. 
[C:\Projects\Cordova\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj]
   ```
   
   Is this maybe related to the actually installed local versions of Windows 
SDK?
   Could you both please check which ones you have installed?
   
   (When creating an actual project, this value is replaced by the highest 
available I think, so this might really only be an issue with `npm test`/`npm 
run test-e2e` but not in actual usage.) 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365344461
 
 
   I can now confirm this error message with (only) Visual Studio 2017 
installed:
   
   ```
   C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\MSBuild\Microsoft\VisualStudio\v15.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(84,3):
 error : "10.0.10240.0" is not a supported value for TargetPlatformVersion. 
Please change it on the Project Property page. 
[C:\Projects\Cordova\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj]
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #251: CB-13817 Add new alias `uwp` for `--appx` param including tests

[GitBox]

janpio commented on issue #251: CB-13817 Add new alias `uwp` for `--appx` param 
including tests
URL: https://github.com/apache/cordova-windows/pull/251#issuecomment-365313201
 
 
   Test failures are identical to current `master`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio opened a new pull request #253: CB-13870 change default from UAP to 10.0

[GitBox]

janpio opened a new pull request #253: CB-13870 change default from UAP to 10.0 
URL: https://github.com/apache/cordova-windows/pull/253
 
 
   ### What does this PR do?
   
   ... which means the same but works for check_reqs as well.
   
   This is an "update" to https://github.com/apache/cordova-windows/pull/241
   
   ### What testing has been done on this change?
   
   - Manual installation as platform and ran `cordova requirements` successfully
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] 01/01: CB-13870 change default from UAP to 10.0 which means the same but works for check_reqs as well

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-CB-13870_2
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit f7a5450e235ebe0888bd417abb612f6d27c9ce95
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 16:37:41 2018 +0100

CB-13870 change default from UAP to 10.0 which means the same but works for 
check_reqs as well
---
 template/cordova/lib/ConfigParser.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/template/cordova/lib/ConfigParser.js 
b/template/cordova/lib/ConfigParser.js
index bd2cb7f..e80521c 100644
--- a/template/cordova/lib/ConfigParser.js
+++ b/template/cordova/lib/ConfigParser.js
@@ -71,7 +71,7 @@ WindowsConfigParser.prototype.getMatchingPreferences = 
function (regexp) {
 WindowsConfigParser.prototype.getWindowsTargetVersion = function () {
 var preference = this.getPreference('windows-target-version');
 
-if (!preference) { preference = 'UAP'; } // default is UAP
+if (!preference) { preference = '10.0'; }
 
 return preference;
 };

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-CB-13870_2 created (now f7a5450)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-CB-13870_2
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git.


  at f7a5450  CB-13870 change default from UAP to 10.0 which means the same 
but works for check_reqs as well

This branch includes the following new commits:

 new f7a5450  CB-13870 change default from UAP to 10.0 which means the same 
but works for check_reqs as well

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: more "

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-more_env_info_on_appveyor
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to 
refs/heads/janpio-more_env_info_on_appveyor by this push:
 new 7d1c424  more "
7d1c424 is described below

commit 7d1c424c0a40476678dacc44881f212485a8f780
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 16:26:25 2018 +0100

more "
---
 appveyor.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/appveyor.yml b/appveyor.yml
index 9a895be..290af11 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -37,6 +37,6 @@ test_script:
   - node --version
   - npm --version
   - msbuild -version -nologo
-  - "%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere 
-property installationPath -products * -all"
-  - "%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere 
-property installationPath -all"
+  - "\"%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere\" 
-property installationPath -products * -all"
+  - "\"%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere\" 
-property installationPath -all"
   - npm test
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: remove which

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-more_env_info_on_appveyor
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to 
refs/heads/janpio-more_env_info_on_appveyor by this push:
 new c0dfac2  remove which
c0dfac2 is described below

commit c0dfac2a30e51e6d2dc113af7e1beb49629be92a
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 16:24:25 2018 +0100

remove which
---
 appveyor.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/appveyor.yml b/appveyor.yml
index adbfbeb..9a895be 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -37,7 +37,6 @@ test_script:
   - node --version
   - npm --version
   - msbuild -version -nologo
-  - which msbuild
   - "%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere 
-property installationPath -products * -all"
   - "%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere 
-property installationPath -all"
   - npm test
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666
 
 
   The error message you posted contains `VisualStudio\v14.0` which is Visual 
Studio 2015. https://issues.apache.org/jira/browse/CB-13861 specifically 
mentions Visual Studio 2017. What is the connection here? Do you also have the 
same problem on a machine with VS17?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion

[GitBox]

janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666
 
 
   The error message you posted contains `VisualStudio\v14.0` which is Visual 
Studio 2015. https://issues.apache.org/jira/browse/CB-13861 specifically 
mentions Visual Studio 2017. What is the connection here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: maybe now?

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-more_env_info_on_appveyor
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to 
refs/heads/janpio-more_env_info_on_appveyor by this push:
 new 961b9e7  maybe now?
961b9e7 is described below

commit 961b9e7d3409aa67c8ac9dc7af6dd47fe1d158d9
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 15:36:04 2018 +0100

maybe now?
---
 appveyor.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/appveyor.yml b/appveyor.yml
index 016a041..adbfbeb 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -38,6 +38,6 @@ test_script:
   - npm --version
   - msbuild -version -nologo
   - which msbuild
-  - "%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere" 
-property installationPath -products * -all
-  - "%ProgramFiles(x86)%\\\Microsoft Visual Studio\\Installer\\vswhere" 
-property installationPath -all
+  - "%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere 
-property installationPath -products * -all"
+  - "%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere 
-property installationPath -all"
   - npm test
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-more_env_info_on_appveyor updated: now?

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-more_env_info_on_appveyor
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to 
refs/heads/janpio-more_env_info_on_appveyor by this push:
 new 4c75046  now?
4c75046 is described below

commit 4c75046ebaa84d003b94afa7512c28e698cd2f28
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 15:35:20 2018 +0100

now?
---
 appveyor.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/appveyor.yml b/appveyor.yml
index 78bdc27..016a041 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -38,6 +38,6 @@ test_script:
   - npm --version
   - msbuild -version -nologo
   - which msbuild
-  - "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere" -property 
installationPath -products * -all
-  - "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere" -property 
installationPath -all
+  - "%ProgramFiles(x86)%\\Microsoft Visual Studio\\Installer\\vswhere" 
-property installationPath -products * -all
+  - "%ProgramFiles(x86)%\\\Microsoft Visual Studio\\Installer\\vswhere" 
-property installationPath -all
   - npm test
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] 01/01: more env information about msbuild and visual studio on appveyor

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-more_env_info_on_appveyor
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit 6a2ea4ae424099735029112109a5d49968ddd8df
Author: Jan Piotrowski 
AuthorDate: Tue Feb 13 15:32:21 2018 +0100

more env information about msbuild and visual studio on appveyor
---
 appveyor.yml | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/appveyor.yml b/appveyor.yml
index a52ea36..78bdc27 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -36,5 +36,8 @@ build: off
 test_script:
   - node --version
   - npm --version
-  - msbuild /version
+  - msbuild -version -nologo
+  - which msbuild
+  - "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere" -property 
installationPath -products * -all
+  - "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere" -property 
installationPath -all
   - npm test
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-windows] branch janpio-more_env_info_on_appveyor created (now 6a2ea4a)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-more_env_info_on_appveyor
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git.


  at 6a2ea4a  more env information about msbuild and visual studio on 
appveyor

This branch includes the following new commits:

 new 6a2ea4a  more env information about msbuild and visual studio on 
appveyor

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org