[cordova-android] 01/01: Merge pull request #486 from jedrivisser/7.1.x
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit 8dfddef6f9f5d00fba591a2fbe8837ccebea49a7 Merge: 73edf4d e3eb933 Author: Darryl Pogue AuthorDate: Tue Sep 25 22:30:46 2018 -0700 Merge pull request #486 from jedrivisser/7.1.x GH-485: (android) Replace deprecated "compile" with "implementation" bin/templates/cordova/lib/builders/ProjectBuilder.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue closed pull request #486: GH-485: (android) Replace deprecated "compile" with "implementation"
dpogue closed pull request #486: GH-485: (android) Replace deprecated "compile"
with "implementation"
URL: https://github.com/apache/cordova-android/pull/486
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bin/templates/cordova/lib/builders/ProjectBuilder.js
b/bin/templates/cordova/lib/builders/ProjectBuilder.js
index bba971d5d..b146b8b0f 100644
--- a/bin/templates/cordova/lib/builders/ProjectBuilder.js
+++ b/bin/templates/cordova/lib/builders/ProjectBuilder.js
@@ -196,7 +196,7 @@ class ProjectBuilder {
throw new CordovaError('Unsupported system library (does
not work with gradle): ' + p);
}
}
-depsList += 'compile "' + mavenRef + '"\n';
+depsList += 'implementation "' + mavenRef + '"\n';
});
buildGradle = buildGradle.replace(/(SUB-PROJECT DEPENDENCIES
START)[\s\S]*(\/\/ SUB-PROJECT DEPENDENCIES END)/, '$1\n' + depsList + '
$2');
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-android] branch master updated (73edf4d -> 8dfddef)
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 73edf4d Update comments (#496) add e3eb933 GH-485: (android) Change deprecated "compile" to "implementation" new 8dfddef Merge pull request #486 from jedrivisser/7.1.x The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: bin/templates/cordova/lib/builders/ProjectBuilder.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue commented on issue #10: Cordova 9 release plan
dpogue commented on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424588550 I think the issue with the Android Gradle latest version is that the current projects are not compatible with the latest Android Studio. I believe newer versions of gradle are now warning that `compile` support will be dropped at the end of 2018, and the work to update to `implementation` is already done, so I think we should get this in the next major. With regards to `implementation` vs `api`, I think at the app level `implementation` makes sense. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu edited a comment on issue #10: Cordova 9 release plan
erisu edited a comment on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424586802 @dpogue **The CocoaPods improvement** is done and can be merged in now. 1. Merge `cordova-common` PR 2. Release `cordova-common` next major tagged `3.0.0`. 3. Update `cordova-ios` package.json with `cordova-common@^3.0.0` 4. Merge `cordova-ios` CocoaPods PR Is the **Android Gradle's latest version** actually a requirement for this next major? Without the latest version, does Android P builds fails? This task seems new and unexpectedly added. I already reviewed **Updating Android gradle files to not use deprecated commands** and said that the changes were OK. The question I left as a comment only asked if we should allow developers the flexibility to pick between `implementation` and `api`. Adding the support is not required for next major. I knew there were **other Gradle PRs** that had questions about adding the helper methods into the dependencies scope to better isolate features that not everyone uses for example Kotlin and EnableGoogleServicesPlugin. https://github.com/apache/cordova-android/pull/438 https://github.com/apache/cordova-android/pull/441 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu commented on issue #10: Cordova 9 release plan
erisu commented on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424586802 @dpogue **The CocoaPods improvement** is done and can be merged in now. `cordova-common` needs to be merged first. Then we need to release cordova-common next major. Once its tagged, then we need to update `cordova-ios` package.json and then merge in the chanfges. Is the **Android Gradle's latest version** actually a requirement for this next major? Without the latest version, does Android P builds fails? This task seems new and unexpectedly added. I already reviewed **Updating Android gradle files to not use deprecated commands** and said that the changes were OK. The question I left as a comment only asked if we should allow developers the flexibility to pick between `implementation` and `api`. Adding the support is not required for next major. I knew there were **other Gradle PRs** that had questions about adding the helper methods into the dependencies scope to better isolate features that not everyone uses for example Kotlin and EnableGoogleServicesPlugin. https://github.com/apache/cordova-android/pull/438 https://github.com/apache/cordova-android/pull/441 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue commented on issue #10: Cordova 9 release plan
dpogue commented on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424581064 My list of remaining items looks something like this: * **Bridge WebView plugin for UIWebView/WKWebView** * **Update Xcode Project to be compatible with Xcode 10** (WIP at https://github.com/apache/cordova-ios/pull/409, but this needs more testing) * **iOS Cocoapod improvements** (WIP at https://github.com/apache/cordova-ios/issues/391, ready to merge?) * **Updating Android gradle files to not use deprecated commands** (PR at https://github.com/apache/cordova-android/pull/486, waiting for someone who understands gradle to review) * **Updating Android gradle version to latest to deal with incompatibilities with newest NDK tools** (See https://github.com/apache/cordova-android/issues/504, again need someone who understands gradle) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu edited a comment on issue #10: Cordova 9 release plan
erisu edited a comment on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424577754 @raphinesse This release plan looks great and very detailed. The very important question: **When are we going to release Cordova 9?** Also adding @dpogue to this question. Looking at the project board, https://github.com/orgs/apache/projects/2 and the previously agreed item from the dev mailing list, all the items for Cordova 9 release appears to have been completed with a few exceptions (package-lock.json, ...). But now it seems the scope is expanding. I am hoping we are not increasing the scope and delaying Cordova 9 release for items that may not be important, or can be release in a minor. Can we list out what are the remaining items and why? - Android P had already been officially released since August 6, 2018. - iOS 12 and Xcode 10 is already officially released. I want to prevent scope creeping if necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu commented on issue #10: Cordova 9 release plan
erisu commented on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-424577754 @raphinesse This release plan looks great and very detailed. The very important question: **When are we going to release Cordova 9?** Also adding @dpogue to this question. Looking at the project board, https://github.com/orgs/apache/projects/2 and the previously agreed item from the dev mailing list, all the items for Cordova 9 release appears to have been completed with a few exceptions. But now it seems the scope is expanding. I am hoping we are not increasing the scope and delaying Cordova 9 release for items that are not important. Can we list out what are the remaining items and why? - Android P had already been officially released since August 6, 2018. - iOS 12 and Xcode 10 is already officially released. I want to prevent scope creeping if necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] sdgpalm2 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX
sdgpalm2 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424564468 @Stefano1964, code has beed code applied. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-browser] branch master updated (f23c998 -> 5ce40e5)
This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-browser.git. from f23c998 Merge pull request #59 from raphinesse/remove-bundled-dependencies add 9a38451 CB-13740 return expected promise resolving with array new 5ce40e5 Merge pull request #61 from purplecabbage/CB-13740 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: bin/lib/check_reqs.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-browser] 01/01: Merge pull request #61 from purplecabbage/CB-13740
This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-browser.git commit 5ce40e53e2ea2be61c78dd3c9c6b9f27c58cc80a Merge: f23c998 9a38451 Author: Jesse MacFadyen AuthorDate: Tue Sep 25 16:56:31 2018 -0700 Merge pull request #61 from purplecabbage/CB-13740 CB-13740 return expected promise resolving with array bin/lib/check_reqs.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] purplecabbage closed pull request #61: CB-13740 return expected promise resolving with array
purplecabbage closed pull request #61: CB-13740 return expected promise
resolving with array
URL: https://github.com/apache/cordova-browser/pull/61
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/bin/lib/check_reqs.js b/bin/lib/check_reqs.js
index 172aa38..c615e14 100644
--- a/bin/lib/check_reqs.js
+++ b/bin/lib/check_reqs.js
@@ -22,5 +22,6 @@ under the License.
// add methods as we determine what are the requirements
module.exports.run = function () {
-return Promise.resolve();
+// caller expects a promise resolved with an array of conditions
+return Promise.resolve([]);
};
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-cli] 01/01: Merge pull request #335 from purplecabbage/CB-13740
This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-cli.git commit 890d336a29c586633b4cfa1f714c1afe5e604ac6 Merge: f8ed27c f10a371 Author: Jesse MacFadyen AuthorDate: Tue Sep 25 15:34:25 2018 -0700 Merge pull request #335 from purplecabbage/CB-13740 CB-13740 safe requirements check src/cli.js | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-cli] branch master updated (f8ed27c -> 890d336)
This is an automated email from the ASF dual-hosted git repository. purplecabbage pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-cli.git. from f8ed27c Stub telemetry calls during all tests (#327) add f10a371 CB-13740 gracefully handle platforms that don't pass back requirements to check new 890d336 Merge pull request #335 from purplecabbage/CB-13740 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/cli.js | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] purplecabbage opened a new pull request #61: CB-13740 return expected promise resolving with array
purplecabbage opened a new pull request #61: CB-13740 return expected promise resolving with array URL: https://github.com/apache/cordova-browser/pull/61 ### Platforms affected - browser ### What does this PR do? - returns what is expected, fixes error in cordova-cli where the return value from here was not checked ### What testing has been done on this change? none ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dhruvdp opened a new issue #73: Difference between connections?
dhruvdp opened a new issue #73: Difference between connections? URL: https://github.com/apache/cordova-plugin-network-information/issues/73 While using navigator['connection].type while connected to Verizon cellular 4g and local wifi, the plugin returns '4g' as the network type even though the device's preferred connection is wifi(which is the case for most devices). How can I differentiate/solve this? Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] vagishmm opened a new issue #305: 'loadstop' event stopped working in iOS 12.0
vagishmm opened a new issue #305: 'loadstop' event stopped working in iOS 12.0 URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/305 'loadstop' event is not working in iOS 12.0. Please help in this case. Thanks in advance. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jruizsulime commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
jruizsulime commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424374517 @dpogue Thanks for your comment, you save my time! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] ianhowe76 commented on issue #303: Android: executeScript failing for large return values (length greater than 10240)
ianhowe76 commented on issue #303: Android: executeScript failing for large
return values (length greater than 10240)
URL:
https://github.com/apache/cordova-plugin-inappbrowser/issues/303#issuecomment-424370742
I implemented a fix that seems to work ok
Instead of calling `injectDeferredObject` in the `injectScriptCode` branch
(here:
https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L254)
I instead call my new function `runJavascriptWithResult(args.getString(0),
callbackContext)`
The implementation of this function is
```
private void runJavascriptWithResult(String scriptToInject, CallbackContext
callbackContext) {
final String finalScriptToInject = scriptToInject;
final CallbackContext finalCallbackContext = callbackContext;
final String callbackId = callbackContext.getCallbackId();
this.cordova.getActivity().runOnUiThread(new Runnable() {
@SuppressLint("NewApi")
@Override
public void run() {
inAppWebView.evaluateJavascript(finalScriptToInject, new
ValueCallback() {
@Override
public void onReceiveValue(String s) {
PluginResult pluginResult;
try {
pluginResult = new
PluginResult(PluginResult.Status.OK, new JSONArray("[" + s + "]"));
} catch(JSONException e) {
pluginResult = new
PluginResult(PluginResult.Status.JSON_EXCEPTION, e.getMessage());
}
finalCallbackContext.sendPluginResult(pluginResult);
}
});
}
});
}
```
Would this be a suitable fix? If so I can create a PR
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX
Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424364211 @sdgpalm2 it's working fine if the app is launched in portrait mode but not in landscape because i made an error, i was testing only height, we have to test both height and width as the original code for points does. Attached the last version. [CDVSplashScreen.zip](https://github.com/apache/cordova-plugin-splashscreen/files/2415596/CDVSplashScreen.zip) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX
Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424364211 @sdgpalm2 it's working fine if the app is launched in portrait mode but not in landscape because i made an error, i was testing only height, we have to test both height and width. Attached the last version. [CDVSplashScreen.zip](https://github.com/apache/cordova-plugin-splashscreen/files/2415596/CDVSplashScreen.zip) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX
Stefano1964 edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424364211 @sdgpalm2 it's working fine if the app is launched in portrait mode but not in landscape because i made an error, attached the last version. [CDVSplashScreen.zip](https://github.com/apache/cordova-plugin-splashscreen/files/2415596/CDVSplashScreen.zip) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] Stefano1964 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX
Stefano1964 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424364211 @sdgpalm2 it's working fine if the app is launched in portrait mode but not in landscape because i made an error, attached the last version. [CDVSplashScreen.zip](https://github.com/apache/cordova-plugin-splashscreen/files/2415596/CDVSplashScreen.zip) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
dpogue commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424362956 > Should we expect the UserModernBuildSystem=0 setting to also persist into the generated workspace, or is it always necessary to manually make that setting change in the Workspace Settings dialog as you have shown above? If you open the project in Xcode, you must change the Workspace Settings. The command-line flags only affect the command-line builds. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] sdgpalm2 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX
sdgpalm2 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424359628 @Stefano1964, I've been using Asset Catalog Creator and did remove and replaced the xcassets, I even cleared the apps from the simulators and all the graphics did show up for me, but anyways, after reading your code, thought your process was correct, part of testing of your code yesterday was to edit the three images and place the works "X XS", "XR", "XSMax" into their respected selfs and did verified that they did show up correctly at launch based on the selected Xcode simulator, Thanks again! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] ajayprakashshukla commented on issue #412: Unable to distribute with Xcode 10
ajayprakashshukla commented on issue #412: Unable to distribute with Xcode 10 URL: https://github.com/apache/cordova-ios/issues/412#issuecomment-424346565 Using Legacy Build System you will be able to build archive with normal mobileprovision and Info.plist files This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jrmihalick commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
jrmihalick commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424338642 @dpogue I added the "-UseModernBuildSystem=0" flag to my build.json and that does address the problem we were having as mentioned on issue https://github.com/apache/cordova-cli/issues/329 . Should we expect the UserModernBuildSystem=0 setting to also persist into the generated workspace, or is it always necessary to manually make that setting change in the Workspace Settings dialog as you have shown above? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] SimoneMSR opened a new issue #304: Listen to click events
SimoneMSR opened a new issue #304: Listen to click events URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/304 Is it possible somehow to listen to click events triggered within the InAppBrowser? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-lib] branch master updated: Dereference possible symlinks when copying plugin (#705)
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git
The following commit(s) were added to refs/heads/master by this push:
new 3079853 Dereference possible symlinks when copying plugin (#705)
3079853 is described below
commit 3079853c0ac2a60c7c38db87fc1996ab3cf1b9b8
Author: Oliver Salzburg
AuthorDate: Tue Sep 25 13:06:17 2018 +0200
Dereference possible symlinks when copying plugin (#705)
When `npm install`ing a local plugin, npm will create a symlink to the
source. When we then attempt to copy that symlink, the result will be invalid
on Windows OS. Thus, we need to dereference the link/junction and create a
proper copy.
Fixes #700
Fixes #704
---
integration-tests/plugman_fetch.spec.js | 6 +++---
src/plugman/fetch.js| 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/integration-tests/plugman_fetch.spec.js
b/integration-tests/plugman_fetch.spec.js
index e16a337..81ef6aa 100644
--- a/integration-tests/plugman_fetch.spec.js
+++ b/integration-tests/plugman_fetch.spec.js
@@ -85,12 +85,12 @@ describe('fetch', function () {
it('Test 001 : should copy locally-available plugin to plugins
directory', function () {
return fetch(test_plugin, temp).then(function () {
-
expect(fs.copySync).toHaveBeenCalledWith(path.join(test_plugin),
path.join(temp, test_plugin_id));
+
expect(fs.copySync).toHaveBeenCalledWith(path.join(test_plugin),
path.join(temp, test_plugin_id), jasmine.objectContaining({dereference: true}));
});
});
it('Test 002 : should copy locally-available plugin to plugins
directory when adding a plugin with searchpath argument', function () {
return fetch(test_plugin_id, temp, { searchpath:
test_plugin_searchpath }).then(function () {
-
expect(fs.copySync).toHaveBeenCalledWith(path.join(test_plugin),
path.join(temp, test_plugin_id));
+
expect(fs.copySync).toHaveBeenCalledWith(path.join(test_plugin),
path.join(temp, test_plugin_id), jasmine.objectContaining({dereference: true}));
});
});
it('Test 003 : should create a symlink if used with `link` param',
function () {
@@ -129,7 +129,7 @@ describe('fetch', function () {
});
it('Test 027 : should copy locally-available plugin to plugins
directory', function () {
return fetch(test_pkgjson_plugin, temp).then(function () {
-
expect(fs.copySync).toHaveBeenCalledWith(path.join(test_pkgjson_plugin),
path.join(temp, 'pkgjson-test-plugin'));
+
expect(fs.copySync).toHaveBeenCalledWith(path.join(test_pkgjson_plugin),
path.join(temp, 'pkgjson-test-plugin'), jasmine.objectContaining({dereference:
true}));
expect(fetchCalls).toBe(1);
});
});
diff --git a/src/plugman/fetch.js b/src/plugman/fetch.js
index d52bae7..86d3ea3 100644
--- a/src/plugman/fetch.js
+++ b/src/plugman/fetch.js
@@ -289,7 +289,7 @@ function copyPlugin (pinfo, plugins_dir, link) {
fs.symlinkSync(fixedPath, dest, 'junction');
} else {
events.emit('verbose', 'Copying plugin "' + plugin_dir + '" => "' +
dest + '"');
-fs.copySync(plugin_dir, dest);
+fs.copySync(plugin_dir, dest, {dereference: true});
}
return dest;
}
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #303: Android: executeScript failing for large return values (length greater than 10240)
janpio commented on issue #303: Android: executeScript failing for large return values (length greater than 10240) URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/303#issuecomment-424286393 I don't know - I was hoping you knew ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-test-platform] branch master updated (31965d0 -> 9f44c72)
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-test-platform.git. from 31965d0 Merge pull request #5 from raphinesse/fix-spec-promise-handling add 22b9d77 Do not try to copy non-existant directory add 761dbb2 Silence Api.js add 4268b03 No error message when creating in existing dir add 927ae6c Silence test output new 9f44c72 Merge pull request #4 from raphinesse/silence-output The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: spec/create.spec.js | 2 +- src/cordova/Api.js | 24 ++-- 2 files changed, 11 insertions(+), 15 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-test-platform] 01/01: Merge pull request #4 from raphinesse/silence-output
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-test-platform.git commit 9f44c72575e9ea09a0957b06b3c42cff2390 Merge: 31965d0 927ae6c Author: Raphael von der Grün AuthorDate: Tue Sep 25 12:14:32 2018 +0200 Merge pull request #4 from raphinesse/silence-output Silence output spec/create.spec.js | 2 +- src/cordova/Api.js | 24 ++-- 2 files changed, 11 insertions(+), 15 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-test-platform] 01/01: Merge pull request #5 from raphinesse/fix-spec-promise-handling
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-test-platform.git commit 31965d0816f8cf6a4221883204d1df49f497436d Merge: 1cce89a cddc8dc Author: Raphael von der Grün AuthorDate: Tue Sep 25 12:12:54 2018 +0200 Merge pull request #5 from raphinesse/fix-spec-promise-handling Fix temp dir & promise handling in specs spec/create.spec.js | 3 ++- spec/projectApi.spec.js | 25 + spec/support/helpers.js | 26 ++ 3 files changed, 41 insertions(+), 13 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-test-platform] branch master updated (1cce89a -> 31965d0)
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-test-platform.git. from 1cce89a Doc requirements for platform api expectations (#1) add fc0a8ab Use proper temp dir in tests add cddc8dc Properly handle promises in test new 31965d0 Merge pull request #5 from raphinesse/fix-spec-promise-handling The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: spec/create.spec.js | 3 ++- spec/projectApi.spec.js | 25 + spec/support/helpers.js | 26 ++ 3 files changed, 41 insertions(+), 13 deletions(-) create mode 100644 spec/support/helpers.js - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] ianhowe76 commented on issue #303: Android: executeScript failing for large return values (length greater than 10240)
ianhowe76 commented on issue #303: Android: executeScript failing for large return values (length greater than 10240) URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/303#issuecomment-424280538 Anyone using prompt interface for the javascript-Java communication is affected by this Chrome update As this plugin uses prompt for communication it affects this plugin Is prompt interface used elsewhere within Cordova? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
janpio commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424261882 @499978920 Your first command is missing an `-- `. You need two of those before `buildflag` so it gets routed to `cordova` and not `ionic`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #303: Android: executeScript failing for large return values (length greater than 10240)
janpio commented on issue #303: Android: executeScript failing for large return values (length greater than 10240) URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/303#issuecomment-424261183 Did I understand correctly that this probably does not apply only for this plugin but all cordova-android communication? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] 499978920 edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
499978920 edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424253916 **when**:`ionic cordova run ios --emulator --buildFlag="-UseModernBuildSystem=0"` > ** BUILD SUCCEEDED ** > > No target specified for emulator. Deploying to iPhone-XS-Max, 12.0 simulator > > An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=2): > Failed to install the requested application > An application bundle was not found at the provided path. > Provide a valid path to the desired application bundle. > logPath: /Users/Mango/desktop/app4/platforms/ios/cordova/console.log > > [OK] Your app has been deployed. > Did you know you can live-reload changes from your app with --livereload? but console.log not exist. app not deployed. **when**:`ionic cordova run ios -- --buildFlag="-UseModernBuildSystem=0"` app deployed to iPhone 7 Plus, and work fine **when**: use Xcode 10 simulator ok iPhone 7 Plus ok This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] 499978920 edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
499978920 edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424253916 when:`ionic cordova run ios --emulator --buildFlag="-UseModernBuildSystem=0"` > ** BUILD SUCCEEDED ** > > No target specified for emulator. Deploying to iPhone-XS-Max, 12.0 simulator > > An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=2): > Failed to install the requested application > An application bundle was not found at the provided path. > Provide a valid path to the desired application bundle. > logPath: /Users/Mango/desktop/app4/platforms/ios/cordova/console.log > > [OK] Your app has been deployed. > Did you know you can live-reload changes from your app with --livereload? but console.log not exist. app not deployed. when:`ionic cordova run ios -- --buildFlag="-UseModernBuildSystem=0"` app deployed to iPhone 7 Plus, and work fine when: use Xcode 10 simulator ok iPhone 7 Plus ok This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] 499978920 commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
499978920 commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-424253916 when:`ionic cordova run ios --emulator --buildFlag="-UseModernBuildSystem=0"` > ** BUILD SUCCEEDED ** > > No target specified for emulator. Deploying to iPhone-XS-Max, 12.0 simulator > > An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=2): > Failed to install the requested application > An application bundle was not found at the provided path. > Provide a valid path to the desired application bundle. > logPath: /Users/Mango/desktop/app4/platforms/ios/cordova/console.log > > [OK] Your app has been deployed. > Did you know you can live-reload changes from your app with --livereload? but console.log not exist. app not deployed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] knight9999 opened a new pull request #892: Add podspec
knight opened a new pull request #892: Add podspec URL: https://github.com/apache/cordova-docs/pull/892 ### Platforms affected Documents (about iOS) ### What does this PR do? This PR is document part of following PRs https://github.com/apache/cordova-ios/pull/405 https://github.com/apache/cordova-common/pull/48 doc for adding new tag `podspec` in plugin.xml. ### What testing has been done on this change? By building docs on local environment. ### Checklist - [ ] Commit message follows the format: "GH-3232: (android) Fix bug with resolving file paths", where GH- is the GitHub issue ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jcesarmobile commented on issue #400: Why is config.xml not being merged?
jcesarmobile commented on issue #400: Why is config.xml not being merged? URL: https://github.com/apache/cordova-ios/issues/400#issuecomment-424234313 You said you were writing a plugin, all plugins should have a plugin.xml, read the docs about plugin creation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] Stefano1964 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX
Stefano1964 commented on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-424233907 @sdgpalm2 thanks, i'm really busy in this days. Also note that if you are editing an existing project in Xcode 10 the launch image for XsMax and Xr dont show up, you have to delete and recreate launch image xcassets: https://stackoverflow.com/questions/52402062/iphone-xs-max-xr-not-able-to-use-native-resolution-when-using-launch-images-in This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
