[GitHub] codecov-io edited a comment on issue #489: WIP: xcodeproj files upgraded for Xcode 10

2019-01-10 Thread GitBox
codecov-io edited a comment on issue #489: WIP: xcodeproj files upgraded for Xcode 10 URL: https://github.com/apache/cordova-ios/pull/489#issuecomment-452190443 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/489?src=pr&el=h1) Report > Merging [#489](https://codecov.io/gh/apa

[GitHub] dpogue commented on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
dpogue commented on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453413715 Been playing with this and updating the Xcode project, but I still haven't managed to get a working build u

[GitHub] dpogue commented on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
dpogue commented on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453411879 > I'll leave this PR open in case I figure how to do it from code (using node-xcode). This should wo

[GitHub] erisu edited a comment on issue #10: Cordova 9 release plan

2019-01-10 Thread GitBox
erisu edited a comment on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-452996516 **Stage 3 Progress Report:** The following tools has been published and its corresponding [release blog post](https://cordova.apache.org/news/2019/01/10

[GitHub] erisu edited a comment on issue #49: [WIP] Major release TODO WIP

2019-01-10 Thread GitBox
erisu edited a comment on issue #49: [WIP] Major release TODO WIP URL: https://github.com/apache/cordova-osx/pull/49#issuecomment-453392377 @brodybits If you want to try and finish this PR for release please do. If there isn't much time, I have a PR (https://github.com/apache/cordova

[GitHub] erisu edited a comment on issue #49: [WIP] Major release TODO WIP

2019-01-10 Thread GitBox
erisu edited a comment on issue #49: [WIP] Major release TODO WIP URL: https://github.com/apache/cordova-osx/pull/49#issuecomment-453392377 @brodybits If you want to try and finish this PR for release please do. If there isn't much time, I have a PR (https://github.com/apache/cordova

[GitHub] erisu commented on issue #49: [WIP] Major release TODO WIP

2019-01-10 Thread GitBox
erisu commented on issue #49: [WIP] Major release TODO WIP URL: https://github.com/apache/cordova-osx/pull/49#issuecomment-453392377 @brodybits If you want to try and finish this for release please do. If there isn't much time, I have a PR (https://github.com/apache/cordova-osx/pull/

[GitHub] erisu commented on issue #83: OSX Platform Release Preparation (Cordova 9)

2019-01-10 Thread GitBox
erisu commented on issue #83: OSX Platform Release Preparation (Cordova 9) URL: https://github.com/apache/cordova-osx/pull/83#issuecomment-453390328 **Remaining Task** - [ ] Update Cordova dependency `xcode@^2.0.0` once released. -

[GitHub] erisu opened a new pull request #83: OSX Platform Release Preparation (Cordova 9)

2019-01-10 Thread GitBox
erisu opened a new pull request #83: OSX Platform Release Preparation (Cordova 9) URL: https://github.com/apache/cordova-osx/pull/83 ### Platforms affected macOS - OSX ### What does this PR do? This PR contains final preparations for the Cordova 9 release goals. See [Co

[cordova-osx] branch master updated: explicit plist@3 dependency (#66)

2019-01-10 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-osx.git The following commit(s) were added to refs/heads/master by this push: new 4e51d2b explicit plist@3 dependency (#66) 4

[GitHub] erisu closed pull request #66: explicit plist@3 dependency

2019-01-10 Thread GitBox
erisu closed pull request #66: explicit plist@3 dependency URL: https://github.com/apache/cordova-osx/pull/66 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] mesqueeb closed issue #490: Prevent tap to touch element during scroll

2019-01-10 Thread GitBox
mesqueeb closed issue #490: Prevent tap to touch element during scroll URL: https://github.com/apache/cordova-ios/issues/490 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] mesqueeb commented on issue #490: Prevent tap to touch element during scroll

2019-01-10 Thread GitBox
mesqueeb commented on issue #490: Prevent tap to touch element during scroll URL: https://github.com/apache/cordova-ios/issues/490#issuecomment-453381691 Thanks so much! The problem is solved by using [WKWebView](https://github.com/apache/cordova-plugin-wkwebview-engine). --

[GitHub] erisu edited a comment on issue #10: Cordova 9 release plan

2019-01-10 Thread GitBox
erisu edited a comment on issue #10: Cordova 9 release plan URL: https://github.com/apache/cordova/issues/10#issuecomment-452996516 **Stage 3 Progress Report:** The following tools has been published and its corresponding [release blog post](https://cordova.apache.org/news/2019/01/10

[GitHub] erisu opened a new pull request #70: Browser Platform Release Preparation (Cordova 9)

2019-01-10 Thread GitBox
erisu opened a new pull request #70: Browser Platform Release Preparation (Cordova 9) URL: https://github.com/apache/cordova-browser/pull/70 ### Platforms affected browser ### What does this PR do? This PR contains final preparations for the Cordova 9 release goals. See

[GitHub] codecov-io edited a comment on issue #612: Android Platform Release Preparation (Cordova 9)

2019-01-10 Thread GitBox
codecov-io edited a comment on issue #612: Android Platform Release Preparation (Cordova 9) URL: https://github.com/apache/cordova-android/pull/612#issuecomment-452649863 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/612?src=pr&el=h1) Report > Merging [#612](https://co

[GitHub] codecov-io edited a comment on issue #612: Android Platform Release Preparation (Cordova 9)

2019-01-10 Thread GitBox
codecov-io edited a comment on issue #612: Android Platform Release Preparation (Cordova 9) URL: https://github.com/apache/cordova-android/pull/612#issuecomment-452649863 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/612?src=pr&el=h1) Report > Merging [#612](https://co

[GitHub] codecov-io edited a comment on issue #612: Android Platform Release Preparation (Cordova 9)

2019-01-10 Thread GitBox
codecov-io edited a comment on issue #612: Android Platform Release Preparation (Cordova 9) URL: https://github.com/apache/cordova-android/pull/612#issuecomment-452649863 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/612?src=pr&el=h1) Report > Merging [#612](https://co

[GitHub] lanjiachuan opened a new issue #396: for help

2019-01-10 Thread GitBox
lanjiachuan opened a new issue #396: for help URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/396 The author: hello!I need cordova - plugin - inappbrowser support mobile positioning, hide the phone status bar when it is open, and the app before passing each other identity

[GitHub] knight9999 edited a comment on issue #486: Cordova run does not work

2019-01-10 Thread GitBox
knight edited a comment on issue #486: Cordova run does not work URL: https://github.com/apache/cordova-ios/issues/486#issuecomment-453338029 @shazron Thanks. As you said, `--buildFlad='-UseModernBuildSystem=0'` works. However I want to solve the issue with this flags. This iss

[GitHub] knight9999 commented on issue #486: Cordova run does not work

2019-01-10 Thread GitBox
knight commented on issue #486: Cordova run does not work URL: https://github.com/apache/cordova-ios/issues/486#issuecomment-453338029 @shazron Thanks. As you said, `--buildFlad='-UseModernBuildSystem=0'` works. However I want to solve the issue with this flags. This issue is s

[GitHub] knight9999 closed pull request #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command.

2019-01-10 Thread GitBox
knight closed pull request #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command. URL: https://github.com/apache/cordova-ios/pull/487 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sa

[GitHub] knight9999 commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command.

2019-01-10 Thread GitBox
knight commented on issue #487: Fix issue #486. Distinguish xcodebuild `build` command and `archive` command. URL: https://github.com/apache/cordova-ios/pull/487#issuecomment-453329118 @shazron Thanks you for the great work https://github.com/apache/cordova-ios/pull/494 . This resol

[GitHub] drewrygh opened a new issue #212: mediaStatus and mediaError callbacks not always firing when Android activity is killed

2019-01-10 Thread GitBox
drewrygh opened a new issue #212: mediaStatus and mediaError callbacks not always firing when Android activity is killed URL: https://github.com/apache/cordova-plugin-media/issues/212 When killing an app on Android (by swiping the activity to dismiss it), the plugin seems to behave inconsi

[GitHub] cvanem edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

2019-01-10 Thread GitBox
cvanem edited a comment on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-453235890 FYI, I got an email today, from Apple, indicating that they closed my bug report because it was a duplicate of

[GitHub] cvanem commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10

2019-01-10 Thread GitBox
cvanem commented on issue #417: Keyboard Dismissal Leaves Viewport Shifted in iOS 12 / XCode 10 URL: https://github.com/apache/cordova-ios/issues/417#issuecomment-453235890 FYI, I got an email today from Apple indicating that they closed my bug report because it was a duplicate of 44655885

[GitHub] brodybits commented on a change in pull request #612: Android Platform Release Preparation (Cordova 9)

2019-01-10 Thread GitBox
brodybits commented on a change in pull request #612: Android Platform Release Preparation (Cordova 9) URL: https://github.com/apache/cordova-android/pull/612#discussion_r246834312 ## File path: package.json ## @@ -48,7 +46,6 @@ "eslint-plugin-promise": "^4.0.1",

[GitHub] shi11 commented on issue #114: Not working on Android devices

2019-01-10 Thread GitBox
shi11 commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-453163484 Hi @terminaltor - I haven't tried your solution yet however I'm noticing that you only used getCurrentPosition() and not watchPosition()

[GitHub] lizqjue commented on issue #384: Fatal Exception occured due to "not attached to window" on AndroidP

2019-01-10 Thread GitBox
lizqjue commented on issue #384: Fatal Exception occured due to "not attached to window" on AndroidP URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/384#issuecomment-453156776 This is also happening in Android O, I can confirm it. At least in inappbrowser version 1.3.1

[GitHub] desmeit commented on issue #345: Camera plugin crashes app on some android phones when an image is taken

2019-01-10 Thread GitBox
desmeit commented on issue #345: Camera plugin crashes app on some android phones when an image is taken URL: https://github.com/apache/cordova-plugin-camera/issues/345#issuecomment-453123367 @mrHassanRaza I updated to the newest Android Cordova Version 7.1.4 but its the same issue. It cr

[GitHub] desmeit opened a new issue #406: App crashs in Android 8.1.0

2019-01-10 Thread GitBox
desmeit opened a new issue #406: App crashs in Android 8.1.0 URL: https://github.com/apache/cordova-plugin-camera/issues/406 The camera plugin is working with Android 7.0 but not with a Samsung J9 2017 and Android 8.1.0. After calling Camera Plugin it crashs the App: ``` E/Android

[GitHub] jacobg edited a comment on issue #372: OverrideUserAgent changes user agent for Cordova view too

2019-01-10 Thread GitBox
jacobg edited a comment on issue #372: OverrideUserAgent changes user agent for Cordova view too URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/372#issuecomment-453075475 In case anyone is interested, I wrote a script that patches the plugin in my build, as follows:

[GitHub] jacobg commented on issue #372: OverrideUserAgent changes user agent for Cordova view too

2019-01-10 Thread GitBox
jacobg commented on issue #372: OverrideUserAgent changes user agent for Cordova view too URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/372#issuecomment-453075475 In case anyone is interested, I wrote a script that patches the plugin in-place, as follows: `patch

[GitHub] goran-hc commented on issue #372: OverrideUserAgent changes user agent for Cordova view too

2019-01-10 Thread GitBox
goran-hc commented on issue #372: OverrideUserAgent changes user agent for Cordova view too URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/372#issuecomment-453073980 +1, same issue here. This is an automat

[GitHub] desmeit commented on issue #373: Cannot take pictures on Android 8

2019-01-10 Thread GitBox
desmeit commented on issue #373: Cannot take pictures on Android 8 URL: https://github.com/apache/cordova-plugin-camera/issues/373#issuecomment-453061548 @AutoAlert What was the issue in detail? I see no difference between your codes.

[GitHub] zzt1413 opened a new issue #126: about onePlus 3T,it’s duration not working

2019-01-10 Thread GitBox
zzt1413 opened a new issue #126: about onePlus 3T,it’s duration not working URL: https://github.com/apache/cordova-plugin-media-capture/issues/126 I tried to use limited function ,that's all right. But when I tried to use duration,it's not working on onePlus 3T and it's working on other And

[GitHub] ianhowe76 commented on issue #303: Android: executeScript failing for large return values (length greater than 10240)

2019-01-10 Thread GitBox
ianhowe76 commented on issue #303: Android: executeScript failing for large return values (length greater than 10240) URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/303#issuecomment-453044630 PR to fix this is #395 --

[GitHub] ianhowe76 closed pull request #395: Android: Use evaluateJavascript execute script (not prompt)

2019-01-10 Thread GitBox
ianhowe76 closed pull request #395: Android: Use evaluateJavascript execute script (not prompt) URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/395 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] ianhowe76 opened a new pull request #395: Android: Use evaluateJavascript execute script (not prompt)

2019-01-10 Thread GitBox
ianhowe76 opened a new pull request #395: Android: Use evaluateJavascript execute script (not prompt) URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/395 ### Platforms affected Android ### What does this PR do? Use `evaluateJavascript` to call ja

[GitHub] jcesarmobile commented on issue #330: On Android an empty string is returned when selecting a video from the photo library

2019-01-10 Thread GitBox
jcesarmobile commented on issue #330: On Android an empty string is returned when selecting a video from the photo library URL: https://github.com/apache/cordova-plugin-camera/issues/330#issuecomment-453027941 I tested on real devices with different android versions. Try using dev vers

[GitHub] uspasojevic96 edited a comment on issue #330: On Android an empty string is returned when selecting a video from the photo library

2019-01-10 Thread GitBox
uspasojevic96 edited a comment on issue #330: On Android an empty string is returned when selecting a video from the photo library URL: https://github.com/apache/cordova-plugin-camera/issues/330#issuecomment-453021733 This issue is not reproducible on emulator, but on real device path is e

[GitHub] uspasojevic96 commented on issue #330: On Android an empty string is returned when selecting a video from the photo library

2019-01-10 Thread GitBox
uspasojevic96 commented on issue #330: On Android an empty string is returned when selecting a video from the photo library URL: https://github.com/apache/cordova-plugin-camera/issues/330#issuecomment-453021733 This issue is not reproducible on emulator, but on real device path is empty s

[GitHub] codecov-io edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
codecov-io edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453009079 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/494?src=pr&el=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
codecov-io edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453009079 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/494?src=pr&el=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
codecov-io edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453009079 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/494?src=pr&el=h1) Report > Merging

[GitHub] knight9999 commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2019-01-10 Thread GitBox
knight commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-453020476 @shazron Ok, I got it. Evenwhen using automatic provisioning, we should speciy provisioning profile to extract .app package from .ipa fi

[GitHub] shazron edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2019-01-10 Thread GitBox
shazron edited a comment on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-453017310 @knight as i suspected, automatic provisioning fails. I think we need to specify the provisioning profile to use even for autom

[GitHub] shazron commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2019-01-10 Thread GitBox
shazron commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-453017310 @knight as i suspected, automatic provisioning fails. I think we need to specify the provisioning profile to use even for automatic, fo

[cordova-ios] branch shazron-patch-1 updated (e070e27 -> 4210f8b)

2019-01-10 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a change to branch shazron-patch-1 in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. from e070e27 Fix linting issues add 4210f8b Fix shelljs error in not removing symlinks during run co

[GitHub] shazron commented on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
shazron commented on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453010319 Yeah I should add that `cordova/lib/run.js` fix in. Changing from automatic signing to manual signi

[GitHub] shazron edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
shazron edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453010319 Yeah I should add that `cordova/lib/run.js` fix in. Changing from automatic signing to manua

[GitHub] codecov-io edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
codecov-io edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453009079 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/494?src=pr&el=h1) Report > Merging

[GitHub] codecov-io commented on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
codecov-io commented on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453009079 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/494?src=pr&el=h1) Report > Merging [#494]

[GitHub] knight9999 edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
knight edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453008919 Thanks @shazron. The ios-deploy successfully works! with following command ```

[GitHub] codecov-io edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
codecov-io edited a comment on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453009079 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/494?src=pr&el=h1) Report > Merging

[GitHub] knight9999 commented on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive

2019-01-10 Thread GitBox
knight commented on issue #494: Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive URL: https://github.com/apache/cordova-ios/pull/494#issuecomment-453008919 Thanks @shazron. The ios-deploy successfully works! with following command ``` $ npx cordo

[cordova-ios] branch shazron-patch-1 updated (df51761 -> e070e27)

2019-01-10 Thread shazron
This is an automated email from the ASF dual-hosted git repository. shazron pushed a change to branch shazron-patch-1 in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. from df51761 Fixes $(PRODUCT_BUNDLE_IDENTIFIER) not being resolved for a product archive add e070e27

[GitHub] dpogue commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2019-01-10 Thread GitBox
dpogue commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-453003954 > Xcode IDE is smart enough My experience here is that it is **not** smart enough, because even when I try to export a build through