[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365446627 #254 is now in a state to be tested and reviewed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365388649 See https://github.com/apache/cordova-windows/pull/254 as a replacement. Would be nice if you could check that out and run it locally to see if the tests succeed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365383160 Problem is that `prepare` is not available on the command line... so I had to implement that. Will open an issue and PR later. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365357575 So I installed my branch which is giving me errors on running the test. On `cordova platform add ...` it creates a `CordovaApp.Windows10.jsproj` file with: ``` UAP 10.0.16299.0 10.0.10240.0 14.0 100 ``` So it updates the `TargetPlatformVersion` to the current version somewhere. Yes, there is some code for that in `prepare.js` and this is actually executed during `cordova platform add ...`. Which means that the tests should probably/maybe do something similar instead of this PR here, right? This PR is only making it possible to run the tests with a very specific setup. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365348748 Can confirm, I currently only have `10.0.16299.0` (newest) installed. These tests only succeed if I change it to that version. Let me confirm that I can actually build an app without updating this value when I install the branch I am currently working on. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365345308 Unfortunately I can not confirm that changing the value to `...10586...` fixes the issue: ``` C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Microsoft\VisualStudio\v15.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(84,3): error : "10.0.10586.0" is not a supported value for TargetPlatformVersion. Please change it on the Project Property page. [C:\Projects\Cordova\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj] ``` Is this maybe related to the actually installed local versions of Windows SDK? Could you both please check which ones you have installed? (When creating an actual project, this value is replaced by the highest available I think, so this might really only be an issue with `npm test`/`npm run test-e2e` but not in actual usage.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365344461 I can now confirm this error message with (only) Visual Studio 2017 installed: ``` C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Microsoft\VisualStudio\v15.0\JavaScript\Microsoft.VisualStudio.JavaScript.UAP.targets(84,3): error : "10.0.10240.0" is not a supported value for TargetPlatformVersion. Please change it on the Project Property page. [C:\Projects\Cordova\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666 The error message you posted contains `VisualStudio\v14.0` which is Visual Studio 2015. https://issues.apache.org/jira/browse/CB-13861 specifically mentions Visual Studio 2017. What is the connection here? Do you also have the same problem on a machine with VS17? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-365297666 The error message you posted contains `VisualStudio\v14.0` which is Visual Studio 2015. https://issues.apache.org/jira/browse/CB-13861 specifically mentions Visual Studio 2017. What is the connection here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364938297 This turned out to be a bigger problem than expected. It is not a blocking issue at https://issues.apache.org/jira/browse/CB-13870 What errors were you trying to solve by changing `TargetPlatformVersion` @purplecabbage and @brodybits? What should I look for the "before" state? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364770895 None right now, just setting up to test/release tomorrow and wanted to make sure I know which combination is known good ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364768966 Ouch. We might want to look into that later ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion
janpio commented on issue #250: [CB-13861] Update TargetPlatformVersion URL: https://github.com/apache/cordova-windows/pull/250#issuecomment-364766938 What does `cordova requirements windows` return for you? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
