[GitHub] brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438645251 Thanks @DavidWiesner, would like to get review from one more member before merging. If someone

[GitHub] brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438635797 Good question. I thought we should run both files, didn't think about the ordering. I would

[GitHub] brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438631866 I just pushed an update to support both locations, didn't test it yet.

[GitHub] brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory

2018-11-14 Thread GitBox
brodybits commented on issue #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553#issuecomment-438608165 I think we will need to adapt pluginHandlers.js instead. Followup question is coming on #552.