Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/7#issuecomment-136768566
ilya to follow up with better fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rnewson closed the pull request at:
https://github.com/apache/couchdb-couch-epi/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/7#issuecomment-136737729
ah good catch, missed those
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/7#issuecomment-136731843
This two probably need the same treatment:
https://github.com/apache/couchdb-couch-epi/blob/master/src/couch_epi_data.erl#L137-L142
https://github.com
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/7#issuecomment-136731729
Good catch. Never liked try/catch. May be fix other modules as well? So far:
- couch_epi_data:get_from_module/1
- couch_epi_data:current/2
- couch_epi_
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/7#issuecomment-136724781
this fixes a performance regression from the introduction of couch_epi.
---
If your project is set up for it, you can reply to this email and have your
reply ap
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch-epi/pull/7
Use function_exported/3 to test for callbacks
try/catch is much slower in comparison to function_exported.
You can merge this pull request into a Git repository by running:
$ git pull
