Re: [PR] Replace ArrayBuffer[State] with Array[State] [daffodil]

2025-02-18 Thread via GitHub
olabusayoT merged PR #1435: URL: https://github.com/apache/daffodil/pull/1435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffod

Re: [PR] Replace ArrayBuffer[State] with Array[State] [daffodil]

2025-02-14 Thread via GitHub
olabusayoT commented on code in PR #1435: URL: https://github.com/apache/daffodil/pull/1435#discussion_r1956828927 ## daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/dfa/CreateDelimiterDFA.scala: ## @@ -186,26 +186,33 @@ object CreateDelimiterDFA { pr

Re: [PR] Replace ArrayBuffer[State] with Array[State] [daffodil]

2025-02-14 Thread via GitHub
mbeckerle commented on code in PR #1435: URL: https://github.com/apache/daffodil/pull/1435#discussion_r1956507677 ## daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/dfa/CreateDelimiterDFA.scala: ## @@ -186,26 +186,33 @@ object CreateDelimiterDFA { pri

[PR] Replace ArrayBuffer[State] with Array[State] [daffodil]

2025-02-13 Thread via GitHub
olabusayoT opened a new pull request, #1435: URL: https://github.com/apache/daffodil/pull/1435 - currently in 2.13 we are getting a "ReflectiveOperationException durins deserialzation" error on account of states being a pass by name parameter leading to lambda serialization, removing that r