[GitHub] [incubator-dolphinscheduler] Yeleights commented on a change in pull request #1542: #1300 Add right alignment function in sql email content
Yeleights commented on a change in pull request #1542: #1300 Add right
alignment function in sql email content
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1542#discussion_r361085833
##
File path:
dolphinscheduler-alert/src/main/resources/mail_templates/alert_mail_template.ftl
##
@@ -14,4 +14,40 @@
~ See the License for the specific language governing permissions and
~ limitations under the License.
-->
-http://www.w3.org/TR/html4/loose.dtd'>
dolphinschedulertable {
margin-top:0px;padding-top:0px;border:1px solid;
font-size: 14px;color: #33;border-width: 1px;
border-color: #66;border-collapse: collapse;}
table th {border-width: 1px;padding: 8px;
border-style: solid;border-color: #66;
background-color: #dedede;}table td {border-width:
1px;padding: 8px;border-style: solid;
border-color: #66;background-color: #ff;
}<#if title??>
${title}<#if content??> ${content}
\ No newline at end of file
+http://www.w3.org/TR/html4/loose.dtd'>
Review comment:
thx, i found this problem. i will fix
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] lgcareer commented on a change in pull request #1542: #1300 Add right alignment function in sql email content
lgcareer commented on a change in pull request #1542: #1300 Add right alignment
function in sql email content
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1542#discussion_r361083271
##
File path:
dolphinscheduler-alert/src/main/resources/mail_templates/alert_mail_template.ftl
##
@@ -14,4 +14,40 @@
~ See the License for the specific language governing permissions and
~ limitations under the License.
-->
-http://www.w3.org/TR/html4/loose.dtd'>
dolphinschedulertable {
margin-top:0px;padding-top:0px;border:1px solid;
font-size: 14px;color: #33;border-width: 1px;
border-color: #66;border-collapse: collapse;}
table th {border-width: 1px;padding: 8px;
border-style: solid;border-color: #66;
background-color: #dedede;}table td {border-width:
1px;padding: 8px;border-style: solid;
border-color: #66;background-color: #ff;
}<#if title??>
${title}<#if content??> ${content}
\ No newline at end of file
+http://www.w3.org/TR/html4/loose.dtd'>
Review comment:
After formatting, you can verify whether the content of the sent email has
spaces and blank lines.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] elonlo opened a new issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大)
elonlo opened a new issue #1547: [Feature] node text edit box supports full-screen magnification(节点文本编辑框支持全屏放大) URL: https://github.com/apache/incubator-dolphinscheduler/issues/1547 **Is your feature request related to a problem? Please describe.** The node text edit box supports full-screen magnification, which is better for long text writing experience. 节点文本编辑框支持全屏放大，这样对于长文本编写体验更好 **Additional context**  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568671208 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568671209 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io URL: https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568671210 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated (6738cef -> 6837bed)
This is an automated email from the ASF dual-hosted git repository. lgcareer pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from 6738cef Add Status and ExecuteType class unit tests #1465 (#1536) add 6837bed Front-end third-party js, css introduced using npm (#1546) No new revisions were added by this update. Summary of changes: dolphinscheduler-ui/build/config.js|21 +- dolphinscheduler-ui/package.json | 9 +- dolphinscheduler-ui/src/3rdcss/animate.css | 4 - dolphinscheduler-ui/src/3rdcss/bootstrap.min.css | 5 - dolphinscheduler-ui/src/3rdcss/codemirror.min.css | 4 - .../src/3rdcss/jsplumbtoolkit-defaults.min.css | 4 - dolphinscheduler-ui/src/3rdcss/mdn-like.min.css| 4 - dolphinscheduler-ui/src/3rdcss/normalize.min.css | 1 - dolphinscheduler-ui/src/3rdcss/reset.css | 2 - dolphinscheduler-ui/src/3rdcss/show-hint.min.css | 4 - dolphinscheduler-ui/src/3rdcss/vs.min.css | 5 - dolphinscheduler-ui/src/3rdjs/bootstrap.min.js | 7 - dolphinscheduler-ui/src/3rdjs/canvg.min.js | 4 - dolphinscheduler-ui/src/3rdjs/clipboard.min.js | 7 - dolphinscheduler-ui/src/3rdjs/codemirror.min.js| 4 - dolphinscheduler-ui/src/3rdjs/d3.min.js| 8 - dolphinscheduler-ui/src/3rdjs/dayjs.min.js | 1 - dolphinscheduler-ui/src/3rdjs/echarts.min.js |21 - dolphinscheduler-ui/src/3rdjs/es5-sham.min.js | 7 - dolphinscheduler-ui/src/3rdjs/es5-shim.min.js | 7 - dolphinscheduler-ui/src/3rdjs/html2canvas.min.js | 8 - dolphinscheduler-ui/src/3rdjs/jquery-ui.min.js |13 - dolphinscheduler-ui/src/3rdjs/jquery.min.js| 2 - dolphinscheduler-ui/src/3rdjs/jsplumb.min.js |10 - dolphinscheduler-ui/src/3rdjs/lodash.min.js| 138 - dolphinscheduler-ui/src/3rdjs/python.min.js| 4 - dolphinscheduler-ui/src/3rdjs/shell.min.js | 4 - dolphinscheduler-ui/src/3rdjs/show-hint.min.js | 4 - dolphinscheduler-ui/src/3rdjs/sql-hint.min.js | 4 - dolphinscheduler-ui/src/3rdjs/sql.min.js | 4 - dolphinscheduler-ui/src/3rdjs/textile.min.js | 4 - dolphinscheduler-ui/src/3rdjs/vue-router.min.js| 6 - dolphinscheduler-ui/src/3rdjs/vue.js | 10552 --- dolphinscheduler-ui/src/3rdjs/vuex.min.js | 6 - dolphinscheduler-ui/src/3rdjs/xml-hint.min.js | 4 - dolphinscheduler-ui/src/3rdjs/xml.min.js | 4 - dolphinscheduler-ui/src/js/conf/home/index.js | 6 +- .../dag/_source/formModel/_source/timeoutAlarm.vue | 2 +- .../conf/home/pages/dag/_source/plugIn/dragZoom.js | 1 - .../home/pages/dag/_source/plugIn/jsPlumbHandle.js | 6 +- .../js/conf/home/pages/dag/_source/plugIn/util.js | 1 - .../pages/monitor/pages/servers/_source/gauge.vue | 1 + .../monitor/pages/servers/_source/gaugeOption.js | 9 +- .../pages/definition/pages/list/_source/list.vue | 4 +- .../pages/definition/pages/tree/_source/tree.js| 1 - .../pages/instance/pages/gantt/_source/gantt.js| 1 - .../conf/home/pages/projects/pages/list/index.vue | 1 + .../src/js/conf/home/store/dag/mutations.js| 1 - .../src/js/conf/home/store/index.js| 4 +- dolphinscheduler-ui/src/js/conf/login/index.js | 3 +- .../components/fileUpdate/definitionUpdate.vue | 2 +- .../src/js/module/permissions/index.js | 2 +- dolphinscheduler-ui/src/sass/common/_font.scss |17 - dolphinscheduler-ui/src/sass/common/index.scss | 164 +- dolphinscheduler-ui/src/view/home/index.html |35 - dolphinscheduler-ui/src/view/login/index.html |35 - 56 files changed, 195 insertions(+), 10997 deletions(-) delete mode 100644 dolphinscheduler-ui/src/3rdcss/animate.css delete mode 100644 dolphinscheduler-ui/src/3rdcss/bootstrap.min.css delete mode 100644 dolphinscheduler-ui/src/3rdcss/codemirror.min.css delete mode 100644 dolphinscheduler-ui/src/3rdcss/jsplumbtoolkit-defaults.min.css delete mode 100644 dolphinscheduler-ui/src/3rdcss/mdn-like.min.css delete mode 100644 dolphinscheduler-ui/src/3rdcss/normalize.min.css delete mode 100644 dolphinscheduler-ui/src/3rdcss/reset.css delete mode 100644 dolphinscheduler-ui/src/3rdcss/show-hint.min.css delete mode 100644 dolphinscheduler-ui/src/3rdcss/vs.min.css delete mode 100644 dolphinscheduler-ui/src/3rdjs/bootstrap.min.js delete mode 100644 dolphinscheduler-ui/src/3rdjs/canvg.min.js delete mode 100644 dolphinscheduler-ui/src/3rdjs/clipboard.min.js delete mode 100644 dolphinscheduler-ui/src/3rdjs/codemirror.min.js delete mode 100644 dolphinscheduler-ui/src/3rdjs/d3.min.js delete mode 100644 dolphinscheduler-ui/src/3rdjs/dayjs.min.js delete mode 100644
[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1545: Front-end compliance modification
lgcareer merged pull request #1545: Front-end compliance modification URL: https://github.com/apache/incubator-dolphinscheduler/pull/1545 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1546: Front-end third-party js, css introduced using npm
codecov-io commented on issue #1546: Front-end third-party js, css introduced using npm URL: https://github.com/apache/incubator-dolphinscheduler/pull/1546#issuecomment-568663165 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr=h1) Report > Merging [#1546](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/41858fdb0b3a7a4ce5ceff85489c307804a923c1?src=pr=desc) will **increase** coverage by `0.37%`. > The diff coverage is `91.42%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr=tree) ```diff @@ Coverage Diff@@ ## dev #1546 +/- ## + Coverage 7.42% 7.79% +0.37% Files272 272 Lines 13634 13641 +7 Branches21692166 -3 + Hits10121063 +51 + Misses 12555 12506 -49 - Partials 67 72 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr=tree) | Coverage Δ | | |---|---|---| | [.../org/apache/dolphinscheduler/api/enums/Status.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL1N0YXR1cy5qYXZh) | `100% <ø> (ø)` | :arrow_up: | | [.../dolphinscheduler/server/utils/SparkArgsUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NwYXJrQXJnc1V0aWxzLmphdmE=) | `92.15% <91.42%> (+92.15%)` | :arrow_up: | | [...apache/dolphinscheduler/api/enums/ExecuteType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2VudW1zL0V4ZWN1dGVUeXBlLmphdmE=) | `66.66% <0%> (+66.66%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr=footer). Last update [41858fd...27ce4ac](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1546?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io
dependabot[bot] commented on issue #1231: Bump axios from 0.16.2 to 0.19.0 in /escheduler-ui/src/lib/@fedor/io URL: https://github.com/apache/incubator-dolphinscheduler/pull/1231#issuecomment-568660835 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui
dependabot[bot] commented on issue #1230: Bump bootstrap from 3.3.7 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1230#issuecomment-568660834 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui
dependabot[bot] commented on issue #1232: Bump jquery from 1.12.4 to 3.4.1 in /escheduler-ui URL: https://github.com/apache/incubator-dolphinscheduler/pull/1232#issuecomment-568660832 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1536: Add Status and ExecuteType class unit tests #1465
qiaozhanwei merged pull request #1536: Add Status and ExecuteType class unit tests #1465 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated (10c39db -> 6738cef)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a change to branch dev
in repository
https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git.
from 10c39db add api/controller unit test (#1488)
add 6738cef Add Status and ExecuteType class unit tests #1465 (#1536)
No new revisions were added by this update.
Summary of changes:
.../apache/dolphinscheduler/api/enums/Status.java | 12 ++--
.../api/enums/ExecuteTypeTest.java}| 32 +++---
.../dolphinscheduler/api/enums/StatusTest.java | 21 +++---
pom.xml| 1 +
4 files changed, 23 insertions(+), 43 deletions(-)
copy
dolphinscheduler-api/src/{main/java/org/apache/dolphinscheduler/api/enums/ExecuteType.java
=> test/java/org/apache/dolphinscheduler/api/enums/ExecuteTypeTest.java} (63%)
copy
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/EncryptionUtilsTest.java
=>
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/enums/StatusTest.java
(69%)
[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on a change in pull request #1532: fix MasterBaseTaskExecThread submit method bug
qiaozhanwei commented on a change in pull request #1532: fix
MasterBaseTaskExecThread submit method bug
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1532#discussion_r361069044
##
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThread.java
##
@@ -74,6 +74,9 @@ public TaskInstance getTaskInstance(){
public Boolean submitWaitComplete() {
Boolean result = false;
this.taskInstance = submit();
+if(this.taskInstance == null){
+return result;
Review comment:
1，Uncertain return, it is recommended to debug
2，submit failed should be logs and mail
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[incubator-dolphinscheduler] branch dev updated (d44d064 -> 10c39db)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a change to branch dev
in repository
https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git.
from d44d064 Add SparkArgsUtilsTest which is the UT of SparkArgsUtils
(#1534)
add 10c39db add api/controller unit test (#1488)
No new revisions were added by this update.
Summary of changes:
.../api/controller/AbstractControllerTest.java | 2 +-
...lerTest.java => AccessTokenControllerTest.java} | 94 +++--
.../api/controller/AlertGroupControllerTest.java | 170 +
.../api/controller/DataAnalysisControllerTest.java | 86 +++--
.../api/controller/DataSourceControllerTest.java | 196 ++-
.../api/controller/ExecutorControllerTest.java | 65 +++-
.../api/controller/LoggerControllerTest.java | 39 ++-
.../api/controller/LoginControllerTest.java| 26 +-
.../api/controller/MonitorControllerTest.java | 58 ++--
.../ProcessDefinitionControllerTest.java | 275 ++-
.../controller/ProcessInstanceControllerTest.java | 153 -
.../api/controller/ProjectControllerTest.java | 166 -
.../api/controller/QueueControllerTest.java| 17 +-
.../api/controller/ResourcesControllerTest.java| 382 -
.../api/controller/SchedulerControllerTest.java| 141 +++-
.../api/controller/TaskInstanceControllerTest.java | 8 +-
...llerTest.java => TaskRecordControllerTest.java} | 68 ++--
.../api/controller/TenantControllerTest.java | 107 +-
.../api/controller/UsersControllerTest.java| 222 +++-
...lerTest.java => WorkerGroupControllerTest.java} | 89 ++---
20 files changed, 2119 insertions(+), 245 deletions(-)
copy
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/{QueueControllerTest.java
=> AccessTokenControllerTest.java} (67%)
create mode 100644
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AlertGroupControllerTest.java
copy
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/{ExecutorControllerTest.java
=> TaskRecordControllerTest.java} (51%)
copy
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/{QueueControllerTest.java
=> WorkerGroupControllerTest.java} (62%)
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1488: add api/controller unit test
qiaozhanwei merged pull request #1488: add api/controller unit test URL: https://github.com/apache/incubator-dolphinscheduler/pull/1488 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen opened a new issue #1544: The workflow import user's other project or other user's project, the database table t_ds_process_definition stores data i
xingchun-chen opened a new issue #1544: The workflow import user's other project or other user's project, the database table t_ds_process_definition stores data incorrectly URL: https://github.com/apache/incubator-dolphinscheduler/issues/1544 *For better global communication, please give priority to using English description, thx! * **Describe the bug** 1. After the user successfully imported the workflow of user’s project B in project A, t_ds_process_definition.project_id is still project B, and project_id should be the project ID of project A 2. The workflow of importing other users prompts success, but the data is not stored in the database table t_ds_process_definition 1.用户在A项目导入该用户B项目的工作流成功后，t_ds_process_definition.project_id仍为B项目的id，project_id应该为A项目的id 2.导入其他用户的工作流提示成功，但是数据未存入数据库 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Yeleights commented on issue #747: Log desensitization(日志脱敏)
Yeleights commented on issue #747: Log desensitization(日志脱敏) URL: https://github.com/apache/incubator-dolphinscheduler/issues/747#issuecomment-568618722 i will fix it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in pull request #1537: refactor zk client and zk config module
Technoboy- commented on a change in pull request #1537: refactor zk client and
zk config module
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1537#discussion_r360910371
##
File path:
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/zk/ZookeeperCachedOperator.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.common.zk;
+
+import org.apache.curator.framework.recipes.cache.ChildData;
+import org.apache.curator.framework.recipes.cache.TreeCache;
+import org.apache.curator.framework.recipes.cache.TreeCacheListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.stereotype.Component;
+
+import java.nio.charset.StandardCharsets;
+import java.util.concurrent.ConcurrentHashMap;
+
+import static org.apache.dolphinscheduler.common.utils.Preconditions.*;
+import static
org.apache.dolphinscheduler.common.utils.Preconditions.checkNotNull;
+
+@Component
+public class ZookeeperCachedOperator extends ZookeeperOperator {
+
+private final Logger logger =
LoggerFactory.getLogger(ZookeeperCachedOperator.class);
+
+//kay is zk path, value is TreeCache
+private ConcurrentHashMap allCaches = new
ConcurrentHashMap<>();
+
+/**
+ * @param cachePath zk path
+ * @param listener operator
+ */
+public void registerListener(final String cachePath, final
TreeCacheListener listener) {
Review comment:
not a good way here
listen a base path is why AbstractListener borns
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1543: Refactor login verification process
codecov-io edited a comment on issue #1543: Refactor login verification process URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543#issuecomment-568450522 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=h1) Report > Merging [#1543](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/d44d06489ad16ae735067ada030ff45cfe1b6dc0?src=pr=desc) will **increase** coverage by `0.72%`. > The diff coverage is `33.82%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=tree) ```diff @@ Coverage Diff@@ ## dev #1543 +/- ## + Coverage 7.76% 8.49% +0.72% Files272 275 +3 Lines 13641 13684 +43 Branches21662171 +5 + Hits10591162 +103 + Misses 12511 12446 -65 - Partials 71 76 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=tree) | Coverage Δ | | |---|---|---| | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `0.87% <0%> (+0.87%)` | :arrow_up: | | [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `0.36% <0%> (+0.36%)` | :arrow_up: | | [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `3.33% <0%> (+3.33%)` | :arrow_up: | | [...duler/api/interceptor/LoginHandlerInterceptor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2ludGVyY2VwdG9yL0xvZ2luSGFuZGxlckludGVyY2VwdG9yLmphdmE=) | `66.66% <100%> (+66.66%)` | :arrow_up: | | [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `100% <100%> (ø)` | | | [...nscheduler/api/security/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `50% <50%> (ø)` | | | [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `64.28% <64.28%> (ø)` | | | ... and [42 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=footer). Last update [d44d064...04823c2](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1543: Refactor login verification process
codecov-io edited a comment on issue #1543: Refactor login verification process URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543#issuecomment-568450522 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=h1) Report > Merging [#1543](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/d44d06489ad16ae735067ada030ff45cfe1b6dc0?src=pr=desc) will **increase** coverage by `0.72%`. > The diff coverage is `33.82%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=tree) ```diff @@ Coverage Diff@@ ## dev #1543 +/- ## + Coverage 7.76% 8.49% +0.72% Files272 275 +3 Lines 13641 13684 +43 Branches21662171 +5 + Hits10591162 +103 + Misses 12511 12446 -65 - Partials 71 76 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=tree) | Coverage Δ | | |---|---|---| | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `0.87% <0%> (+0.87%)` | :arrow_up: | | [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `0.36% <0%> (+0.36%)` | :arrow_up: | | [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `3.33% <0%> (+3.33%)` | :arrow_up: | | [...duler/api/interceptor/LoginHandlerInterceptor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2ludGVyY2VwdG9yL0xvZ2luSGFuZGxlckludGVyY2VwdG9yLmphdmE=) | `66.66% <100%> (+66.66%)` | :arrow_up: | | [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `100% <100%> (ø)` | | | [...nscheduler/api/security/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `50% <50%> (ø)` | | | [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `64.28% <64.28%> (ø)` | | | ... and [42 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=footer). Last update [d44d064...d079c50](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1543: Refactor login verification process
codecov-io commented on issue #1543: Refactor login verification process URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543#issuecomment-568450522 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=h1) Report > Merging [#1543](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/d44d06489ad16ae735067ada030ff45cfe1b6dc0?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=tree) ```diff @@ Coverage Diff@@ ## dev #1543 +/- ## - Coverage 7.76% 7.72% -0.04% Files272 275 +3 Lines 13641 13684 +43 Branches21662171 +5 - Hits10591057 -2 - Misses 12511 12556 +45 Partials 71 71 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=tree) | Coverage Δ | | |---|---|---| | [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...nscheduler/api/security/PasswordAuthenticator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1Bhc3N3b3JkQXV0aGVudGljYXRvci5qYXZh) | `0% <0%> (ø)` | | | [.../dolphinscheduler/api/security/SecurityConfig.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L1NlY3VyaXR5Q29uZmlnLmphdmE=) | `0% <0%> (ø)` | | | [...duler/api/interceptor/LoginHandlerInterceptor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2ludGVyY2VwdG9yL0xvZ2luSGFuZGxlckludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...lphinscheduler/api/controller/LoginController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvTG9naW5Db250cm9sbGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...phinscheduler/api/security/AuthenticationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlY3VyaXR5L0F1dGhlbnRpY2F0aW9uVHlwZS5qYXZh) | `0% <0%> (ø)` | | | [...ache/dolphinscheduler/common/enums/ZKNodeType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1pLTm9kZVR5cGUuamF2YQ==) | `0% <0%> (-100%)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=footer). Last update [d44d064...04823c2](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1543?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact
[GitHub] [incubator-dolphinscheduler] elonlo opened a new pull request #1543: Refactor login verification process
elonlo opened a new pull request #1543: Refactor login verification process URL: https://github.com/apache/incubator-dolphinscheduler/pull/1543 ## What is the purpose of the pull request Refactor login authentication process, use interface ## Brief change log - *AuthenticationType file to dolphinscheduler-api module* - *Add AuthenticationType file to dolphinscheduler-api module* - *Add Authenticator file to dolphinscheduler-api module* - *Add SecurityConfig file to dolphinscheduler-api module* - *Add PasswordAuthenticator file to dolphinscheduler-api module* - *Add LoginHandlerInterceptorTest file to dolphinscheduler-api module* - *Add SecurityConfigTest file to dolphinscheduler-api module* - *Add PasswordAuthenticatorTest file to dolphinscheduler-api module* - *Modify LoginHandlerInterceptor file* - *Modify LoginController file* - *Modify TenantService file* - *Modify UsersService file* ## Verify this pull request This change added tests and can be verified as follows: - *Added PasswordAuthenticatorTest to verify password authenticator.* - *Added LoginHandlerInterceptorTest to verify interceptor.* - *Add SecurityConfigTest to verify authenticator is available.* - *Manually verified the change by testing locally.* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1541: remove duplicated code
zjcnb commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568419423 > > > > > how about keeping the code the same ? > > > > > like : add TableField in Alert class > > > > > > > > > > > > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project > > > > > > > > > why did you keep it in AccessToken? I think we should keep the same manager . > > > > > > this project has @TableField annotation already， I didn't add it > > I mean : try to add @TableField in Alert class to keep code in the same style. ok! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code
Technoboy- commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568419069 > > > > how about keeping the code the same ? > > > > like : add TableField in Alert class > > > > > > > > > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project > > > > > > why did you keep it in AccessToken? I think we should keep the same manager . > > this project has @TableField annotation already， I didn't add it I mean : try to add @TableField in Alert class to keep code in the same style. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1541: remove duplicated code
zjcnb commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568418553 > > > how about keeping the code the same ? > > > like : add TableField in Alert class > > > > > > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project > > why did you keep it in AccessToken? I think we should keep the same manager . this project has @TableField annotation already， I didn't add it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1541: remove duplicated code
Technoboy- commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568417376 > > how about keeping the code the same ? > > like : add TableField in Alert class > > I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project why did you keep it in AccessToken? I think we should keep the same manager . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Yeleights commented on issue #1542: #1300 Add right alignment function in sql email content
Yeleights commented on issue #1542: #1300 Add right alignment function in sql email content URL: https://github.com/apache/incubator-dolphinscheduler/pull/1542#issuecomment-568410680 @qiaozhanwei @Technoboy- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] zjcnb commented on issue #1541: remove duplicated code
zjcnb commented on issue #1541: remove duplicated code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1541#issuecomment-568408410 > how about keeping the code the same ? > like : add TableField in Alert class I don't know，@TableField annotation，It is need to retain？ i think it's can remove for this project This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1542: #1300 Add right alignment function in sql email content
codecov-io commented on issue #1542: #1300 Add right alignment function in sql email content URL: https://github.com/apache/incubator-dolphinscheduler/pull/1542#issuecomment-568399614 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1542?src=pr=h1) Report > Merging [#1542](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1542?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/d44d06489ad16ae735067ada030ff45cfe1b6dc0?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1542?src=pr=tree) ```diff @@ Coverage Diff@@ ## dev #1542 +/- ## + Coverage 7.76% 7.79% +0.02% Files272 272 Lines 13641 13645 +4 Branches21662166 + Hits10591063 +4 Misses 12511 12511 Partials 71 71 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1542?src=pr=tree) | Coverage Δ | | |---|---|---| | [...pache/dolphinscheduler/alert/utils/ExcelUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1542/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FeGNlbFV0aWxzLmphdmE=) | `79.62% <100%> (+1.62%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1542?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1542?src=pr=footer). Last update [d44d064...abddf57](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1542?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Yeleights opened a new pull request #1542: #1300 Add right alignment function in sql email content
Yeleights opened a new pull request #1542: #1300 Add right alignment function in sql email content URL: https://github.com/apache/incubator-dolphinscheduler/pull/1542 ## *Tips* ## What is the purpose of the pull request *Add right alignment function in sql email content* ## Brief change log - *Modify alert.utils.ExcelUtils* - *Modify alert.resources.mail_templates.alert_mail_template.ftl* ## Verify this pull request This pull request is already covered by existing MailUtilsTest. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
