[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3305: [Test-3288][server] Fix github ci unit test oom
sonarcloud[bot] removed a comment on pull request #3305: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3305#issuecomment-663820002 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3305: [Test-3288][server] Fix github ci unit test oom
sonarcloud[bot] commented on pull request #3305: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3305#issuecomment-663822445 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3305: [Test-3288][server] Fix github ci unit test oom
sonarcloud[bot] commented on pull request #3305: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3305#issuecomment-663823128 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3305: [Test-3288][*] Test github action oom
sonarcloud[bot] removed a comment on pull request #3305: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3305#issuecomment-663809763 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3305: [Test-3288][*] Test github action oom
sonarcloud[bot] commented on pull request #3305: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3305#issuecomment-663820002 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3305: [Test-3288][server] Fix github ci unit test oom
sonarcloud[bot] removed a comment on pull request #3305: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3305#issuecomment-663822445 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3305=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3305=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3305=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] codecov-commenter commented on pull request #3305: [Test-3288][server] Fix github ci unit test oom
codecov-commenter commented on pull request #3305: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3305#issuecomment-663822158 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305?src=pr=h1) Report > Merging [#3305](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/e03f1e2dbe01f21909d1ad9a9dbb3bc39692e555=desc) will **increase** coverage by `0.06%`. > The diff coverage is `43.68%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305?src=pr=tree) ```diff @@ Coverage Diff @@ ##dev#3305 +/- ## + Coverage 34.20% 34.26% +0.06% - Complexity 2425 2458 +33 Files 443 444 +1 Lines 2063720670 +33 Branches 2531 2536 +5 + Hits 7058 7083 +25 - Misses1291512925 +10 + Partials664 662 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/dolphinscheduler/api/utils/ZookeeperMonitor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1pvb2tlZXBlck1vbml0b3IuamF2YQ==) | `6.45% <0.00%> (+0.20%)` | `2.00 <0.00> (ø)` | | | [...g/apache/dolphinscheduler/dao/utils/DagHelper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3V0aWxzL0RhZ0hlbHBlci5qYXZh) | `27.11% <0.00%> (-1.63%)` | `18.00 <0.00> (ø)` | | | [...heduler/server/entity/SQLTaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9TUUxUYXNrRXhlY3V0aW9uQ29udGV4dC5qYXZh) | `90.90% <ø> (+90.90%)` | `7.00 <0.00> (+7.00)` | | | [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...r/server/master/runner/MasterSchedulerService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyU2NoZWR1bGVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [.../dolphinscheduler/service/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQWJzdHJhY3RaS0NsaWVudC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...nscheduler/service/zk/ZookeeperCachedOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvWm9va2VlcGVyQ2FjaGVkT3BlcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...dolphinscheduler/service/zk/ZookeeperOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvWm9va2VlcGVyT3BlcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...inscheduler/service/zk/CuratorZookeeperClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3305/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvemsvQ3VyYXRvclpvb2tlZXBlckNsaWVudC5qYXZh) | `62.16% <62.16%> (ø)` | `7.00 <7.00> (?)` | | | ... and [32
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3241: [Feature-3189][alert,spi,dao,plugin-api] base code of dolphinscheduler spi and alert plugin implemen
yangyichao-mango commented on a change in pull request #3241: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3241#discussion_r460406059 ## File path: sql/upgrade/1.4.0_schema/mysql/dolphinscheduler_ddl.sql ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +SET sql_mode=(SELECT REPLACE(@@sql_mode,'ONLY_FULL_GROUP_BY','')); +DROP TABLE IF EXISTS `t_ds_plugin_define`; +CREATE TABLE `t_ds_plugin_define` ( + `id` int NOT NULL AUTO_INCREMENT, + `plugin_name` varchar(100) NOT NULL COMMENT 'the name of plugin eg: email', + `plugin_type` varchar(100) NOT NULL COMMENT 'plugin type . alert=alert plugin, job=job plugin', + `plugin_params` text COMMENT 'plugin params', + `create_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, + `update_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, + PRIMARY KEY (`id`), + UNIQUE KEY `t_ds_plugin_define_UN` (`plugin_name`,`plugin_type`) +) ENGINE=InnoDB AUTO_INCREMENT=2 DEFAULT CHARSET=utf8 Review comment: ```suggestion ) ENGINE=InnoDB AUTO_INCREMENT=2 DEFAULT CHARSET=utf8; ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3241: [Feature-3189][alert,spi,dao,plugin-api] base code of dolphinscheduler spi and alert plugin implemen
yangyichao-mango commented on a change in pull request #3241: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3241#discussion_r460406072 ## File path: sql/upgrade/1.4.0_schema/mysql/dolphinscheduler_ddl.sql ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +SET sql_mode=(SELECT REPLACE(@@sql_mode,'ONLY_FULL_GROUP_BY','')); +DROP TABLE IF EXISTS `t_ds_plugin_define`; +CREATE TABLE `t_ds_plugin_define` ( + `id` int NOT NULL AUTO_INCREMENT, + `plugin_name` varchar(100) NOT NULL COMMENT 'the name of plugin eg: email', + `plugin_type` varchar(100) NOT NULL COMMENT 'plugin type . alert=alert plugin, job=job plugin', + `plugin_params` text COMMENT 'plugin params', + `create_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, + `update_time` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, + PRIMARY KEY (`id`), + UNIQUE KEY `t_ds_plugin_define_UN` (`plugin_name`,`plugin_type`) +) ENGINE=InnoDB AUTO_INCREMENT=2 DEFAULT CHARSET=utf8 + +DROP TABLE IF EXISTS `t_ds_alert_plugin_instance`; +CREATE TABLE `t_ds_alert_plugin_instance` ( + `id` int NOT NULL AUTO_INCREMENT, + `plugin_define_id` int NOT NULL, + `plugin_instance_params` text COMMENT 'plugin instance params. Also contain the params value which user input in web ui.', + `create_time` timestamp NULL DEFAULT CURRENT_TIMESTAMP, + `update_time` timestamp NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, + `alert_group_id` int DEFAULT NULL, + `instance_name` varchar(200) DEFAULT NULL COMMENT 'alert instance name', + PRIMARY KEY (`id`) +) ENGINE=InnoDB DEFAULT CHARSET=utf8 Review comment: ```suggestion ) ENGINE=InnoDB DEFAULT CHARSET=utf8; ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3302: [Improvement]Replace GetPropertyAction
sonarcloud[bot] commented on pull request #3302: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3302#issuecomment-663857707 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3302=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3304: [FIX_BUG]fix test error
sonarcloud[bot] commented on pull request #3304: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3304#issuecomment-663857341 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3302: [Improvement]Replace GetPropertyAction
sonarcloud[bot] commented on pull request #3302: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3302#issuecomment-663860478 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3302=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3302: [Improvement]Replace GetPropertyAction
sonarcloud[bot] removed a comment on pull request #3302: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3302#issuecomment-663857707 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3302=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3302=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3302=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r40709 - in /dev/incubator/dolphinscheduler: ./ dolphinscheduler-maven-plugin/ dolphinscheduler-maven-plugin/1.0.0/
Author: gaojun2048 Date: Sat Jul 25 12:21:05 2020 New Revision: 40709 Log: release dolphinscheduler-maven-plugin 1.0.0 Added: dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/ dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/ dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip (with props) dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.asc (with props) dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.sha512 Modified: dev/incubator/dolphinscheduler/KEYS Modified: dev/incubator/dolphinscheduler/KEYS == Binary files - no diff available. Added: dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip == Binary file - no diff available. Propchange: dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip -- svn:mime-type = application/zip Added: dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.asc == Binary file - no diff available. Propchange: dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.asc -- svn:mime-type = application/pgp-signature Added: dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.sha512 == --- dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.sha512 (added) +++ dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.sha512 Sat Jul 25 12:21:05 2020 @@ -0,0 +1 @@ +3c81b71e57b30d0d87e8414af5a2c60cb80ad4c23f605dd847cb9e1a3a544e4a1147e011b3610ce19d77455b913fbf3675241ae7e6945b382bc090a4b1f9fb66 apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip
svn commit: r40710 - /dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/
Author: gaojun2048 Date: Sat Jul 25 13:04:17 2020 New Revision: 40710 Log: release dolphinscheduler maven plugin version 1.0.0 Modified: dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.asc dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.sha512 Modified: dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip == Binary files - no diff available. Modified: dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.asc == Binary files - no diff available. Modified: dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.sha512 == --- dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.sha512 (original) +++ dev/incubator/dolphinscheduler/dolphinscheduler-maven-plugin/1.0.0/apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip.sha512 Sat Jul 25 13:04:17 2020 @@ -1 +1 @@ -3c81b71e57b30d0d87e8414af5a2c60cb80ad4c23f605dd847cb9e1a3a544e4a1147e011b3610ce19d77455b913fbf3675241ae7e6945b382bc090a4b1f9fb66 apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip +43d81c0327a753d004bab6145eb1afd31bc39b603286c1c966db30faa79a3b09c59aa4b1c2596a1829860d0b739ca44ce3e43bcddaf2dfe40f3ad1022101c351 apache-dolphinscheduler-maven-plugin-incubating-1.0.0-src.zip
[GitHub] [incubator-dolphinscheduler] rockxsj closed pull request #3267: [feature]add presto datasource support
rockxsj closed pull request #3267: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3267 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] rockxsj opened a new pull request #3308: [Feature]add presto datasource support
rockxsj opened a new pull request #3308: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3308 ## *Tips* - *Thanks very much for contributing to Apache DolphinScheduler.* - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.* ## What is the purpose of the pull request update .gitigonre to igonre some files add presto datasource support ## Brief change log ``` log new file: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/PrestoDataSource.java modified: .gitignore modified: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java modified: dolphinscheduler-common/pom.xml modified: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java modified: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/DbType.java modified: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/BaseDataSource.java modified: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/DataSourceFactory.java modified: dolphinscheduler-ui/src/js/conf/home/pages/datasource/pages/list/_source/createDataSource.vue modified: dolphinscheduler-ui/src/js/conf/home/store/dag/state.js modified: dolphinscheduler-ui/src/js/conf/home/store/datasource/actions.js modified: pom.xml ``` ## Verify this pull request This pull request is already covered by existing tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-dolphinscheduler] branch dev updated: [Test-3288][server] Fix github ci unit test oom (#3305)
This is an automated email from the ASF dual-hosted git repository.
lidongdai pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 0577dc9 [Test-3288][server] Fix github ci unit test oom (#3305)
0577dc9 is described below
commit 0577dc97808226b2a5ef4b1fa5fc819b3a54095e
Author: Yichao Yang <1048262...@qq.com>
AuthorDate: Sat Jul 25 19:24:16 2020 +0800
[Test-3288][server] Fix github ci unit test oom (#3305)
* [Improvement] Test github action oom
* Optimize the test case performance
* Remove the unused import
---
.../server/master/MasterServer.java| 4 +-
.../server/master/runner/MasterExecThread.java | 14 +++--
.../master/runner/MasterSchedulerService.java | 23 +--
.../server/master/MasterExecThreadTest.java| 21 ---
.../consumer/TaskPriorityQueueConsumerTest.java| 18 +-
.../master/dispatch/ExecutorDispatcherTest.java| 2 +
.../dispatch/host/RoundRobinHostManagerTest.java | 1 +
.../server/master/registry/MasterRegistryTest.java | 1 +
.../master/runner/MasterTaskExecThreadTest.java| 71 --
.../server/registry/ZookeeperNodeManagerTest.java | 9 ++-
.../worker/processor/TaskCallbackServiceTest.java | 7 ++-
.../server/worker/registry/WorkerRegistryTest.java | 1 +
12 files changed, 109 insertions(+), 63 deletions(-)
diff --git
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
index d863742..e6c7792 100644
---
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
+++
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/MasterServer.java
@@ -123,8 +123,8 @@ public class MasterServer {
// self tolerant
this.zkMasterClient.start();
-//
-masterSchedulerService.start();
+// scheduler start
+this.masterSchedulerService.start();
// start QuartzExecutors
// what system should do if exception
diff --git
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java
index 4b5c3f7..177fb8a 100644
---
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java
+++
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java
@@ -35,7 +35,6 @@ import org.apache.dolphinscheduler.dao.utils.DagHelper;
import org.apache.dolphinscheduler.remote.NettyRemotingClient;
import org.apache.dolphinscheduler.server.master.config.MasterConfig;
import org.apache.dolphinscheduler.server.utils.AlertManager;
-import org.apache.dolphinscheduler.service.bean.SpringApplicationContext;
import org.apache.dolphinscheduler.service.process.ProcessService;
import org.apache.dolphinscheduler.service.quartz.cron.CronUtils;
import org.slf4j.Logger;
@@ -123,12 +122,12 @@ public class MasterExecThread implements Runnable {
/**
* alert manager
*/
-private AlertManager alertManager = new AlertManager();
+private AlertManager alertManager;
/**
* the object of DAG
*/
-private DAG dag;
+private DAG dag;
/**
* process service
@@ -151,15 +150,20 @@ public class MasterExecThread implements Runnable {
* @param processService processService
* @param nettyRemotingClient nettyRemotingClient
*/
-public MasterExecThread(ProcessInstance processInstance, ProcessService
processService, NettyRemotingClient nettyRemotingClient){
+public MasterExecThread(ProcessInstance processInstance
+, ProcessService processService
+, NettyRemotingClient nettyRemotingClient
+, AlertManager alertManager
+, MasterConfig masterConfig) {
this.processService = processService;
this.processInstance = processInstance;
-this.masterConfig =
SpringApplicationContext.getBean(MasterConfig.class);
+this.masterConfig = masterConfig;
int masterTaskExecNum = masterConfig.getMasterExecTaskNum();
this.taskExecService =
ThreadUtils.newDaemonFixedThreadExecutor("Master-Task-Exec-Thread",
masterTaskExecNum);
this.nettyRemotingClient = nettyRemotingClient;
+this.alertManager = alertManager;
}
diff --git
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterSchedulerService.java
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterSchedulerService.java
index
[GitHub] [incubator-dolphinscheduler] dailidong closed issue #3288: [Improvement][JUNIT TEST] Improvement UT OutOfMemory GC overhead limit
dailidong closed issue #3288: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #3305: [Test-3288][server] Fix github ci unit test oom
dailidong merged pull request #3305: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3305 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3308: [Feature]add presto datasource support
sonarcloud[bot] commented on pull request #3308: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3308#issuecomment-663847096 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3308=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3308=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3308=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3308=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3308=new_duplicated_lines_density=list) [5.7% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3308=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3306: [BUG FIX] issues #3256
sonarcloud[bot] commented on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-663927442 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3306: [BUG FIX] issues #3256
yangyichao-mango commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460470528
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
Hi, thx a lot for your contribution~
There are already the phone judge, so we do need to set the photo blank is
required.
You can just need to change the sql to `INSERT INTO `t_ds_user` VALUES ('1',
'admin', '7ad2410b2f4c074479a8937a28a22b8f', '0', 'x...@qq.com', '', '0',
'2018-03-27 15:48:50', '2018-10-24 17:40:22', null, 1);`
If you have any question or suggestion, welcome to put forward~
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] feloxx opened a new issue #3309: [Feature][del_zk] Use zookeeper own delete method.
feloxx opened a new issue #3309: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3309 **Describe the feature** Use zookeeper own delete method to replace the existing method. **Is your feature request related to a problem? Please describe.** Do not consider py, do not consider using java, it is too cumbersome. **Describe the solution you'd like** zookeeper comes with it, we just call it in the shell. **Describe alternatives you've considered** None. **Additional context** None. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3306: [BUG FIX] issues #3256
yangyichao-mango commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460470528
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
Hi,
There is the phone judge, so we do need to set the photo blank is required.
You can just need to change the sql to `INSERT INTO `t_ds_user` VALUES ('1',
'admin', '7ad2410b2f4c074479a8937a28a22b8f', '0', 'x...@qq.com', '', '0',
'2018-03-27 15:48:50', '2018-10-24 17:40:22', null, 1);`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3306: [BUG FIX] issues #3256
yangyichao-mango commented on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-663929122 Hi, Please change the title to `[Fix-3256][ui] Fix admin user info update error` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango edited a comment on pull request #3306: [BUG FIX] issues #3256
yangyichao-mango edited a comment on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-663929122 Hi, Please change the title to `[Fix-3256][ui] Fix admin user info update error`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [BUG FIX] issues #3256
wuchunfu commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460470915
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
I think it is also necessary to add `*` to remind
users of this required item
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] feloxx opened a new pull request #3310: use zk own del func
feloxx opened a new pull request #3310: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3310 # What is the purpose of the pull request **implementation #3309 ** # Brief change log *(for example:)* - *Add install_config zk root directory* - *Add install.sh zkRoot sed* - *Change remove-zk-node.sh use zk own del func* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [BUG FIX] issues #3256
wuchunfu commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460471038
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
I have modified the SQL file,
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3306: [BUG FIX] issues #3256
yangyichao-mango commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460471264
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
> I have modified the SQL file,
Hi~
If the mobile phone information is not currently used, there is no need to
set photo as a required field.
And we just need to change the sql to [1] to fix this bug, and not need to
insert an example photo number in sql [2].
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3306: [BUG FIX] issues #3256
yangyichao-mango commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460471264
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
> I have modified the SQL file,
Hi~
If the mobile phone information is not currently used, there is no need to
set photo as a required field.
And we just need to change the sql to [1], and not need to insert an example
photo number in sql [2].
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [BUG FIX] issues #3256
wuchunfu commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460471425
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
OK, I'll revise it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3310: use zk own del func
sonarcloud[bot] commented on pull request #3310: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3310#issuecomment-663930041 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3310=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3310=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3310=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3310=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3310=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3310=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3310=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3310=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3310=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3310=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3310=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3310=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3310=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [BUG FIX] issues #3256
wuchunfu commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460471704
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
I have revised and submitted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3306: [Fix-3256][ui] Fix admin user info update error
yangyichao-mango commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460471871
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
> I have revised and submitted.
Good job.
I think we also need to revert the `` changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] wuchunfu commented on issue #3309: [Feature][del_zk] Use zookeeper own delete method.
wuchunfu commented on issue #3309: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3309#issuecomment-663930288 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3304: [FIX_BUG]fix test error
yangyichao-mango commented on pull request #3304: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3304#issuecomment-663930130 Hi, Please change the title to `[Test][server] Fix TaskPriorityQueueConsumerTest ContextConfiguration error`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3306: [Fix-3256][ui] Fix admin user info update error
yangyichao-mango commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460471871
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
> I have revised and submitted.
Good job.
I think we also need to revert the changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3306: [Fix-3256][ui] Fix admin user info update error
sonarcloud[bot] commented on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-663930603 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3306: [Fix-3256][ui] Fix admin user info update error
yangyichao-mango commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460472328
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
> Do you want to remove `*`?
Hi,
I think we do not need add `*`, because the phone is not
required field, and `*` means required field.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [Fix-3256][ui] Fix admin user info update error
wuchunfu commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460472181
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
Do you want to remove `*`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3306: [Fix-3256][ui] Fix admin user info update error
sonarcloud[bot] removed a comment on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-663927442 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] wa-ooo commented on issue #3177: [BUG] The shellTask scheduler reruns the date expression in the script to the current system time
wa-ooo commented on issue #3177: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3177#issuecomment-663930809 > This parameter will only return the current timestamp. What you said should be the function of `supplementing data`. > > For example, when a user needs to rerun the task of the previous day or supplement data of the previous day , the user just wants this parameter of the previous day's time. Is this the scene you are referring to? Yes, it is easier to use if you rerun the working instance directly without modifying the script This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [Fix-3256][ui] Fix admin user info update error
wuchunfu commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460472668
##
File path:
dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue
##
@@ -84,7 +84,7 @@
- {{$t('Phone')}}
+ *{{$t('Phone')}}
Review comment:
I have deleted and submitted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3306: [Fix-3256][ui] Fix admin user info update error
sonarcloud[bot] removed a comment on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-663930603 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3306: [Fix-3256][ui] Fix admin user info update error
sonarcloud[bot] commented on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-663931404 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3306: [Fix-3256][ui] Fix admin user info update error
yangyichao-mango commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460473384
##
File path: sql/dolphinscheduler-postgre.sql
##
@@ -752,7 +752,7 @@ ALTER TABLE t_ds_worker_server ALTER COLUMN id SET DEFAULT
NEXTVAL('t_ds_worker_
-- Records of t_ds_user?user : admin , password : dolphinscheduler123
-INSERT INTO
t_ds_user(user_name,user_password,user_type,email,phone,tenant_id,state,create_time,update_time)
VALUES ('admin', '7ad2410b2f4c074479a8937a28a22b8f', '0', 'x...@qq.com', 'xx',
'0', 1, '2018-03-27 15:48:50', '2018-10-24 17:40:22');
+INSERT INTO
t_ds_user(user_name,user_password,user_type,email,phone,tenant_id,state,create_time,update_time)
VALUES ('admin', '7ad2410b2f4c074479a8937a28a22b8f', '0', 'x...@qq.com', '',
'0', 1, '2018-03-27 15:48:50', '2018-10-24 17:40:22');
Review comment:
Very good job,
Sorry about I didn't notice that these two places before, and these tow
places also need to be changed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] wuchunfu commented on a change in pull request #3306: [Fix-3256][ui] Fix admin user info update error
wuchunfu commented on a change in pull request #3306:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3306#discussion_r460473715
##
File path: sql/dolphinscheduler-postgre.sql
##
@@ -752,7 +752,7 @@ ALTER TABLE t_ds_worker_server ALTER COLUMN id SET DEFAULT
NEXTVAL('t_ds_worker_
-- Records of t_ds_user?user : admin , password : dolphinscheduler123
-INSERT INTO
t_ds_user(user_name,user_password,user_type,email,phone,tenant_id,state,create_time,update_time)
VALUES ('admin', '7ad2410b2f4c074479a8937a28a22b8f', '0', 'x...@qq.com', 'xx',
'0', 1, '2018-03-27 15:48:50', '2018-10-24 17:40:22');
+INSERT INTO
t_ds_user(user_name,user_password,user_type,email,phone,tenant_id,state,create_time,update_time)
VALUES ('admin', '7ad2410b2f4c074479a8937a28a22b8f', '0', 'x...@qq.com', '',
'0', 1, '2018-03-27 15:48:50', '2018-10-24 17:40:22');
Review comment:
I have deleted and submitted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3306: [Fix-3256][ui] Fix admin user info update error
sonarcloud[bot] removed a comment on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-663931404 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3306: [Fix-3256][ui] Fix admin user info update error
sonarcloud[bot] commented on pull request #3306: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3306#issuecomment-663932469 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3306=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3306=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3306=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #3304: [Test][server] Fix TaskPriorityQueueConsumerTest ContextConfiguration error.
CalvinKirs commented on pull request #3304: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3304#issuecomment-663932986 > Please add the unused test cased `TaskPriorityQueueConsumerTest`. >  done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3304: [Test][server] Fix TaskPriorityQueueConsumerTest ContextConfiguration error.
sonarcloud[bot] commented on pull request #3304: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3304#issuecomment-663933539 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3304: [Test][server] Fix TaskPriorityQueueConsumerTest ContextConfiguration error.
sonarcloud[bot] removed a comment on pull request #3304: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3304#issuecomment-663857341 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] wuchunfu commented on issue #193: Support scheduling by calendar(支持按日历调度)
wuchunfu commented on issue #193: URL: https://github.com/apache/incubator-dolphinscheduler/issues/193#issuecomment-663933422 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3304: [Test][server] Fix TaskPriorityQueueConsumerTest ContextConfiguration error.
sonarcloud[bot] commented on pull request #3304: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3304#issuecomment-663933715 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3304: [Test][server] Fix TaskPriorityQueueConsumerTest ContextConfiguration error.
sonarcloud[bot] removed a comment on pull request #3304: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3304#issuecomment-663933539 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #3308: [Feature]add presto datasource support
CalvinKirs commented on pull request #3308: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3308#issuecomment-663934751 Good job, adding a new jar requires sending an email to dev and getting approval from PPMC. At the same time, you can refer to the following article to check by yourself first. https://github.com/apache/incubator-dolphinscheduler-website/blob/master/docs/zh-cn/development/DS-License.md This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3304: [Test][server] Fix Test ContextConfiguration error.
sonarcloud[bot] commented on pull request #3304: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3304#issuecomment-663934818 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3304: [Test][server] Fix Test ContextConfiguration error.
sonarcloud[bot] removed a comment on pull request #3304: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3304#issuecomment-663933715 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje ct/issues?id=apache-dolphinscheduler=3304=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=3304=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=3304=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango opened a new issue #3311: [Feature][alert] Improvement of the plugin-able alert group function
yangyichao-mango opened a new issue #3311: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3311 **Describe the feature** Improvement of the alert group function to support plugin-able alert group, in the alert group, an alert instance can be created based on the existing alert plug-in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3311: [Feature][alert] Improvement of the plugin-able alert group function
yangyichao-mango commented on issue #3311: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3311#issuecomment-663935508 I'm working on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
