svn commit: r40204 - /release/incubator/dolphinscheduler/KEYS
Author: leonbao Date: Sun Jun 28 06:34:50 2020 New Revision: 40204 Log: transfer KEYS for 1.3.0 Added: release/incubator/dolphinscheduler/KEYS - copied unchanged from r40203, dev/incubator/dolphinscheduler/KEYS
svn commit: r40203 - /release/incubator/dolphinscheduler/KEYS
Author: leonbao Date: Sun Jun 28 06:34:19 2020 New Revision: 40203 Log: delete KEYS Removed: release/incubator/dolphinscheduler/KEYS
[GitHub] [incubator-dolphinscheduler] whitelowrie opened a new issue #3064: [BUG] com.sun.jna.platform.win32.Win32Exception: 占位程序接收到错误数据。when the WorkerServer work in the Windows
whitelowrie opened a new issue #3064: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3064 When I'm running the workerServer in Windows 10 System，I schedule a simple program like `dir` then the task run fail，and get some exception  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
svn commit: r40202 - /dev/incubator/dolphinscheduler/1.3.0/ /release/incubator/dolphinscheduler/1.3.0/
Author: leonbao Date: Sun Jun 28 06:08:25 2020 New Revision: 40202 Log: transfer packages for 1.3.0 Added: release/incubator/dolphinscheduler/1.3.0/ - copied from r40201, dev/incubator/dolphinscheduler/1.3.0/ Removed: dev/incubator/dolphinscheduler/1.3.0/
svn commit: r40200 - /release/incubator/dolphinscheduler/KEYS
Author: leonbao Date: Sun Jun 28 06:07:48 2020 New Revision: 40200 Log: delete KEYS Removed: release/incubator/dolphinscheduler/KEYS
svn commit: r40201 - /release/incubator/dolphinscheduler/KEYS
Author: leonbao Date: Sun Jun 28 06:08:13 2020 New Revision: 40201 Log: transfer KEYS for 1.3.0 Added: release/incubator/dolphinscheduler/KEYS - copied unchanged from r40200, dev/incubator/dolphinscheduler/KEYS
[GitHub] [incubator-dolphinscheduler-website] CalvinKirs commented on pull request #135: add DS-License.md
CalvinKirs commented on pull request #135: URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/135#issuecomment-650696761 @dailidong Thank you very much for your review, I have completed the changes, please check again This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hlzhu1983 opened a new issue #3063: [QUESTION] worker get yarn application status failed
hlzhu1983 opened a new issue #3063: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3063 1.worker log  2.worker conf  3.yarn app stauts  How can I solve this problem? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong closed issue #3033: [QUESTION] how to add a worker server
dailidong closed issue #3033: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong closed issue #2984: [QUESTION] question title
dailidong closed issue #2984: URL: https://github.com/apache/incubator-dolphinscheduler/issues/2984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2984: [QUESTION] question title
dailidong commented on issue #2984: URL: https://github.com/apache/incubator-dolphinscheduler/issues/2984#issuecomment-650691303 > > dolphinscheduler just executes the start command, > > Services like datax need to be deployed by themselves. > > not happy, 囧. datax has so many dependencies which may not compitable with apache v2 license , so we can' t put datax installation package into DolphinScheduler This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong closed issue #2868: [QUESTION] python path and version different
dailidong closed issue #2868: URL: https://github.com/apache/incubator-dolphinscheduler/issues/2868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #2868: [QUESTION] python path and version different
dailidong commented on issue #2868: URL: https://github.com/apache/incubator-dolphinscheduler/issues/2868#issuecomment-650690783 no reponse from user, temporarily close This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zhangchunyang1024 commented on a change in pull request #3031: [feature] readme.md adds instructions for changing environment variables
zhangchunyang1024 commented on a change in pull request #3031: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3031#discussion_r446596093 ## File path: ambari_plugin/README.md ## @@ -16,8 +17,12 @@ 3. Install with rpm package - Manual installation (recommended）： - - Copy the prepared RPM packages to each node of the cluster - - Execute with DS installation user: ```rpm -ivh apache-dolphinscheduler-incubating-xxx.noarch.rpm``` + - Copy the prepared RPM packages to each node of the cluster. + - Execute with DS installation user: ```rpm -ivh apache-dolphinscheduler-incubating-xxx.noarch.rpm``` + - Mysql-connector-java packaged using the default POM file will not be included. + - The RPM package was packaged in the project with the installation path of /opt/soft. +If you use mysql as the database, you need add it manually. Review comment: Yeah. Mysql's non-Apache protocol does not provide the JAR package containing the mysql-Connector. When making the RPM package with the plug-in in the project, the POM file can be modified to include the lib mysql-Connecto in the RPM package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-dolphinscheduler] branch dev-1.3.0 updated: [bugfix] remove Conflicting configuration sudo and user (#3038)
This is an automated email from the ASF dual-hosted git repository.
lgcareer pushed a commit to branch dev-1.3.0
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev-1.3.0 by this push:
new 39b3a37 [bugfix] remove Conflicting configuration sudo and user
(#3038)
39b3a37 is described below
commit 39b3a37abdb1bed088e5494de41769c1862acac8
Author: zhangchunyang
AuthorDate: Sun Jun 28 11:37:59 2020 +0800
[bugfix] remove Conflicting configuration sudo and user (#3038)
Co-authored-by: zhangchunyang1024
---
.../DOLPHIN/1.3.0/package/scripts/dolphin_alert_service.py| 3 ++-
.../DOLPHIN/1.3.0/package/scripts/dolphin_api_service.py | 3 ++-
.../DOLPHIN/1.3.0/package/scripts/dolphin_logger_service.py | 4 ++--
.../DOLPHIN/1.3.0/package/scripts/dolphin_master_service.py | 3 ++-
.../DOLPHIN/1.3.0/package/scripts/dolphin_worker_service.py | 3 ++-
5 files changed, 10 insertions(+), 6 deletions(-)
diff --git
a/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_alert_service.py
b/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_alert_service.py
index 62255a3..e78c38d 100644
---
a/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_alert_service.py
+++
b/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_alert_service.py
@@ -26,7 +26,8 @@ class DolphinAlertService(Script):
import params
env.set_params(params)
self.install_packages(env)
-Execute(('chmod', '-R', '777', params.dolphin_home),
user=params.dolphin_user, sudo=True)
+Execute(('chmod', '-R', '777', params.dolphin_home))
+Execute(('chown', '-R', params.dolphin_user + ":" +
params.dolphin_group, params.dolphin_home))
def configure(self, env):
import params
diff --git
a/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_api_service.py
b/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_api_service.py
index bdc18fb..5a28924 100644
---
a/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_api_service.py
+++
b/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_api_service.py
@@ -26,7 +26,8 @@ class DolphinApiService(Script):
import params
env.set_params(params)
self.install_packages(env)
-Execute(('chmod', '-R', '777', params.dolphin_home),
user=params.dolphin_user, sudo=True)
+Execute(('chmod', '-R', '777', params.dolphin_home))
+Execute(('chown', '-R', params.dolphin_user + ":" +
params.dolphin_group, params.dolphin_home))
def configure(self, env):
import params
diff --git
a/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_logger_service.py
b/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_logger_service.py
index f1c19bd..fb47e13 100644
---
a/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_logger_service.py
+++
b/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_logger_service.py
@@ -26,8 +26,8 @@ class DolphinLoggerService(Script):
import params
env.set_params(params)
self.install_packages(env)
-Execute(('chmod', '-R', '777', params.dolphin_home),
user=params.dolphin_user, sudo=True)
-
+Execute(('chmod', '-R', '777', params.dolphin_home))
+Execute(('chown', '-R', params.dolphin_user + ":" +
params.dolphin_group, params.dolphin_home))
def configure(self, env):
import params
params.pika_slave = True
diff --git
a/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_master_service.py
b/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_master_service.py
index 6ee7ecf..8d64935 100644
---
a/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_master_service.py
+++
b/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_master_service.py
@@ -27,7 +27,8 @@ class DolphinMasterService(Script):
import params
env.set_params(params)
self.install_packages(env)
-Execute(('chmod', '-R', '777', params.dolphin_home),
user=params.dolphin_user, sudo=True)
+Execute(('chmod', '-R', '777', params.dolphin_home))
+Execute(('chown', '-R', params.dolphin_user + ":" +
params.dolphin_group, params.dolphin_home))
def configure(self, env):
import params
diff --git
a/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_worker_service.py
b/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_worker_service.py
index 2d145ee..1f542c0 100644
---
a/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_worker_service.py
+++
b/ambari_plugin/common-services/DOLPHIN/1.3.0/package/scripts/dolphin_worker_service.py
@@ -26,7 +26,8
[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #3038: [bugfix] remove Conflicting configuration sudo and user
lgcareer merged pull request #3038: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3038 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] break60 commented on issue #3058: [BUG] 1.3.0 branch The task running order in the process instance does not follow the topological order in the process definitio
break60 commented on issue #3058: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3058#issuecomment-650684642 Regarding the front-end cache, the front-end currently adds a version number when compiling, and it is still being tested. This problem will not occur in versions after 1.3.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #2884: batch copy or move process #2753
sonarcloud[bot] commented on pull request #2884: URL: https://github.com/apache/incubator-dolphinscheduler/pull/2884#issuecomment-650679955 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [70.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #2884: batch copy or move process #2753
sonarcloud[bot] removed a comment on pull request #2884: URL: https://github.com/apache/incubator-dolphinscheduler/pull/2884#issuecomment-650677868 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [70.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #2884: batch copy or move process #2753
sonarcloud[bot] commented on pull request #2884: URL: https://github.com/apache/incubator-dolphinscheduler/pull/2884#issuecomment-650677868 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [70.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #2884: batch copy or move process #2753
sonarcloud[bot] removed a comment on pull request #2884: URL: https://github.com/apache/incubator-dolphinscheduler/pull/2884#issuecomment-650674373 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [70.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hlzhu1983 commented on issue #3061: [QUESTION] task submit succuess but can't continue
hlzhu1983 commented on issue #3061:
URL:
https://github.com/apache/incubator-dolphinscheduler/issues/3061#issuecomment-650676574
[INFO] 2020-06-28 10:17:43.736
org.apache.dolphinscheduler.server.master.runner.MasterSchedulerService:[132] -
find one command: id: 167, type: START_PROCESS
[INFO] 2020-06-28 10:17:43.748
org.apache.dolphinscheduler.server.master.runner.MasterSchedulerService:[140] -
start master exec thread , split DAG ...
[INFO] 2020-06-28 10:17:43.757
org.apache.dolphinscheduler.server.master.runner.MasterExecThread:[331] -
prepare process :166 end
[INFO] 2020-06-28 10:17:43.762
org.apache.dolphinscheduler.server.master.runner.MasterExecThread:[930] - add
task to stand by list: pre
[INFO] 2020-06-28 10:17:43.763
org.apache.dolphinscheduler.server.master.runner.MasterExecThread:[939] -
remove task from stand by list: pre
[INFO] 2020-06-28 10:17:43.770
org.apache.dolphinscheduler.service.process.ProcessService:[833] - start submit
task : pre, instance id:166, state: RUNNING_EXEUTION
[INFO] 2020-06-28 10:17:43.772
org.apache.dolphinscheduler.service.process.ProcessService:[846] - end submit
task to db successfully:pre state:SUBMITTED_SUCCESS complete, instance id:166
state: RUNNING_EXEUTION
[INFO] 2020-06-28 10:17:43.775
org.apache.dolphinscheduler.server.master.runner.MasterTaskExecThread:[179] -
task ready to submit: TaskInstance{id=222, name='pre', taskType='SHELL',
processDefinitionId=5, processInstanceId=166, processInstanceName='null',
taskJson='{"conditionResult":"{\"successNode\":[\"\"],\"failedNode\":[\"\"]}","conditionsTask":false,"depList":[],"dependence":"{}","forbidden":false,"id":"tasks-43366","maxRetryTimes":0,"name":"pre","params":"{\"rawScript\":\"hive
-f
jkm/pre.hql\",\"localParams\":[],\"resourceList\":[{\"res\":\"jkm/pre.hql\",\"name\":\"pre.hql\",\"id\":35}]}","preTasks":"[]","retryInterval":1,"runFlag":"NORMAL","taskInstancePriority":"MEDIUM","taskTimeoutParameter":{"enable":false,"interval":0},"timeout":"{\"enable\":false,\"strategy\":\"\"}","type":"SHELL","workerGroup":"default"}',
state=SUBMITTED_SUCCESS, submitTime=Sun Jun 28 10:17:43 CST 2020,
startTime=Sun Jun 28 10:17:43 CST 2020, endTime=null, host='null',
executePath='null', logPath='null', retryTimes=0, alertFlag=NO,
processInstance=null, processDefine=null, pid=0, appLink='null', flag=YES,
dependency='null', duration=null, maxRetryTimes=0, retryInterval=1,
taskInstancePriority=MEDIUM, processInstancePriority=MEDIUM,
dependentResult='null', workerGroup='default', executorId=2,
executorName='null'}
[INFO] 2020-06-28 10:17:43.776
org.apache.dolphinscheduler.server.master.runner.MasterTaskExecThread:[190] -
master submit success, task : pre
[INFO] 2020-06-28 10:17:43.779
org.apache.dolphinscheduler.server.master.runner.MasterTaskExecThread:[123] -
wait task: process id: 166, task id:222, task name:pre complete
[ERROR] 2020-06-28 10:33:16.456
org.apache.dolphinscheduler.remote.handler.NettyClientHandler:[173] -
exceptionCaught : {}
java.io.IOException: Connection timed out
at sun.nio.ch.FileDispatcherImpl.read0(Native Method)
at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39)
at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
at sun.nio.ch.IOUtil.read(IOUtil.java:192)
at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380)
at
io.netty.buffer.PooledUnsafeDirectByteBuf.setBytes(PooledUnsafeDirectByteBuf.java:288)
at io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:1132)
at
io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:347)
at
io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:148)
at
io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:677)
at
io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:612)
at
io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:529)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:491)
at
io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:905)
at java.lang.Thread.run(Thread.java:748)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] feiyalun commented on issue #3062: It is recommended to modify some of the 1.3.0 table field types
feiyalun commented on issue #3062: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3062#issuecomment-650676679 部分字段长度类型不够，我建议修改一下，因为工作流中一旦有500+task，维护表关系就会报错 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] feiyalun opened a new issue #3062: It is recommended to modify some of the 1.3.0 table field types
feiyalun opened a new issue #3062: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3062 Some of the field length types are not sufficient, and I recommend that they be modified, because once there are 500+ tasks in the workflow, the maintenance of table relationships will report an error ALTER TABLE t_ds_task_instance CHANGE app_link app_link text COMMENT 'yarn app id'; ALTER TABLE t_ds_process_definition CHANGE connects connects longtext COMMENT 'Node connection information'; ALTER TABLE t_ds_process_definition CHANGE locations locations longtext COMMENT 'Node location information'; ALTER TABLE t_ds_process_instance CHANGE connects connects longtext COMMENT 'Node connection information'; ALTER TABLE t_ds_process_instance CHANGE locations locations longtext COMMENT 'Node location information'; This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-dolphinscheduler] branch dev updated: Revise annotation spelling errors & Enhanced code robustness (#3042)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 9bf67d8 Revise annotation spelling errors & Enhanced code robustness
(#3042)
9bf67d8 is described below
commit 9bf67d80d0db866d2ead7fce1b9d33767ee0f66e
Author: zixi0825 <649790...@qq.com>
AuthorDate: Sun Jun 28 10:48:14 2020 +0800
Revise annotation spelling errors & Enhanced code robustness (#3042)
* revise annotation spelling errors & enhanced code robustness
* revise annotation spelling errors & enhanced code robustness
Co-authored-by: sunchaohe
Co-authored-by: dailidong
Co-authored-by: qiaozhanwei
---
.../dolphinscheduler/api/utils/CheckUtils.java | 2 +-
.../dolphinscheduler/remote/command/TaskInfo.java | 2 +-
.../server/entity/TaskExecutionContext.java| 2 +-
.../worker/processor/NettyRemoteChannel.java | 2 +-
.../worker/processor/TaskCallbackService.java | 5 +-
.../worker/processor/TaskExecuteProcessor.java | 14 --
.../worker/processor/TaskCallbackServiceTest.java | 56 --
7 files changed, 68 insertions(+), 15 deletions(-)
diff --git
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/CheckUtils.java
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/CheckUtils.java
index 9c3bbe9..9dee69b 100644
---
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/CheckUtils.java
+++
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/CheckUtils.java
@@ -115,7 +115,7 @@ public class CheckUtils {
*
* @param parameter parameter
* @param taskType task type
- * @return true if taks node parameters are valid, otherwise return false
+ * @return true if task node parameters are valid, otherwise return false
*/
public static boolean checkTaskNodeParameters(String parameter, String
taskType) {
AbstractParameters abstractParameters =
TaskParametersUtils.getParameters(taskType, parameter);
diff --git
a/dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/TaskInfo.java
b/dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/TaskInfo.java
index 196d0a7..1adf5a8 100644
---
a/dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/TaskInfo.java
+++
b/dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/command/TaskInfo.java
@@ -34,7 +34,7 @@ public class TaskInfo implements Serializable{
/**
- * taks name
+ * task name
*/
private String taskName;
diff --git
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/entity/TaskExecutionContext.java
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/entity/TaskExecutionContext.java
index 7b4c721..3fc65c1 100644
---
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/entity/TaskExecutionContext.java
+++
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/entity/TaskExecutionContext.java
@@ -39,7 +39,7 @@ public class TaskExecutionContext implements Serializable{
/**
- * taks name
+ * task name
*/
private String taskName;
diff --git
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/NettyRemoteChannel.java
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/NettyRemoteChannel.java
index cbb8972..b1b67af 100644
---
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/NettyRemoteChannel.java
+++
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/NettyRemoteChannel.java
@@ -34,7 +34,7 @@ public class NettyRemoteChannel {
private final Channel channel;
/**
- * equest unique identification
+ * request unique identification
*/
private final long opaque;
diff --git
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackService.java
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackService.java
index 1e8bf9d..0fe7524 100644
---
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackService.java
+++
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackService.java
@@ -17,7 +17,6 @@
package org.apache.dolphinscheduler.server.worker.processor;
-
import io.netty.channel.Channel;
import io.netty.channel.ChannelFuture;
import io.netty.channel.ChannelFutureListener;
@@ -33,14 +32,12 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFacto
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3042: Revise annotation spelling errors & Enhanced code robustness
sonarcloud[bot] removed a comment on pull request #3042: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3042#issuecomment-650564171 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_coverage&view=list) [72.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xingchun-chen closed issue #3058: [BUG] 1.3.0 branch The task running order in the process instance does not follow the topological order in the process definitio
xingchun-chen closed issue #3058: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3042: Revise annotation spelling errors & Enhanced code robustness
sonarcloud[bot] commented on pull request #3042: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3042#issuecomment-650676461 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_coverage&view=list) [72.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3042: Revise annotation spelling errors & Enhanced code robustness
qiaozhanwei merged pull request #3042: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3042 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hlzhu1983 opened a new issue #3061: [QUESTION] task submit succuess but can't continue
hlzhu1983 opened a new issue #3061: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3061 master log as follow  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hlzhu1983 commented on issue #3058: [BUG] 1.3.0 branch The task running order in the process instance does not follow the topological order in the process definit
hlzhu1983 commented on issue #3058: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3058#issuecomment-650675662 that's right! thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #5: Dev
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/incubator-dolphinscheduler/pull/5#issuecomment-650674870 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5&metric=duplicated_lines_density&view=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #5: Dev
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/incubator-dolphinscheduler/pull/5#issuecomment-650673721 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5&metric=duplicated_lines_density&view=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #3059: [BUG] Workflow definition display exception
xingchun-chen commented on issue #3059: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3059#issuecomment-650674613 This is because the arrow icon is clicked and the Bezier line is selected, which is caused by the component This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xiaoning123456 opened a new issue #3060: Abnormal situation of cluster time display
xiaoning123456 opened a new issue #3060: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3060 dolphinscheduler版本：1.2.0版本 工作人员：技术人员； 问题：集群监控中心那边master服务那边显示的心跳时间比北京时间快了5个小时，集群是3节点的，其中一个节点的心跳时间显示的是正常，另外两个的心跳时间比北京时间快了5个小时   ，检查集群服务器时间及时区，数据库时间都是正常的，请问这是为什么 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #2884: batch copy or move process #2753
sonarcloud[bot] commented on pull request #2884: URL: https://github.com/apache/incubator-dolphinscheduler/pull/2884#issuecomment-650674373 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [70.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #2884: batch copy or move process #2753
sonarcloud[bot] removed a comment on pull request #2884: URL: https://github.com/apache/incubator-dolphinscheduler/pull/2884#issuecomment-648780757 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=2884&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [65.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=2884&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] BoYiZhang opened a new issue #3059: [BUG] Workflow definition display exception
BoYiZhang opened a new issue #3059: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3059  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #5: Dev
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/incubator-dolphinscheduler/pull/5#issuecomment-650673721 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5&metric=duplicated_lines_density&view=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #5: Dev
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/incubator-dolphinscheduler/pull/5#issuecomment-647259018 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=5&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-dolphinscheduler] branch dev updated: [WIP] load balance #3054 (#3057)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 8213da5 [WIP] load balance #3054 (#3057)
8213da5 is described below
commit 8213da50d39ebea00d3d4dfdbcbca51107103157
Author: CalvinKirs
AuthorDate: Sun Jun 28 10:20:59 2020 +0800
[WIP] load balance #3054 (#3057)
* Load balancing abstract
* code
smell
* lower weight select
---
...undRobinSelector.java => AbstractSelector.java} | 25 --
.../host/assign/LowerWeightRoundRobin.java | 4 ++--
.../dispatch/host/assign/RandomSelector.java | 15 ++---
.../dispatch/host/assign/RoundRobinSelector.java | 14 ++--
4 files changed, 15 insertions(+), 43 deletions(-)
diff --git
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/RoundRobinSelector.java
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/AbstractSelector.java
similarity index 72%
copy from
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/RoundRobinSelector.java
copy to
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/AbstractSelector.java
index 1eb30c8..8560da9 100644
---
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/RoundRobinSelector.java
+++
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/AbstractSelector.java
@@ -16,23 +16,18 @@
*/
package org.apache.dolphinscheduler.server.master.dispatch.host.assign;
-import org.springframework.stereotype.Service;
+import org.apache.dolphinscheduler.common.utils.CollectionUtils;
import java.util.Collection;
-import java.util.concurrent.atomic.AtomicInteger;
/**
- * round robin selector
- * @param T
+ * AbstractSelector
*/
-@Service
-public class RoundRobinSelector implements Selector {
-
-private final AtomicInteger index = new AtomicInteger(0);
-
+public abstract class AbstractSelector implements Selector{
@Override
public T select(Collection source) {
-if (source == null || source.size() == 0) {
+
+if (CollectionUtils.isEmpty(source)) {
throw new IllegalArgumentException("Empty source.");
}
@@ -42,11 +37,9 @@ public class RoundRobinSelector implements Selector {
if (source.size() == 1) {
return (T)source.toArray()[0];
}
-
-int size = source.size();
-/**
- * round robin
- */
-return (T) source.toArray()[index.getAndIncrement() % size];
+return doSelect(source);
}
+
+protected abstract T doSelect(Collection source);
+
}
diff --git
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/LowerWeightRoundRobin.java
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/LowerWeightRoundRobin.java
index bdf0f41..843397e 100644
---
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/LowerWeightRoundRobin.java
+++
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/LowerWeightRoundRobin.java
@@ -22,7 +22,7 @@ import java.util.Collection;
/**
* lower weight round robin
*/
-public class LowerWeightRoundRobin implements Selector{
+public class LowerWeightRoundRobin extends AbstractSelector{
/**
* select
@@ -30,7 +30,7 @@ public class LowerWeightRoundRobin implements
Selector{
* @return HostWeight
*/
@Override
-public HostWeight select(Collection sources){
+public HostWeight doSelect(Collection sources){
int totalWeight = 0;
int lowWeight = 0;
HostWeight lowerNode = null;
diff --git
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/RandomSelector.java
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/RandomSelector.java
index be52fcb..e00d6f7 100644
---
a/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/RandomSelector.java
+++
b/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/assign/RandomSelector.java
@@ -24,23 +24,12 @@ import java.util.Random;
* random selector
* @param T
*/
-public class RandomSelector implements Selector {
+public class RandomSelector extends AbstractSelector {
private final Random random = new Random();
@Override
-public T select(final Collection source) {
-
-if (source =
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3057: [WIP] load balance #3054
qiaozhanwei merged pull request #3057: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3057 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong closed issue #624: Consultation: Scheduled scheduled tasks cannot be online（咨询：调度定时任务不能上线）
dailidong closed issue #624: URL: https://github.com/apache/incubator-dolphinscheduler/issues/624 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong edited a comment on issue #624: Consultation: Scheduled scheduled tasks cannot be online（咨询：调度定时任务不能上线）
dailidong edited a comment on issue #624: URL: https://github.com/apache/incubator-dolphinscheduler/issues/624#issuecomment-650673051 no response , close the issue temporarily，if have new issue, please reopen it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #624: Consultation: Scheduled scheduled tasks cannot be online（咨询：调度定时任务不能上线）
dailidong commented on issue #624: URL: https://github.com/apache/incubator-dolphinscheduler/issues/624#issuecomment-650673051 no response , close the issue temporarily This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #202: Ali nail, WeChat alarm（阿里钉钉、微信告警）
dailidong commented on issue #202: URL: https://github.com/apache/incubator-dolphinscheduler/issues/202#issuecomment-650672582 https://github.com/apache/incubator-dolphinscheduler/pull/2594 support Ali nail alarm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #3058: [BUG] 1.3.0 branch The task running order in the process instance does not follow the topological order in the process def
xingchun-chen commented on issue #3058: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3058#issuecomment-650672039 Please check the preTasks field value of the database table t_ds_process_definition.process_definition_json，If the preTasks are empty, it should be caused by not clearing the cache when creating the workflow definition. You can clear the browser cache and re-edit the workflow definition This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hlzhu1983 opened a new issue #3058: [BUG] 1.3.0 branch The task running order in the process instance does not follow the topological order in the process definit
hlzhu1983 opened a new issue #3058: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3058 1. process definition  2. task instance order in database  3. task instance order in web ui  4.task instance order in process instance  The task running order in the process instance does not follow the topological order in the process definition, Why? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] JinyLeeChina removed a comment on issue #2458: why don't support ding ding ？need more alert way
JinyLeeChina removed a comment on issue #2458: URL: https://github.com/apache/incubator-dolphinscheduler/issues/2458#issuecomment-616905381 Support dingtalk need add taobao-sdk-java-auto.jar, this involves the issue of license. I have this feature code, if you need,please contact me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3057: [WIP] load balance #3054
sonarcloud[bot] commented on pull request #3057: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3057#issuecomment-650670691 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3057&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3057&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3057&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3057&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3057&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #3053: [Feature-2154] Workflow version control
yangyichao-mango commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-650669527 > > Hi @dailidong . > > When I want to add the unit test case in `ProcessDefinitionControllerTest`, I found the `ProcessDefinitionControllerTest` is ran with the `MockitoJUnitRunner` but not the `SpringRunner` like the other controller test cases. I checked the history log and found @zixi0825 changed it from `SpringRunner` to `MockitoJUnitRunner` in `ProcessDefinitionControllerTest`. > > Hi @zixi0825 , can you help me to understand why changed `SpringRunner` to `MockitoJUnitRunner`, Thx a lot. > > MockitoJUnitRunner is used to simulate spring injection objects. > like this : Mockito.when(projectMapper.queryByName(projectName)).thenReturn(getProject(projectName)); Hi @zixi0825 , thx a lot for your answer. What I actually want to know is why we need to change the `ProcessDefinitionControllerTest` test component from `SpringRunner` to `MockitoJUnitRunner`. Is it necessary for us to keep all the ApiTestCase consistent(Replace to MockitoJUnitRunner or SpringRunner)? 非常感谢你的回答。 但是我想了解的是之前是有什么场景需要我们把`ProcessDefinitionControllerTest` 的测试组件从`SpringRunner` 换为`MockitoJUnitRunner` 吗？ 我们是否有必要将api层所有的测试框架统一(全部换为MockitoJUnitRunner或者SpringRunner)？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs opened a new pull request #3057: [WIP] load balance #3054
CalvinKirs opened a new pull request #3057: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3057 see #3054 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs closed pull request #3054: [WIP]Load balancing abstract
CalvinKirs closed pull request #3054: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3054 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zixi0825 commented on a change in pull request #2884: batch copy or move process #2753
zixi0825 commented on a change in pull request #2884:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/2884#discussion_r446587161
##
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
##
@@ -295,38 +294,209 @@ private String getResourceIds(ProcessData processData) {
/**
* copy process definition
*
- * @param loginUser login user
- * @param projectName project name
- * @param processId process definition id
- * @return copy result code
+ * @param loginUser loginUser
+ * @param processId processId
+ * @param targetProject targetProject
+ * @return
+ * @throws JsonProcessingException
*/
-public Map copyProcessDefinition(User loginUser, String
projectName, Integer processId) throws JsonProcessingException {
+private Map copyProcessDefinition(User loginUser,
+ Integer processId,
+ Project targetProject)
throws JsonProcessingException {
Map result = new HashMap<>(5);
-Project project = projectMapper.queryByName(projectName);
-
-Map checkResult =
projectService.checkProjectAndAuth(loginUser, project, projectName);
-Status resultStatus = (Status) checkResult.get(Constants.STATUS);
-if (resultStatus != Status.SUCCESS) {
-return checkResult;
-}
ProcessDefinition processDefinition =
processDefineMapper.selectById(processId);
if (processDefinition == null) {
putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, processId);
return result;
} else {
+
return createProcessDefinition(
loginUser,
-projectName,
+targetProject.getName(),
processDefinition.getName() + "_copy_" +
System.currentTimeMillis(),
processDefinition.getProcessDefinitionJson(),
processDefinition.getDescription(),
processDefinition.getLocations(),
processDefinition.getConnects());
+
+}
+}
+
+/**
+ * batch copy or move process definition
+ * @param loginUser loginUser
+ * @param projectName projectName
+ * @param processDefinitionIds processDefinitionIds
+ * @param targetProjectId targetProjectId
+ * @param isCopy isCopy
+ * @return
+ */
+public Map batchCopyOrMoveProcessDefinition(User loginUser,
+ String projectName,
+ String
processDefinitionIds,
+ int targetProjectId,
boolean isCopy){
+Map result = new HashMap<>(5);
Review comment:
OK!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] zixi0825 commented on pull request #3053: [Feature-2154] Workflow version control
zixi0825 commented on pull request #3053: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3053#issuecomment-650664056 > Hi @dailidong . > When I want to add the unit test case in `ProcessDefinitionControllerTest`, I found the `ProcessDefinitionControllerTest` is ran with the `MockitoJUnitRunner` but not the `SpringRunner` like the other controller test cases. I checked the history log and found @zixi0825 changed it from `SpringRunner` to `MockitoJUnitRunner` in `ProcessDefinitionControllerTest`. > > Hi @zixi0825 , can you help me to understand why changed `SpringRunner` to `MockitoJUnitRunner`, Thx a lot. MockitoJUnitRunner is used to simulate spring injection objects. like this : Mockito.when(projectMapper.queryByName(projectName)).thenReturn(getProject(projectName)); This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #3050: [QUESTION] question title 监控中心那边worker和marter那边的心跳时间比北京时间快5小时，检查了服务器时间，时区，数据库时间都是正确的，请问这个问题要怎么处理？
xingchun-chen commented on issue #3050: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3050#issuecomment-650662072 You can refer to this issue #2485 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler-website] AhahaGe opened a new pull request #136: [Feature] need to collect FAQ issues to official website faq.md docs
AhahaGe opened a new pull request #136: URL: https://github.com/apache/incubator-dolphinscheduler-website/pull/136 [Feature] need to collect FAQ issues to official website faq.md docs, [issue 3020](https://github.com/apache/incubator-dolphinscheduler/issues/3020) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on pull request #3042: Revise annotation spelling errors & Enhanced code robustness
sonarcloud[bot] removed a comment on pull request #3042: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3042#issuecomment-648630022 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_coverage&view=list) [72.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3042: Revise annotation spelling errors & Enhanced code robustness
sonarcloud[bot] commented on pull request #3042: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3042#issuecomment-650564171 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3042&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_coverage&view=list) [72.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3042&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #3056: [BUG] 1.20 branch, sometimes the login step will throw 502 bad gateway at first time.
dailidong commented on issue #3056: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3056#issuecomment-650562070 how to reproduce this scene？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] caoyj1991 commented on issue #3046: [Feature] Workflow version control
caoyj1991 commented on issue #3046: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3046#issuecomment-650550456 @yangyichao-mango any release plan? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] caoyj1991 commented on issue #57: Wanted: Who is using DolphinScheduler
caoyj1991 commented on issue #57: URL: https://github.com/apache/incubator-dolphinscheduler/issues/57#issuecomment-650549674 Organization: NA Location: Shanghai, China Contact: caoyj1...@sina.com Scenario: DevOps for micro service. 地点：中国上海 联系方式：caoyj1...@sina.com 场景：用于微服务快速交付混合测试场景。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] caoyj1991 opened a new issue #3056: [BUG] 1.20 branch, sometimes the login step will throw 502 bad gateway at first time.
caoyj1991 opened a new issue #3056: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3056 workaround: 1.reset the nginx export port -> 2.reload nginx config This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] caoyj1991 opened a new issue #3055: [BUG] 1.20 branch docker build solution is not working. tar.gz file version is 1.21-SNAPSHOT.
caoyj1991 opened a new issue #3055: URL: https://github.com/apache/incubator-dolphinscheduler/issues/3055 as title. need update the readme guide. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-dolphinscheduler] Rubik-W commented on a change in pull request #2884: batch copy or move process #2753
Rubik-W commented on a change in pull request #2884:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/2884#discussion_r446498357
##
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
##
@@ -295,36 +295,188 @@ private String getResourceIds(ProcessData processData) {
/**
* copy process definition
- *
* @param loginUser login user
- * @param projectName project name
* @param processId process definition id
* @return copy result code
*/
-public Map copyProcessDefinition(User loginUser, String
projectName, Integer processId) throws JsonProcessingException {
+private Map copyProcessDefinition(User loginUser,
+ Integer processId,
+ String targetProjectName)
throws JsonProcessingException {
Map result = new HashMap<>(5);
+
+ProcessDefinition processDefinition =
processDefineMapper.selectById(processId);
+if (processDefinition == null) {
+putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, processId);
+return result;
+} else {
+Project targetProject =
projectMapper.queryByName(targetProjectName);
+if(targetProject == null){
+putMsg(result, Status.PROJECT_NOT_FOUNT, targetProjectName);
+return result;
+}else{
+return createProcessDefinition(
+loginUser,
+targetProjectName,
+processDefinition.getName() + "_copy_" +
System.currentTimeMillis(),
+processDefinition.getProcessDefinitionJson(),
+processDefinition.getDescription(),
+processDefinition.getLocations(),
+processDefinition.getConnects());
+}
+}
+}
+
+/**
+ * batch copy or move process definition
+ * @param loginUser loginUser
+ * @param projectName projectName
+ * @param processDefinitionIds processDefinitionIds
+ * @param targetProjectName targetProjectName
+ * @return
+ */
+public Map batchCopyOrMoveProcessDefinition(User loginUser,
+ String projectName,
+ String
processDefinitionIds,
+ String
targetProjectName, boolean isCopy){
+Map result = new HashMap<>(5);
+List failedIdList = new ArrayList<>();
+
+if (StringUtils.isEmpty(processDefinitionIds)) {
+putMsg(result, Status.PROCESS_DEFINITION_IDS_IS_EMPTY,
targetProjectName);
+return result;
+}
+
+//check src project auth
+Map checkResult = checkProjectAndAuth(loginUser,
projectName);
+if (checkResult != null) {
+return checkResult;
+}
+
+if(!targetProjectName.equals(projectName)){
+Map checkTargetProjectResult =
checkProjectAndAuth(loginUser, targetProjectName);
+if (checkTargetProjectResult != null) {
+return checkTargetProjectResult;
+}
+}
+
+String[] processDefinitionIdList =
processDefinitionIds.split(Constants.COMMA);
+if(isCopy){
+doBatchCopyProcessDefinition(loginUser, targetProjectName,
failedIdList, processDefinitionIdList);
+}else{
+doBatchMoveProcessDefinition(targetProjectName, failedIdList,
processDefinitionIdList);
+}
+
+checkBatchOperateResult(result, failedIdList);
+
+return result;
+}
+
+/**
+ * batch move process definition
+ * @param targetProjectName targetProjectName
+ * @param failedIdList failedIdList
+ * @param processDefinitionIdList processDefinitionIdList
+ */
+private void doBatchMoveProcessDefinition(String targetProjectName,
List failedIdList, String[] processDefinitionIdList) {
+for(String processDefinitionId:processDefinitionIdList){
+try {
+Map moveProcessDefinitionResult =
+
moveProcessDefinition(Integer.valueOf(processDefinitionId),targetProjectName);
+if
(!Status.SUCCESS.equals(moveProcessDefinitionResult.get(Constants.STATUS))) {
+failedIdList.add(processDefinitionId);
+logger.error((String)
moveProcessDefinitionResult.get(Constants.MSG));
+}
+} catch (Exception e) {
+failedIdList.add(processDefinitionId);
+}
+}
+}
+
+/**
+ * batch copy process definition
+ * @param loginUser loginUser
+ * @param targetProjectName targetProjectName
+ * @param failedIdList failedIdList
+ * @param processDefinitionIdList
[GitHub] [incubator-dolphinscheduler] Rubik-W commented on a change in pull request #2884: batch copy or move process #2753
Rubik-W commented on a change in pull request #2884:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/2884#discussion_r446498242
##
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java
##
@@ -295,36 +295,188 @@ private String getResourceIds(ProcessData processData) {
/**
* copy process definition
- *
* @param loginUser login user
- * @param projectName project name
* @param processId process definition id
* @return copy result code
*/
-public Map copyProcessDefinition(User loginUser, String
projectName, Integer processId) throws JsonProcessingException {
+private Map copyProcessDefinition(User loginUser,
+ Integer processId,
+ String targetProjectName)
throws JsonProcessingException {
Map result = new HashMap<>(5);
+
+ProcessDefinition processDefinition =
processDefineMapper.selectById(processId);
+if (processDefinition == null) {
+putMsg(result, Status.PROCESS_DEFINE_NOT_EXIST, processId);
+return result;
+} else {
+Project targetProject =
projectMapper.queryByName(targetProjectName);
Review comment:
Hi, This is not fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
