[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3695: [Improvement][COMMON-NetUtils] Get the native IP policy problem (获取本机ip策略问题 )

2020-09-12 Thread GitBox 


yangyichao-mango commented on a change in pull request #3695:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3695#discussion_r487354505



##
File path: dolphinscheduler-common/src/main/resources/common.properties
##
@@ -72,3 +72,7 @@ kerberos.expire.time=2
 # datasource encryption salt
 datasource.encryption.enable=false
 datasource.encryption.salt=!@#$%^&*
+
+#Network IP gets priority, default inner outer

Review comment:
   ```suggestion
   # Network IP gets priority, default inner outer
   ```
   
   Format the description as the others.

##
File path: dolphinscheduler-common/src/main/resources/common.properties
##
@@ -72,3 +72,7 @@ kerberos.expire.time=2
 # datasource encryption salt
 datasource.encryption.enable=false
 datasource.encryption.salt=!@#$%^&*
+
+#Network IP gets priority, default inner outer

Review comment:
   ```suggestion
   # Network IP gets priority, default inner outer
   ```
   
   Format the description as the others.

##
File path: dolphinscheduler-common/src/main/resources/common.properties
##
@@ -72,3 +72,7 @@ kerberos.expire.time=2
 # datasource encryption salt
 datasource.encryption.enable=false
 datasource.encryption.salt=!@#$%^&*
+
+#Network IP gets priority, default inner outer

Review comment:
   ```suggestion
   # Network IP gets priority, default inner outer
   ```
   
   Format the description as the others.

##
File path: dolphinscheduler-common/src/main/resources/common.properties
##
@@ -72,3 +72,7 @@ kerberos.expire.time=2
 # datasource encryption salt
 datasource.encryption.enable=false
 datasource.encryption.salt=!@#$%^&*
+
+#Network IP gets priority, default inner outer

Review comment:
   ```suggestion
   # Network IP gets priority, default inner outer
   ```
   
   Format the description as the others.

##
File path: dolphinscheduler-common/src/main/resources/common.properties
##
@@ -72,3 +72,7 @@ kerberos.expire.time=2
 # datasource encryption salt
 datasource.encryption.enable=false
 datasource.encryption.salt=!@#$%^&*
+
+#Network IP gets priority, default inner outer

Review comment:
   ```suggestion
   # Network IP gets priority, default inner outer
   ```
   
   Format the description as the others.

##
File path: dolphinscheduler-common/src/main/resources/common.properties
##
@@ -72,3 +72,7 @@ kerberos.expire.time=2
 # datasource encryption salt
 datasource.encryption.enable=false
 datasource.encryption.salt=!@#$%^&*
+
+#Network IP gets priority, default inner outer

Review comment:
   ```suggestion
   # Network IP gets priority, default inner outer
   ```
   
   Format the description as the others.

##
File path: dolphinscheduler-common/src/main/resources/common.properties
##
@@ -72,3 +72,7 @@ kerberos.expire.time=2
 # datasource encryption salt
 datasource.encryption.enable=false
 datasource.encryption.salt=!@#$%^&*
+
+#Network IP gets priority, default inner outer

Review comment:
   ```suggestion
   # Network IP gets priority, default inner outer
   ```
   
   Format the description as the others.

##
File path: dolphinscheduler-common/src/main/resources/common.properties
##
@@ -72,3 +72,7 @@ kerberos.expire.time=2
 # datasource encryption salt
 datasource.encryption.enable=false
 datasource.encryption.salt=!@#$%^&*
+
+#Network IP gets priority, default inner outer

Review comment:
   ```suggestion
   # Network IP gets priority, default inner outer
   ```
   
   Format the description as the others.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3695: [Improvement][COMMON-NetUtils] Get the native IP policy problem (获取本机ip策略问题 )

2020-09-12 Thread GitBox 


yangyichao-mango commented on a change in pull request #3695:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3695#discussion_r487354505



##
File path: dolphinscheduler-common/src/main/resources/common.properties
##
@@ -72,3 +72,7 @@ kerberos.expire.time=2
 # datasource encryption salt
 datasource.encryption.enable=false
 datasource.encryption.salt=!@#$%^&*
+
+#Network IP gets priority, default inner outer

Review comment:
   ```suggestion
   # Network IP gets priority, default inner outer
   ```
   
   Format the description as the others.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on a change in pull request #3695: [Improvement][COMMON-NetUtils] Get the native IP policy problem (获取本机ip策略问题 )

2020-09-11 Thread GitBox 


yangyichao-mango commented on a change in pull request #3695:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3695#discussion_r487354505



##
File path: dolphinscheduler-common/src/main/resources/common.properties
##
@@ -72,3 +72,7 @@ kerberos.expire.time=2
 # datasource encryption salt
 datasource.encryption.enable=false
 datasource.encryption.salt=!@#$%^&*
+
+#Network IP gets priority, default inner outer

Review comment:
   ```suggestion
   # Network IP gets priority, default inner outer
   ```
   
   Format the description as the others.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org