[GitHub] [incubator-doris] imay commented on issue #1825: HLL support default value

2019-09-20 Thread GitBox
imay commented on issue #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825#issuecomment-533770433 > > And also, should will and a function empty_bitmap() for BITMAP column > > @morningman I agree with you. I agree too @HangyuanLiu

[GitHub] [incubator-doris] imay commented on a change in pull request #1798: Optimize the load performance for large file

2019-09-20 Thread GitBox
imay commented on a change in pull request #1798: Optimize the load performance for large file URL: https://github.com/apache/incubator-doris/pull/1798#discussion_r326848390 ## File path: be/src/olap/delta_writer.cpp ## @@ -132,48 +135,93 @@ OLAPStatus DeltaWriter::init()

[GitHub] [incubator-doris] kangkaisen closed issue #1843: All BE crash when schema change

2019-09-20 Thread GitBox
kangkaisen closed issue #1843: All BE crash when schema change URL: https://github.com/apache/incubator-doris/issues/1843 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] kangkaisen commented on issue #1825: HLL support default value

2019-09-20 Thread GitBox
kangkaisen commented on issue #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825#issuecomment-533767262 > And also, should will and a function empty_bitmap() for BITMAP column @morningman I agree with you.

[GitHub] [incubator-doris] morningman commented on issue #1825: HLL support default value

2019-09-20 Thread GitBox
morningman commented on issue #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825#issuecomment-533766895 @HangyuanLiu I think using `empty_hll()` is more reasonable. If business A does not care not column `uv2`, It should leave `uv2` unchanged by

[GitHub] [incubator-doris] imay commented on issue #1840: [Bug-fix]: Remove conjuncts for empty set node

2019-09-20 Thread GitBox
imay commented on issue #1840: [Bug-fix]: Remove conjuncts for empty set node URL: https://github.com/apache/incubator-doris/pull/1840#issuecomment-533764843 @EmmyMiao87 Can you create a bug labeled Issue, and relate this fix with it?

[GitHub] [incubator-doris] imay commented on a change in pull request #1845: Reduce size of HyperLogLog struct

2019-09-20 Thread GitBox
imay commented on a change in pull request #1845: Reduce size of HyperLogLog struct URL: https://github.com/apache/incubator-doris/pull/1845#discussion_r326701831 ## File path: be/src/olap/hll.h ## @@ -23,59 +23,68 @@ #include #include -#include "olap/olap_common.h"

[GitHub] [incubator-doris] imay commented on a change in pull request #1845: Reduce size of HyperLogLog struct

2019-09-20 Thread GitBox
imay commented on a change in pull request #1845: Reduce size of HyperLogLog struct URL: https://github.com/apache/incubator-doris/pull/1845#discussion_r326700506 ## File path: be/src/olap/hll.cpp ## @@ -20,172 +20,236 @@ #include #include +#include

[GitHub] [incubator-doris] imay commented on a change in pull request #1845: Reduce size of HyperLogLog struct

2019-09-20 Thread GitBox
imay commented on a change in pull request #1845: Reduce size of HyperLogLog struct URL: https://github.com/apache/incubator-doris/pull/1845#discussion_r326700381 ## File path: be/src/olap/hll.h ## @@ -23,59 +23,68 @@ #include #include -#include "olap/olap_common.h"

[GitHub] [incubator-doris] imay commented on a change in pull request #1845: Reduce size of HyperLogLog struct

2019-09-20 Thread GitBox
imay commented on a change in pull request #1845: Reduce size of HyperLogLog struct URL: https://github.com/apache/incubator-doris/pull/1845#discussion_r326700229 ## File path: be/src/exprs/hll_function.cpp ## @@ -32,16 +32,16 @@ StringVal

[GitHub] [incubator-doris] morningman commented on a change in pull request #1845: Reduce size of HyperLogLog struct

2019-09-20 Thread GitBox
morningman commented on a change in pull request #1845: Reduce size of HyperLogLog struct URL: https://github.com/apache/incubator-doris/pull/1845#discussion_r326677267 ## File path: be/src/olap/hll.h ## @@ -23,59 +23,68 @@ #include #include -#include

[GitHub] [incubator-doris] morningman commented on a change in pull request #1845: Reduce size of HyperLogLog struct

2019-09-20 Thread GitBox
morningman commented on a change in pull request #1845: Reduce size of HyperLogLog struct URL: https://github.com/apache/incubator-doris/pull/1845#discussion_r326670122 ## File path: be/src/olap/hll.cpp ## @@ -20,172 +20,236 @@ #include #include +#include

[GitHub] [incubator-doris] morningman commented on a change in pull request #1845: Reduce size of HyperLogLog struct

2019-09-20 Thread GitBox
morningman commented on a change in pull request #1845: Reduce size of HyperLogLog struct URL: https://github.com/apache/incubator-doris/pull/1845#discussion_r326673621 ## File path: be/src/exprs/hll_function.cpp ## @@ -32,16 +32,16 @@ StringVal

[incubator-doris] branch master updated: Fix two digit year bug in to_days function (#1839)

2019-09-20 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 74d6d04 Fix two digit year bug in

[GitHub] [incubator-doris] imay merged pull request #1839: Fix two digit year bug in to_days function

2019-09-20 Thread GitBox
imay merged pull request #1839: Fix two digit year bug in to_days function URL: https://github.com/apache/incubator-doris/pull/1839 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-doris] branch master updated: Add schema change check for DUPLICATE KEY table (#1844)

2019-09-20 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 9036014 Add schema change check

[GitHub] [incubator-doris] morningman merged pull request #1844: Add schema change check for DUPLICATE KEY table

2019-09-20 Thread GitBox
morningman merged pull request #1844: Add schema change check for DUPLICATE KEY table URL: https://github.com/apache/incubator-doris/pull/1844 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] imay commented on issue #1844: Add schema change check for DUPLICATE KEY table

2019-09-20 Thread GitBox
imay commented on issue #1844: Add schema change check for DUPLICATE KEY table URL: https://github.com/apache/incubator-doris/pull/1844#issuecomment-533571628 for #1843 This is an automated message from the Apache Git

[GitHub] [incubator-doris] imay opened a new pull request #1845: Reduce size of HyperLogLog struct

2019-09-20 Thread GitBox
imay opened a new pull request #1845: Reduce size of HyperLogLog struct URL: https://github.com/apache/incubator-doris/pull/1845 Now size of HyperLogLog struct is so large that it lead the rowset is too small when ingesting data. In this CL, registers in HyperLogLog are only created

[GitHub] [incubator-doris] imay merged pull request #1841: Fix write file crash when using segment V2 in debug mode

2019-09-20 Thread GitBox
imay merged pull request #1841: Fix write file crash when using segment V2 in debug mode URL: https://github.com/apache/incubator-doris/pull/1841 This is an automated message from the Apache Git Service. To respond to the

[incubator-doris] branch master updated (abd27df -> cc36905)

2019-09-20 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from abd27df Remove unused debug (#1836) add cc36905 Fix write file crash when using segment V2 in debug

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1844: Add schema change check for DUPLICATE KEY table

2019-09-20 Thread GitBox
kangkaisen opened a new pull request #1844: Add schema change check for DUPLICATE KEY table URL: https://github.com/apache/incubator-doris/pull/1844 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] kangkaisen opened a new issue #1843: All BE crash when schema change

2019-09-20 Thread GitBox
kangkaisen opened a new issue #1843: All BE crash when schema change URL: https://github.com/apache/incubator-doris/issues/1843 **Describe the bug** Today, The following sql make our BE crash. ``` alter table xx modify column title varchar(255) key ``` The origin size for

[GitHub] [incubator-doris] italyfiori opened a new issue #1842: 使用窗函数lead和lag时,default参数必须为null

2019-09-20 Thread GitBox
italyfiori opened a new issue #1842: 使用窗函数lead和lag时,default参数必须为null URL: https://github.com/apache/incubator-doris/issues/1842 **Describe the bug** 使用窗函数lead和lag时,默认值的参数如果不为NULL时,语句报错 **To Reproduce** Steps to reproduce the behavior: 1. create table CREATE TABLE

[GitHub] [incubator-doris] wubiaoi opened a new pull request #1841: Fix write file crash when using segment V2 in debug mode

2019-09-20 Thread GitBox
wubiaoi opened a new pull request #1841: Fix write file crash when using segment V2 in debug mode URL: https://github.com/apache/incubator-doris/pull/1841 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1840: [Bug-fix]: Remove conjuncts for empty set node

2019-09-20 Thread GitBox
EmmyMiao87 opened a new pull request #1840: [Bug-fix]: Remove conjuncts for empty set node URL: https://github.com/apache/incubator-doris/pull/1840 The function named assign conjuncts has been invoked before creating aggregation plan node. If the empty set node is the child of

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1839: Fix two digit year bug in to_days function

2019-09-20 Thread GitBox
HangyuanLiu opened a new pull request #1839: Fix two digit year bug in to_days function URL: https://github.com/apache/incubator-doris/pull/1839 #1838 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] HangyuanLiu opened a new issue #1838: Error result in to_days function

2019-09-20 Thread GitBox
HangyuanLiu opened a new issue #1838: Error result in to_days function URL: https://github.com/apache/incubator-doris/issues/1838 TO_DAYS('1997-10-07'), TO_DAYS('97-10-07') should be same result in mysql But the result return by Doris is error MySQL [(none)]> SELECT

[GitHub] [incubator-doris] xionglei0 commented on issue #1821: Add some profile metrics

2019-09-20 Thread GitBox
xionglei0 commented on issue #1821: Add some profile metrics URL: https://github.com/apache/incubator-doris/pull/1821#issuecomment-533442130 ![Image](https://user-images.githubusercontent.com/55084968/65307771-1dfd0800-dbbb-11e9-9ea0-e46dadd19fb9.png)