[GitHub] [incubator-doris] xy720 commented on a change in pull request #6418: [Enhance] [Binlog] Reduce thread number of SyncJob to save resources

2021-08-30 Thread GitBox
xy720 commented on a change in pull request #6418: URL: https://github.com/apache/incubator-doris/pull/6418#discussion_r698993519 ## File path: fe/fe-core/src/main/java/org/apache/doris/task/SerialExecutorService.java ## @@ -0,0 +1,80 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] xy720 commented on a change in pull request #6418: [Enhance] [Binlog] Reduce thread number of SyncJob to save resources

2021-08-30 Thread GitBox
xy720 commented on a change in pull request #6418: URL: https://github.com/apache/incubator-doris/pull/6418#discussion_r698993299 ## File path: fe/fe-core/src/main/java/org/apache/doris/task/SyncTask.java ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] morningman commented on a change in pull request #6416: #6386 Enforce null check at Catalog.getDb and Database.getTable

2021-08-30 Thread GitBox
morningman commented on a change in pull request #6416: URL: https://github.com/apache/incubator-doris/pull/6416#discussion_r698963809 ## File path: fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java ## @@ -260,17 +251,11 @@ private void

[GitHub] [incubator-doris] morningman commented on issue #6529: [Proposal] Extend logging framework to support structured log output and custom log format

2021-08-30 Thread GitBox
morningman commented on issue #6529: URL: https://github.com/apache/incubator-doris/issues/6529#issuecomment-908898117 It is useful, but a very huge code refactor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-doris] ccoffline commented on issue #6529: [Proposal] Extend logging framework to support structured log output and custom log format

2021-08-30 Thread GitBox
ccoffline commented on issue #6529: URL: https://github.com/apache/incubator-doris/issues/6529#issuecomment-90102 There are already similar designs in Doris. `Logbuilder` is used in some code, but not widely.

[GitHub] [incubator-doris] D-YuLin opened a new issue #6535: doris中的建立的前缀索引限定36byte,和遇到varchar截断

2021-08-30 Thread GitBox
D-YuLin opened a new issue #6535: URL: https://github.com/apache/incubator-doris/issues/6535 doris中的建立的前缀索引限定36byte,和遇到varchar截断,这个原理是什么 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-doris] morningman opened a new pull request #6534: [Community] Add new template for issues

2021-08-30 Thread GitBox
morningman opened a new pull request #6534: URL: https://github.com/apache/incubator-doris/pull/6534 ## Proposed changes Inpired by Apache Skywalking https://github.com/apache/skywalking/issues/new?assignees==bug=bug-report.yml=%5BBug%5D+ ## Types of changes

[GitHub] [incubator-doris] xiaoxiaopan118 commented on issue #6533: [Bug] Fix dataTables bootstrap js version differ.

2021-08-30 Thread GitBox
xiaoxiaopan118 commented on issue #6533: URL: https://github.com/apache/incubator-doris/issues/6533#issuecomment-908867669 The PR is https://github.com/apache/incubator-doris/pull/6532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] xiaoxiaopan118 opened a new issue #6533: [Bug] Fix dataTables bootstrap js version differ.

2021-08-30 Thread GitBox
xiaoxiaopan118 opened a new issue #6533: URL: https://github.com/apache/incubator-doris/issues/6533 **Describe the bug** FE logs ERROR (nioEventLoopGroup-3-2|84) [StaticResourceAction.executeGet():160] Request with wrong path. url:

[GitHub] [incubator-doris] xiaoxiaopan118 opened a new pull request #6532: [Bug] Fix dataTables bootstrap js version differ.

2021-08-30 Thread GitBox
xiaoxiaopan118 opened a new pull request #6532: URL: https://github.com/apache/incubator-doris/pull/6532 FE logs ERROR (nioEventLoopGroup-3-2|84) [StaticResourceAction.executeGet():160] Request with wrong path. url: /static?res=DataTables-1.10.21/js/dataTables.bootstrap.js because

[incubator-doris] branch master updated: Fix min(string) Unable to find symbol (#6531)

2021-08-30 Thread lingmiao
This is an automated email from the ASF dual-hosted git repository. lingmiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 138e7e8 Fix min(string) Unable to

[GitHub] [incubator-doris] EmmyMiao87 merged pull request #6531: fix min(string) Unable to find symbol

2021-08-30 Thread GitBox
EmmyMiao87 merged pull request #6531: URL: https://github.com/apache/incubator-doris/pull/6531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-doris] yangzhg opened a new pull request #6531: fix min(string) Unable to find symbol

2021-08-30 Thread GitBox
yangzhg opened a new pull request #6531: URL: https://github.com/apache/incubator-doris/pull/6531 ## Proposed changes Fix a bug that min() string type cannot find symbol ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in the

[GitHub] [incubator-doris] crazy2323 opened a new issue #6530: Build failed

2021-08-30 Thread GitBox
crazy2323 opened a new issue #6530: URL: https://github.com/apache/incubator-doris/issues/6530 /opt/apache-doris-0.14.0-incubating-src/thirdparty/src/incubator-brpc-0.9.5/src/bvar/recorder.h:31:8: note: ‘struct bvar::Stat’ declared here 31 | struct Stat { |^~~~ [

[GitHub] [incubator-doris] morningman commented on a change in pull request #6418: [Enhance] [Binlog] Reduce thread number of SyncJob to save resources

2021-08-30 Thread GitBox
morningman commented on a change in pull request #6418: URL: https://github.com/apache/incubator-doris/pull/6418#discussion_r698919562 ## File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ChannelDescription.java ## @@ -60,6 +60,8 @@ // column names of source

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6504: [Feature]support three functions of json

2021-08-30 Thread GitBox
yangzhg commented on a change in pull request #6504: URL: https://github.com/apache/incubator-doris/pull/6504#discussion_r698921023 ## File path: be/src/exprs/json_functions.cpp ## @@ -107,6 +107,89 @@ DoubleVal JsonFunctions::get_json_double(FunctionContext* context, const

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6203: [Feature][ResourceTag] Support Resource Tag

2021-08-30 Thread GitBox
github-actions[bot] commented on pull request #6203: URL: https://github.com/apache/incubator-doris/pull/6203#issuecomment-908826895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] leafgodgood commented on issue #6483: New Optimizer

2021-08-30 Thread GitBox
leafgodgood commented on issue #6483: URL: https://github.com/apache/incubator-doris/issues/6483#issuecomment-908509707 【英文缩写】 3R 【词性类别】 生物科学 【英文全称】 Reduction Refinement Replacement 【中文解释】 减少、优化和替代 【缩写简介】

[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #5781: [Compaction][ThreadPool]Support adjust compaction threads num at runtime

2021-08-30 Thread GitBox
weizuo93 commented on a change in pull request #5781: URL: https://github.com/apache/incubator-doris/pull/5781#discussion_r698519765 ## File path: be/src/util/threadpool.cpp ## @@ -610,6 +607,47 @@ void ThreadPool::check_not_pool_thread_unlocked() { } } +Status

[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #5781: [Compaction][ThreadPool]Support adjust compaction threads num at runtime

2021-08-30 Thread GitBox
weizuo93 commented on a change in pull request #5781: URL: https://github.com/apache/incubator-doris/pull/5781#discussion_r698519126 ## File path: be/src/util/threadpool.cpp ## @@ -610,6 +607,47 @@ void ThreadPool::check_not_pool_thread_unlocked() { } } +Status

[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #5781: [Compaction][ThreadPool]Support adjust compaction threads num at runtime

2021-08-30 Thread GitBox
weizuo93 commented on a change in pull request #5781: URL: https://github.com/apache/incubator-doris/pull/5781#discussion_r698518783 ## File path: be/src/util/threadpool.cpp ## @@ -610,6 +607,47 @@ void ThreadPool::check_not_pool_thread_unlocked() { } } +Status

[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #5781: [Compaction][ThreadPool]Support adjust compaction threads num at runtime

2021-08-30 Thread GitBox
weizuo93 commented on a change in pull request #5781: URL: https://github.com/apache/incubator-doris/pull/5781#discussion_r698518440 ## File path: be/test/util/threadpool_test.cpp ## @@ -778,6 +778,85 @@ TEST_F(ThreadPoolTest, TestLIFOThreadWakeUps) { } */

[GitHub] [incubator-doris] ccoffline opened a new issue #6529: [Proposal] Extend logging framework to support structured log output and custom log format

2021-08-30 Thread GitBox
ccoffline opened a new issue #6529: URL: https://github.com/apache/incubator-doris/issues/6529 **Is your feature request related to a problem? Please describe.** Observability is a very important capability for a distributed system. We have encountered several problems many times while

[GitHub] [incubator-doris] nimuyuhan commented on a change in pull request #6507: 【Bug】Some functions of doris push down mysql to run abnormally

2021-08-30 Thread GitBox
nimuyuhan commented on a change in pull request #6507: URL: https://github.com/apache/incubator-doris/pull/6507#discussion_r698454186 ## File path: fe/fe-core/src/main/java/org/apache/doris/planner/OdbcScanNode.java ## @@ -169,7 +155,8 @@ private void

[GitHub] [incubator-doris] xy720 commented on a change in pull request #6418: [Enhance] [Binlog] Reduce thread number of SyncJob to save resources

2021-08-30 Thread GitBox
xy720 commented on a change in pull request #6418: URL: https://github.com/apache/incubator-doris/pull/6418#discussion_r698446705 ## File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java ## @@ -634,6 +634,11 @@ */ @ConfField public static int

[GitHub] [incubator-doris] xy720 commented on a change in pull request #6418: [Enhance] [Binlog] Reduce thread number of SyncJob to save resources

2021-08-30 Thread GitBox
xy720 commented on a change in pull request #6418: URL: https://github.com/apache/incubator-doris/pull/6418#discussion_r698446514 ## File path: fe/fe-core/src/main/java/org/apache/doris/task/SyncTaskPool.java ## @@ -0,0 +1,35 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] weizuo93 opened a new pull request #6528: [Refactor][Compaction] Produce compaction tasks for all disks by by visiting full tablets once

2021-08-30 Thread GitBox
weizuo93 opened a new pull request #6528: URL: https://github.com/apache/incubator-doris/pull/6528 ## Proposed changes Compaction producer will produce compaction tasks for all disks in turn, and full tablets would be visited for each disk task. Maybe it's more elegant to produce

[GitHub] [incubator-doris] morningman closed issue #6512: [Optimize][Clone] Optimize clone task replica selector

2021-08-30 Thread GitBox
morningman closed issue #6512: URL: https://github.com/apache/incubator-doris/issues/6512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-doris] morningman merged pull request #6513: [Optimize][Clone] Take version count into consideration when choosing src replica for clone task

2021-08-30 Thread GitBox
morningman merged pull request #6513: URL: https://github.com/apache/incubator-doris/pull/6513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-doris] branch master updated: [Optimize][Clone] Take version count into consideration when choosing src replica for clone task (#6513)

2021-08-30 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new d5d8316 [Optimize][Clone] Take

[GitHub] [incubator-doris] morningman closed issue #6447: [Bug] DeleteInfos in the DeleteHandler will never be deleted

2021-08-30 Thread GitBox
morningman closed issue #6447: URL: https://github.com/apache/incubator-doris/issues/6447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-doris] branch master updated (abbc920 -> 7324f4b)

2021-08-30 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from abbc920 support routine load isolation_level read_committed (#6191) add 7324f4b [Bug] Regularly

[GitHub] [incubator-doris] morningman merged pull request #6448: [Bug] Regularly clean up old DeleteInfos in the DeleteHandler

2021-08-30 Thread GitBox
morningman merged pull request #6448: URL: https://github.com/apache/incubator-doris/pull/6448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-doris] branch master updated: support routine load isolation_level read_committed (#6191)

2021-08-30 Thread yangzhg
This is an automated email from the ASF dual-hosted git repository. yangzhg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new abbc920 support routine load

[GitHub] [incubator-doris] yangzhg merged pull request #6191: support routine load isolation_level read_committed

2021-08-30 Thread GitBox
yangzhg merged pull request #6191: URL: https://github.com/apache/incubator-doris/pull/6191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-doris] yangzhg closed issue #6138: routine load kafka property 未生效

2021-08-30 Thread GitBox
yangzhg closed issue #6138: URL: https://github.com/apache/incubator-doris/issues/6138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6191: support routine load isolation_level read_committed

2021-08-30 Thread GitBox
github-actions[bot] commented on pull request #6191: URL: https://github.com/apache/incubator-doris/pull/6191#issuecomment-908174624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-doris] stalary closed pull request #6527: MOD: arrow support boolean

2021-08-30 Thread GitBox
stalary closed pull request #6527: URL: https://github.com/apache/incubator-doris/pull/6527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-doris] stalary opened a new pull request #6527: MOD: arrow support boolean

2021-08-30 Thread GitBox
stalary opened a new pull request #6527: URL: https://github.com/apache/incubator-doris/pull/6527 ## Proposed changes arrow support boolean, use in spark/flink-connector ## Types of changes What types of changes does your code introduce to Doris? _Put an `x` in the