Re: [PR] [Enhancement](FE) add ping request when validate broker thrift client [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28770: URL: https://github.com/apache/doris/pull/28770#issuecomment-1867185752 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Enhancement](FE) add ping request when validate broker thrift client [doris]

2023-12-21 Thread via GitHub
WinkerDu commented on PR #28770: URL: https://github.com/apache/doris/pull/28770#issuecomment-1866213263 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Enhancement](FE) add ping request when validate broker thrift client [doris]

2023-12-20 Thread via GitHub
fm commented on code in PR #28770: URL: https://github.com/apache/doris/pull/28770#discussion_r1433627443 ## fe/fe-core/src/main/java/org/apache/doris/common/BrokerGenericPool.java: ## @@ -0,0 +1,59 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] [Enhancement](FE) add ping request when validate broker thrift client [doris]

2023-12-20 Thread via GitHub
fm commented on PR #28770: URL: https://github.com/apache/doris/pull/28770#issuecomment-1865683448 run buildall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Enhancement](FE) add ping request when validate broker thrift client [doris]

2023-12-20 Thread via GitHub
WinkerDu commented on code in PR #28770: URL: https://github.com/apache/doris/pull/28770#discussion_r1433616084 ## fe/fe-core/src/main/java/org/apache/doris/common/BrokerGenericPool.java: ## @@ -0,0 +1,59 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

Re: [PR] [Enhancement](FE) add ping request when validate broker thrift client [doris]

2023-12-20 Thread via GitHub
fm commented on PR #28770: URL: https://github.com/apache/doris/pull/28770#issuecomment-1865554613 @WinkerDu @morningman @chenlinzhong Please take a review, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [Enhancement](FE) add ping request when validate broker thrift client [doris]

2023-12-20 Thread via GitHub
fm commented on PR #28770: URL: https://github.com/apache/doris/pull/28770#issuecomment-1865554865 run buildall. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Enhancement](FE) add ping request when validate broker thrift client [doris]

2023-12-20 Thread via GitHub
fm opened a new pull request, #28770: URL: https://github.com/apache/doris/pull/28770 ## Proposed changes My organization try to run TPC-DS 100G HMS Lake query. During the testing process, we encountered the following issues. - when BrokerFileSystem listLocatedFiles,