xiaokang commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1831524454
already merged in #https://github.com/apache/doris/pull/27676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
xiaokang closed pull request #26749: [Feature-Variant](Variant Type) support
variant type query and index
URL: https://github.com/apache/doris/pull/26749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1831127330
Already merged https://github.com/apache/doris/pull/27676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
yiguolei merged PR #27676:
URL: https://github.com/apache/doris/pull/27676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #27676:
URL: https://github.com/apache/doris/pull/27676#issuecomment-1829921784
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on PR #27676:
URL: https://github.com/apache/doris/pull/27676#issuecomment-1829921881
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
eldenmoon commented on PR #27676:
URL: https://github.com/apache/doris/pull/27676#issuecomment-1829895593
#26749 PR is already reviewed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1829142434
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #27676:
URL: https://github.com/apache/doris/pull/27676#issuecomment-1829135675
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.95 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1829118969
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.99 seconds
stream load tsv: 562 seconds loaded 74807831229 Bytes,
github-actions[bot] commented on code in PR #27676:
URL: https://github.com/apache/doris/pull/27676#discussion_r1407046184
##
be/src/olap/rowset/segment_v2/column_reader.cpp:
##
@@ -1464,5 +1483,73 @@ void
eldenmoon commented on PR #27676:
URL: https://github.com/apache/doris/pull/27676#issuecomment-1829016046
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon opened a new pull request, #27676:
URL: https://github.com/apache/doris/pull/27676
## Proposed changes
This is the last part of variant and contains many regression cases
#26225
Issue Number: close #xxx
## Further comments
If this is a relatively
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1828992034
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1828161728
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1828002943
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1828002780
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1406284149
##
be/src/vec/common/schema_util.cpp:
##
@@ -289,70 +303,140 @@ void update_least_common_schema(const
std::vector& schemas,
TabletColumn common_column;
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1827529337
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
amorynan commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405926099
##
be/src/vec/data_types/serde/data_type_jsonb_serde.cpp:
##
@@ -199,7 +199,7 @@ void DataTypeJsonbSerDe::write_one_cell_to_json(const
IColumn& column, rapidjson
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405925632
##
be/src/olap/tablet_schema.cpp:
##
@@ -1015,9 +1145,15 @@ std::vector
TabletSchema::get_indexes_for_column(int32_t col
return indexes_for_column;
}
-bool
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405920546
##
be/src/olap/rowset/segment_creator.cpp:
##
@@ -280,6 +441,17 @@ Status SegmentCreator::add_block(const vectorized::Block*
block) {
size_t
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405899239
##
be/src/olap/tablet_schema.cpp:
##
@@ -1015,9 +1145,15 @@ std::vector
TabletSchema::get_indexes_for_column(int32_t col
return indexes_for_column;
}
-bool
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405894365
##
be/src/olap/rowset/segment_creator.cpp:
##
@@ -280,6 +441,17 @@ Status SegmentCreator::add_block(const vectorized::Block*
block) {
size_t
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1827264667
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.53 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes,
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1827146442
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1827144140
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405595918
##
be/src/olap/rowset/segment_creator.cpp:
##
@@ -40,32 +49,168 @@ SegmentFlusher::SegmentFlusher() = default;
SegmentFlusher::~SegmentFlusher() =
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405591908
##
be/src/olap/rowset/segment_creator.h:
##
@@ -142,7 +145,7 @@ class SegmentFlusher {
int64_t* flush_size = nullptr);
private:
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1827086864
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405587875
##
be/src/olap/rowset/segment_v2/inverted_index_desc.cpp:
##
@@ -27,30 +27,32 @@ const std::string segment_suffix = ".dat";
const std::string index_suffix = ".idx";
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405576346
##
be/src/olap/column_predicate.h:
##
@@ -210,6 +212,11 @@ class ColumnPredicate {
virtual bool can_do_bloom_filter(bool ngram) const { return false; }
+
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405575877
##
be/src/vec/columns/column_object.cpp:
##
@@ -436,8 +436,7 @@ ColumnPtr ColumnObject::index(const IColumn& indexes,
size_t limit) const {
}
bool
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405575590
##
be/src/vec/data_types/data_type_object.cpp:
##
@@ -47,10 +47,7 @@ namespace doris::vectorized {
DataTypeObject::DataTypeObject(const String& schema_format_, bool
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405574707
##
be/src/olap/match_predicate.cpp:
##
@@ -39,34 +44,37 @@ PredicateType MatchPredicate::type() const {
return PredicateType::MATCH;
}
-Status
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405566317
##
be/src/olap/schema_change.h:
##
@@ -119,7 +119,7 @@ class SchemaChange {
_inner_process(rowset_reader, rowset_writer, new_tablet,
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405566200
##
be/src/olap/schema.cpp:
##
@@ -130,10 +131,11 @@ vectorized::IColumn::MutablePtr
Schema::get_column_by_field(const Field& field)
return
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405565952
##
be/src/olap/tablet_schema.h:
##
@@ -207,16 +211,15 @@ class TabletIndex {
return 0;
}
-TabletIndex(const TabletIndex& other) {
Review
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405565891
##
be/src/olap/tablet_schema.h:
##
@@ -207,16 +211,15 @@ class TabletIndex {
return 0;
}
-TabletIndex(const TabletIndex& other) {
-
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405565755
##
be/src/olap/rowset/segment_creator.cpp:
##
@@ -40,32 +49,178 @@ SegmentFlusher::SegmentFlusher() = default;
SegmentFlusher::~SegmentFlusher() = default;
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405549745
##
be/src/olap/rowset/segment_creator.cpp:
##
@@ -40,32 +49,178 @@ SegmentFlusher::SegmentFlusher() = default;
SegmentFlusher::~SegmentFlusher() = default;
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1405391529
##
be/src/olap/rowset/segment_creator.cpp:
##
@@ -280,6 +441,17 @@ Status SegmentCreator::add_block(const vectorized::Block*
block) {
size_t
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825870102
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.4 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes,
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825835728
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1404441250
##
be/src/olap/rowset/segment_creator.cpp:
##
@@ -40,32 +49,178 @@ SegmentFlusher::SegmentFlusher() = default;
SegmentFlusher::~SegmentFlusher() =
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825784668
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825774490
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825628971
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.81 seconds
stream load tsv: 582 seconds loaded 74807831229 Bytes,
github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1404224884
##
be/src/olap/rowset/segment_v2/segment.cpp:
##
@@ -318,14 +330,42 @@ Status Segment::_load_index_impl() {
});
}
+// Return the storage datatype
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825492204
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825407353
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.55 seconds
stream load tsv: 581 seconds loaded 74807831229 Bytes,
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825270046
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825194239
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403964901
##
be/src/olap/rowset/segment_v2/segment.cpp:
##
@@ -483,5 +648,23 @@
return Status::OK();
}
+bool Segment::same_with_storage_type(int32_t cid,
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825176739
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1825174677
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403957377
##
be/src/vec/exec/scan/new_olap_scanner.cpp:
##
@@ -406,6 +411,55 @@ Status NewOlapScanner::_init_tablet_reader_params(
return Status::OK();
}
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403950491
##
be/src/vec/exec/scan/vscan_node.h:
##
@@ -271,10 +276,15 @@ class VScanNode : public ExecNode, public
RuntimeFilterConsumer {
// Save all function
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403942997
##
be/src/olap/rowset/segment_v2/segment.cpp:
##
@@ -318,14 +330,44 @@ Status Segment::_load_index_impl() {
});
}
+static vectorized::DataTypePtr
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403933281
##
fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java:
##
@@ -1004,11 +1011,49 @@ public SlotDescriptor registerColumnRef(TableName
tblName, String
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403931468
##
fe/fe-core/src/main/cup/sql_parser.cup:
##
@@ -7049,6 +7066,16 @@ column_ref ::=
{: RESULT = new SlotRef(new TableName(null, db, tbl), col); :}
| ident:ctl
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403930488
##
fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java:
##
@@ -57,6 +57,7 @@ public class SlotRef extends Expr {
private String col;
// Used in
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403929052
##
be/src/vec/exec/scan/new_olap_scan_node.cpp:
##
@@ -414,6 +419,49 @@ std::string NewOlapScanNode::get_name() {
return fmt::format("VNewOlapScanNode({0})",
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403921979
##
be/src/olap/rowset/segment_v2/segment.cpp:
##
@@ -318,14 +330,44 @@ Status Segment::_load_index_impl() {
});
}
+static vectorized::DataTypePtr
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403912247
##
be/src/vec/exec/scan/new_olap_scanner.cpp:
##
@@ -406,6 +411,55 @@ Status NewOlapScanner::_init_tablet_reader_params(
return Status::OK();
}
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403910866
##
be/src/vec/exec/scan/vscan_node.cpp:
##
@@ -78,6 +80,10 @@ static bool ignore_cast(SlotDescriptor* slot, VExpr* expr) {
if (slot->type().is_string_type() &&
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403847439
##
be/src/vec/exec/scan/new_olap_scanner.cpp:
##
@@ -406,6 +411,55 @@ Status NewOlapScanner::_init_tablet_reader_params(
return Status::OK();
}
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403847052
##
be/src/vec/exec/scan/new_olap_scanner.cpp:
##
@@ -406,6 +411,55 @@ Status NewOlapScanner::_init_tablet_reader_params(
return Status::OK();
}
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403846760
##
be/src/vec/exec/scan/new_olap_scanner.cpp:
##
@@ -406,6 +411,55 @@ Status NewOlapScanner::_init_tablet_reader_params(
return Status::OK();
}
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403846367
##
be/src/vec/exec/scan/new_olap_scan_node.cpp:
##
@@ -414,6 +419,49 @@ std::string NewOlapScanNode::get_name() {
return fmt::format("VNewOlapScanNode({0})",
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403846166
##
be/src/vec/exec/scan/scanner_scheduler.cpp:
##
@@ -414,6 +413,7 @@ void ScannerScheduler::_scanner_scan(ScannerScheduler*
scheduler, ScannerContext
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403845709
##
be/src/vec/exec/scan/vscan_node.cpp:
##
@@ -78,6 +80,10 @@ static bool ignore_cast(SlotDescriptor* slot, VExpr* expr) {
if (slot->type().is_string_type() &&
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403844542
##
fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java:
##
@@ -1004,11 +1011,49 @@ public SlotDescriptor registerColumnRef(TableName
tblName, String
xiaokang commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1403825647
##
be/src/vec/exec/scan/new_olap_scan_node.cpp:
##
@@ -414,6 +419,49 @@ std::string NewOlapScanNode::get_name() {
return fmt::format("VNewOlapScanNode({0})",
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1823328390
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.28 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1823265204
TeamCity be ut coverage result:
Function Coverage: 36.48% (8458/23184)
Line Coverage: 28.78% (68820/239162)
Region Coverage: 27.77% (35633/128309)
Branch Coverage:
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1823148019
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1823095385
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.44 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1823010128
TeamCity be ut coverage result:
Function Coverage: 36.46% (8456/23192)
Line Coverage: 28.76% (68791/239208)
Region Coverage: 27.75% (35615/128347)
Branch Coverage:
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1822874630
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1822873619
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1822851684
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.07 seconds
stream load tsv: 585 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1822775950
TeamCity be ut coverage result:
Function Coverage: 36.48% (8459/23188)
Line Coverage: 28.78% (68866/239321)
Region Coverage: 27.76% (35645/128388)
Branch Coverage:
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1822649418
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1822621911
TeamCity be ut coverage result:
Function Coverage: 36.48% (8459/23188)
Line Coverage: 28.78% (68867/239310)
Region Coverage: 27.77% (35649/128383)
Branch Coverage:
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1822491117
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1822473715
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1401715620
##
be/src/olap/rowset/segment_creator.cpp:
##
@@ -40,31 +49,177 @@ SegmentFlusher::SegmentFlusher() = default;
SegmentFlusher::~SegmentFlusher() =
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1401701524
##
gensrc/proto/internal_service.proto:
##
@@ -589,6 +589,7 @@ message PTabletWriteSlaveRequest {
message IndexSize {
required int64 indexId = 1;
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1822344872
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
yiguolei commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1398327235
##
gensrc/proto/internal_service.proto:
##
@@ -589,6 +589,7 @@ message PTabletWriteSlaveRequest {
message IndexSize {
required int64 indexId = 1;
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1811995688
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.08 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1811962400
TeamCity be ut coverage result:
Function Coverage: 36.71% (8428/22957)
Line Coverage: 29.20% (68564/234828)
Region Coverage: 27.82% (35470/127492)
Branch Coverage:
github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1393707407
##
be/src/olap/rowset/segment_v2/segment.cpp:
##
@@ -352,36 +499,53 @@ Status Segment::_create_column_readers(const
SegmentFooterPB& footer) {
// but in
eldenmoon commented on PR #26749:
URL: https://github.com/apache/doris/pull/26749#issuecomment-1811878381
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1393702837
##
be/src/olap/rowset/segment_v2/segment.h:
##
@@ -84,7 +91,14 @@ class Segment : public std::enable_shared_from_this
{
uint32_t num_rows() const { return
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1393695979
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -1632,19 +1685,35 @@ void SegmentIterator::_init_current_block(
for (size_t i = 0; i <
github-actions[bot] commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1393696155
##
be/src/olap/rowset/segment_v2/segment.cpp:
##
@@ -341,6 +379,115 @@
_file_reader, ));
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1393695979
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -1632,19 +1685,35 @@ void SegmentIterator::_init_current_block(
for (size_t i = 0; i <
eldenmoon commented on code in PR #26749:
URL: https://github.com/apache/doris/pull/26749#discussion_r1393695747
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -276,7 +282,12 @@ Status SegmentIterator::_init_impl(const
StorageReadOptions& opts) {
1 - 100 of 169 matches
Mail list logo
