Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
yiguolei merged PR #25524: URL: https://github.com/apache/doris/pull/25524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
github-actions[bot] commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1776388687 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
github-actions[bot] commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1776388725 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1775051411 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.28 seconds stream load tsv: 552 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1774994800 TeamCity be ut coverage result: Function Coverage: 37.01% (8293/22407) Line Coverage: 29.17% (66615/228391) Region Coverage: 27.76% (34607/124671) Branch Coverage:

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1774919119 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
github-actions[bot] commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1774909194 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
github-actions[bot] commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1774907043 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
zhiqiang- commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1368456858 ## be/src/runtime/fragment_mgr.cpp: ## @@ -979,37 +984,13 @@ void FragmentMgr::cancel_query_unlocked(const TUniqueId& query_id, return; } -

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
zhiqiang- commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1368456456 ## be/src/runtime/fragment_mgr.cpp: ## @@ -961,6 +961,11 @@ void FragmentMgr::_set_scan_concurrency(const Param& params, QueryContext* query #endif } +bool

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
yiguolei commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1368400446 ## be/src/service/internal_service.cpp: ## @@ -558,15 +558,19 @@ void PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
yiguolei commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1368398358 ## be/src/runtime/fragment_mgr.cpp: ## @@ -979,37 +984,13 @@ void FragmentMgr::cancel_query_unlocked(const TUniqueId& query_id, return; } -if

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
yiguolei commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1368397867 ## be/src/runtime/fragment_mgr.cpp: ## @@ -961,6 +961,11 @@ void FragmentMgr::_set_scan_concurrency(const Param& params, QueryContext* query #endif } +bool

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
yiguolei commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1368393738 ## be/src/service/internal_service.cpp: ## @@ -558,15 +558,19 @@ void PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController*

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-23 Thread via GitHub
zhiqiang- commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1368175613 ## be/src/runtime/fragment_mgr.cpp: ## @@ -961,6 +961,14 @@ void FragmentMgr::_set_scan_concurrency(const Param& params, QueryContext* query #endif } +bool

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-22 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1774437107 TeamCity be ut coverage result: Function Coverage: 37.03% (8297/22408) Line Coverage: 29.17% (66612/228342) Region Coverage: 27.79% (34606/124539) Branch Coverage:

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-22 Thread via GitHub
github-actions[bot] commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1774370871 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-22 Thread via GitHub
github-actions[bot] commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1774369652 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-22 Thread via GitHub
github-actions[bot] commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1774368494 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-22 Thread via GitHub
github-actions[bot] commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1774365576 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-22 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1774365360 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-22 Thread via GitHub
github-actions[bot] commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1368079723 ## be/src/runtime/fragment_mgr.cpp: ## @@ -961,6 +961,14 @@ void FragmentMgr::_set_scan_concurrency(const Param& params, QueryContext* query #endif }

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-19 Thread via GitHub
github-actions[bot] commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1366473381 ## be/src/runtime/fragment_mgr.cpp: ## @@ -951,6 +960,14 @@ void FragmentMgr::_set_scan_concurrency(const Param& params, QueryContext* query #endif }

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1769870974 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.26 seconds stream load tsv: 556 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1769858102 TeamCity be ut coverage result: Function Coverage: 37.02% (8281/22371) Line Coverage: 29.07% (66424/228464) Region Coverage: 27.73% (34497/124408) Branch Coverage:

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1769842442 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
zhiqiang- commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1363749998 ## be/src/pipeline/task_scheduler.cpp: ## @@ -228,8 +228,6 @@ void TaskScheduler::_do_work(size_t index) { }

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
yiguolei commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1363748836 ## be/src/pipeline/task_scheduler.cpp: ## @@ -228,8 +228,6 @@ void TaskScheduler::_do_work(size_t index) { }

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1768298790 TeamCity be ut coverage result: Function Coverage: 37.01% (8278/22369) Line Coverage: 29.08% (66403/228343) Region Coverage: 27.73% (34464/124283) Branch Coverage:

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1768270879 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1768270250 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1363718042 ## be/src/runtime/fragment_mgr.cpp: ## @@ -951,6 +959,14 @@ void FragmentMgr::_set_scan_concurrency(const Param& params, QueryContext* query #endif }

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1363714603 ## be/src/runtime/fragment_mgr.cpp: ## @@ -951,6 +959,14 @@ void FragmentMgr::_set_scan_concurrency(const Param& params, QueryContext* query #endif }

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1768254183 run P0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1768247277 run P0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1768125360 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.77 seconds stream load tsv: 557 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1768116148 TeamCity be ut coverage result: Function Coverage: 37.00% (8276/22369) Line Coverage: 29.07% (66382/228342) Region Coverage: 27.72% (34451/124279) Branch Coverage:

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
github-actions[bot] commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1363580642 ## be/src/runtime/fragment_mgr.cpp: ## @@ -951,6 +955,14 @@ void FragmentMgr::_set_scan_concurrency(const Param& params, QueryContext* query #endif }

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-18 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1768067812 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1767633542 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.11 seconds stream load tsv: 576 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1767623484 TeamCity be ut coverage result: Function Coverage: 37.01% (8282/22379) Line Coverage: 29.09% (66445/228400) Region Coverage: 27.75% (34484/124285) Branch Coverage:

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1767609257 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1766110753 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.96 seconds stream load tsv: 556 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1766079451 TeamCity be ut coverage result: Function Coverage: 37.02% (8281/22372) Line Coverage: 29.07% (66435/228536) Region Coverage: 27.75% (34465/124201) Branch Coverage:

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1766028144 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1765969067 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.42 seconds stream load tsv: 550 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
doris-robot commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1765947530 TeamCity be ut coverage result: Function Coverage: 37.01% (8282/22375) Line Coverage: 29.06% (66432/228567) Region Coverage: 27.75% (34465/124216) Branch Coverage:

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
github-actions[bot] commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1361728413 ## be/src/runtime/fragment_mgr.cpp: ## @@ -951,6 +951,14 @@ void FragmentMgr::_set_scan_concurrency(const Param& params, QueryContext* query #endif }

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
github-actions[bot] commented on code in PR #25524: URL: https://github.com/apache/doris/pull/25524#discussion_r1361723807 ## be/src/runtime/fragment_mgr.cpp: ## @@ -951,6 +951,14 @@ void FragmentMgr::_set_scan_concurrency(const Param& params, QueryContext* query #endif }

Re: [PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
zhiqiang- commented on PR #25524: URL: https://github.com/apache/doris/pull/25524#issuecomment-1765909973 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [Fix](query execution) Fix result sink fragment can't be cancelled in non-pipeline [doris]

2023-10-17 Thread via GitHub
zhiqiang- opened a new pull request, #25524: URL: https://github.com/apache/doris/pull/25524 close https://github.com/apache/doris/issues/25523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go