Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-12 Thread via GitHub
qidaye merged PR #26689: URL: https://github.com/apache/doris/pull/26689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-11 Thread via GitHub
github-actions[bot] commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1807019289 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-11 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1806854544 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.44 seconds stream load tsv: 556 seconds loaded 74807831229 Bytes,

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-11 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1806851980 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit e09def9222dd6308179f0007d84fcf41e6c15c9a, data reload: false

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-11 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1806851043 TeamCity be ut coverage result: Function Coverage: 36.78% (8408/22863) Line Coverage: 29.28% (68142/232757) Region Coverage: 27.90% (35228/126260) Branch Coverage:

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-11 Thread via GitHub
airborne12 commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1806849975 > could we provide any performance result? updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-11 Thread via GitHub
airborne12 commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1806846701 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-11 Thread via GitHub
github-actions[bot] commented on code in PR #26689: URL: https://github.com/apache/doris/pull/26689#discussion_r1390243461 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -2127,35 +2205,28 @@ } } -void SegmentIterator::_build_index_result_column(uint16_t*

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-11 Thread via GitHub
airborne12 commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1806844081 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-11 Thread via GitHub
airborne12 commented on code in PR #26689: URL: https://github.com/apache/doris/pull/26689#discussion_r1390227681 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -189,9 +193,38 @@ class SegmentIterator::BackwardBitmapRangeIterator : public SegmentIterator::Bit

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-11 Thread via GitHub
airborne12 commented on code in PR #26689: URL: https://github.com/apache/doris/pull/26689#discussion_r1390221566 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -189,9 +193,38 @@ class SegmentIterator::BackwardBitmapRangeIterator : public SegmentIterator::Bit

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-10 Thread via GitHub
zzzxl1993 commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1806696548 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-10 Thread via GitHub
xiaokang commented on code in PR #26689: URL: https://github.com/apache/doris/pull/26689#discussion_r1390106600 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -189,9 +193,38 @@ class SegmentIterator::BackwardBitmapRangeIterator : public SegmentIterator::Bit

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-10 Thread via GitHub
github-actions[bot] commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1806652984 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-10 Thread via GitHub
github-actions[bot] commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1806652997 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-10 Thread via GitHub
xiaokang commented on code in PR #26689: URL: https://github.com/apache/doris/pull/26689#discussion_r1390101855 ## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ## @@ -1614,53 +1647,27 @@ Status SegmentIterator::_read_columns_by_index(uint32_t nrows_read_limit, uint32

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1805067646 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 868c6b6e46dfaf73dd7644b8b1c4b51e5b58f5bf, data reload: false

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1805059263 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.92 seconds stream load tsv: 558 seconds loaded 74807831229 Bytes,

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1805016993 TeamCity be ut coverage result: Function Coverage: 36.76% (8403/22858) Line Coverage: 29.26% (68101/232731) Region Coverage: 27.89% (35209/126223) Branch Coverage:

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
eldenmoon commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1804983198 could we provide any performance result? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
github-actions[bot] commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1804967208 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
airborne12 commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1804962817 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1804126017 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.68 seconds stream load tsv: 558 seconds loaded 74807831229 Bytes,

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1804123760 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 9b13941ca68c11f0c290ab745ad05713315163b9, data reload: false

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1804089716 TeamCity be ut coverage result: Function Coverage: 36.75% (8396/22849) Line Coverage: 29.24% (68071/232773) Region Coverage: 27.88% (35209/126268) Branch Coverage:

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
github-actions[bot] commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1804058780 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
airborne12 commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-180403 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1803756382 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 8c74f262b939a6f80d1b0fdec63f11d454cd77ef, data reload: false

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1803712974 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.93 seconds stream load tsv: 555 seconds loaded 74807831229 Bytes,

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
doris-robot commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1803670587 TeamCity be ut coverage result: Function Coverage: 36.73% (8392/22847) Line Coverage: 29.22% (68017/232751) Region Coverage: 27.87% (35183/126244) Branch Coverage:

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
github-actions[bot] commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1803613911 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
airborne12 commented on PR #26689: URL: https://github.com/apache/doris/pull/26689#issuecomment-1803605097 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [Improvement](segment iterator) remove range in first read to save time [doris]

2023-11-09 Thread via GitHub
airborne12 opened a new pull request, #26689: URL: https://github.com/apache/doris/pull/26689 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at