Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-06 Thread via GitHub
github-actions[bot] commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1879944131 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-06 Thread via GitHub
yiguolei merged PR #28556: URL: https://github.com/apache/doris/pull/28556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-06 Thread via GitHub
github-actions[bot] commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1879931697 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1879465680 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1879153266 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.24 seconds stream load tsv: 566 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1879151420 TeamCity be ut coverage result: Function Coverage: 36.61% (8624/23557) Line Coverage: 28.65% (70119/244779) Region Coverage: 27.62% (36294/131386) Branch Coverage:

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1879148130 TPC-DS: Total hot run time: 184744 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1879138754 TPC-H: Tpch sf100 test result on commit f50b019eb5bc1786aa89788d0a4be305b13bdb77, data reload: false run tpch-sf100 query with default conf and session variables q1

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1879135400 TPC-H: Total hot run time: 38692 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1879072265 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1878445698 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1878390076 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1878317017 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1878313810 TeamCity be ut coverage result: Function Coverage: 36.63% (8622/23540) Line Coverage: 28.66% (70065/244428) Region Coverage: 27.65% (36275/131203) Branch Coverage:

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1878312539 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.24 seconds stream load tsv: 563 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1878310286 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-05 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1878296352 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-04 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1878251468 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-04 Thread via GitHub
amorynan commented on code in PR #28556: URL: https://github.com/apache/doris/pull/28556#discussion_r1442543994 ## be/src/vec/functions/function_ip.h: ## @@ -348,4 +348,138 @@ class FunctionIPv6NumToString : public IFunction { } }; +class FunctionIsIPv4String : public

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-04 Thread via GitHub
amorynan commented on code in PR #28556: URL: https://github.com/apache/doris/pull/28556#discussion_r1442541249 ## be/src/vec/functions/function_ip.h: ## @@ -348,4 +348,138 @@ class FunctionIPv6NumToString : public IFunction { } }; +class FunctionIsIPv4String : public

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-30 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1872684303 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-30 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1872669491 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.18 seconds stream load tsv: 576 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-30 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1872668016 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 93746c7b392119ed538445593e01d672d7e46baf, data reload: false run

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-30 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1872665627 TeamCity be ut coverage result: Function Coverage: 36.62% (8618/23535) Line Coverage: 28.67% (70040/244258) Region Coverage: 27.67% (36253/131037) Branch Coverage:

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-30 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1872657081 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-30 Thread via GitHub
github-actions[bot] commented on code in PR #28556: URL: https://github.com/apache/doris/pull/28556#discussion_r1438670934 ## be/src/vec/runtime/ipv4_value.h: ## @@ -70,6 +79,23 @@ class IPv4Value { return {buf, len}; } +static bool is_valid_string(const

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-30 Thread via GitHub
github-actions[bot] commented on code in PR #28556: URL: https://github.com/apache/doris/pull/28556#discussion_r1438668584 ## be/src/vec/runtime/ipv4_value.h: ## @@ -70,6 +75,22 @@ class IPv4Value { return {buf, len}; } +static bool is_valid_string(const

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-29 Thread via GitHub
amorynan commented on code in PR #28556: URL: https://github.com/apache/doris/pull/28556#discussion_r1438098261 ## be/src/vec/functions/function_ip.h: ## @@ -348,4 +348,108 @@ class FunctionIPv6NumToString : public IFunction { } }; +class FunctionIsIPv4String : public

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-29 Thread via GitHub
amorynan commented on code in PR #28556: URL: https://github.com/apache/doris/pull/28556#discussion_r1438097228 ## be/src/vec/functions/function_ip.h: ## @@ -348,4 +348,108 @@ class FunctionIPv6NumToString : public IFunction { } }; +class FunctionIsIPv4String : public

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-29 Thread via GitHub
amorynan commented on code in PR #28556: URL: https://github.com/apache/doris/pull/28556#discussion_r1438096015 ## be/src/vec/functions/function_ip.h: ## @@ -348,4 +348,108 @@ class FunctionIPv6NumToString : public IFunction { } }; +class FunctionIsIPv4String : public

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-29 Thread via GitHub
amorynan commented on code in PR #28556: URL: https://github.com/apache/doris/pull/28556#discussion_r1438094986 ## be/src/vec/functions/function_ip.h: ## @@ -348,4 +348,108 @@ class FunctionIPv6NumToString : public IFunction { } }; +class FunctionIsIPv4String : public

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-29 Thread via GitHub
amorynan commented on code in PR #28556: URL: https://github.com/apache/doris/pull/28556#discussion_r1438094534 ## be/src/vec/runtime/ipv6_value.h: ## @@ -65,6 +65,11 @@ class IPv6Value { return {buf, len}; } +static bool is_valid_string(const std::string&

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-28 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1870997900 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-27 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1870868831 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 43eb703a1703be1353e6aa7f04b1d6b9906e97e9, data reload: false run

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-27 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1870862164 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.88 seconds stream load tsv: 565 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-27 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1870845964 TeamCity be ut coverage result: Function Coverage: 36.63% (8590/23449) Line Coverage: 28.70% (69836/243368) Region Coverage: 27.68% (36128/130504) Branch Coverage:

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-27 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1870819460 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1867216558 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.77 seconds stream load tsv: 568 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1867212321 TeamCity be ut coverage result: Function Coverage: 36.45% (8537/23419) Line Coverage: 28.58% (69402/242843) Region Coverage: 27.59% (35907/130126) Branch Coverage:

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
nanfeng1999 commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1867155674 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1866422707 TeamCity be ut coverage result: Function Coverage: 36.46% (8539/23419) Line Coverage: 28.59% (69433/242874) Region Coverage: 27.61% (35930/130139) Branch Coverage:

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1866381868 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit cfb3f1ccb0fb51b26e90075f7648568a38735da8, data reload: false run

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
nanfeng1999 commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1866258528 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
nanfeng1999 commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1866150052 run arm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
nanfeng1999 commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1866062057 run arm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1865878289 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit cfb3f1ccb0fb51b26e90075f7648568a38735da8, data reload: false run

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
nanfeng1999 commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1865849603 run arm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1865823211 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.11 seconds stream load tsv: 569 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-20 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1865811656 TeamCity be ut coverage result: Function Coverage: 36.46% (8538/23420) Line Coverage: 28.58% (69400/242841) Region Coverage: 27.60% (35912/130109) Branch Coverage:

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-20 Thread via GitHub
nanfeng1999 commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1865746783 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-18 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1859747923 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-18 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1859727299 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit cfb3f1ccb0fb51b26e90075f7648568a38735da8, data reload: false run

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-17 Thread via GitHub
doris-robot commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1859708120 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.73 seconds stream load tsv: 577 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-17 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1859664604 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-17 Thread via GitHub
github-actions[bot] commented on code in PR #28556: URL: https://github.com/apache/doris/pull/28556#discussion_r1429578055 ## be/src/vec/functions/function_ip.h: ## @@ -348,4 +348,108 @@ } }; +class FunctionIsIPv4String : public IFunction { +private: +Status

[PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2023-12-17 Thread via GitHub
sjyango opened a new pull request, #28556: URL: https://github.com/apache/doris/pull/28556 ## Proposed changes Issue Number: #20584 doris output: https://github.com/apache/doris/assets/114391101/098ef9ef-b7a9-47e3-a22b-af810f0eaa65;>