Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-16 Thread via GitHub
morningman commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1764595057 Fixed by #25496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-16 Thread via GitHub
morningman closed pull request #25434: [fix](Backup) use correct variable name to check the conf correctness when doing backup job URL: https://github.com/apache/doris/pull/25434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1764343367 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763814355 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763814117 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-16 Thread via GitHub
ByteYue commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763806075 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763798933 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763668794 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.35 seconds stream load tsv: 562 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763661022 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.13 seconds stream load tsv: 561 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763658461 TeamCity be ut coverage result: Function Coverage: 36.64% (8228/22457) Line Coverage: 28.77% (65939/229155) Region Coverage: 27.49% (34200/124429) Branch Coverage:

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763658919 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.72 seconds stream load tsv: 562 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763651075 TeamCity be ut coverage result: Function Coverage: 36.64% (8228/22457) Line Coverage: 28.78% (65941/229156) Region Coverage: 27.49% (34210/124429) Branch Coverage:

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763650359 TeamCity be ut coverage result: Function Coverage: 36.65% (8230/22457) Line Coverage: 28.78% (65962/229156) Region Coverage: 27.49% (34208/124429) Branch Coverage:

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
github-actions[bot] commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763645441 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
github-actions[bot] commented on code in PR #25434: URL: https://github.com/apache/doris/pull/25434#discussion_r1360046918 ## be/src/util/s3_util.cpp: ## @@ -181,8 +183,33 @@ std::shared_ptr S3ClientFactory::create(const S3Conf& s3_conf return new_client; } +std::map

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
ByteYue commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763640082 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
ByteYue commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763638934 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
github-actions[bot] commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763637487 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
ByteYue commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763632151 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763352570 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.5 seconds stream load tsv: 574 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763348116 TeamCity be ut coverage result: Function Coverage: 36.64% (8228/22456) Line Coverage: 28.78% (65933/229132) Region Coverage: 27.48% (34197/124422) Branch Coverage:

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
github-actions[bot] commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763345299 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-15 Thread via GitHub
ByteYue commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1763343293 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-14 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1762892797 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.08 seconds stream load tsv: 552 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-14 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1762889545 TeamCity be ut coverage result: Function Coverage: 36.27% (8145/22456) Line Coverage: 28.50% (65299/229133) Region Coverage: 27.19% (33824/124421) Branch Coverage:

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-14 Thread via GitHub
github-actions[bot] commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1762885577 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-14 Thread via GitHub
ByteYue commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1762883673 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1761449475 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.94 seconds stream load tsv: 552 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1761432265 TeamCity be ut coverage result: Function Coverage: 36.27% (8144/22454) Line Coverage: 28.50% (65288/229117) Region Coverage: 27.18% (33810/124411) Branch Coverage:

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-13 Thread via GitHub
github-actions[bot] commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1761404297 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-13 Thread via GitHub
ByteYue opened a new pull request, #25434: URL: https://github.com/apache/doris/pull/25434 ## Proposed changes Issue Number: close #xxx When using backup on doris, user might encounter following error

Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]

2023-10-13 Thread via GitHub
ByteYue commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1761395601 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To