Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-16 Thread via GitHub
dataroaring merged PR #25420: URL: https://github.com/apache/doris/pull/25420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-15 Thread via GitHub
github-actions[bot] commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1763689104 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-15 Thread via GitHub
github-actions[bot] commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1763689060 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761230569 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.58 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761225421 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.25 seconds stream load tsv: 560 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761199760 TeamCity be ut coverage result: Function Coverage: 36.32% (8146/22427) Line Coverage: 28.52% (65319/229055) Region Coverage: 27.21% (33835/124355) Branch Coverage:

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761199364 TeamCity be ut coverage result: Function Coverage: 36.32% (8146/22427) Line Coverage: 28.51% (65315/229055) Region Coverage: 27.20% (33825/124355) Branch Coverage:

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
doris-robot commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761199135 TeamCity be ut coverage result: Function Coverage: 36.31% (8144/22427) Line Coverage: 28.51% (65297/229055) Region Coverage: 27.20% (33822/124355) Branch Coverage:

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
github-actions[bot] commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761163181 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
yujun777 commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761152425 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
github-actions[bot] commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761142561 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
yujun777 commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761131169 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
github-actions[bot] commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761128184 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
yujun777 commented on PR #25420: URL: https://github.com/apache/doris/pull/25420#issuecomment-1761115661 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [fix](path gc) fix data dir path gc [doris]

2023-10-13 Thread via GitHub
yujun777 opened a new pull request, #25420: URL: https://github.com/apache/doris/pull/25420 ## Proposed changes Data dir path gc include gc by tablet and gc by rowset, both use the same one thread. If notify to gc by rowset, but the gc thread is just waiting for gc by tablet, then