Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-28 Thread via GitHub
hust-hhb closed pull request #28756: [improvement](group commit) refector replay wal function URL: https://github.com/apache/doris/pull/28756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-22 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1867713347 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 74fa760b618438405b3595f54622662a7675ff39, data reload: false run

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-22 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1867711433 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.86 seconds stream load tsv: 578 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-22 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1867686201 TeamCity be ut coverage result: Function Coverage: 36.52% (8537/23374) Line Coverage: 28.61% (69418/242620) Region Coverage: 27.63% (35915/129982) Branch Coverage:

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-22 Thread via GitHub
github-actions[bot] commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1867642603 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-22 Thread via GitHub
hust-hhb commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1867635939 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-22 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1867445230 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit b41679ab54ad3eec3c9af8c9db7ad269a1550c57, data reload: false run

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-22 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1867374535 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.58 seconds stream load tsv: 568 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-22 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1867361742 TeamCity be ut coverage result: Function Coverage: 36.48% (8538/23404) Line Coverage: 28.59% (69433/242838) Region Coverage: 27.61% (35927/130119) Branch Coverage:

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1867341670 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
hust-hhb commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1867337061 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1866931727 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.07 seconds stream load tsv: 569 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1866913239 TeamCity be ut coverage result: Function Coverage: 36.47% (8537/23406) Line Coverage: 28.59% (69426/242843) Region Coverage: 27.61% (35923/130109) Branch Coverage:

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1866889076 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
hust-hhb commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1866882733 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1866422030 TeamCity be ut coverage result: Function Coverage: 36.47% (8536/23404) Line Coverage: 28.60% (69425/242751) Region Coverage: 27.61% (35919/130078) Branch Coverage:

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1866408660 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit d89ebb23a215ad0f4cfc64f0ddd9e7beb4e3fe5b, data reload: false run

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1866408100 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.98 seconds stream load tsv: 569 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
dataroaring commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1866331323 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-21 Thread via GitHub
github-actions[bot] commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1866149198 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
github-actions[bot] commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1865696767 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1865490907 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 43.78 seconds stream load tsv: 580 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1865482592 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit c6c0ee582892ade1e94756f211cdb1b939cfaca1, data reload: false run

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1865481959 TeamCity be ut coverage result: Function Coverage: 36.47% (8536/23405) Line Coverage: 28.59% (69401/242729) Region Coverage: 27.61% (35913/130054) Branch Coverage:

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
github-actions[bot] commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1865472186 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
hust-hhb commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1865463380 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
github-actions[bot] commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1865462867 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1865058911 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.32 seconds stream load tsv: 570 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1865045282 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 390555b9bd1efcffd41a46bce61532a5fb7ff451, data reload: false run

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
hust-hhb commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1865006344 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1864980442 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 44.27 seconds stream load tsv: 575 seconds loaded 74807831229 Bytes,

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
doris-robot commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1864962817 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Tpch sf100 test result on commit 03c53890912f2a38635de87e9b9748e742f405a9, data reload: false run

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
github-actions[bot] commented on code in PR #28756: URL: https://github.com/apache/doris/pull/28756#discussion_r1433033906 ## be/src/olap/wal_table.h: ## @@ -15,15 +15,22 @@ // specific language governing permissions and limitations // under the License. #pragma once

Re: [PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
hust-hhb commented on PR #28756: URL: https://github.com/apache/doris/pull/28756#issuecomment-1864908725 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [improvement](group commit) refector replay wal function [doris]

2023-12-20 Thread via GitHub
hust-hhb opened a new pull request, #28756: URL: https://github.com/apache/doris/pull/28756 ## Proposed changes now be replaying wal by sending a http request, which is not reliable, change it to use stream load internal infector is a better way. ## Further comments