Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
dataroaring merged PR #34526: URL: https://github.com/apache/doris/pull/34526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
xinyiZzz commented on code in PR #34526: URL: https://github.com/apache/doris/pull/34526#discussion_r1593964105 ## be/src/common/config.cpp: ## @@ -1053,6 +1053,10 @@ DEFINE_mInt32(schema_cache_sweep_time_sec, "100"); // max number of segment cache, default -1 for backward

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
github-actions[bot] commented on PR #34526: URL: https://github.com/apache/doris/pull/34526#issuecomment-2100425644 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
github-actions[bot] commented on PR #34526: URL: https://github.com/apache/doris/pull/34526#issuecomment-2100425578 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
github-actions[bot] commented on PR #34526: URL: https://github.com/apache/doris/pull/34526#issuecomment-2100056418 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
Lchangliang commented on PR #34526: URL: https://github.com/apache/doris/pull/34526#issuecomment-2100045752 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
Lchangliang commented on code in PR #34526: URL: https://github.com/apache/doris/pull/34526#discussion_r1593541497 ## be/src/olap/rowset/segment_v2/segment.cpp: ## @@ -408,6 +408,7 @@ Status Segment::_create_column_readers(const SegmentFooterPB& footer) {

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
xinyiZzz commented on code in PR #34526: URL: https://github.com/apache/doris/pull/34526#discussion_r1593531683 ## be/src/olap/rowset/segment_v2/segment.cpp: ## @@ -408,6 +408,7 @@ Status Segment::_create_column_readers(const SegmentFooterPB& footer) {

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
xinyiZzz commented on PR #34526: URL: https://github.com/apache/doris/pull/34526#issuecomment-2099935198 ![image](https://github.com/apache/doris/assets/13197424/fc167873-4256-4bdb-8407-b9965e75daee) ``` auto* lru_handle = LRUCachePolicy::insert( key.encode(), , 1,

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
github-actions[bot] commented on PR #34526: URL: https://github.com/apache/doris/pull/34526#issuecomment-2099934088 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
Lchangliang commented on PR #34526: URL: https://github.com/apache/doris/pull/34526#issuecomment-2099924079 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Improve] Estimated column reader memory to control segment cache [doris]

2024-05-08 Thread via GitHub
doris-robot commented on PR #34526: URL: https://github.com/apache/doris/pull/34526#issuecomment-2099923883 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your