[GitHub] [incubator-doris] kangpinghuang commented on issue #2233: fix schema change validate failure #2230

kangpinghuang commented on issue #2233: fix schema change validate failure #2230 URL: https://github.com/apache/incubator-doris/pull/2233#issuecomment-555384058 related issue # 2233 This is an automated message from the

[incubator-doris] branch master updated (23078a5 -> 4984be9)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 23078a5 Avoid Chinese garbled for streamLoad java sample (#2229) add 4984be9 Persist sqlmode in

[incubator-doris] branch master updated: Change sqlmode 'required' to 'optional' in forward master request, (#2236)

This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new db8819d Change sqlmode 'required' to

[GitHub] [incubator-doris] imay merged pull request #2236: Change sqlmode 'required' to 'optional' in forward master request,

imay merged pull request #2236: Change sqlmode 'required' to 'optional' in forward master request, URL: https://github.com/apache/incubator-doris/pull/2236 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #2233: fix schema change validate failure #2230

kangpinghuang opened a new pull request #2233: fix schema change validate failure #2230 URL: https://github.com/apache/incubator-doris/pull/2233 fix schema change failure because of row number check failed This is an

[incubator-doris] branch master updated: Improve to_bitmap parse int performance (#2223)

This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 14769b0 Improve to_bitmap parse int

[GitHub] [incubator-doris] imay merged pull request #2223: Improve to_bitmap parse int performance

imay merged pull request #2223: Improve to_bitmap parse int performance URL: https://github.com/apache/incubator-doris/pull/2223 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] kangpinghuang closed pull request #2233: fix schema change validate failure #2230

kangpinghuang closed pull request #2233: fix schema change validate failure #2230 URL: https://github.com/apache/incubator-doris/pull/2233 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] vagetablechicken opened a new pull request #2235: Support setting properties for storage_root_path

vagetablechicken opened a new pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235 ref https://github.com/apache/incubator-doris/issues/2195 We can specify the properties of storage_root_path by setting ':',

[incubator-doris] branch master updated (db8819d -> 42a4fff)

This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from db8819d Change sqlmode 'required' to 'optional' in forward master request, (#2236) add 42a4fff

[GitHub] [incubator-doris] imay merged pull request #2209: Change replace boost canonicalize

imay merged pull request #2209: Change replace boost canonicalize URL: https://github.com/apache/incubator-doris/pull/2209 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] imay commented on a change in pull request #2216: Persist sqlmode in load metadata and add sqlmode to forward master request

imay commented on a change in pull request #2216: Persist sqlmode in load metadata and add sqlmode to forward master request URL: https://github.com/apache/incubator-doris/pull/2216#discussion_r347803664 ## File path: gensrc/thrift/FrontendService.thrift ## @@ -413,6

[GitHub] [incubator-doris] xy720 opened a new pull request #2236: Change sqlmode 'required' to 'optional' in forward master request,

xy720 opened a new pull request #2236: Change sqlmode 'required' to 'optional' in forward master request, URL: https://github.com/apache/incubator-doris/pull/2236 Fix the previous pull request. This commit will change sqlMode param's modifier from 'required' to 'optional' in forward

[GitHub] [incubator-doris] imay commented on a change in pull request #2223: Improve to_bitmap parse int performance

imay commented on a change in pull request #2223: Improve to_bitmap parse int performance URL: https://github.com/apache/incubator-doris/pull/2223#discussion_r347828967 ## File path: be/test/util/string_parser_test.cpp ## @@ -209,13 +224,59 @@ TEST(StringToInt, Limit) {

[GitHub] [incubator-doris] kangpinghuang closed issue #1195: Optimize meta tool for be_refactor

kangpinghuang closed issue #1195: Optimize meta tool for be_refactor URL: https://github.com/apache/incubator-doris/issues/1195 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] kangpinghuang commented on issue #2247: add a flag mechanism for FE to control all BEs' behaviour

kangpinghuang commented on issue #2247: add a flag mechanism for FE to control all BEs' behaviour URL: https://github.com/apache/incubator-doris/issues/2247#issuecomment-555805219 There are two flag bits for Issue #2245, one for set the default rowset type to BETA; one for set the

[GitHub] [incubator-doris] kangpinghuang opened a new issue #2247: add a flag mechanism for FE to control all BEs' behaviour

kangpinghuang opened a new issue #2247: add a flag mechanism for FE to control all BEs' behaviour URL: https://github.com/apache/incubator-doris/issues/2247 **Is your feature request related to a problem? Please describe.** Now, Doris lack a mechinism for FE to control all BEs. To solve

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2241: Fix some bugs about load label

EmmyMiao87 commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r348266634 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -231,20 +225,20 @@

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2241: Fix some bugs about load label

EmmyMiao87 commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r348266288 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -135,23 +135,17 @@

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2241: Fix some bugs about load label

EmmyMiao87 commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r348266093 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -135,23 +135,17 @@

[GitHub] [incubator-doris] kangpinghuang commented on issue #1389: Support bloom filter in new format segment

kangpinghuang commented on issue #1389: Support bloom filter in new format segment URL: https://github.com/apache/incubator-doris/issues/1389#issuecomment-555811201 I will solve this issue. Here is my basic design: 1. use BlockedBloomFilter to realize the bloom filter format, ref:

[GitHub] [incubator-doris] gaodayue opened a new pull request #2050: segment_v2: Support bitmap index build

gaodayue opened a new pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050 This PR implements the build part of bitmap index support. It follows most of the design described in #1684 , but with the following differences and

[GitHub] [incubator-doris] imay closed pull request #2050: segment_v2: Support bitmap index build

imay closed pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348316710 ## File path: extension/spark-doris-connector/pom.xml ## @@ -0,0 +1,162 @@ + Review comment:

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348327831 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +# Spark-Doris-Connector

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348328880 ## File path:

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348328096 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +# Spark-Doris-Connector

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348328510 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348330926 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348330174 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348330380 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348329350 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348331072 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348331947 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348330642 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[incubator-doris] branch master updated (9b5eeae -> 9be86a3)

This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 9b5eeae Fix bug that DeployManager should start working after catalog is ready. (#2244) add 9be86a3

[GitHub] [incubator-doris] imay merged pull request #2238: Add gutil split and strip tool

imay merged pull request #2238: Add gutil split and strip tool URL: https://github.com/apache/incubator-doris/pull/2238 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] chaoyli merged pull request #2253: fix npe for null stats

chaoyli merged pull request #2253: fix npe for null stats URL: https://github.com/apache/incubator-doris/pull/2253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[incubator-doris] branch master updated (46005bf -> aedccc4)

This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 46005bf Fix bug for show create table statement with unique key types (#2231) add aedccc4 fix

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #2253: fix npe for null stats

kangpinghuang opened a new pull request #2253: fix npe for null stats URL: https://github.com/apache/incubator-doris/pull/2253 fix npe for null stats when schema change. This is an automated message from the Apache Git

[GitHub] [incubator-doris] xy720 commented on a change in pull request #2252: Add pipes_as_concat_mode

xy720 commented on a change in pull request #2252: Add pipes_as_concat_mode URL: https://github.com/apache/incubator-doris/pull/2252#discussion_r348318076 ## File path: fe/src/main/jflex/sql_scanner.flex ## @@ -352,7 +352,7 @@ import org.apache.doris.common.util.SqlUtils;

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348332359 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/serialization/RowBatch.java

[GitHub] [incubator-doris] morningman merged pull request #2244: Fix bug that DeployManager should start working after catalog is ready.

morningman merged pull request #2244: Fix bug that DeployManager should start working after catalog is ready. URL: https://github.com/apache/incubator-doris/pull/2244 This is an automated message from the Apache Git

[incubator-doris] branch master updated: Fix bug that DeployManager should start working after catalog is ready. (#2244)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 9b5eeae Fix bug that

[GitHub] [incubator-doris] kangpinghuang opened a new issue #2245: support online upgrade from alpha rowset to beta rowset

kangpinghuang opened a new issue #2245: support online upgrade from alpha rowset to beta rowset URL: https://github.com/apache/incubator-doris/issues/2245 In order to support dictionary encoding and bitmap index, we develop new file storage format: segment_v2(#1305 ), and add a new Rowset

[GitHub] [incubator-doris] kangpinghuang commented on issue #2248: add a mechanism to convert all AlphaRowsets in table to BetaRowset

kangpinghuang commented on issue #2248: add a mechanism to convert all AlphaRowsets in table to BetaRowset URL: https://github.com/apache/incubator-doris/issues/2248#issuecomment-555808636 Maybe we shoule export a api to convert one table's format from Alpha to Beta for users who want to

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #2248: add a mechanism to convert all AlphaRowsets in table to BetaRowset

kangpinghuang edited a comment on issue #2248: add a mechanism to convert all AlphaRowsets in table to BetaRowset URL: https://github.com/apache/incubator-doris/issues/2248#issuecomment-555808636 Maybe we shoule export **a api to convert one table's format** from Alpha to Beta for users

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build

gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r348272133 ## File path: gensrc/proto/segment_v2.proto ## @@ -164,3 +166,51 @@ message SegmentFooterPB {

[GitHub] [incubator-doris] xy720 opened a new issue #2251: String | | String Syntax not supported in Doris

xy720 opened a new issue #2251: String | | String Syntax not supported in Doris URL: https://github.com/apache/incubator-doris/issues/2251 String | | String Syntax is a required test in tp-cds benchmark but it is not supported for Doris, we can rewrite is as concat (string, string).

[GitHub] [incubator-doris] imay commented on a change in pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error

imay commented on a change in pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error URL: https://github.com/apache/incubator-doris/pull/2254#discussion_r348303308 ## File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.java ##

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348317327 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +# Spark-Doris-Connector

[GitHub] [incubator-doris] kangpinghuang opened a new issue #2249: add a mechanism for FE to collect the table's format statistics

kangpinghuang opened a new issue #2249: add a mechanism for FE to collect the table's format statistics URL: https://github.com/apache/incubator-doris/issues/2249 For issue #2245 , in order to be aware of the convert process from AlphaRowset to BetaRowset, we need a mechanism to know the

[GitHub] [incubator-doris] xy720 opened a new pull request #2252: Add pipes_as_concat_mode

xy720 opened a new pull request #2252: Add pipes_as_concat_mode URL: https://github.com/apache/incubator-doris/pull/2252 ISSUE #2251 This commit will add a new sql mode named MODE_PIPES_AS_CONCAT: Description: 1、If this mode is active, '||' will be handled different from the

[GitHub] [incubator-doris] xy720 commented on a change in pull request #2252: Add pipes_as_concat_mode

xy720 commented on a change in pull request #2252: Add pipes_as_concat_mode URL: https://github.com/apache/incubator-doris/pull/2252#discussion_r348318076 ## File path: fe/src/main/jflex/sql_scanner.flex ## @@ -352,7 +352,7 @@ import org.apache.doris.common.util.SqlUtils;

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #2247: add a flag mechanism for FE to control all BEs' behaviour

kangpinghuang edited a comment on issue #2247: add a flag mechanism for FE to control all BEs' behaviour URL: https://github.com/apache/incubator-doris/issues/2247#issuecomment-555805219 There are two flag bits for Issue #2245, - one for set the default rowset type to BETA;

[GitHub] [incubator-doris] wkhappy1 opened a new pull request #2250: fix export to hdfs bug

wkhappy1 opened a new pull request #2250: fix export to hdfs bug URL: https://github.com/apache/incubator-doris/pull/2250 can not export table to hdfs thanks to @imay help This is an automated message from the Apache Git

[GitHub] [incubator-doris] caiconghui opened a new issue #2255: Showing columns from non exist table doesn't prompt error

caiconghui opened a new issue #2255: Showing columns from non exist table doesn't prompt error URL: https://github.com/apache/incubator-doris/issues/2255 **Describe the bug** showing columns from non exist table doesn't prompt error **To Reproduce** Steps to reproduce the

[GitHub] [incubator-doris] caiconghui commented on issue #2242: Is that will be better create table with column default enable to be null?

caiconghui commented on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-555850786 or it will be better nullable default for normal column and not nullable default for key

[GitHub] [incubator-doris] imay commented on issue #2242: Is that will be better create table with column default enable to be null?

imay commented on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-555854684 @caiconghui Now we have no restrict on key columns and value columns. So it is OK to make

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2252: Add pipes_as_concat_mode

EmmyMiao87 commented on a change in pull request #2252: Add pipes_as_concat_mode URL: https://github.com/apache/incubator-doris/pull/2252#discussion_r348306895 ## File path: fe/src/main/jflex/sql_scanner.flex ## @@ -352,7 +352,7 @@ import

[incubator-doris] branch master updated (aedccc4 -> d72fbdf)

This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from aedccc4 fix npe for null stats (#2253) add d72fbdf Support bitmap index build (#2050) No new

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348324265 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +#

[GitHub] [incubator-doris] caiconghui opened a new pull request #2256: Create table with nullable column for default

caiconghui opened a new pull request #2256: Create table with nullable column for default URL: https://github.com/apache/incubator-doris/pull/2256 on production enviroment, create table usually with so many nullable columns,so default nullable for column will be better

[GitHub] [incubator-doris] kangpinghuang opened a new issue #2246: specify storage format for newly created table

kangpinghuang opened a new issue #2246: specify storage format for newly created table URL: https://github.com/apache/incubator-doris/issues/2246 For issue #2245 , to solve problem No.1, we should add a method to specify the storage format for newly created table. here is a method:

[GitHub] [incubator-doris] kangpinghuang opened a new issue #2248: add a mechanism to convert all AlphaRowsets in table to BetaRowset

kangpinghuang opened a new issue #2248: add a mechanism to convert all AlphaRowsets in table to BetaRowset URL: https://github.com/apache/incubator-doris/issues/2248 For issue #2245 , in the final phase, we should convert all AlphaRowsets to BetaRowset, and need a method to make sure to

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build

gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r348275793 ## File path: be/src/olap/rowset/segment_v2/index_page.h ## @@ -0,0 +1,142 @@ +// Licensed to the

[GitHub] [incubator-doris] caiconghui opened a new pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error

caiconghui opened a new pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error URL: https://github.com/apache/incubator-doris/pull/2254 when we execute show columns statement for non exist table, the response from doris is nothing, which may make user

[GitHub] [incubator-doris] imay merged pull request #2231: Fix bug when create table using unique key and repalce aggragate type for non key column

imay merged pull request #2231: Fix bug when create table using unique key and repalce aggragate type for non key column URL: https://github.com/apache/incubator-doris/pull/2231 This is an automated message from the Apache

[incubator-doris] branch master updated (9be86a3 -> 46005bf)

This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 9be86a3 Add gutil split and strip tool (#2238) add 46005bf Fix bug for show create table statement

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348317170 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +#

[GitHub] [incubator-doris] caiconghui commented on issue #2256: Create table with nullable column for default

caiconghui commented on issue #2256: Create table with nullable column for default URL: https://github.com/apache/incubator-doris/pull/2256#issuecomment-555884900 #2242 This is an automated message from the Apache Git

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r347832159 ## File path: be/src/olap/options.h ## @@ -26,11 +26,14 @@ namespace doris { struct

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r347833986 ## File path: be/src/olap/options.cpp ## @@ -47,18 +47,63 @@ OLAPStatus

[GitHub] [incubator-doris] imay commented on issue #2235: Support setting properties for storage_root_path

imay commented on issue #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#issuecomment-555449216 @vagetablechicken 1. I think meta tool should not care about the medium of data path. 2. Even if meta tool care about

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2235: Support setting properties for storage_root_path

lingbin commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r347880981 ## File path: be/src/olap/data_dir.cpp ## @@ -55,12 +55,13 @@ namespace doris { static

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build

gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347888331 ## File path: be/src/olap/rowset/segment_v2/rle_page.h ## @@ -86,14 +86,12 @@ class RlePageBuilder :

[GitHub] [incubator-doris] lingbin opened a new issue #2239: Add gutil split and strip tool

lingbin opened a new issue #2239: Add gutil split and strip tool URL: https://github.com/apache/incubator-doris/issues/2239 With these two tools, we can very easily perform splitting and trimming operations on strings. In these tools, StringPiece is used to split a string, which

[GitHub] [incubator-doris] lingbin commented on issue #2238: Add gutil split and strip tool

lingbin commented on issue #2238: Add gutil split and strip tool URL: https://github.com/apache/incubator-doris/pull/2238#issuecomment-555487504 #2239 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] morningman commented on issue #2240: Fix some bugs about load label

morningman commented on issue #2240: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/issues/2240#issuecomment-00016 There still remaining a bug that load job's state is not consistent with transaction status. It looks like the job' state is LOADING but

[GitHub] [incubator-doris] imay commented on a change in pull request #2050: segment_v2: Support bitmap index build

imay commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347915326 ## File path: be/src/olap/rowset/segment_v2/encoding_info.cpp ## @@ -50,7 +55,7 @@ struct

[GitHub] [incubator-doris] caiconghui commented on issue #2232: When create table with unique key using replace type for non key column encounter error

caiconghui commented on issue #2232: When create table with unique key using replace type for non key column encounter error URL: https://github.com/apache/incubator-doris/issues/2232#issuecomment-02890 it seems that only show create table statement from no range partition table can

[GitHub] [incubator-doris] imay commented on a change in pull request #2050: segment_v2: Support bitmap index build

imay commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347915541 ## File path: gensrc/proto/segment_v2.proto ## @@ -48,12 +48,12 @@ message MetadataPairPB { enum

[GitHub] [incubator-doris] imay commented on a change in pull request #2050: segment_v2: Support bitmap index build

imay commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347915326 ## File path: be/src/olap/rowset/segment_v2/encoding_info.cpp ## @@ -50,7 +55,7 @@ struct

[GitHub] [incubator-doris] lingbin opened a new pull request #2238: Add gutil split and strip tool

lingbin opened a new pull request #2238: Add gutil split and strip tool URL: https://github.com/apache/incubator-doris/pull/2238 With these two tools, we can very easily perform splitting and trimming operations on strings. The subsequent PR will use them to replace the existing

[GitHub] [incubator-doris] imay commented on a change in pull request #2050: segment_v2: Support bitmap index build

imay commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347861228 ## File path: be/src/olap/rowset/segment_v2/rle_page.h ## @@ -86,14 +86,12 @@ class RlePageBuilder :

[GitHub] [incubator-doris] imay commented on a change in pull request #2050: segment_v2: Support bitmap index build

imay commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347872264 ## File path: be/src/olap/rowset/segment_v2/encoding_info.cpp ## @@ -50,7 +55,7 @@ struct

[GitHub] [incubator-doris] imay commented on a change in pull request #2050: segment_v2: Support bitmap index build

imay commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347862996 ## File path: be/src/olap/rowset/segment_v2/bitmap_index_writer.h ## @@ -0,0 +1,51 @@ +// Licensed to

[GitHub] [incubator-doris] imay commented on a change in pull request #2050: segment_v2: Support bitmap index build

imay commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347861808 ## File path: gensrc/proto/segment_v2.proto ## @@ -48,12 +48,12 @@ message MetadataPairPB { enum

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build

gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347888331 ## File path: be/src/olap/rowset/segment_v2/rle_page.h ## @@ -86,14 +86,12 @@ class RlePageBuilder :

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build

gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347894233 ## File path: gensrc/proto/segment_v2.proto ## @@ -48,12 +48,12 @@ message MetadataPairPB { enum

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build

gaodayue commented on a change in pull request #2050: segment_v2: Support bitmap index build URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r347898217 ## File path: be/src/olap/rowset/segment_v2/encoding_info.cpp ## @@ -50,7 +55,7 @@ struct

[GitHub] [incubator-doris] morningman opened a new issue #2240: Fix some bugs about load label

morningman opened a new issue #2240: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/issues/2240 1. `dbIdToTxnLabels` in `GlobalTransactionMgr` should be consistent with `idToTransactionState`, not only contains running or finished transactions' labels.

[GitHub] [incubator-doris] caiconghui opened a new issue #2242: Is that will be better create table with column default enable to be null?

caiconghui opened a new issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242 on production enviroment, create table usually with so many nullable columns, i think except key column, other column

[GitHub] [incubator-doris] vagetablechicken commented on issue #2235: Support setting properties for storage_root_path

vagetablechicken commented on issue #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#issuecomment-555438703 property medium has a higher priority, so I decide to set storage_medium in c'tor of DataDir, change

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #2235: Support setting properties for storage_root_path

vagetablechicken commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r347844509 ## File path: be/src/olap/options.h ## @@ -26,11 +26,14 @@ namespace doris {

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r347849961 ## File path: be/src/olap/options.h ## @@ -26,11 +26,14 @@ namespace doris { struct

[GitHub] [incubator-doris] imay merged pull request #2234: [gutil] Fix the line breaks to '\n'

imay merged pull request #2234: [gutil] Fix the line breaks to '\n' URL: https://github.com/apache/incubator-doris/pull/2234 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-doris] branch master updated (14769b0 -> 03a5359)

This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 14769b0 Improve to_bitmap parse int performance (#2223) add 03a5359 Fix the line breaks to '\n'

[GitHub] [incubator-doris] lingbin closed pull request #2238: Add gutil split and strip tool

lingbin closed pull request #2238: Add gutil split and strip tool URL: https://github.com/apache/incubator-doris/pull/2238 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] lingbin opened a new pull request #2238: Add gutil split and strip tool

lingbin opened a new pull request #2238: Add gutil split and strip tool URL: https://github.com/apache/incubator-doris/pull/2238 With these two tools, we can very easily perform splitting and trimming operations on strings. The subsequent PR will use them to replace the existing

  1   2   >