[GitHub] [incubator-doris] imay commented on a change in pull request #1828: Seek block when starts a ScanKey

imay commented on a change in pull request #1828: Seek block when starts a ScanKey URL: https://github.com/apache/incubator-doris/pull/1828#discussion_r326007261 ## File path: be/src/olap/rowset/segment_reader.h ## @@ -308,7 +308,7 @@ class SegmentReader { // If thi

[GitHub] [incubator-doris] HangyuanLiu commented on issue #1825: HLL support default value

HangyuanLiu commented on issue #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825#issuecomment-532987181 This PR will support this capability. There is a scenario where a Doris table may have multiple HLL columns that may come from different streams

[GitHub] [incubator-doris] imay commented on a change in pull request #1829: Remove the "author" tag

imay commented on a change in pull request #1829: Remove the "author" tag URL: https://github.com/apache/incubator-doris/pull/1829#discussion_r326004709 ## File path: be/src/gutil/utf/rune.c ## @@ -1,5 +1,4 @@ /* - * The authors of this software are Rob Pike and Ken Thomps

[GitHub] [incubator-doris] imay commented on a change in pull request #1829: Remove the "author" tag

imay commented on a change in pull request #1829: Remove the "author" tag URL: https://github.com/apache/incubator-doris/pull/1829#discussion_r326004828 ## File path: webroot/static/jquery.dataTables.js ## @@ -7,7 +7,6 @@ * @description Paginate, search and order HTML tab

[GitHub] [incubator-doris] imay commented on a change in pull request #1829: Remove the "author" tag

imay commented on a change in pull request #1829: Remove the "author" tag URL: https://github.com/apache/incubator-doris/pull/1829#discussion_r326004684 ## File path: be/src/gutil/utf/LICENSE ## @@ -1,6 +1,5 @@ UTF-8 Library -The authors of this software are Rob Pike and

[GitHub] [incubator-doris] imay commented on a change in pull request #1829: Remove the "author" tag

imay commented on a change in pull request #1829: Remove the "author" tag URL: https://github.com/apache/incubator-doris/pull/1829#discussion_r326004953 ## File path: be/src/gutil/dynamic_annotations.c ## @@ -28,7 +28,6 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIB

[GitHub] [incubator-doris] kangkaisen commented on issue #1825: HLL support default value

kangkaisen commented on issue #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825#issuecomment-532983775 > curl --location-trusted -u root:123456 -H column_separator:, -H label:test_uv_15 -H "columns:pin_id,idx,u1,u2,id=12" -T uv_test http://11.40.166.

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1818: Add frame_of_reference page

gaodayue commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325998239 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] xy720 opened a new pull request #1829: Remove the "author" tag

xy720 opened a new pull request #1829: Remove the "author" tag URL: https://github.com/apache/incubator-doris/pull/1829 Corresponding issue #1755 "Remove author tag in our code " This is an automated message from the Apache G

[GitHub] [incubator-doris] chaoyli opened a new pull request #1828: Seek block when starts a ScanKey

chaoyli opened a new pull request #1828: Seek block when starts a ScanKey URL: https://github.com/apache/incubator-doris/pull/1828 In Doris, one block has 1024 rows. 1. If the previous ScanKey scan rows multiple blocks, and also the final block has 1024 rows just right. 2. The c

[incubator-doris] branch master updated (e70e48c -> d1676c3)

This is an automated email from the ASF dual-hosted git repository. lichaoyong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from e70e48c Add a ALTER operation to change distribution type from RANDOM to HASH (#1823) add d1676c3

[GitHub] [incubator-doris] chaoyli merged pull request #1819: Check file descriptor number should between configuration upon start

chaoyli merged pull request #1819: Check file descriptor number should between configuration upon start URL: https://github.com/apache/incubator-doris/pull/1819 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325982719 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325982801 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325982286 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325982090 ## File path: be/src/util/frame_of_reference_coding.h ## @@ -0,0 +1,147 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325982103 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325981712 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325981689 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325981627 ## File path: be/src/olap/rowset/segment_v2/frame_of_reference_page.h ## @@ -0,0 +1,165 @@ +// Licensed to the

[GitHub] [incubator-doris] HangyuanLiu commented on issue #1825: HLL support default value

HangyuanLiu commented on issue #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825#issuecomment-532956046 Update example @imay This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1818: Add frame_of_reference page

gaodayue commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325964351 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1818: Add frame_of_reference page

gaodayue commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325979164 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1818: Add frame_of_reference page

gaodayue commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325968757 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1818: Add frame_of_reference page

gaodayue commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325980082 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1818: Add frame_of_reference page

gaodayue commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325969045 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1818: Add frame_of_reference page

gaodayue commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325964295 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1818: Add frame_of_reference page

gaodayue commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325961175 ## File path: be/src/olap/rowset/segment_v2/frame_of_reference_page.h ## @@ -0,0 +1,165 @@ +// Licensed to the A

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1818: Add frame_of_reference page

gaodayue commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325964763 ## File path: be/src/util/frame_of_reference_coding.h ## @@ -0,0 +1,147 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1825: HLL support default value

HangyuanLiu commented on a change in pull request #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825#discussion_r325976459 ## File path: be/src/olap/aggregate_func.h ## @@ -408,7 +408,11 @@ struct AggregateFuncTraitssize = sizeof(Hyp

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1825: HLL support default value

kangkaisen commented on a change in pull request #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825#discussion_r325972888 ## File path: be/src/olap/aggregate_func.h ## @@ -408,7 +408,11 @@ struct AggregateFuncTraitssize = sizeof(Hype

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325972183 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325972140 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325972164 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325972055 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1818: Add frame_of_reference page

kangkaisen commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325972082 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] imay opened a new issue #1827: DataStreamSender close channel serially

imay opened a new issue #1827: DataStreamSender close channel serially URL: https://github.com/apache/incubator-doris/issues/1827 Currently, in Doris code, DataStreamSender close all channels serially. It will make receivers wait for the results. It will cause that concurrent queries can n

[GitHub] [incubator-doris] imay commented on a change in pull request #1821: Add some profile metrics

imay commented on a change in pull request #1821: Add some profile metrics URL: https://github.com/apache/incubator-doris/pull/1821#discussion_r325716775 ## File path: gensrc/thrift/Metrics.thrift ## @@ -32,7 +32,8 @@ enum TUnit { // No units at all, may not be a numeric

[GitHub] [incubator-doris] imay commented on a change in pull request #1821: Add some profile metrics

imay commented on a change in pull request #1821: Add some profile metrics URL: https://github.com/apache/incubator-doris/pull/1821#discussion_r325718288 ## File path: be/src/util/pretty_printer.h ## @@ -145,7 +145,23 @@ class PrettyPrinter { ss << std::setprec

[GitHub] [incubator-doris] imay commented on a change in pull request #1821: Add some profile metrics

imay commented on a change in pull request #1821: Add some profile metrics URL: https://github.com/apache/incubator-doris/pull/1821#discussion_r325715448 ## File path: be/src/runtime/plan_fragment_executor.cpp ## @@ -354,6 +355,8 @@ Status PlanFragmentExecutor::open_interna

[GitHub] [incubator-doris] imay commented on issue #1825: HLL support default value

imay commented on issue #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825#issuecomment-532714987 @HangyuanLiu Can you add some document or usage example for this change? This is an a

[GitHub] [incubator-doris] imay commented on a change in pull request #1818: Add frame_of_reference page

imay commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325695691 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] imay commented on a change in pull request #1818: Add frame_of_reference page

imay commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325707828 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] imay commented on a change in pull request #1818: Add frame_of_reference page

imay commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325693580 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] imay commented on a change in pull request #1818: Add frame_of_reference page

imay commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325700504 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] imay commented on a change in pull request #1818: Add frame_of_reference page

imay commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325698769 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] imay commented on a change in pull request #1818: Add frame_of_reference page

imay commented on a change in pull request #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#discussion_r325702436 ## File path: be/src/util/frame_of_reference_coding.cpp ## @@ -0,0 +1,261 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] imay opened a new pull request #1826: Improve LRUCache to get better performance

imay opened a new pull request #1826: Improve LRUCache to get better performance URL: https://github.com/apache/incubator-doris/pull/1826 In this CL, I move the entry's deleter out of LRUCache's mutex block, which can let others access this cache without waiting free cache entry. F

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: Add fixed partitions

morningman commented on a change in pull request #1679: Add fixed partitions URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r325615065 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -1515,6 +1523,81 @@ partition_key_desc ::= :} ; +fixed_

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: Add fixed partitions

morningman commented on a change in pull request #1679: Add fixed partitions URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r325617910 ## File path: fe/src/main/java/org/apache/doris/analysis/LiteralExpr.java ## @@ -45,6 +45,9 @@ protected LiteralExpr(L

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: Add fixed partitions

morningman commented on a change in pull request #1679: Add fixed partitions URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r325618318 ## File path: fe/src/main/java/org/apache/doris/catalog/PartitionKey.java ## @@ -120,11 +120,34 @@ public boolean isMi

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: Add fixed partitions

morningman commented on a change in pull request #1679: Add fixed partitions URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r325623130 ## File path: fe/src/main/java/org/apache/doris/catalog/RangePartitionInfo.java ## @@ -93,12 +93,60 @@ public void add

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: Add fixed partitions

morningman commented on a change in pull request #1679: Add fixed partitions URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r325623854 ## File path: fe/src/main/java/org/apache/doris/catalog/RangePartitionInfo.java ## @@ -93,12 +93,60 @@ public void add

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: Add fixed partitions

morningman commented on a change in pull request #1679: Add fixed partitions URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r325613548 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -1515,6 +1523,81 @@ partition_key_desc ::= :} ; +fixed_

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: Add fixed partitions

morningman commented on a change in pull request #1679: Add fixed partitions URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r325621864 ## File path: fe/src/main/java/org/apache/doris/catalog/RangePartitionInfo.java ## @@ -93,12 +93,60 @@ public void add

[GitHub] [incubator-doris] kangkaisen commented on issue #1818: Add frame_of_reference page

kangkaisen commented on issue #1818: Add frame_of_reference page URL: https://github.com/apache/incubator-doris/pull/1818#issuecomment-532640063 @imay update This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1825: HLL support default value

HangyuanLiu opened a new pull request #1825: HLL support default value URL: https://github.com/apache/incubator-doris/pull/1825 When load date don't have HLL value , HLL value is a empty HyperLogLog This is an automated messa