kangkaisen commented on a change in pull request #1825: HLL support default
value
URL: https://github.com/apache/incubator-doris/pull/1825#discussion_r325972888
##########
File path: be/src/olap/aggregate_func.h
##########
@@ -408,7 +408,11 @@ struct
AggregateFuncTraits<OLAP_FIELD_AGGREGATION_HLL_UNION, OLAP_FIELD_TYPE_HLL
dst_slice->size = sizeof(HyperLogLog);
// use 'placement new' to allocate HyperLogLog on arena, so that we
can control the memory usage.
char* mem = arena->Allocate(dst_slice->size);
- dst_slice->data = (char*) new (mem) HyperLogLog(src_slice->data);
+ if (src_slice->empty()) {
+ dst_slice->data = (char*) new (mem) HyperLogLog();
Review comment:
When the slice size is empty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
