[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r334230348 ## File path: be/src/olap/field.h ## @@ -389,6 +397,7 @@ class VarcharField: public Field {

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r334229094 ## File path: be/src/olap/types.h ## @@ -601,22 +594,11 @@ struct FieldTypeTraits : public

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r334228945 ## File path: be/src/olap/field.h ## @@ -55,9 +55,9 @@ class Field { inline size_t

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r334228828 ## File path: be/src/olap/field.h ## @@ -55,9 +55,9 @@ class Field { inline size_t

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r334218215 ## File path: be/src/olap/field.h ## @@ -55,9 +55,11 @@ class Field { inline size_t

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r334217064 ## File path: be/src/olap/field.h ## @@ -55,9 +55,11 @@ class Field { inline size_t

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r333915743 ## File path: be/src/olap/field.h ## @@ -55,9 +55,11 @@ class Field { inline size_t

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r333915743 ## File path: be/src/olap/field.h ## @@ -55,9 +55,11 @@ class Field { inline size_t

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r333807895 ## File path: be/src/olap/field.h ## @@ -55,9 +55,11 @@ class Field { inline size_t

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r333808141 ## File path: be/src/olap/rowset/segment_v2/column_writer.cpp ## @@ -72,13 +72,13 @@ class

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r333808109 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -55,17 +55,17 @@ Status

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r333808062 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -55,17 +55,17 @@ Status

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r333807936 ## File path: be/src/olap/field.h ## @@ -55,9 +55,11 @@ class Field { inline size_t

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r333807981 ## File path: be/src/olap/field.h ## @@ -400,6 +411,16 @@ class VarcharField: public Field {

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r333807995 ## File path: be/src/olap/field.h ## @@ -400,6 +411,16 @@ class VarcharField: public Field {

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943)

wangbo commented on a change in pull request #1944: Segment v2 use string's real length(#1943) URL: https://github.com/apache/incubator-doris/pull/1944#discussion_r333807895 ## File path: be/src/olap/field.h ## @@ -55,9 +55,11 @@ class Field { inline size_t