Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-06 Thread via GitHub
kaka11chen commented on PR #33245: URL: https://github.com/apache/doris/pull/33245#issuecomment-2041292101 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-06 Thread via GitHub
github-actions[bot] commented on code in PR #33245: URL: https://github.com/apache/doris/pull/33245#discussion_r1554805601 ## be/src/vec/sink/writer/vhive_table_writer.cpp: ## @@ -68,114 +81,155 @@ Status VHiveTableWriter::open(RuntimeState* state, RuntimeProfile* profile) {

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-06 Thread via GitHub
kaka11chen commented on code in PR #33245: URL: https://github.com/apache/doris/pull/33245#discussion_r1554804030 ## be/src/common/config.cpp: ## @@ -1194,6 +1194,7 @@ DEFINE_mInt32(table_sink_partition_write_max_partition_nums_per_writer, "128"); /** Hive sink

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-05 Thread via GitHub
morningman commented on code in PR #33245: URL: https://github.com/apache/doris/pull/33245#discussion_r1553491665 ## be/src/common/config.cpp: ## @@ -1194,6 +1194,7 @@ DEFINE_mInt32(table_sink_partition_write_max_partition_nums_per_writer, "128"); /** Hive sink

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
doris-robot commented on PR #33245: URL: https://github.com/apache/doris/pull/33245#issuecomment-2036227968 TeamCity be ut coverage result: Function Coverage: 35.63% (8880/24924) Line Coverage: 27.36% (72893/266470) Region Coverage: 26.53% (37695/142080) Branch Coverage:

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
github-actions[bot] commented on code in PR #33245: URL: https://github.com/apache/doris/pull/33245#discussion_r1550926968 ## be/src/vec/sink/writer/vhive_table_writer.cpp: ## @@ -68,114 +81,153 @@ Status VHiveTableWriter::open(RuntimeState* state, RuntimeProfile* profile) {

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
kaka11chen commented on PR #33245: URL: https://github.com/apache/doris/pull/33245#issuecomment-2036193232 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
doris-robot commented on PR #33245: URL: https://github.com/apache/doris/pull/33245#issuecomment-2035447094 TeamCity be ut coverage result: Function Coverage: 35.63% (8881/24924) Line Coverage: 27.37% (72917/266460) Region Coverage: 26.54% (37699/142072) Branch Coverage:

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
doris-robot commented on PR #33245: URL: https://github.com/apache/doris/pull/33245#issuecomment-2035447945 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit c8508dcc447ff941fbb827d1d66708525e2241ce with default session variables Stream

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
doris-robot commented on PR #33245: URL: https://github.com/apache/doris/pull/33245#issuecomment-2035443286 ClickBench: Total hot run time: 29.76 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
doris-robot commented on PR #33245: URL: https://github.com/apache/doris/pull/33245#issuecomment-2035434699 TPC-DS: Total hot run time: 181257 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
doris-robot commented on PR #33245: URL: https://github.com/apache/doris/pull/33245#issuecomment-2035417131 TPC-H: Total hot run time: 39338 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
github-actions[bot] commented on code in PR #33245: URL: https://github.com/apache/doris/pull/33245#discussion_r1550246489 ## be/src/vec/sink/writer/vhive_table_writer.cpp: ## @@ -68,114 +81,154 @@ Status VHiveTableWriter::open(RuntimeState* state, RuntimeProfile* profile) {

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
kaka11chen commented on PR #33245: URL: https://github.com/apache/doris/pull/33245#issuecomment-2035282383 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
doris-robot commented on PR #33245: URL: https://github.com/apache/doris/pull/33245#issuecomment-2035281967 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your

[PR] [Feature][Enhancement](hive-writer) Add hive-writer runtime profiles, change output file names and add `hive_sink_max_open_partitions` . [doris]

2024-04-03 Thread via GitHub
kaka11chen opened a new pull request, #33245: URL: https://github.com/apache/doris/pull/33245 ## Proposed changes Issue Number: #31442 - Add hive-writer runtime profiles. - Change output file names to `${query_id}${uuid}-${index}.${compression}.${format}`. e.g.