Repository: drill Updated Branches: refs/heads/master 8c706e6fa -> 79a712aae
DRILL-2809: Increase the default value of partitioner_sender_threads_factor. Project: http://git-wip-us.apache.org/repos/asf/drill/repo Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/79a712aa Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/79a712aa Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/79a712aa Branch: refs/heads/master Commit: 79a712aaee320594dc9fc88e49d953df3d9fad9d Parents: 8c706e6 Author: Aman Sinha <asi...@maprtech.com> Authored: Wed Apr 29 20:34:04 2015 -0700 Committer: Aman Sinha <asi...@maprtech.com> Committed: Thu May 7 15:32:13 2015 -0700 ---------------------------------------------------------------------- .../physical/impl/partitionsender/PartitionSenderRootExec.java | 2 -- .../org/apache/drill/exec/planner/physical/PlannerSettings.java | 2 +- .../exec/physical/impl/partitionsender/TestPartitionSender.java | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/drill/blob/79a712aa/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java ---------------------------------------------------------------------- diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java b/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java index cf7ba16..16d1400 100644 --- a/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java +++ b/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java @@ -111,8 +111,6 @@ public class PartitionSenderRootExec extends BaseRootExec { stats.setLongStat(Metric.N_RECEIVERS, outGoingBatchCount); // Algorithm to figure out number of threads to parallelize output // numberOfRows/sliceTarget/numReceivers/threadfactor - // threadFactor = 4 by default - // one more param to put a limit on number max number of threads: default 32 this.cost = operator.getChild().getCost(); final OptionManager optMgr = context.getOptions(); long sliceTarget = optMgr.getOption(ExecConstants.SLICE_TARGET).num_val; http://git-wip-us.apache.org/repos/asf/drill/blob/79a712aa/exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java ---------------------------------------------------------------------- diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java index 8f089c4..2fd8135 100644 --- a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java +++ b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java @@ -53,7 +53,7 @@ public class PlannerSettings implements Context{ public static final OptionValidator JOIN_ROW_COUNT_ESTIMATE_FACTOR = new RangeDoubleValidator("planner.join.row_count_estimate_factor", 0, Double.MAX_VALUE, 1.0d); public static final OptionValidator MUX_EXCHANGE = new BooleanValidator("planner.enable_mux_exchange", true); public static final OptionValidator DEMUX_EXCHANGE = new BooleanValidator("planner.enable_demux_exchange", false); - public static final OptionValidator PARTITION_SENDER_THREADS_FACTOR = new LongValidator("planner.partitioner_sender_threads_factor", 1); + public static final OptionValidator PARTITION_SENDER_THREADS_FACTOR = new LongValidator("planner.partitioner_sender_threads_factor", 2); public static final OptionValidator PARTITION_SENDER_MAX_THREADS = new LongValidator("planner.partitioner_sender_max_threads", 8); public static final OptionValidator PARTITION_SENDER_SET_THREADS = new LongValidator("planner.partitioner_sender_set_threads", -1); public static final OptionValidator PRODUCER_CONSUMER = new BooleanValidator("planner.add_producer_consumer", false); http://git-wip-us.apache.org/repos/asf/drill/blob/79a712aa/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java ---------------------------------------------------------------------- diff --git a/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java b/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java index 320e722..f269bd7 100644 --- a/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java +++ b/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java @@ -182,7 +182,7 @@ public class TestPartitionSender extends PlanTestBase { // try multiple scenarios with different set of options options.add(OptionValue.createLong(OptionType.SESSION, "planner.slice_target", 1)); testThreadsHelper(hashToRandomExchange, drillbitContext, options, - incoming, registry, planReader, planningSet, rootFragment, 2); + incoming, registry, planReader, planningSet, rootFragment, 1); options.clear(); options.add(OptionValue.createLong(OptionType.SESSION, "planner.slice_target", 1));