[GitHub] robertervin opened a new pull request #6330: Fix Empty InDimFilter Failure

2018-09-12 Thread GitBox
robertervin opened a new pull request #6330: Fix Empty InDimFilter Failure URL: https://github.com/apache/incubator-druid/pull/6330 Fixes #6101 While it may be more efficient to not process an empty filter, it is not wrong logically and should be supported for correctness. A

[GitHub] fjy closed pull request #6328: [Backport] Use PasswordProvider, fix info on initial passwords in basic security extension docs

2018-09-12 Thread GitBox
fjy closed pull request #6328: [Backport] Use PasswordProvider, fix info on initial passwords in basic security extension docs URL: https://github.com/apache/incubator-druid/pull/6328 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] leventov edited a comment on issue #6329: CostBalancerStrategy.pickSegmentToMove can pick the same segment twice

2018-09-12 Thread GitBox
leventov edited a comment on issue #6329: CostBalancerStrategy.pickSegmentToMove can pick the same segment twice URL: https://github.com/apache/incubator-druid/issues/6329#issuecomment-420775588 It doesn't seem to me that this is a "bug" in the sense that the authors of the original code

[GitHub] leventov edited a comment on issue #6329: CostBalancerStrategy.pickSegmentToMove can pick the same segment twice

2018-09-12 Thread GitBox
leventov edited a comment on issue #6329: CostBalancerStrategy.pickSegmentToMove can pick the same segment twice URL: https://github.com/apache/incubator-druid/issues/6329#issuecomment-420775588 It doesn't seem to me that this is a "bug" in the sense that the authors of the original code

[GitHub] leventov commented on issue #6329: CostBalancerStrategy.pickSegmentToMove can pick the same segment twice

2018-09-12 Thread GitBox
leventov commented on issue #6329: CostBalancerStrategy.pickSegmentToMove can pick the same segment twice URL: https://github.com/apache/incubator-druid/issues/6329#issuecomment-420775588 It doesn't seem to me that this is a "bug" in the sense that authors of the original code didn't

[GitHub] egor-ryashin opened a new issue #6329: CostBalancerStrategy.pickSegmentToMove can pick the same segment twice

2018-09-12 Thread GitBox
egor-ryashin opened a new issue #6329: CostBalancerStrategy.pickSegmentToMove can pick the same segment twice URL: https://github.com/apache/incubator-druid/issues/6329 ```java @Override public BalancerSegmentHolder pickSegmentToMove(final List serverHolders) {

[GitHub] leventov commented on issue #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements

2018-09-12 Thread GitBox
leventov commented on issue #5957: Renamed 'Generic Column' -> 'Numeric Column'; Fixed a few resource leaks in processing; misc refinements URL: https://github.com/apache/incubator-druid/pull/5957#issuecomment-420770448 @nishantmonu51 could you please take a look?

[GitHub] jon-wei opened a new pull request #6328: [Backport] Use PasswordProvider, fix info on initial passwords in basic security extension docs

2018-09-12 Thread GitBox
jon-wei opened a new pull request #6328: [Backport] Use PasswordProvider, fix info on initial passwords in basic security extension docs URL: https://github.com/apache/incubator-druid/pull/6328 Backport #6303 to 0.12.3 This

[GitHub] sanastas commented on issue #5698: Oak: New Concurrent Key-Value Map

2018-09-12 Thread GitBox
sanastas commented on issue #5698: Oak: New Concurrent Key-Value Map URL: https://github.com/apache/incubator-druid/issues/5698#issuecomment-420670748 The last PR is now: #6327 This is an automated message from the Apache

[GitHub] sanastas commented on issue #6235: Druid with Oak supporting also plain mode v04

2018-09-12 Thread GitBox
sanastas commented on issue #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#issuecomment-420670400 According to the request we have fixed the merge conflicts. The result is PR#6327. I am closing this PR, the comment existing

[GitHub] sanastas opened a new pull request #6327: Druid based on OakIncrementalIndex

2018-09-12 Thread GitBox
sanastas opened a new pull request #6327: Druid based on OakIncrementalIndex URL: https://github.com/apache/incubator-druid/pull/6327 Yet another PR, after re-basing on top of the new state of the Druid master. The comments added in PR#6235 will be all fixed. Adding here the previous

[GitHub] leventov commented on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary

2018-09-12 Thread GitBox
leventov commented on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary URL: https://github.com/apache/incubator-druid/issues/6322#issuecomment-420636937 @kaijianding this is not a matter of the size variable increment, this is a matter of

[GitHub] kaijianding commented on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary

2018-09-12 Thread GitBox
kaijianding commented on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary URL: https://github.com/apache/incubator-druid/issues/6322#issuecomment-420627238 @leventov for the ArrayList part, I don't think it is a problem, because size++

[GitHub] leventov commented on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary

2018-09-12 Thread GitBox
leventov commented on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary URL: https://github.com/apache/incubator-druid/issues/6322#issuecomment-420589298 Ok, now I see how #4049 is relevant. Two things need to be done: 1) Highlight,

[GitHub] kaijianding edited a comment on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary

2018-09-12 Thread GitBox
kaijianding edited a comment on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary URL: https://github.com/apache/incubator-druid/issues/6322#issuecomment-420563701 @leventov I removed synchronized from read operation, and it worked fine.

[GitHub] kaijianding edited a comment on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary

2018-09-12 Thread GitBox
kaijianding edited a comment on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary URL: https://github.com/apache/incubator-druid/issues/6322#issuecomment-420563701 @leventov I removed synchronized from read operation, and it worked fine.

[GitHub] kaijianding edited a comment on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary

2018-09-12 Thread GitBox
kaijianding edited a comment on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary URL: https://github.com/apache/incubator-druid/issues/6322#issuecomment-420563701 @leventov I removed synchronized from read operation, and it worked fine.

[GitHub] kaijianding edited a comment on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary

2018-09-12 Thread GitBox
kaijianding edited a comment on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary URL: https://github.com/apache/incubator-druid/issues/6322#issuecomment-420563701 @leventov I removed synchronized from read operation, and it worked fine.

[GitHub] kaijianding edited a comment on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary

2018-09-12 Thread GitBox
kaijianding edited a comment on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary URL: https://github.com/apache/incubator-druid/issues/6322#issuecomment-420563701 @leventov I removed synchronized from read operation, and it worked fine.

[GitHub] kaijianding commented on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary

2018-09-12 Thread GitBox
kaijianding commented on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary URL: https://github.com/apache/incubator-druid/issues/6322#issuecomment-420563701 @leventov I removed synchronized from read operation, and it worked fine. because

[GitHub] leventov commented on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary

2018-09-12 Thread GitBox
leventov commented on issue #6322: severe performance issue due to lock in StringDimensionIndexer.DimensionDictionary URL: https://github.com/apache/incubator-druid/issues/6322#issuecomment-420559559 It is possible to improve concurrency here, I'm not sure that #4049 is relevant, but