[GitHub] [druid] jon-wei commented on a change in pull request #9647: document useFilterCNF query context parameter

2020-04-08 Thread GitBox
jon-wei commented on a change in pull request #9647: document useFilterCNF query context parameter URL: https://github.com/apache/druid/pull/9647#discussion_r405969200 ## File path: processing/src/main/java/org/apache/druid/query/QueryContexts.java ## @@ -67,7 +68,8 @@

[GitHub] [druid] jon-wei commented on a change in pull request #9647: document useFilterCNF query context parameter

2020-04-08 Thread GitBox
jon-wei commented on a change in pull request #9647: document useFilterCNF query context parameter URL: https://github.com/apache/druid/pull/9647#discussion_r405972067 ## File path: docs/querying/query-context.md ## @@ -45,6 +45,7 @@ The query context is used for various q

[GitHub] [druid] himanshug commented on a change in pull request #9573: Fix some flaws of KafkaEmitter

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9573: Fix some flaws of KafkaEmitter URL: https://github.com/apache/druid/pull/9573#discussion_r405966642 ## File path: extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitter.java ## @@ -

[GitHub] [druid] himanshug commented on a change in pull request #9573: Fix some flaws of KafkaEmitter

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9573: Fix some flaws of KafkaEmitter URL: https://github.com/apache/druid/pull/9573#discussion_r405966622 ## File path: extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitter.java ## @@ -

[GitHub] [druid] himanshug commented on issue #9649: Document possible vulnerabilities for the druid-ranger-security

2020-04-08 Thread GitBox
himanshug commented on issue #9649: Document possible vulnerabilities for the druid-ranger-security URL: https://github.com/apache/druid/pull/9649#issuecomment-611337438 sgtm, but I will let @ccaominh approve this as he is more familiar with the specifics.

[druid] branch master updated: More optimize CNF conversion of filters (#9634)

2020-04-08 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new a6790ff More optimize CNF conversion of filters

[GitHub] [druid] jon-wei merged pull request #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
jon-wei merged pull request #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[druid] branch master updated: Preserve the null values for numeric type dimensions post-compaction. (#9622)

2020-04-08 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 08851c0 Preserve the null values for numeric typ

[GitHub] [druid] clintropolis merged pull request #9622: Preserve the null values for numeric type dimensions post-compaction.

2020-04-08 Thread GitBox
clintropolis merged pull request #9622: Preserve the null values for numeric type dimensions post-compaction. URL: https://github.com/apache/druid/pull/9622 This is an automated message from the Apache Git Service. To respon

[GitHub] [druid] ccaominh opened a new pull request #9651: Upgrade netty 4 to fix CVE-2020-11612

2020-04-08 Thread GitBox
ccaominh opened a new pull request #9651: Upgrade netty 4 to fix CVE-2020-11612 URL: https://github.com/apache/druid/pull/9651 ### Description CVE-2020-11612 affects netty 4 versions 4.1.45 or older. Current latest version is 4.41.48. This PR has: - [x] been self-re

[GitHub] [druid] yuanlihan commented on a change in pull request #9573: Fix some flaws of KafkaEmitter

2020-04-08 Thread GitBox
yuanlihan commented on a change in pull request #9573: Fix some flaws of KafkaEmitter URL: https://github.com/apache/druid/pull/9573#discussion_r405903401 ## File path: extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitter.java ## @@ -

[GitHub] [druid] jihoonson commented on a change in pull request #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
jihoonson commented on a change in pull request #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634#discussion_r405897673 ## File path: processing/src/main/java/org/apache/druid/segment/filter/Filters.java ## @@ -426,175 +424,21 @

[GitHub] [druid] jihoonson commented on issue #9622: Preserve the null values for numeric type dimensions post-compaction.

2020-04-08 Thread GitBox
jihoonson commented on issue #9622: Preserve the null values for numeric type dimensions post-compaction. URL: https://github.com/apache/druid/pull/9622#issuecomment-611263378 @clintropolis do you have more comments? This is

[GitHub] [druid] vogievetsky merged pull request #9587: Use auto-form for add an edit lookups

2020-04-08 Thread GitBox
vogievetsky merged pull request #9587: Use auto-form for add an edit lookups URL: https://github.com/apache/druid/pull/9587 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[druid] branch master updated (2b2b9ef -> 6f3d403)

2020-04-08 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 2b2b9ef add new text to lookup action dialog (#9643) add 6f3d403 Use auto-form for add an edit lookups (#9

[GitHub] [druid] vogievetsky commented on issue #9587: Use auto-form for add an edit lookups

2020-04-08 Thread GitBox
vogievetsky commented on issue #9587: Use auto-form for add an edit lookups URL: https://github.com/apache/druid/pull/9587#issuecomment-611247242 Thank you for responding to all the feedback! This is an automated message from

[GitHub] [druid] himanshug commented on a change in pull request #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634#discussion_r405866028 ## File path: processing/src/main/java/org/apache/druid/segment/filter/Filters.java ## @@ -426,175 +424,21 @

[GitHub] [druid] abhishekrb19 commented on a change in pull request #9622: Preserve the null values for numeric type dimensions post-compaction.

2020-04-08 Thread GitBox
abhishekrb19 commented on a change in pull request #9622: Preserve the null values for numeric type dimensions post-compaction. URL: https://github.com/apache/druid/pull/9622#discussion_r405827586 ## File path: processing/src/test/java/org/apache/druid/segment/TestNullableFloatColu

[GitHub] [druid] jihoonson commented on issue #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
jihoonson commented on issue #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634#issuecomment-611195064 @jon-wei thanks, fixed checkstyle. This is an automated message from the Apache

[GitHub] [druid] jihoonson commented on issue #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
jihoonson commented on issue #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634#issuecomment-611194940 > > The CNF conversion returned ((C || E) && (D || E) && (C || F) && (D || F) && C && D && (D || C) && A && B (F || E)) prior to this PR. >

[GitHub] [druid] jihoonson commented on a change in pull request #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
jihoonson commented on a change in pull request #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634#discussion_r405814703 ## File path: processing/src/main/java/org/apache/druid/segment/filter/cnf/HiveCnfHelper.java ## @@ -0,0 +1,

[GitHub] [druid] jihoonson commented on a change in pull request #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
jihoonson commented on a change in pull request #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634#discussion_r405814531 ## File path: processing/src/main/java/org/apache/druid/segment/filter/Filters.java ## @@ -426,175 +424,21 @

[GitHub] [druid] himanshug commented on a change in pull request #9638: refactor internal type system

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9638: refactor internal type system URL: https://github.com/apache/druid/pull/9638#discussion_r405807021 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java ## @@ -467,21 +470,24 @@ publi

[GitHub] [druid] himanshug commented on a change in pull request #9638: refactor internal type system

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9638: refactor internal type system URL: https://github.com/apache/druid/pull/9638#discussion_r405805624 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java ## @@ -340,22 +340,25 @@ publi

[GitHub] [druid] jihoonson commented on a change in pull request #9622: Preserve the null values for numeric type dimensions post-compaction.

2020-04-08 Thread GitBox
jihoonson commented on a change in pull request #9622: Preserve the null values for numeric type dimensions post-compaction. URL: https://github.com/apache/druid/pull/9622#discussion_r405803078 ## File path: processing/src/test/java/org/apache/druid/segment/TestNullableFloatColumnS

[GitHub] [druid] himanshug commented on a change in pull request #9638: refactor internal type system

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9638: refactor internal type system URL: https://github.com/apache/druid/pull/9638#discussion_r405797714 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/AggregatorFactory.java ## @@ -214,19 +216,42

[GitHub] [druid] himanshug commented on a change in pull request #9638: refactor internal type system

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9638: refactor internal type system URL: https://github.com/apache/druid/pull/9638#discussion_r405791486 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/PostAggregator.java ## @@ -43,6 +45,13 @@

[GitHub] [druid] himanshug commented on issue #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
himanshug commented on issue #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634#issuecomment-611156592 > The CNF conversion returned ((C || E) && (D || E) && (C || F) && (D || F) && C && D && (D || C) && A && B (F || E)) prior to this PR. wh

[GitHub] [druid] himanshug commented on a change in pull request #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634#discussion_r405769400 ## File path: processing/src/main/java/org/apache/druid/segment/filter/cnf/HiveCnfHelper.java ## @@ -0,0 +1,

[GitHub] [druid] himanshug commented on a change in pull request #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634#discussion_r405769028 ## File path: processing/src/main/java/org/apache/druid/segment/filter/Filters.java ## @@ -426,175 +424,21 @

[GitHub] [druid] bolkedebruin commented on a change in pull request #9649: Document possible vulnerabilities for the druid-ranger-security

2020-04-08 Thread GitBox
bolkedebruin commented on a change in pull request #9649: Document possible vulnerabilities for the druid-ranger-security URL: https://github.com/apache/druid/pull/9649#discussion_r405733421 ## File path: owasp-dependency-check-suppressions.xml ## @@ -187,4 +187,36 @@

[GitHub] [druid] bolkedebruin opened a new issue #9650: Upgrade Ranger dependency to 2.1 when released due to CVEs in its dependencies

2020-04-08 Thread GitBox
bolkedebruin opened a new issue #9650: Upgrade Ranger dependency to 2.1 when released due to CVEs in its dependencies URL: https://github.com/apache/druid/issues/9650 ### Description Ranger's current release packages log4j 1.2.17 and Kafka 2.0.0 both of which have vulnerabilities. R

[GitHub] [druid] bolkedebruin commented on issue #9649: Document possible vulnerabilities for the druid-ranger-security

2020-04-08 Thread GitBox
bolkedebruin commented on issue #9649: Document possible vulnerabilities for the druid-ranger-security URL: https://github.com/apache/druid/pull/9649#issuecomment-611121850 I did a `mvn clean && mvn install -DskipTests=true -Dtar -T 8` and a `mvn dependency-check:check` both passed locally

[GitHub] [druid] himanshug commented on issue #9649: Document possible vulnerabilities for the druid-ranger-security

2020-04-08 Thread GitBox
himanshug commented on issue #9649: Document possible vulnerabilities for the druid-ranger-security URL: https://github.com/apache/druid/pull/9649#issuecomment-611121176 LGTM , can you verify that the build gets fixed. This i

[GitHub] [druid] himanshug commented on a change in pull request #9649: Document possible vulnerabilities for the druid-ranger-security

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9649: Document possible vulnerabilities for the druid-ranger-security URL: https://github.com/apache/druid/pull/9649#discussion_r405730466 ## File path: owasp-dependency-check-suppressions.xml ## @@ -187,4 +187,36 @@ ^

[GitHub] [druid] vogievetsky commented on issue #9643: add new text to lookup action dialog

2020-04-08 Thread GitBox
vogievetsky commented on issue #9643: add new text to lookup action dialog URL: https://github.com/apache/druid/pull/9643#issuecomment-69711 nice. Thank you for the update 👍 This is an automated message from the Apache Gi

[GitHub] [druid] himanshug commented on a change in pull request #9573: Fix some flaws of KafkaEmitter

2020-04-08 Thread GitBox
himanshug commented on a change in pull request #9573: Fix some flaws of KafkaEmitter URL: https://github.com/apache/druid/pull/9573#discussion_r405729389 ## File path: extensions-contrib/kafka-emitter/src/main/java/org/apache/druid/emitter/kafka/KafkaEmitter.java ## @@ -

[druid] branch master updated: add new text to lookup action dialog (#9643)

2020-04-08 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 2b2b9ef add new text to lookup action dialo

[GitHub] [druid] vogievetsky merged pull request #9643: add new text to lookup action dialog

2020-04-08 Thread GitBox
vogievetsky merged pull request #9643: add new text to lookup action dialog URL: https://github.com/apache/druid/pull/9643 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [druid] marklu2018 commented on issue #5773: gcloud pubsub support

2020-04-08 Thread GitBox
marklu2018 commented on issue #5773: gcloud pubsub support URL: https://github.com/apache/druid/issues/5773#issuecomment-611107212 @aditya-r-m , why would the Pubsub indexing service care about the ordering of packets? Could it just index those pulled packets as it arrives? ---

[GitHub] [druid] bolkedebruin commented on issue #9629: druid-ranger-security failure when building distribution

2020-04-08 Thread GitBox
bolkedebruin commented on issue #9629: druid-ranger-security failure when building distribution URL: https://github.com/apache/druid/issues/9629#issuecomment-611096951 @jon-wei @ccaominh anything left for me to cover? Or is what @ccaominh suggest the correct fix? -

[GitHub] [druid] fjy merged pull request #9633: fix flaky jetty test

2020-04-08 Thread GitBox
fjy merged pull request #9633: fix flaky jetty test URL: https://github.com/apache/druid/pull/9633 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[druid] branch master updated: fix flaky jetty test (#9633)

2020-04-08 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 7bf2dfa fix flaky jetty test (#9633) 7bf2dfa is des

[GitHub] [druid] stale[bot] closed issue #5291: hadoop ingesting problem of segmentGranularity when moving from UTC to UTC+8

2020-04-08 Thread GitBox
stale[bot] closed issue #5291: hadoop ingesting problem of segmentGranularity when moving from UTC to UTC+8 URL: https://github.com/apache/druid/issues/5291 This is an automated message from the Apache Git Service. To respon

[GitHub] [druid] stale[bot] commented on issue #5291: hadoop ingesting problem of segmentGranularity when moving from UTC to UTC+8

2020-04-08 Thread GitBox
stale[bot] commented on issue #5291: hadoop ingesting problem of segmentGranularity when moving from UTC to UTC+8 URL: https://github.com/apache/druid/issues/5291#issuecomment-611077245 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue require

[GitHub] [druid] ak08 removed a comment on issue #6089: Use Filtered Aggregator return null but expect 0

2020-04-08 Thread GitBox
ak08 removed a comment on issue #6089: Use Filtered Aggregator return null but expect 0 URL: https://github.com/apache/druid/issues/6089#issuecomment-611069411 Can I know if this issue has been fixed ? This is an automated me

[GitHub] [druid] marklu2018 commented on issue #9116: WIP: gcloud pubsub indexing service

2020-04-08 Thread GitBox
marklu2018 commented on issue #9116: WIP: gcloud pubsub indexing service URL: https://github.com/apache/druid/pull/9116#issuecomment-611070533 @aditya-r-m , any chance this PR would be merged or released soon? Would really like to try out this extension as our data ingestion pipeline is usi

[GitHub] [druid] ak08 commented on issue #6089: Use Filtered Aggregator return null but expect 0

2020-04-08 Thread GitBox
ak08 commented on issue #6089: Use Filtered Aggregator return null but expect 0 URL: https://github.com/apache/druid/issues/6089#issuecomment-611069411 Can I know if this issue has been fixed ? This is an automated message fro

[GitHub] [druid] jon-wei commented on issue #9634: More optimize CNF conversion of filters

2020-04-08 Thread GitBox
jon-wei commented on issue #9634: More optimize CNF conversion of filters URL: https://github.com/apache/druid/pull/9634#issuecomment-611024073 there's a checkstyle failure This is an automated message from the Apache Git Serv

[GitHub] [druid] bolkedebruin opened a new pull request #9649: Document possible vulnerabilities for the druid-ranger-security

2020-04-08 Thread GitBox
bolkedebruin opened a new pull request #9649: Document possible vulnerabilities for the druid-ranger-security URL: https://github.com/apache/druid/pull/9649 In certain configurations the ranger plugin can expose vulnerabilities due to some of its dependencies having CVEs. @ccaomin

[GitHub] [druid] gianm opened a new pull request #9648: SQL: More straightforward handling of join planning.

2020-04-08 Thread GitBox
gianm opened a new pull request #9648: SQL: More straightforward handling of join planning. URL: https://github.com/apache/druid/pull/9648 Two major changes that simplify how joins are planned: 1) Stop using JoinProjectTransposeRule as a way of guiding subquery removal. Instead, a

[GitHub] [druid] bolkedebruin commented on issue #9579: Add Apache Ranger Authorization

2020-04-08 Thread GitBox
bolkedebruin commented on issue #9579: Add Apache Ranger Authorization URL: https://github.com/apache/druid/pull/9579#issuecomment-610899468 @himanshug both vulnerabilities are only exposed when you configure them to do so. It is not a default config. Log4j requires the SocketAppender to be

[GitHub] [druid] clintropolis opened a new pull request #9647: document useFilterCNF query context parameter

2020-04-08 Thread GitBox
clintropolis opened a new pull request #9647: document useFilterCNF query context parameter URL: https://github.com/apache/druid/pull/9647 Does the thing the title says, and adds `useFilterCNF` to the query context docs. It might be worth adding a preamble of sorts to some of these setting

[GitHub] [druid] gianm opened a new issue #9646: SQL: Excessive time and memory use while planning joins on subqueries

2020-04-08 Thread GitBox
gianm opened a new issue #9646: SQL: Excessive time and memory use while planning joins on subqueries URL: https://github.com/apache/druid/issues/9646 These queries will blow up the planner's rule queue and make it take forever (and also use a lot of memory). ```sql SELECT *

[GitHub] [druid] gianm commented on issue #9645: String last aggregator is not considering all the segments for calculating the aggregation

2020-04-08 Thread GitBox
gianm commented on issue #9645: String last aggregator is not considering all the segments for calculating the aggregation URL: https://github.com/apache/druid/issues/9645#issuecomment-610860353 Hi @roopini550, Aggregators don't really have control over what segments they read. So I

[GitHub] [druid] roopini550 opened a new issue #9645: String last aggregator is not considering all the segments for calculating the aggregation

2020-04-08 Thread GitBox
roopini550 opened a new issue #9645: String last aggregator is not considering all the segments for calculating the aggregation URL: https://github.com/apache/druid/issues/9645 String last aggregator is not considering all the segments in the given interval for calculating the aggregation