[GitHub] [druid] maytasm commented on a change in pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
maytasm commented on a change in pull request #10371: URL: https://github.com/apache/druid/pull/10371#discussion_r488392899 ## File path: server/src/main/java/org/apache/druid/server/coordinator/AutoCompactionSnapshot.java ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache So

[GitHub] [druid] maytasm commented on a change in pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
maytasm commented on a change in pull request #10371: URL: https://github.com/apache/druid/pull/10371#discussion_r488392581 ## File path: server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java ## @@ -238,25 +272,102 @@ private CoordinatorStats makeS

[GitHub] [druid] maytasm commented on a change in pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
maytasm commented on a change in pull request #10371: URL: https://github.com/apache/druid/pull/10371#discussion_r488392405 ## File path: server/src/main/java/org/apache/druid/server/coordinator/AutoCompactionSnapshot.java ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache So

[GitHub] [druid] maytasm commented on pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
maytasm commented on pull request #10371: URL: https://github.com/apache/druid/pull/10371#issuecomment-692471451 > > I was thinking of "snapshot" as the snapshot taken at the point in time the API is called. I think "status" also works. Let me know if you still think "status" is better. I'

[GitHub] [druid] maytasm commented on a change in pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
maytasm commented on a change in pull request #10371: URL: https://github.com/apache/druid/pull/10371#discussion_r488390448 ## File path: server/src/main/java/org/apache/druid/server/coordinator/duty/CompactSegments.java ## @@ -238,25 +272,102 @@ private CoordinatorStats makeS

[GitHub] [druid] maytasm commented on a change in pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
maytasm commented on a change in pull request #10371: URL: https://github.com/apache/druid/pull/10371#discussion_r488385897 ## File path: server/src/main/java/org/apache/druid/server/coordinator/duty/NewestSegmentFirstIterator.java ## @@ -112,27 +114,38 @@ } @Override

[GitHub] [druid] jon-wei commented on pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
jon-wei commented on pull request #10371: URL: https://github.com/apache/druid/pull/10371#issuecomment-692462764 > I was thinking of "snapshot" as the snapshot taken at the point in time the API is called. I think "status" also works. Let me know if you still think "status" is better. I'm

[GitHub] [druid] jon-wei commented on a change in pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
jon-wei commented on a change in pull request #10371: URL: https://github.com/apache/druid/pull/10371#discussion_r488322171 ## File path: server/src/main/java/org/apache/druid/server/coordinator/AutoCompactionSnapshot.java ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache So

[GitHub] [druid] tianzhipeng-git commented on issue #10384: OutOfMemoryError when hadoop ingest

2020-09-14 Thread GitBox
tianzhipeng-git commented on issue #10384: URL: https://github.com/apache/druid/issues/10384#issuecomment-692437817 How many reducers does this hadoop task have? And which `segmentGranularity` and `partitionsSpec` you use? Maybe you should adjust your ingestion json to make `more seg

[druid] branch master updated (5751d0e -> e465f05)

2020-09-14 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 5751d0e Skip coverage check for tag builds (#10397) add e465f05 Web console: Improve number alignment in tables

[GitHub] [druid] clintropolis merged pull request #10389: Web console: Improve number alignment in tables

2020-09-14 Thread GitBox
clintropolis merged pull request #10389: URL: https://github.com/apache/druid/pull/10389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[druid] branch master updated (f71ba6f -> 5751d0e)

2020-09-14 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from f71ba6f Vectorized ANY aggregators (#10338) add 5751d0e Skip coverage check for tag builds (#10397) No new revisi

[GitHub] [druid] fjy merged pull request #10397: Skip coverage check for tag builds

2020-09-14 Thread GitBox
fjy merged pull request #10397: URL: https://github.com/apache/druid/pull/10397 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] suneet-s merged pull request #10338: Vectorized ANY aggregators

2020-09-14 Thread GitBox
suneet-s merged pull request #10338: URL: https://github.com/apache/druid/pull/10338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[druid] branch master updated (e012d5c -> f71ba6f)

2020-09-14 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from e012d5c allow vectorized query engines to utilize vectorized virtual columns (#10388) add f71ba6f Vectorized A

[GitHub] [druid] suneet-s commented on a change in pull request #10388: allow vectorized query engines to utilize vectorized virtual columns

2020-09-14 Thread GitBox
suneet-s commented on a change in pull request #10388: URL: https://github.com/apache/druid/pull/10388#discussion_r488348990 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/vector/VectorGroupByEngine.java ## @@ -70,24 +73,47 @@ public static

[GitHub] [druid] suneet-s commented on a change in pull request #10388: allow vectorized query engines to utilize vectorized virtual columns

2020-09-14 Thread GitBox
suneet-s commented on a change in pull request #10388: URL: https://github.com/apache/druid/pull/10388#discussion_r488348359 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/vector/VectorGroupByEngine.java ## @@ -70,24 +73,47 @@ public static

[druid] branch master updated (184b202 -> e012d5c)

2020-09-14 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 184b202 add computed Expr output types (#10370) add e012d5c allow vectorized query engines to utilize vectorize

[GitHub] [druid] clintropolis merged pull request #10388: allow vectorized query engines to utilize vectorized virtual columns

2020-09-14 Thread GitBox
clintropolis merged pull request #10388: URL: https://github.com/apache/druid/pull/10388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[druid] branch master updated (084b23d -> 184b202)

2020-09-14 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 084b23d benchmark for indexed table experiments (#10327) add 184b202 add computed Expr output types (#10370) N

[druid] branch master updated (084b23d -> 184b202)

2020-09-14 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 084b23d benchmark for indexed table experiments (#10327) add 184b202 add computed Expr output types (#10370) N

[GitHub] [druid] clintropolis commented on a change in pull request #10370: add computed Expr output types

2020-09-14 Thread GitBox
clintropolis commented on a change in pull request #10370: URL: https://github.com/apache/druid/pull/10370#discussion_r488324915 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -57,6 +57,17 @@ protected final double evalDouble(d

[GitHub] [druid] clintropolis merged pull request #10370: add computed Expr output types

2020-09-14 Thread GitBox
clintropolis merged pull request #10370: URL: https://github.com/apache/druid/pull/10370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [druid] suneet-s commented on a change in pull request #10390: Vectorized variance aggregators

2020-09-14 Thread GitBox
suneet-s commented on a change in pull request #10390: URL: https://github.com/apache/druid/pull/10390#discussion_r488319436 ## File path: extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/VarianceAggregatorFactory.java ## @@ -162,10 +167,36 @@ pu

[GitHub] [druid] jihoonson commented on issue #10321: [Proposal] Design for a Configurable Index Type

2020-09-14 Thread GitBox
jihoonson commented on issue #10321: URL: https://github.com/apache/druid/issues/10321#issuecomment-692390625 @liran-funaro thanks for your answer. > I'll look into that. Improving query performance is on our agenda, and we considered comparing the groupBy v1 with Oak to the groupBy

[GitHub] [druid] clintropolis commented on a change in pull request #10390: Vectorized variance aggregators

2020-09-14 Thread GitBox
clintropolis commented on a change in pull request #10390: URL: https://github.com/apache/druid/pull/10390#discussion_r488305025 ## File path: extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/VarianceAggregatorFactory.java ## @@ -162,10 +167,36 @

[GitHub] [druid] suneet-s commented on a change in pull request #10390: Vectorized variance aggregators

2020-09-14 Thread GitBox
suneet-s commented on a change in pull request #10390: URL: https://github.com/apache/druid/pull/10390#discussion_r488292797 ## File path: extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/VarianceAggregatorFactory.java ## @@ -162,10 +167,36 @@ pu

[GitHub] [druid] suneet-s commented on a change in pull request #10338: Vectorized ANY aggregators

2020-09-14 Thread GitBox
suneet-s commented on a change in pull request #10338: URL: https://github.com/apache/druid/pull/10338#discussion_r488280699 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/any/NumericNilVectorAggregator.java ## @@ -0,0 +1,146 @@ +/* + * Licensed to t

[GitHub] [druid] clintropolis commented on a change in pull request #10390: Vectorized variance aggregators

2020-09-14 Thread GitBox
clintropolis commented on a change in pull request #10390: URL: https://github.com/apache/druid/pull/10390#discussion_r488175527 ## File path: extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/VarianceAggregatorFactory.java ## @@ -162,10 +167,36 @

[GitHub] [druid] clintropolis commented on a change in pull request #10338: Vectorized ANY aggregators

2020-09-14 Thread GitBox
clintropolis commented on a change in pull request #10338: URL: https://github.com/apache/druid/pull/10338#discussion_r488262030 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/any/NumericNilVectorAggregator.java ## @@ -0,0 +1,146 @@ +/* + * Licensed

[GitHub] [druid] clintropolis merged pull request #10327: benchmark for indexed table experiments

2020-09-14 Thread GitBox
clintropolis merged pull request #10327: URL: https://github.com/apache/druid/pull/10327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[druid] branch master updated (f5e2645 -> 084b23d)

2020-09-14 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from f5e2645 Support SearchQueryDimFilter in sql via new methods (#10350) add 084b23d benchmark for indexed table ex

[GitHub] [druid] ccaominh commented on pull request #10397: Skip coverage check for tag builds

2020-09-14 Thread GitBox
ccaominh commented on pull request #10397: URL: https://github.com/apache/druid/pull/10397#issuecomment-692336327 > LGTM > > I found some tags that had failed CI > `druid-0.19.0-rc1` -> https://travis-ci.org/github/apache/druid/builds/707574622 > `druid-0.19.0` -> https://trav

[GitHub] [druid] ccaominh opened a new pull request #10397: Skip coverage check for tag builds

2020-09-14 Thread GitBox
ccaominh opened a new pull request #10397: URL: https://github.com/apache/druid/pull/10397 ### Description The code coverage diff calculation assumes the `TRAVIS_BRANCH` environment variable is the name of a branch; however, for tag builds it is the name of the tag so the diff calcu

[GitHub] [druid] mitchlloyd commented on pull request #10386: Upgrade AWS SDK

2020-09-14 Thread GitBox
mitchlloyd commented on pull request #10386: URL: https://github.com/apache/druid/pull/10386#issuecomment-692269623 @suneet-s I'm running the tests following [the documentation](https://github.com/apache/druid/blob/master/integration-tests/README.md#running-a-test-that-uses-cloud): H

[GitHub] [druid] clintropolis commented on a change in pull request #10370: add computed Expr output types

2020-09-14 Thread GitBox
clintropolis commented on a change in pull request #10370: URL: https://github.com/apache/druid/pull/10370#discussion_r488172223 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -57,6 +57,17 @@ protected final double evalDouble(d

[druid-website] branch asf-site updated (1b56e53 -> 375870d)

2020-09-14 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/druid-website.git. from 1b56e53 Merge pull request #94 from implydata/autobuild new 60c2ccd Autobuild new 9adff91

[GitHub] [druid-website] vogievetsky merged pull request #95: Autobuild

2020-09-14 Thread GitBox
vogievetsky merged pull request #95: URL: https://github.com/apache/druid-website/pull/95 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [druid-website] vogievetsky opened a new pull request #95: Autobuild

2020-09-14 Thread GitBox
vogievetsky opened a new pull request #95: URL: https://github.com/apache/druid-website/pull/95 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[druid-website-src] branch master updated: add 9/28 meetup

2020-09-14 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid-website-src.git The following commit(s) were added to refs/heads/master by this push: new 852c067 add 9/28 meetup ne

[druid-website-src] branch master updated: fix typo on index.html

2020-09-14 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid-website-src.git The following commit(s) were added to refs/heads/master by this push: new 09e6842 fix typo on index.html

[GitHub] [druid-website-src] vogievetsky merged pull request #161: add 9/28 meetup

2020-09-14 Thread GitBox
vogievetsky merged pull request #161: URL: https://github.com/apache/druid-website-src/pull/161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [druid-website-src] vogievetsky merged pull request #160: fix typo on index.html

2020-09-14 Thread GitBox
vogievetsky merged pull request #160: URL: https://github.com/apache/druid-website-src/pull/160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [druid-website-src] druid-matt closed pull request #150: fix broken links to docs

2020-09-14 Thread GitBox
druid-matt closed pull request #150: URL: https://github.com/apache/druid-website-src/pull/150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [druid-website-src] druid-matt opened a new pull request #161: add 9/28 meetup

2020-09-14 Thread GitBox
druid-matt opened a new pull request #161: URL: https://github.com/apache/druid-website-src/pull/161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[druid] branch master updated (3d4b48e -> f5e2645)

2020-09-14 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 3d4b48e TransformSpecTest should extends InitializedNullHandlingTest (#10392) add f5e2645 Support SearchQueryD

[druid] branch master updated (3d4b48e -> f5e2645)

2020-09-14 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 3d4b48e TransformSpecTest should extends InitializedNullHandlingTest (#10392) add f5e2645 Support SearchQueryD

[druid] branch master updated (3d4b48e -> f5e2645)

2020-09-14 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 3d4b48e TransformSpecTest should extends InitializedNullHandlingTest (#10392) add f5e2645 Support SearchQueryD

[druid] branch master updated (3d4b48e -> f5e2645)

2020-09-14 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 3d4b48e TransformSpecTest should extends InitializedNullHandlingTest (#10392) add f5e2645 Support SearchQueryD

[druid] branch master updated (3d4b48e -> f5e2645)

2020-09-14 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 3d4b48e TransformSpecTest should extends InitializedNullHandlingTest (#10392) add f5e2645 Support SearchQueryD

[GitHub] [druid] suneet-s merged pull request #10350: Support SearchQueryDimFilter in sql via new methods

2020-09-14 Thread GitBox
suneet-s merged pull request #10350: URL: https://github.com/apache/druid/pull/10350 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] suneet-s commented on a change in pull request #10350: Support SearchQueryDimFilter in sql via new methods

2020-09-14 Thread GitBox
suneet-s commented on a change in pull request #10350: URL: https://github.com/apache/druid/pull/10350#discussion_r488085625 ## File path: processing/src/test/java/org/apache/druid/query/expression/ContainsExprMacroTest.java ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache

[GitHub] [druid] clintropolis commented on a change in pull request #10327: benchmark for indexed table experiments

2020-09-14 Thread GitBox
clintropolis commented on a change in pull request #10327: URL: https://github.com/apache/druid/pull/10327#discussion_r488079104 ## File path: benchmarks/src/test/java/org/apache/druid/benchmark/IndexedTableLoadingBenchmark.java ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apac

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10370: add computed Expr output types

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10370: URL: https://github.com/apache/druid/pull/10370#discussion_r488075026 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -57,6 +57,17 @@ protected final double evalDou

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10370: add computed Expr output types

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10370: URL: https://github.com/apache/druid/pull/10370#discussion_r488075026 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -57,6 +57,17 @@ protected final double evalDou

[GitHub] [druid] gianm commented on pull request #10377: Include Sequence-building time in CPU time metric.

2020-09-14 Thread GitBox
gianm commented on pull request #10377: URL: https://github.com/apache/druid/pull/10377#issuecomment-692168297 > Nice. It would be useful to call this out in the Release notes as well. Good point, I added the "Release Notes" label. I haven't had time to fix the coverage issue y

[GitHub] [druid] suneet-s commented on pull request #10386: Upgrade AWS SDK

2020-09-14 Thread GitBox
suneet-s commented on pull request #10386: URL: https://github.com/apache/druid/pull/10386#issuecomment-692145515 @mitchlloyd it looks like the license check job is complaining about the licenses file not being updated ``` Error: found 3 missing licenses. These licenses are report

[GitHub] [druid] AshishKapoor commented on a change in pull request #10357: [web-console] Update README.md

2020-09-14 Thread GitBox
AshishKapoor commented on a change in pull request #10357: URL: https://github.com/apache/druid/pull/10357#discussion_r488034132 ## File path: web-console/README.md ## @@ -25,7 +25,9 @@ This is the unified Druid web console that servers as a data management layer fo 1. You

[GitHub] [druid] AshishKapoor commented on a change in pull request #10357: [web-console] Update README.md

2020-09-14 Thread GitBox
AshishKapoor commented on a change in pull request #10357: URL: https://github.com/apache/druid/pull/10357#discussion_r488031187 ## File path: web-console/README.md ## @@ -25,7 +25,9 @@ This is the unified Druid web console that servers as a data management layer fo 1. You

[GitHub] [druid] AshishKapoor commented on a change in pull request #10357: [web-console] Update README.md

2020-09-14 Thread GitBox
AshishKapoor commented on a change in pull request #10357: URL: https://github.com/apache/druid/pull/10357#discussion_r488031187 ## File path: web-console/README.md ## @@ -25,7 +25,9 @@ This is the unified Druid web console that servers as a data management layer fo 1. You

[GitHub] [druid] suneet-s commented on a change in pull request #10357: [web-console] Update README.md

2020-09-14 Thread GitBox
suneet-s commented on a change in pull request #10357: URL: https://github.com/apache/druid/pull/10357#discussion_r488025313 ## File path: web-console/README.md ## @@ -25,7 +25,9 @@ This is the unified Druid web console that servers as a data management layer fo 1. You need

[GitHub] [druid] suneet-s merged pull request #10392: TransformSpecTest should extends InitializedNullHandlingTest

2020-09-14 Thread GitBox
suneet-s merged pull request #10392: URL: https://github.com/apache/druid/pull/10392 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] suneet-s closed issue #10391: Unit test fail due to missing extend InitializedNullHandlingTest

2020-09-14 Thread GitBox
suneet-s closed issue #10391: URL: https://github.com/apache/druid/issues/10391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[druid] branch master updated: TransformSpecTest should extends InitializedNullHandlingTest (#10392)

2020-09-14 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 3d4b48e TransformSpecTest should extends Initial

[GitHub] [druid] a2l007 commented on pull request #10377: Include Sequence-building time in CPU time metric.

2020-09-14 Thread GitBox
a2l007 commented on pull request #10377: URL: https://github.com/apache/druid/pull/10377#issuecomment-692096884 Nice. It would be useful to call this out in the Release notes as well. This is an automated message from the Apa

[GitHub] [druid] tlblessing opened a new pull request #10396: Update index.md

2020-09-14 Thread GitBox
tlblessing opened a new pull request #10396: URL: https://github.com/apache/druid/pull/10396 Cool product. Minor suggested copy edits. -avoid excessive use of double quotes for terms that are well understood. -avoid future tense when possible. -missing punctuation.

[GitHub] [druid] a2l007 commented on pull request #9832: Disable sending server version in response headers

2020-09-14 Thread GitBox
a2l007 commented on pull request #9832: URL: https://github.com/apache/druid/pull/9832#issuecomment-692057094 Yeah makes sense. I've removed the config and related changes. This is an automated message from the Apache Git Ser

[GitHub] [druid] AshishKapoor commented on issue #10349: Druid data loader does not work with input time column name - '__time'

2020-09-14 Thread GitBox
AshishKapoor commented on issue #10349: URL: https://github.com/apache/druid/issues/10349#issuecomment-692018903 > `__time` is a reserved name representing time column of the segment. Currently it requires a value of of unix epoch. You could change the property name of `__time` in json to

[GitHub] [druid] AshishKapoor edited a comment on issue #10349: Druid data loader does not work with input time column name - '__time'

2020-09-14 Thread GitBox
AshishKapoor edited a comment on issue #10349: URL: https://github.com/apache/druid/issues/10349#issuecomment-692018903 > `__time` is a reserved name representing time column of the segment. Currently it requires a value of of unix epoch. You could change the property name of `__time` in j

[GitHub] [druid] clintropolis commented on a change in pull request #10370: add computed Expr output types

2020-09-14 Thread GitBox
clintropolis commented on a change in pull request #10370: URL: https://github.com/apache/druid/pull/10370#discussion_r487868191 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -57,6 +57,17 @@ protected final double evalDouble(d

[GitHub] [druid] clintropolis commented on a change in pull request #10370: add computed Expr output types

2020-09-14 Thread GitBox
clintropolis commented on a change in pull request #10370: URL: https://github.com/apache/druid/pull/10370#discussion_r487841757 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -57,6 +57,17 @@ protected final double evalDouble(d

[GitHub] [druid] maytasm commented on a change in pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
maytasm commented on a change in pull request #10371: URL: https://github.com/apache/druid/pull/10371#discussion_r487839440 ## File path: server/src/main/java/org/apache/druid/server/coordinator/AutoCompactionSnapshot.java ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache So

[GitHub] [druid] maytasm commented on a change in pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
maytasm commented on a change in pull request #10371: URL: https://github.com/apache/druid/pull/10371#discussion_r487838791 ## File path: server/src/main/java/org/apache/druid/server/coordinator/duty/EmitClusterStatsAndMetrics.java ## @@ -296,18 +296,87 @@ public DruidCoordina

[GitHub] [druid] maytasm commented on a change in pull request #10371: Auto-compaction snapshot status API

2020-09-14 Thread GitBox
maytasm commented on a change in pull request #10371: URL: https://github.com/apache/druid/pull/10371#discussion_r487838589 ## File path: server/src/main/java/org/apache/druid/server/coordinator/duty/EmitClusterStatsAndMetrics.java ## @@ -296,18 +296,87 @@ public DruidCoordina

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10366: Proposed changes for making joins cacheable

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10366: URL: https://github.com/apache/druid/pull/10366#discussion_r487837336 ## File path: server/src/main/java/org/apache/druid/query/ResultLevelCachingQueryRunner.java ## @@ -86,7 +92,15 @@ public ResultLevelCachingQue

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10366: Proposed changes for making joins cacheable

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10366: URL: https://github.com/apache/druid/pull/10366#discussion_r487835902 ## File path: processing/src/main/java/org/apache/druid/segment/join/table/BroadcastSegmentIndexedTable.java ## @@ -241,6 +244,22 @@ public Col

[GitHub] [druid] AshishKapoor closed issue #10349: Druid data loader does not work with input time column name - '__time'

2020-09-14 Thread GitBox
AshishKapoor closed issue #10349: URL: https://github.com/apache/druid/issues/10349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10366: Proposed changes for making joins cacheable

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10366: URL: https://github.com/apache/druid/pull/10366#discussion_r487819771 ## File path: processing/src/main/java/org/apache/druid/segment/join/Joinables.java ## @@ -118,6 +126,47 @@ public static boolean isPrefixedBy(f

[GitHub] [druid] jagtapsantosh opened a new issue #10395: Getting error when accessing materialized view query in web console and in logs using druid 0.19.0: Could not resolve type id 'view' as a subt

2020-09-14 Thread GitBox
jagtapsantosh opened a new issue #10395: URL: https://github.com/apache/druid/issues/10395 Hello Guys, I am using druid 0.19.0 version and trying to setup Materialized View and Materialized Selection Features. I am following the instruction given on [this link](https://dr

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10366: Proposed changes for making joins cacheable

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10366: URL: https://github.com/apache/druid/pull/10366#discussion_r487818427 ## File path: server/src/main/java/org/apache/druid/server/coordination/ServerManager.java ## @@ -293,21 +302,28 @@ public ServerManager(

[GitHub] [druid] pan3793 commented on pull request #9507: optionally disable all of hardcoded zookeeper use

2020-09-14 Thread GitBox
pan3793 commented on pull request #9507: URL: https://github.com/apache/druid/pull/9507#issuecomment-691971352 It would be nice if druid support k8s in mainline, will it be addressed in next release? This is an automated mes

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10366: Proposed changes for making joins cacheable

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10366: URL: https://github.com/apache/druid/pull/10366#discussion_r48760 ## File path: server/src/main/java/org/apache/druid/segment/join/BroadcastTableJoinableFactory.java ## @@ -76,4 +76,27 @@ public boolean isDire

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10366: Proposed changes for making joins cacheable

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10366: URL: https://github.com/apache/druid/pull/10366#discussion_r487699662 ## File path: server/src/main/java/org/apache/druid/query/ResultLevelCachingQueryRunner.java ## @@ -86,7 +92,15 @@ public ResultLevelCachingQue

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10366: Proposed changes for making joins cacheable

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10366: URL: https://github.com/apache/druid/pull/10366#discussion_r487699118 ## File path: processing/src/main/java/org/apache/druid/segment/join/table/BroadcastSegmentIndexedTable.java ## @@ -241,6 +244,22 @@ public Col

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10366: Proposed changes for making joins cacheable

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10366: URL: https://github.com/apache/druid/pull/10366#discussion_r487698508 ## File path: processing/src/main/java/org/apache/druid/segment/join/MapJoinableFactory.java ## @@ -80,4 +80,21 @@ public boolean isDirectlyJoi

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10366: Proposed changes for making joins cacheable

2020-09-14 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10366: URL: https://github.com/apache/druid/pull/10366#discussion_r487695326 ## File path: processing/src/main/java/org/apache/druid/segment/join/Joinables.java ## @@ -118,6 +126,47 @@ public static boolean isPrefixedBy(f