[GitHub] [druid] ayushkul2910 commented on a change in pull request #10448: Added CronScheduler support as a proof to clock drift while emitting metrics

ayushkul2910 commented on a change in pull request #10448: URL: https://github.com/apache/druid/pull/10448#discussion_r553162349 ## File path: server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java ## @@ -108,10 +108,10 @@ public MonitorScheduler

[GitHub] [druid] bananaaggle commented on pull request #10710: fix web-console show json bug

bananaaggle commented on pull request #10710: URL: https://github.com/apache/druid/pull/10710#issuecomment-755929310 @vogievetsky I change code follow your suggestion. And I check all places JSON.stringify used and replace it if necessary.

[GitHub] [druid] abhishekagarwal87 opened a new pull request #10734: add offsetFetchPeriod to kinesis ingestion doc

abhishekagarwal87 opened a new pull request #10734: URL: https://github.com/apache/druid/pull/10734 Minor doc fix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [druid] clintropolis commented on a change in pull request #10724: Coordinator Dynamic Config changes to ease upgrading with new config value

clintropolis commented on a change in pull request #10724: URL: https://github.com/apache/druid/pull/10724#discussion_r553119211 ## File path: server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java ## @@ -87,6 +88,8 @@ private final int

[GitHub] [druid] jon-wei opened a new pull request #10733: Update deps for CVE-2020-28168 and CVE-2020-28052

jon-wei opened a new pull request #10733: URL: https://github.com/apache/druid/pull/10733 This PR updates the axios dependency (from web-console) and a bouncy castle dependency coming in through the kubernetes extension, addressing the following CVEs that cause `mvn

[druid] branch master updated (48e576a -> c7b1212)

This is an automated email from the ASF dual-hosted git repository. himanshug pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 48e576a Scan query: More accurate error message when segment per time chunk limit is exceeded. (#10630) add

[GitHub] [druid] himanshug commented on pull request #9518: AWS RDS token based password provider

himanshug commented on pull request #9518: URL: https://github.com/apache/druid/pull/9518#issuecomment-755889518 thanks @clintropolis This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [druid] himanshug merged pull request #9518: AWS RDS token based password provider

himanshug merged pull request #9518: URL: https://github.com/apache/druid/pull/9518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] lgtm-com[bot] commented on pull request #10732: Add a config for monitorScheduler type

lgtm-com[bot] commented on pull request #10732: URL: https://github.com/apache/druid/pull/10732#issuecomment-755862034 This pull request **introduces 1 alert** when merging 6b791d120362fdcfd14e7b1f10d30e941a52a373 into 48e576a307da0efba1cb036c274327733658c1d6 - [view on

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553074881 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/common/OrderedPartitionableRecord.java ## @@ -55,7 +54,7 @@ public

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553074022 ## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/data/input/kafka/KafkaRecordEntity.java ## @@ -0,0 +1,39 @@ +/* + *

[GitHub] [druid] jihoonson opened a new pull request #10732: Add a config for monitorScheduler type

jihoonson opened a new pull request #10732: URL: https://github.com/apache/druid/pull/10732 https://github.com/apache/druid/pull/10448 modified the `MonitorScheduler` to use `CronScheduler` instead of `ScheduledExecutorService`. This change looks good to me except that I'm not sure how

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553074022 ## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/data/input/kafka/KafkaRecordEntity.java ## @@ -0,0 +1,39 @@ +/* + *

[GitHub] [druid] himanshug commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

himanshug commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553063732 ## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaRecordSupplier.java ## @@ -119,15 +120,16 @@

[GitHub] [druid] vogievetsky commented on a change in pull request #10710: fix web-console show json bug

vogievetsky commented on a change in pull request #10710: URL: https://github.com/apache/druid/pull/10710#discussion_r552995684 ## File path: web-console/src/components/show-json/show-json.tsx ## @@ -41,7 +41,13 @@ export const ShowJson = React.memo(function ShowJson(props:

[GitHub] [druid] jihoonson edited a comment on pull request #10448: Added CronScheduler support as a proof to clock drift while emitting metrics

jihoonson edited a comment on pull request #10448: URL: https://github.com/apache/druid/pull/10448#issuecomment-755111625 Hi @leventov, as test coverage is not very great for Druid metrics system, I'm wondering how much the CronScheduler is well-tested in production environment,

[druid] branch master updated (f9fc189 -> 48e576a)

This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from f9fc189 Typo: missing comma in json (#10711) add 48e576a Scan query: More accurate error message when segment

[GitHub] [druid] gianm merged pull request #10630: Scan query: More accurate error message when segment per time chunk limit is exceeded.

gianm merged pull request #10630: URL: https://github.com/apache/druid/pull/10630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] himanshug commented on a change in pull request #9518: AWS RDS token based password provider

himanshug commented on a change in pull request #9518: URL: https://github.com/apache/druid/pull/9518#discussion_r552981751 ## File path: docs/development/extensions-core/druid-aws-rds.md ## @@ -0,0 +1,38 @@ +--- +id: druid-aws-rds +title: "Druid AWS RDS Module" +--- + + +

[GitHub] [druid] himanshug commented on a change in pull request #9518: AWS RDS token based password provider

himanshug commented on a change in pull request #9518: URL: https://github.com/apache/druid/pull/9518#discussion_r552983056 ## File path: server/src/main/java/org/apache/druid/metadata/BasicDataSourceExt.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software

[GitHub] [druid] himanshug commented on a change in pull request #9518: AWS RDS token based password provider

himanshug commented on a change in pull request #9518: URL: https://github.com/apache/druid/pull/9518#discussion_r552981751 ## File path: docs/development/extensions-core/druid-aws-rds.md ## @@ -0,0 +1,38 @@ +--- +id: druid-aws-rds +title: "Druid AWS RDS Module" +--- + + +

[druid] branch master updated (68bb038 -> f9fc189)

This is an automated email from the ASF dual-hosted git repository. suneet pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 68bb038 Multiphase segment merge for IndexMergerV9 (#10689) add f9fc189 Typo: missing comma in json (#10711)

[GitHub] [druid] suneet-s merged pull request #10711: Typo: missing comma in json

suneet-s merged pull request #10711: URL: https://github.com/apache/druid/pull/10711 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] jihoonson commented on a change in pull request #10685: Subtotal queries give incorrect results if query has a limit spec

jihoonson commented on a change in pull request #10685: URL: https://github.com/apache/druid/pull/10685#discussion_r552972254 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferMinMaxOffsetHeap.java ## @@ -59,6 +60,35 @@ public

[GitHub] [druid] jihoonson commented on a change in pull request #10685: Subtotal queries give incorrect results if query has a limit spec

jihoonson commented on a change in pull request #10685: URL: https://github.com/apache/druid/pull/10685#discussion_r552969515 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferMinMaxOffsetHeap.java ## @@ -59,6 +60,35 @@ public

[GitHub] [druid] suneet-s commented on pull request #10724: Coordinator Dynamic Config changes to ease upgrading with new config value

suneet-s commented on pull request #10724: URL: https://github.com/apache/druid/pull/10724#issuecomment-755627357 @capistrant It looks like CI is complaining about a missing file for a newly added (I think) integration test 樂 I'm not sure how this PR could have caused that failure -

[GitHub] [druid] loquisgon commented on a change in pull request #10685: Subtotal queries give incorrect results if query has a limit spec

loquisgon commented on a change in pull request #10685: URL: https://github.com/apache/druid/pull/10685#discussion_r552813435 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferMinMaxOffsetHeap.java ## @@ -59,6 +60,35 @@ public

[GitHub] [druid] loquisgon commented on a change in pull request #10685: Subtotal queries give incorrect results if query has a limit spec

loquisgon commented on a change in pull request #10685: URL: https://github.com/apache/druid/pull/10685#discussion_r552811029 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferMinMaxOffsetHeap.java ## @@ -59,6 +60,35 @@ public

[GitHub] [druid] loquisgon commented on a change in pull request #10685: Subtotal queries give incorrect results if query has a limit spec

loquisgon commented on a change in pull request #10685: URL: https://github.com/apache/druid/pull/10685#discussion_r552810775 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferMinMaxOffsetHeap.java ## @@ -59,6 +60,35 @@ public

[GitHub] [druid] liran-funaro commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

liran-funaro commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-755211304 Can we proceed to merge this PR? This is an automated message from the Apache Git Service. To respond to

[GitHub] [druid] aaasif04 opened a new issue #10731: service is not loading

aaasif04 opened a new issue #10731: URL: https://github.com/apache/druid/issues/10731 I have installed druid 0.20.0as cluster and started all the services. But only the data services are up and shown in druid console. And in the router log, it shows errors like ERROR

[GitHub] [druid] kaijianding commented on a change in pull request #10688: Historical lazy on start enhancement with segment files check

kaijianding commented on a change in pull request #10688: URL: https://github.com/apache/druid/pull/10688#discussion_r552404073 ## File path: core/src/main/java/org/apache/druid/coordination/CommonCallback.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software