abhishekagarwal87 commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-76089
I usually avoid abstract classes so there is no tight coupling. It can make
unit testing easier as well. I can pass a mock helper into a vector aggregator
and unit
abhishekagarwal87 commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-760774449
Right. I was being subtle about it :) It would be nice to use the same style
everywhere. If that pattern needs some modification, I can do that as well.
abhishekagarwal87 commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-760715147
By the way, I did a similar thing in
https://github.com/apache/druid/pull/10304 to reduce some boilerplate code but
used composition instead of inheritance. Added
