[GitHub] [druid] ccaominh commented on a change in pull request #9488: Match GREATEST/LEAST function behavior to other DBs

2020-03-12 Thread GitBox
ccaominh commented on a change in pull request #9488: Match GREATEST/LEAST function behavior to other DBs URL: https://github.com/apache/druid/pull/9488#discussion_r391809838 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -976,6 +981,163

[GitHub] [druid] ccaominh commented on a change in pull request #9488: Match GREATEST/LEAST function behavior to other DBs

2020-03-09 Thread GitBox
ccaominh commented on a change in pull request #9488: Match GREATEST/LEAST function behavior to other DBs URL: https://github.com/apache/druid/pull/9488#discussion_r390019784 ## File path: docs/querying/sql.md ## @@ -334,6 +332,22 @@ simplest way to write literal

[GitHub] [druid] ccaominh commented on a change in pull request #9488: Match GREATEST/LEAST function behavior to other DBs

2020-03-09 Thread GitBox
ccaominh commented on a change in pull request #9488: Match GREATEST/LEAST function behavior to other DBs URL: https://github.com/apache/druid/pull/9488#discussion_r390016128 ## File path: docs/misc/math-expr.md ## @@ -181,6 +181,22 @@ See javadoc of java.lang.Math for

[GitHub] [druid] ccaominh commented on a change in pull request #9488: Match GREATEST/LEAST function behavior to other DBs

2020-03-09 Thread GitBox
ccaominh commented on a change in pull request #9488: Match GREATEST/LEAST function behavior to other DBs URL: https://github.com/apache/druid/pull/9488#discussion_r390015518 ## File path: docs/querying/sql.md ## @@ -334,6 +332,22 @@ simplest way to write literal

[GitHub] [druid] ccaominh commented on a change in pull request #9488: Match GREATEST/LEAST function behavior to other DBs

2020-03-09 Thread GitBox
ccaominh commented on a change in pull request #9488: Match GREATEST/LEAST function behavior to other DBs URL: https://github.com/apache/druid/pull/9488#discussion_r390011309 ## File path: docs/querying/sql.md ## @@ -334,6 +332,22 @@ simplest way to write literal