[GitHub] [druid] samarthjain commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
samarthjain commented on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1058752068 Submitted https://github.com/apache/druid/pull/12304 to fix CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [druid] samarthjain commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
samarthjain commented on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1058748780 Looks like the last rebase you pushed reverted your String.format changes, @jasonk000 . I will submit a PR to fix CI, @clintropolis -- This is an automated message from

[GitHub] [druid] samarthjain commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-03 Thread GitBox
samarthjain commented on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1058518405 Looking at the CI failures, it looks like the build timed out because `HashPartitionMultiPhaseParallelIndexingTest` never completed. To be double sure, I ran the test

[GitHub] [druid] samarthjain commented on pull request #12097: perf: eliminate double string concat in remote-task-runner shutdown logging

2022-03-02 Thread GitBox
samarthjain commented on pull request #12097: URL: https://github.com/apache/druid/pull/12097#issuecomment-1057522274 +1, looks good. I will merge after CI completes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use