SandishKumarHN commented on issue #8060: 6855 add Checkstyle for constant name
static final
URL: https://github.com/apache/incubator-druid/pull/8060#issuecomment-524389752
> @SandishKumarHN thanks for persisting on this task.
Thanks for being patience with me review changes!
SandishKumarHN commented on issue #8060: 6855 add Checkstyle for constant name
static final
URL: https://github.com/apache/incubator-druid/pull/8060#issuecomment-524209501
@leventov only 1 build failed with some random reason!
SandishKumarHN commented on issue #8060: 6855 add Checkstyle for constant name
static final
URL: https://github.com/apache/incubator-druid/pull/8060#issuecomment-518961707
@leventov Thanks for the first review, Please review this file first
SandishKumarHN commented on issue #8060: 6855 add Checkstyle for constant name
static final
URL: https://github.com/apache/incubator-druid/pull/8060#issuecomment-515829203
@leventov Sorry for squash and force push's, I did not recognize commits
will be used for monitoring my changes
SandishKumarHN commented on issue #8060: 6855 add Checkstyle for constant name
static final
URL: https://github.com/apache/incubator-druid/pull/8060#issuecomment-515663246
@leventov self reviewed again! and merged with the master branch! looks
good to me. let me know if you want me to
SandishKumarHN commented on issue #8060: 6855 add Checkstyle for constant name
static final
URL: https://github.com/apache/incubator-druid/pull/8060#issuecomment-514420526
@leventov Sorry, I was working on my fork branch which was effecting here!
now gone through twice by comparing my
SandishKumarHN commented on issue #8060: 6855 add Checkstyle for constant name
static final
URL: https://github.com/apache/incubator-druid/pull/8060#issuecomment-510265717
@leventov took some time to come up with this PR! a lot of patience was
required! all tests were passed locally
