[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

2019-12-12 Thread GitBox
ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357445331 ## File path: docs/tutorials/cluster.md ## @@ -135,6 +135,8 @@ We recommend running your

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

2019-12-12 Thread GitBox
ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357445420 ## File path: docs/tutorials/index.md ## @@ -39,6 +39,8 @@ You will need: * Linux, Mac OS X, or

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

2019-12-12 Thread GitBox
ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357446069 ## File path: examples/bin/run-zk ## @@ -19,7 +19,7 @@ if [ "$#" -gt 1 ] then - echo

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

2019-12-12 Thread GitBox
ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357445951 ## File path: examples/bin/run-druid ## @@ -17,9 +17,9 @@ # specific language governing

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

2019-12-12 Thread GitBox
ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357403722 ## File path: examples/bin/verify-java ## @@ -44,7 +45,18 @@ if ($skip_var && $skip_var ne "0"

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

2019-12-12 Thread GitBox
ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357406603 ## File path: examples/bin/java-util ## @@ -0,0 +1,39 @@ +#!/bin/bash +# Licensed to the Apache

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

2019-12-12 Thread GitBox
ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357408691 ## File path: examples/bin/java-util ## @@ -0,0 +1,39 @@ +#!/bin/bash Review comment: I

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

2019-12-12 Thread GitBox
ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357406938 ## File path: examples/bin/java-util ## @@ -0,0 +1,39 @@ +#!/bin/bash +# Licensed to the Apache

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

2019-12-12 Thread GitBox
ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357413942 ## File path: examples/bin/run-druid ## @@ -17,7 +17,7 @@ # specific language governing

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

2019-12-12 Thread GitBox
ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357408219 ## File path: examples/bin/java-util ## @@ -0,0 +1,39 @@ +#!/bin/bash +# Licensed to the Apache